https://github.com/ddpagan commented:
LGTM.
https://github.com/llvm/llvm-project/pull/94680
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ddpagan closed
https://github.com/llvm/llvm-project/pull/87278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1537,6 +1537,12 @@ class CodeGenModule : public CodeGenTypeCache {
void printPostfixForExternalizedDecl(llvm::raw_ostream ,
const Decl *D) const;
+ /// Under debug mode, print status of target teams loop transformation,
+ ///
@@ -11311,6 +11311,10 @@ class Sema final {
OpenMPDirectiveKind ,
OpenMPDirectiveKind );
+ /// [target] teams loop is equivalent to parallel for if associated loop
+ /// nest meets certain critera.
+ bool
ddpagan wrote:
After some additional discussion with Alexey offline, he concluded that the
current changes are okay, specifically for this reason:
_"Then I realized that actually it does not require AST nodes building. In this
case, this helper class should be moved to CodeGenStmt and hidden
ddpagan wrote:
Ping.
https://github.com/llvm/llvm-project/pull/72417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6106,6 +6106,8 @@ class OMPTeamsGenericLoopDirective final : public
OMPLoopDirective {
class OMPTargetTeamsGenericLoopDirective final : public OMPLoopDirective {
friend class ASTStmtReader;
friend class OMPExecutableDirective;
+ /// true if loop directive's
@@ -6106,6 +6106,8 @@ class OMPTeamsGenericLoopDirective final : public
OMPLoopDirective {
class OMPTargetTeamsGenericLoopDirective final : public OMPLoopDirective {
friend class ASTStmtReader;
friend class OMPExecutableDirective;
+ /// true if loop directive's
ddpagan wrote:
Ping.
https://github.com/llvm/llvm-project/pull/72417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ddpagan commented:
Aside from Alexey's comments, LGTM.
https://github.com/llvm/llvm-project/pull/75709
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -7485,6 +7485,99 @@ void
CodeGenModule::printPostfixForExternalizedDecl(llvm::raw_ostream ,
}
}
+namespace {
+/// A 'teams loop' with a nested 'loop bind(parallel)' or generic function
+/// call in the associated loop-nest cannot be a 'parllel for'.
+class
https://github.com/ddpagan closed
https://github.com/llvm/llvm-project/pull/70268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ddpagan created
https://github.com/llvm/llvm-project/pull/70268
Fixed assertion failure
Basic Block in function 'main' does not have terminator!
label %land.end
caused by premature setting of CodeGenIP upon entry to emitTargetDataCalls,
where subsequent evaluation of
13 matches
Mail list logo
