Author: gribozavr
Date: Tue Aug 27 15:13:31 2019
New Revision: 370122
URL: http://llvm.org/viewvc/llvm-project?rev=370122&view=rev
Log:
ArrayRef'ized CompilerInvocation::CreateFromArgs
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66797
Modified:
cf
Author: gribozavr
Date: Tue Aug 27 03:56:13 2019
New Revision: 370039
URL: http://llvm.org/viewvc/llvm-project?rev=370039&view=rev
Log:
Refactor GlobList from an ad-hoc linked list to a vector
Summary: I think it makes method implementations more obvious.
Subscribers: cfe-commits
Tags: #clang
Author: gribozavr
Date: Tue Aug 27 01:42:42 2019
New Revision: 370028
URL: http://llvm.org/viewvc/llvm-project?rev=370028&view=rev
Log:
GlobList: added a clear test for pattern priority
Summary:
The last glob that matches the string decides whether that string is
included or excluded.
Subscriber
Author: gribozavr
Date: Mon Aug 26 08:44:32 2019
New Revision: 369918
URL: http://llvm.org/viewvc/llvm-project?rev=369918&view=rev
Log:
Moved GlobList into a separate header file
Summary:
It is a separate abstraction that is used in more contexts than just
a helper for ClangTidyDiagnosticConsumer
Author: gribozavr
Date: Sun Aug 25 11:20:18 2019
New Revision: 369873
URL: http://llvm.org/viewvc/llvm-project?rev=369873&view=rev
Log:
[Wdocumentation] improve wording of a warning message
Based on @davezarzycki remarks in D64696 improved the wording of the warning
message.
Differential Revisio
Author: gribozavr
Date: Wed Aug 21 01:48:24 2019
New Revision: 369504
URL: http://llvm.org/viewvc/llvm-project?rev=369504&view=rev
Log:
Removed some dead code in BugReporter and related files
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66473
Modified:
Author: gribozavr
Date: Tue Aug 20 06:02:28 2019
New Revision: 369380
URL: http://llvm.org/viewvc/llvm-project?rev=369380&view=rev
Log:
Removed the 'id' AST matcher, which is superseded by '.bind()'
Summary:
The 'id' matcher is not even included in the AST Matchers Reference
document, so I don't
Author: gribozavr
Date: Wed Aug 14 04:35:04 2019
New Revision: 368832
URL: http://llvm.org/viewvc/llvm-project?rev=368832&view=rev
Log:
Removed ToolExecutor::isSingleProcess, it is not used by anything
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66212
Author: gribozavr
Date: Wed Aug 14 04:11:52 2019
New Revision: 368827
URL: http://llvm.org/viewvc/llvm-project?rev=368827&view=rev
Log:
Improved the doc comment for getCommentsInFile
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D66209
Modified:
cfe/
Author: gribozavr
Date: Wed Aug 14 00:32:51 2019
New Revision: 368805
URL: http://llvm.org/viewvc/llvm-project?rev=368805&view=rev
Log:
Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp,h}
Reviewers: jkorous
Subscribers: dexonsmith, arphaman, cfe-commits
Tags: #clang
Differe
Author: gribozavr
Date: Tue Aug 13 12:07:28 2019
New Revision: 368738
URL: http://llvm.org/viewvc/llvm-project?rev=368738&view=rev
Log:
Revert "Fix crash on switch conditions of non-integer types in templates"
This reverts commit r368706. It broke ClangTidy tests.
Removed:
cfe/trunk/test/Sem
Author: gribozavr
Date: Thu Aug 8 23:14:54 2019
New Revision: 368399
URL: http://llvm.org/viewvc/llvm-project?rev=368399&view=rev
Log:
Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit
Summary: ASSERT_THAT_ERROR looks like the intended helper for use in tests.
Reviewers: plotfi, jkoro
Author: gribozavr
Date: Wed Aug 7 01:16:29 2019
New Revision: 368132
URL: http://llvm.org/viewvc/llvm-project?rev=368132&view=rev
Log:
Remove inclusion of a private gmock header from a test
Modified:
cfe/trunk/unittests/AST/RecursiveASTVisitorTest.cpp
Modified: cfe/trunk/unittests/AST/Recur
Author: gribozavr
Date: Mon Aug 5 01:05:16 2019
New Revision: 367809
URL: http://llvm.org/viewvc/llvm-project?rev=367809&view=rev
Log:
Adds a warning when an inline Doxygen comment has no argument
Summary:
It warns for for comments like
/** \pre \em */
where \em has no argument
This warning is
Author: gribozavr
Date: Tue Jul 9 04:04:04 2019
New Revision: 365463
URL: http://llvm.org/viewvc/llvm-project?rev=365463&view=rev
Log:
Enhance abseil-faster-strsplit-delimiter to handle other non-printable
characters.
Summary:
Currently it fails on cases like '\001'.
Note: Since `StringLiteral
Author: gribozavr
Date: Wed Jul 3 13:18:34 2019
New Revision: 365078
URL: http://llvm.org/viewvc/llvm-project?rev=365078&view=rev
Log:
Fixed a link in ReleaseNotes.rst (follow-up to r365007)
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-extra/trunk/docs/Relea
Author: gribozavr
Date: Wed Jul 3 02:20:18 2019
New Revision: 365007
URL: http://llvm.org/viewvc/llvm-project?rev=365007&view=rev
Log:
[clang-tidy] new check: bugprone-posix-return
Summary:
Checks if any calls to posix functions (except posix_openpt) expect negative
return values.
These functio
Author: gribozavr
Date: Thu Jun 13 08:16:44 2019
New Revision: 363273
URL: http://llvm.org/viewvc/llvm-project?rev=363273&view=rev
Log:
[clang-tidy] Made abseil-faster-strsplit-delimiter tests pass on C++17
Reviewers: hokein, gribozavr
Reviewed By: hokein, gribozavr
Subscribers: xazax.hun, cfe-
Author: gribozavr
Date: Thu Jun 13 08:11:02 2019
New Revision: 363272
URL: http://llvm.org/viewvc/llvm-project?rev=363272&view=rev
Log:
[clang-tidy] Fixed abseil-time-subtraction to work on C++17
Summary: Fixed abseil-time-subtraction to work on C++17
Reviewers: hokein, gribozavr
Subscribers: x
Author: gribozavr
Date: Thu Jun 13 07:27:54 2019
New Revision: 363270
URL: http://llvm.org/viewvc/llvm-project?rev=363270&view=rev
Log:
[clang-tidy] Made abseil-upgrade-duration-conversions tests pass on c++17
Summary: Made abseil-upgrade-duration-conversions tests pass on c++17
Reviewers: hokei
Author: gribozavr
Date: Thu Jun 13 06:52:45 2019
New Revision: 363263
URL: http://llvm.org/viewvc/llvm-project?rev=363263&view=rev
Log:
[clang-tidy] Fixed abseil-duration-unnecessary-conversion tests for c++17
Summary: Fixed abseil-duration-unnecessary-conversion tests for c++17
Reviewers: hokei
Author: gribozavr
Date: Thu Jun 13 06:48:24 2019
New Revision: 363262
URL: http://llvm.org/viewvc/llvm-project?rev=363262&view=rev
Log:
Added AST matcher for ignoring elidable constructors
Summary: Added AST matcher for ignoring elidable move constructors
Reviewers: hokein, gribozavr
Reviewed B
Author: gribozavr
Date: Wed Jun 12 01:40:53 2019
New Revision: 363133
URL: http://llvm.org/viewvc/llvm-project?rev=363133&view=rev
Log:
Fixed a crash in misc-redundant-expression ClangTidy checker
Summary: It was trying to pass a dependent expression into constant evaluator.
Reviewers: ilya-biry
Author: gribozavr
Date: Tue Jun 11 03:59:22 2019
New Revision: 363047
URL: http://llvm.org/viewvc/llvm-project?rev=363047&view=rev
Log:
Fixed google-readability-casting test to work in c++17
Summary: Fixed google-readability-casting.cpp to get tests working in c++17
Reviewers: gribozavr, hokein
Author: gribozavr
Date: Fri May 24 03:50:15 2019
New Revision: 361629
URL: http://llvm.org/viewvc/llvm-project?rev=361629&view=rev
Log:
Make cppcoreguidelines-pro-type-member-init-use-assignment.cpp pass on
platforms where char is unsigned
The other options are to completely specify the triple (
Author: gribozavr
Date: Fri May 24 03:39:00 2019
New Revision: 361628
URL: http://llvm.org/viewvc/llvm-project?rev=361628&view=rev
Log:
Made cppcoreguidelines-pro-type-member-init-use-assignment run in all language
modes
Modified:
clang-tools-extra/trunk/test/clang-tidy/cppcoreguidelines-pr
Author: gribozavr
Date: Thu May 23 05:01:26 2019
New Revision: 361487
URL: http://llvm.org/viewvc/llvm-project?rev=361487&view=rev
Log:
[clang-tidy] New check calling out uses of +new in Objective-C code
Summary:
Google's Objective-C style guide forbids calling or overriding +new to
instantiate
Author: gribozavr
Date: Thu May 23 02:22:43 2019
New Revision: 361468
URL: http://llvm.org/viewvc/llvm-project?rev=361468&view=rev
Log:
Delete default constructors, copy constructors, move constructors, copy
assignment, move assignment operators on Expr, Stmt and Decl
Reviewers: ilya-biryukov, r
Author: gribozavr
Date: Wed May 22 10:45:24 2019
New Revision: 361411
URL: http://llvm.org/viewvc/llvm-project?rev=361411&view=rev
Log:
Fixed a -Wunused-variable warning when assertions are disabled
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.c
Author: gribozavr
Date: Tue May 21 23:57:23 2019
New Revision: 361353
URL: http://llvm.org/viewvc/llvm-project?rev=361353&view=rev
Log:
Fixed a -Wunused-variable warning when assertions are disabled
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
Modified: cfe/trunk/lib/AST/ExprConstant.cpp
URL
Author: gribozavr
Date: Mon May 20 09:30:49 2019
New Revision: 361170
URL: http://llvm.org/viewvc/llvm-project?rev=361170&view=rev
Log:
Renamed `apply` to `select` to avoid ADL conflict with `std::apply`
Summary:
`std::apply` in C++14 and above is defined with two unrestricted arguments, and
it w
Author: gribozavr
Date: Mon May 20 08:12:12 2019
New Revision: 361163
URL: http://llvm.org/viewvc/llvm-project?rev=361163&view=rev
Log:
Disable the modernize-use-trailing-return-type.cpp test in C++2a mode
It is performing a use-of-uninitialized-value, as detected by MSan.
Modified:
clang-t
Author: gribozavr
Date: Fri May 17 10:16:53 2019
New Revision: 361050
URL: http://llvm.org/viewvc/llvm-project?rev=361050&view=rev
Log:
Added an assertion to constant evaluation enty points that prohibits dependent
expressions
Summary:
Constant evaluator does not work on value-dependent or type-
Author: gribozavr
Date: Thu May 9 23:39:20 2019
New Revision: 360406
URL: http://llvm.org/viewvc/llvm-project?rev=360406&view=rev
Log:
Added an assert in `isConstantInitializer`: initializer lists must be in
semantic form
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://re
Author: gribozavr
Date: Thu May 9 10:08:10 2019
New Revision: 360358
URL: http://llvm.org/viewvc/llvm-project?rev=360358&view=rev
Log:
check_clang_tidy.py now passes `-format-style=none` to clang_tidy
Summary:
If the test does not specify a formatting style, force "none"; otherwise
autodetection
Author: gribozavr
Date: Wed May 8 05:02:31 2019
New Revision: 360247
URL: http://llvm.org/viewvc/llvm-project?rev=360247&view=rev
Log:
Documentation for bugprone-inaccurate-erase: added an example of a bug that
this checker catches
Reviewers: alexfh
Subscribers: cfe-commits
Tags: #clang
Diff
Author: gribozavr
Date: Fri May 3 05:50:00 2019
New Revision: 359876
URL: http://llvm.org/viewvc/llvm-project?rev=359876&view=rev
Log:
Added an AST matcher for declarations that are in the `std` namespace
Reviewers: alexfh
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://r
Author: gribozavr
Date: Fri May 3 05:50:00 2019
New Revision: 359876
URL: http://llvm.org/viewvc/llvm-project?rev=359876&view=rev
Log:
Added an AST matcher for declarations that are in the `std` namespace
Reviewers: alexfh
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://r
Author: gribozavr
Date: Wed Apr 10 13:25:07 2019
New Revision: 358134
URL: http://llvm.org/viewvc/llvm-project?rev=358134&view=rev
Log:
Check i < FD->getNumParams() before querying
Summary:
As was already stated in a previous comment, the parameter isn't
necessarily referring to one of the DeclCo
Author: gribozavr
Date: Tue Mar 5 04:38:18 2019
New Revision: 355395
URL: http://llvm.org/viewvc/llvm-project?rev=355395&view=rev
Log:
[ASTMatchers] Improved formatting in a documentation comment
Modified:
cfe/trunk/include/clang/ASTMatchers/ASTMatchersInternal.h
Modified: cfe/trunk/include
Author: gribozavr
Date: Thu Feb 28 06:01:11 2019
New Revision: 355092
URL: http://llvm.org/viewvc/llvm-project?rev=355092&view=rev
Log:
Added missing license headers
Reviewers: ioeric
Subscribers: jkorous, arphaman, kadircet, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm
Author: gribozavr
Date: Thu Feb 28 06:00:26 2019
New Revision: 355091
URL: http://llvm.org/viewvc/llvm-project?rev=355091&view=rev
Log:
Use ArrayRef::copy, instead of copying data manually
Reviewers: ioeric
Subscribers: jkorous, arphaman, kadircet, cfe-commits
Tags: #clang
Differential Revisio
Author: gribozavr
Date: Thu Feb 28 05:49:25 2019
New Revision: 355090
URL: http://llvm.org/viewvc/llvm-project?rev=355090&view=rev
Log:
Moved Ref into its own header and implementation file
Reviewers: ioeric
Subscribers: mgorny, jkorous, mgrang, arphaman, kadircet, cfe-commits
Tags: #clang
Dif
Author: gribozavr
Date: Thu Feb 28 05:23:03 2019
New Revision: 355088
URL: http://llvm.org/viewvc/llvm-project?rev=355088&view=rev
Log:
Moved Symbol into its own header and implementation file
Reviewers: ioeric
Subscribers: mgorny, jkorous, arphaman, kadircet, jdoerfert, cfe-commits
Tags: #clan
Author: gribozavr
Date: Thu Feb 28 04:31:49 2019
New Revision: 355086
URL: http://llvm.org/viewvc/llvm-project?rev=355086&view=rev
Log:
Moved SymbolOrigin into its own header and implementation file
Reviewers: ioeric
Subscribers: mgorny, jkorous, arphaman, kadircet, jdoerfert, cfe-commits
Tags:
Author: gribozavr
Date: Thu Feb 28 03:02:01 2019
New Revision: 355082
URL: http://llvm.org/viewvc/llvm-project?rev=355082&view=rev
Log:
Moved SymbolLocation into its own header and implementation file
Reviewers: ioeric
Subscribers: mgorny, jkorous, arphaman, kadircet, cfe-commits
Tags: #clang
Author: gribozavr
Date: Thu Feb 28 03:00:44 2019
New Revision: 355081
URL: http://llvm.org/viewvc/llvm-project?rev=355081&view=rev
Log:
Moved DenseMap support for SymbolID into SymbolID.h
Modified:
clang-tools-extra/trunk/clangd/index/Index.h
clang-tools-extra/trunk/clangd/index/SymbolID.
Author: gribozavr
Date: Wed Feb 27 08:08:04 2019
New Revision: 354994
URL: http://llvm.org/viewvc/llvm-project?rev=354994&view=rev
Log:
Added documentation for clangd v9+ features
Reviewers: ilya-biryukov
Subscribers: ioeric, MaskRay, jkorous, arphaman, kadircet, jdoerfert,
cfe-commits
Tags: #
Author: gribozavr
Date: Wed Feb 27 07:53:05 2019
New Revision: 354992
URL: http://llvm.org/viewvc/llvm-project?rev=354992&view=rev
Log:
Added more detailed documentation for clangd
Summary:
The text was written mostly by Sam McCall, screenshots are mostly made
by me.
Reviewers: ilya-biryukov
Su
Author: gribozavr
Date: Mon Feb 25 05:43:48 2019
New Revision: 354786
URL: http://llvm.org/viewvc/llvm-project?rev=354786&view=rev
Log:
Moved clangd docs to a separate directory in preparation to restructure them
into multiple files
Reviewers: ilya-biryukov
Subscribers: ioeric, MaskRay, jkorous
Author: gribozavr
Date: Mon Feb 25 05:41:59 2019
New Revision: 354785
URL: http://llvm.org/viewvc/llvm-project?rev=354785&view=rev
Log:
Fixed typos in tests: s/CHEKC/CHECK/
Reviewers: ilya-biryukov
Subscribers: nemanjai, javed.absar, jsji, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differen
Author: gribozavr
Date: Mon Feb 25 05:03:44 2019
New Revision: 354779
URL: http://llvm.org/viewvc/llvm-project?rev=354779&view=rev
Log:
Updated the documentation build instructions for the current CMake build system
Reviewers: ilya-biryukov
Subscribers: cfe-commits
Tags: #clang
Differential Re
Author: gribozavr
Date: Mon Feb 25 04:49:27 2019
New Revision: 354778
URL: http://llvm.org/viewvc/llvm-project?rev=354778&view=rev
Log:
Fixed grammar in index.rst
Subscribers: arphaman, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D58601
Modified:
clang-tools-ex
Author: gribozavr
Date: Mon Feb 25 04:48:52 2019
New Revision: 354777
URL: http://llvm.org/viewvc/llvm-project?rev=354777&view=rev
Log:
Removed an unhelpful comment in index.rst
Reviewers: ilya-biryukov
Subscribers: arphaman, jdoerfert, cfe-commits
Tags: #clang
Differential Revision: https://r
gribozavr added a subscriber: gribozavr.
gribozavr added a comment.
> If a user specifies "-fsanitize=" I think it is expected that the
> sanitizer library would be included on the link line.
I deeply disagree.
If the user asks for `-nodefaultlibs`, we should not add any libraries
ourselves,
gribozavr accepted this revision.
gribozavr added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D24024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
gribozavr accepted this revision.
gribozavr added a comment.
LGTM, thanks!
https://reviews.llvm.org/D23653
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gribozavr added a comment.
Here's the new builder:
http://lab.llvm.org:8011/builders/clang-tools-sphinx-docs
Fails with `ninja: error: unknown target 'docs-clang-tools-html'`.
Repository:
rL LLVM
https://reviews.llvm.org/D23787
___
cfe-commits
gribozavr accepted this revision.
gribozavr added a comment.
This revision is now accepted and ready to land.
LGTM with two more tests.
Comment at: test/Sema/warn-documentation.cpp:433
@@ +432,3 @@
+template
+using test_function_like_usingA = foo::function_wrapper;
+
---
gribozavr added a comment.
We need to ask Galina Kistanova to reload the configuration.
Repository:
rL LLVM
https://reviews.llvm.org/D23787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
gribozavr accepted this revision.
gribozavr added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM!
https://reviews.llvm.org/D23787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
gribozavr accepted this revision.
gribozavr added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D23783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
gribozavr added a comment.
Just one comment about the workdir.
Comment at: zorg/buildbot/builders/SphinxDocsBuilder.py:46
@@ +45,3 @@
+ defaultBranch='trunk',
+ workdir=clang_srcdir))
+
I think workdir should be `clang_t
gribozavr added a comment.
LGTM.
http://reviews.llvm.org/D20781
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Mon, Feb 29, 2016 at 10:59 AM, Romanova, Katya
wrote:
> Hi Dmitri,
>
> Could you please let us know your opinion about C++ vs C-style doxygen
> comments. Read this thread for ‘pro’ and ‘con’ arguments about using C++
> headers. Will LLVM online documentation look proper if we decide to use
> C-
On Fri, Feb 5, 2016 at 6:06 PM, Richard Smith via cfe-commits
wrote:
> Author: rsmith
> Date: Fri Feb 5 20:06:43 2016
> New Revision: 259976
>
> URL: http://llvm.org/viewvc/llvm-project?rev=259976&view=rev
> Log:
> [modules] Compress files embedded into a .pcm file, to reduce the disk usage
> of
gribozavr added inline comments.
Comment at:
test/std/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.pass.cpp:35
@@ -30,1 +34,3 @@
}
+
+template
gribozavr wrote:
> mclow.lists wrote:
> > This is not how I would rewrite this test.
> > I wo
gribozavr added inline comments.
Comment at:
test/std/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.pass.cpp:35
@@ -30,1 +34,3 @@
}
+
+template
mclow.lists wrote:
> This is not how I would rewrite this test.
> I would write a routine tha
gribozavr added a comment.
The Debian configuration LGTM.
http://reviews.llvm.org/D14293
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gribozavr closed this revision.
gribozavr added a comment.
Current trunk does not contain this line, no need to apply the patch.
http://reviews.llvm.org/D12549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
gribozavr accepted this revision.
gribozavr added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D12549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
gribozavr added inline comments.
Comment at: tools/clang/lib/StaticAnalyzer/Checkers/Checkers.td:524
@@ +523,3 @@
+def MPIChecker : Checker<"MPI-Checker">,
+ HelpText<"Checks MPI code written in C">,
+ DescFile<"MPIChecker.cpp">;
Does it only works with C code,
201 - 272 of 272 matches
Mail list logo
