[PATCH] D63329: Allow static linking of libc++ on Linux, just like -static-libstdc++

erikjv added a comment. In D63329#1543407 , @lebedev.ri wrote: > Tests? I can add a test, but I'd first like to know if this would be accepted. Test would be along the lines of "test/Driver/fuchsia.cpp" line 36, where it tests "-static-libstdc++".

[PATCH] D63329: Allow static linking of libc++ on Linux, just like -static-libstdc++

erikjv created this revision. erikjv added reviewers: dlj, cfe-commits. Herald added a reviewer: EricWF. Herald added a subscriber: jfb. Herald added a project: clang. Dynamic linking against libc++ on Linux was already supported, as is dynamic and static linking against libstdc++. What was

[PATCH] D45815: [libclang] Add options to limit skipping of function bodies

erikjv added a comment. About the timing testing: I'm not very familiar with boost, but it probably has a library that's using templates more than either LLVM or Qt. Maybe you can test one of those too? LGTM otherwise. Repository: rC Clang https://reviews.llvm.org/D45815

[PATCH] D38615: [libclang] Only mark CXCursors for explicit attributes with a type

erikjv closed this revision. erikjv added a comment. Committed as r330692 https://reviews.llvm.org/D38615 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

erikjv added a comment. lgtm. Ilya? https://reviews.llvm.org/D20124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40643: [libclang] Add function to get the buffer for a file

This revision was automatically updated to reflect the committed changes. Closed by commit rL319881: [libclang] Add function to get the buffer for a file (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D40643?vs=124904=125677#toc Repository: rL LLVM

[PATCH] D40643: [libclang] Add function to get the buffer for a file

erikjv updated this revision to Diff 124904. erikjv added a comment. Bumped the CINDEX_VERSION_MINOR. https://reviews.llvm.org/D40643 Files: include/clang-c/Index.h tools/libclang/CIndex.cpp Index: tools/libclang/CIndex.cpp

[PATCH] D33765: Show correct column nr. when multi-byte utf8 chars are used.

erikjv updated this revision to Diff 124903. erikjv added a comment. I moved all code to the TextDiagnostics, so all other interfaces still get byte offsets. https://reviews.llvm.org/D33765 Files: lib/Frontend/TextDiagnostic.cpp test/Misc/diag-utf8.cpp Index: test/Misc/diag-utf8.cpp

[PATCH] D40643: [libclang] Add function to get the buffer for a file

erikjv created this revision. This can be used by clients in conjunction with an offset returned by e.g. clang_getFileLocation. Now those clients do not need to also open/read the file. https://reviews.llvm.org/D40643 Files: include/clang-c/Index.h tools/libclang/CIndex.cpp Index:

[PATCH] D40640: Fix code completion crash with unresolved member expr and explicit base

erikjv created this revision. This is actually a failing assert. When doing object argument initialization, it is valid to have e.g. 'this' as a base in a member access expression (which is a prvalue). It's also possible to have a scope specifier as part of the member expression, in which case a

[PATCH] D38578: [preamble] Also record the "skipping" state of the preprocessor

erikjv closed this revision. erikjv added a comment. Submitted as r317308. https://reviews.llvm.org/D38578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

erikjv added a comment. Maybe something like this works: --- a/tools/libclang/CIndex.cpp +++ b/tools/libclang/CIndex.cpp @@ -8090,6 +8090,7 @@ CXSourceRangeList *clang_getSkippedRanges(CXTranslationUnit TU, CXFile file) { SourceManager = Ctx.getSourceManager(); FileEntry

[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

erikjv closed this revision. erikjv added a comment. Committed as r318142. https://reviews.llvm.org/D37554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

erikjv added a comment. The patch has aged a bit since upload, so does it still apply? And, can you add a testcase please? Repository: rL LLVM https://reviews.llvm.org/D20124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38618: Do not add a colon chunk to the code completion of class inheritance access modifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rL316436: Do not add a colon chunk to the code completion of class inheritance access… (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D38618?vs=119273=120067#toc Repository:

[PATCH] D38578: [preamble] Also record the "skipping" state of the preprocessor

erikjv updated this revision to Diff 117986. https://reviews.llvm.org/D38578 Files: include/clang/Lex/Preprocessor.h lib/Lex/PPDirectives.cpp lib/Lex/Preprocessor.cpp lib/Serialization/ASTReader.cpp lib/Serialization/ASTWriter.cpp test/Index/preamble-conditionals-inverted.cpp

[PATCH] D38615: [libclang] Only mark CXCursors for explicit attributes with a type

erikjv updated this revision to Diff 117975. erikjv added a comment. Added more context to the diff https://reviews.llvm.org/D38615 Files: test/Index/annotate-tokens-unexposed.cpp tools/libclang/CIndex.cpp Index: tools/libclang/CIndex.cpp

[PATCH] D38615: [libclang] Only mark CXCursors for explicit attributes with a type

erikjv created this revision. All attributes have a source range associated with it. However, implicit attributes are added by the compiler, and not added because the user wrote something in the input. So no token type should be set to CXCursor_*Attr. The problem was visible when a class gets

[PATCH] D38578: [preamble] Also record the "skipping" state of the preprocessor

erikjv created this revision. When a preamble ends in a conditional preprocessor block that is being skipped, the preprocessor needs to continue skipping that block when the preamble is used. This fixes PR34570. https://reviews.llvm.org/D38578 Files: include/clang/Lex/Preprocessor.h

[PATCH] D33765: Show correct column nr. when multi-byte utf8 chars are used.

erikjv updated this revision to Diff 117660. erikjv edited the summary of this revision. https://reviews.llvm.org/D33765 Files: include/clang/Basic/SourceManager.h lib/Basic/SourceManager.cpp test/Misc/diag-utf8.cpp Index: test/Misc/diag-utf8.cpp

[PATCH] D37700: Fix recording preamble's conditional stack in skipped PP branches.

erikjv added a comment. I'd put/fix Nik's issue in a separate patch. https://reviews.llvm.org/D37700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37491: [Preamble] Fixed preamble breaking with BOM presence (and particularly, fluctuating BOM presence)

erikjv added a comment. Will this fix PR25023 and PR21144? https://reviews.llvm.org/D37491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36821: [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit*

This revision was automatically updated to reflect the committed changes. Closed by commit rL311990: [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit* (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D36821?vs=111472=113041#toc Repository: rL LLVM

[PATCH] D35355: Fix templated type alias completion when using global completion cache

This revision was automatically updated to reflect the committed changes. Closed by commit rL311442: Fix templated type alias completion when using global completion cache (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D35355?vs=109968=112144#toc Repository: rL LLVM

[PATCH] D35355: Fix templated type alias completion when using global completion cache

erikjv added a comment. I'll commit it, probably next Tuesday. https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36872: Fixed a crash on replaying Preamble's PP conditional stack.

erikjv added a comment. Can you check if the example in https://bugs.llvm.org/show_bug.cgi?id=33574 works correctly? Comment at: include/clang/Lex/Preprocessor.h:2029 + private: // Macro handling. Duplicate "private:" https://reviews.llvm.org/D36872

[PATCH] D33644: Add default values for function parameter chunks

This revision was automatically updated to reflect the committed changes. Closed by commit rL308433: Add default values for function parameter chunks (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D33644?vs=107077=107276#toc Repository: rL LLVM

[PATCH] D35186: [analyzer] Add annotation for functions taking user-facing strings

This revision was automatically updated to reflect the committed changes. Closed by commit rL308012: [analyzer] Add annotation for functions taking user-facing strings (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D35186?vs=105792=106605#toc Repository: rL LLVM

[PATCH] D35186: [analyzer] Add annotation for functions taking user-facing strings

erikjv updated this revision to Diff 105792. erikjv added a comment. Sorry, now with more context in the diff. https://reviews.llvm.org/D35186 Files: lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp test/Analysis/localization-aggressive.m Index: test/Analysis/localization-aggressive.m

[PATCH] D35186: [analyzer] Add annotation for functions taking user-facing strings

erikjv created this revision. Herald added a subscriber: xazax.hun. There was already a returns_localized_nsstring annotation to indicate that the return value could be passed to UIKit methods that would display them. However, those UIKit methods were hard-coded, and it was not possible to

[PATCH] D33493: Speed up preamble loading

This revision was automatically updated to reflect the committed changes. Closed by commit rL305061: Speed up preamble loading (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D33493?vs=101995=102003#toc Repository: rL LLVM https://reviews.llvm.org/D33493 Files:

[PATCH] D33765: Show correct column nr. when multi-byte utf8 chars are used.

erikjv created this revision. Previously, the column number in a diagnostic would be the byte position in the line. This results in incorrect column numbers when a multi-byte UTF-8 character would be present in the input. By ignoring all bytes starting with 0b10 the correct column number is

[PATCH] D33042: [libclang] Allow to suspend a translation unit.

erikjv closed this revision. erikjv added a comment. Committed as r304212. https://reviews.llvm.org/D33042 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33405: Mark all ARCMT test files as binary files in git, just like with svn

erikjv added a comment. Ping? https://reviews.llvm.org/D33405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15994: Allow for unfinished #if blocks in preambles.

This revision was automatically updated to reflect the committed changes. erikjv marked 3 inline comments as done. Closed by commit rL304207: Allow for unfinished #if blocks in preambles (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D15994?vs=98757=100691#toc

[PATCH] D33405: Mark all ARCMT test files as binary files in git, just like with svn

erikjv created this revision. Herald added a subscriber: javed.absar. This is a work-around for ARCMT's inability to handle Windows-style line terminators (\r\n) correctly. The underlying problem seems to be that line terminators are assumed to be 1 character long. So with files ending with \r\n

[PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv updated this revision to Diff 98757. https://reviews.llvm.org/D15994 Files: include/clang/Lex/Preprocessor.h include/clang/Lex/PreprocessorLexer.h include/clang/Lex/PreprocessorOptions.h include/clang/Serialization/ASTBitCodes.h lib/Frontend/ASTUnit.cpp lib/Lex/Lexer.cpp

[PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv marked 8 inline comments as done. erikjv added a comment. Fixed with the next patch. https://reviews.llvm.org/D15994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27810: FileManager: mark virtual file entries as valid entries

erikjv closed this revision. erikjv added a comment. Committed as r298905. https://reviews.llvm.org/D27810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27810: FileManager: mark virtual file entries as valid entries

erikjv updated this revision to Diff 93221. erikjv added a comment. Added a test for the specific scenario, and added asserts for validity of UFEs returned by getVirtualFile. https://reviews.llvm.org/D27810 Files: lib/Basic/FileManager.cpp unittests/Basic/FileManagerTest.cpp Index:

[PATCH] D30248: [libclang] Fix crash in member access code completion with implicit base

erikjv closed this revision. erikjv added a comment. Landed as r298903. https://reviews.llvm.org/D30248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27810: FileManager: mark virtual file entries as valid entries

erikjv added a comment. @klimek no, it's a 1 line fix. The rest was the previous version of the patch. https://reviews.llvm.org/D27810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27810: FileManager: mark virtual file entries as valid entries

erikjv added a comment. @kfunk yes and yes, so @bkramer or @klimek : ping? https://reviews.llvm.org/D27810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30248: [libclang] Fix crash in member access code completion with implicit base

erikjv created this revision. If there is an unresolved member access AST node, and the base is implicit, do not access/use it for generating candidate overloads for code completion results (because the base is a nullptr). Fixes PR31093. https://reviews.llvm.org/D30248 Files:

[PATCH] D27810: FileManager: mark virtual file entries as valid entries

erikjv updated this revision to Diff 88874. erikjv retitled this revision from "Normalize all filenames before searching FileManager caches" to "FileManager: mark virtual file entries as valid entries". erikjv edited the summary of this revision. https://reviews.llvm.org/D27810 Files:

[PATCH] D29755: Cache FileID when translating diagnostics in PCH files

This revision was automatically updated to reflect the committed changes. Closed by commit rL295301: Cache FileID when translating diagnostics in PCH files (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D29755?vs=88366=88701#toc Repository: rL LLVM

[PATCH] D29755: Cache FileID when translating diagnostics in PCH files

erikjv updated this revision to Diff 88366. https://reviews.llvm.org/D29755 Files: lib/Frontend/ASTUnit.cpp Index: lib/Frontend/ASTUnit.cpp === --- lib/Frontend/ASTUnit.cpp +++ lib/Frontend/ASTUnit.cpp @@ -2539,14 +2539,19 @@

[PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv updated this revision to Diff 87792. https://reviews.llvm.org/D15994 Files: include/clang/Lex/Preprocessor.h include/clang/Lex/PreprocessorLexer.h include/clang/Lex/PreprocessorOptions.h include/clang/Serialization/ASTBitCodes.h lib/Frontend/ASTUnit.cpp lib/Lex/Lexer.cpp

[PATCH] D29755: Cache FileID when translating diagnostics in PCH files

erikjv created this revision. Modules/preambles/PCH files can contain diagnostics, which, when used, are added to the current ASTUnit. For that to work, they are translated to use the current FileManager's FileIDs. When the entry is not the main file, all local source locations will be checked by

[PATCH] D27810: Normalize all filenames before searching FileManager caches

erikjv updated this revision to Diff 87376. erikjv added a comment. Fixed all failing tests on Windows. https://reviews.llvm.org/D27810 Files: lib/Basic/FileManager.cpp lib/Basic/VirtualFileSystem.cpp lib/StaticAnalyzer/Core/BugReporterVisitors.cpp test/CodeGen/debug-prefix-map.c

[PATCH] D27810: Normalize all filenames before searching FileManager caches

erikjv added inline comments. Comment at: lib/Basic/FileManager.cpp:218 +#ifdef LLVM_ON_WIN32 + SmallString<128> NormalizedPath(Filename.str()); + llvm::sys::path::native(NormalizedPath); yaron.keren wrote: > I'd use a larger SmallString<256>, with large

[PATCH] D27810: Normalize all filenames before searching FileManager caches

erikjv added a comment. besc: I can't reproduce any crash. I tried trunk and the release_39 branch with msvc2015. https://reviews.llvm.org/D27810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27810: Normalize all filenames before searching FileManager caches

erikjv created this revision. erikjv added reviewers: bkramer, klimek. erikjv added a subscriber: cfe-commits. The problem on windows is that both forward-slashes and back-slashes are accepted as path separators. However, the FileManager stores the path as reported by the OS after opening the

[PATCH] D21075: Correct invalid end location in diagnostics for some identifiers.

erikjv updated this revision to Diff 80735. https://reviews.llvm.org/D21075 Files: lib/Parse/ParseDecl.cpp lib/Sema/SemaExpr.cpp test/Index/diagnostic-ranges.cpp Index: test/Index/diagnostic-ranges.cpp === --- /dev/null +++

[PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv updated this revision to Diff 80589. https://reviews.llvm.org/D15994 Files: include/clang/Lex/Preprocessor.h include/clang/Lex/PreprocessorLexer.h include/clang/Lex/PreprocessorOptions.h include/clang/Serialization/ASTBitCodes.h lib/Frontend/ASTUnit.cpp lib/Lex/Lexer.cpp

[PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv marked 7 inline comments as done. erikjv added inline comments. Comment at: lib/Serialization/ASTReader.cpp:2816 +} +PP.setReplayablePreambleConditionalStack(ConditionalStack); + } rsmith wrote: > Why can't we set the conditional