[PATCH] D70157: Align branches within 32-Byte boundary

fedor.sergeev added a comment. In D70157#1776424 , @skan wrote: > > What if I insert explicit align(8) right *after* the sequence? > > If your insert explicit `.align 8` after the sequence, and the sequence > doesn't has any branch to be aligned, the

[PATCH] D70157: Align branches within 32-Byte boundary

fedor.sergeev added a comment. In D70157#1775016 , @annita.zhang wrote: > > The point is that we have explicit requirement at the start and we have a > > lowering into 16-byte sequence that we need to be preserved exactly as it > > is. > > Essentially

[PATCH] D70157: Align branches within 32-Byte boundary

fedor.sergeev added a comment. In D70157#1774561 , @skan wrote: > I could not reproduce the phenomenon that N-byte nop becomes (N+M) bytes with > your example. So according to my understanding, I slightly modified your > case. (If my understand is

[PATCH] D70157: Align branches within 32-Byte boundary

fedor.sergeev added a comment. In D70157#1768310 , @skan wrote: > fix the bug > > https://bugs.llvm.org/show_bug.cgi?id=44215 FYI: I did close the bug as fixed after verifying that the fix works for me. CHANGES SINCE LAST ACTION

[PATCH] D70157: Align branches within 32-Byte boundary

fedor.sergeev requested changes to this revision. fedor.sergeev added a comment. This revision now requires changes to proceed. In D70157#1767212 , @fedor.sergeev wrote: > Working on getting upstream reproducer Hangs on a moderately small piece

[PATCH] D70157: Align branches within 32-Byte boundary

fedor.sergeev added a comment. Just FYI for now as I'm trying to dig futher... I have been trying this fix in our downstream environment and managed to get a hang with this backtrace: #0 needPadding (BoundarySize=, Size=, StartAddr=) at ./llvm/lib/MC/MCAssembler.cpp:1028 #1

[PATCH] D65975: [NewPM][PassInstrumentation] IR printing support from clang driver

fedor.sergeev accepted this revision. fedor.sergeev added a comment. This revision is now accepted and ready to land. LGTM. Thanks for addressing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65975/new/ https://reviews.llvm.org/D65975

[PATCH] D65975: [NewPM][PassInstrumentation] IR printing support from clang driver

fedor.sergeev added a comment. In D65975#1621892 , @twoh wrote: > @fedor.sergeev @yamauchi I saw your discussions over llvm-dev mailing list > regarding IR printing with the new pass manager, and though this might be the > reason why IR printing is not

[PATCH] D57835: Fix -ftime-report with -x ir

fedor.sergeev requested changes to this revision. fedor.sergeev added a comment. This revision now requires changes to proceed. just to make the comments visible :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57835/new/ https://reviews.llvm.org/D57835

[PATCH] D57835: Fix -ftime-report with -x ir

fedor.sergeev added inline comments. Comment at: test/Frontend/ftime-report-bitcode.ll:1 +; RUN: %clang_cc1 -triple x86_64-apple-darwin10 -ftime-report -emit-obj -o /dev/null %s 2>&1 | FileCheck %s + Can you, please, test -fexperimental-new-pass-manager mode as

[PATCH] D57835: Fix -ftime-report with -x ir

fedor.sergeev added a comment. In D57835#1387622 , @arsenm wrote: > I partially solved the problem with double printing the reports. It's from > this in cc1_main: > > // If any timers were active but haven't been destroyed yet, print theirp > //

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

fedor.sergeev added a comment. In D57265#1393453 , @vsk wrote: > > I'd prefer not adding this kind of state to PassBuilder. SplitColdCode is > > soemthing that refers to the construction of one particular pipeline, not > > to pipeline-building in

[PATCH] D52814: [PassManager/Sanitizer] Enable usage of ported AddressSanitizer passes with -fsanitize=address

fedor.sergeev accepted this revision. fedor.sergeev added a comment. LGTM. Repository: rC Clang https://reviews.llvm.org/D52814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52814: [PassManager/Sanitizer] Enable usage of ported AddressSanitizer passes with -fsanitize=address

fedor.sergeev added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:1031-1038 + MPM.addPass(AddressSanitizerModulePass()); + + // Add Function Pass + CGSCCPassManager MainCGPipeline(CodeGenOpts.DebugPassManager); +

[PATCH] D41241: [Solaris] Only define _REENTRANT if -pthread

fedor.sergeev accepted this revision. fedor.sergeev added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D41241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

fedor.sergeev accepted this revision. fedor.sergeev added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D41240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41242: [Solaris] Silence -pthread warning on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rC324344: [Solaris] Silence -pthread warning on Solaris (authored by fedor.sergeev, committed by ). Repository: rC Clang https://reviews.llvm.org/D41242 Files: lib/Driver/ToolChains/Solaris.cpp

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

This revision was automatically updated to reflect the committed changes. Closed by commit rL323193: [Solaris] gcc toolchain handling revamp (authored by fedor.sergeev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D42029: [Solaris] Make RHEL devtoolsets handling Linux-specific

This revision was automatically updated to reflect the committed changes. Closed by commit rL323194: [Solaris] Make RHEL devtoolsets handling Linux-specific (authored by fedor.sergeev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D42029: [Solaris] Make RHEL devtoolsets handling Linux-specific

fedor.sergeev added a comment. I'm trying! I had no access to Solaris box, and I finally got one yesterday, though it is rather old one and slow. I plan to resolve it all till the end of this week. Repository: rC Clang https://reviews.llvm.org/D42029

[PATCH] D42029: [Solaris] Make RHEL devtoolsets handling Linux-specific

fedor.sergeev accepted this revision. fedor.sergeev added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D42029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41242: [Solaris] Silence -pthread warning on Solaris

fedor.sergeev accepted this revision. fedor.sergeev added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D41242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39640: [lit] Set shlibpath_var on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL319026: [lit] Set shlibpath_var on Solaris (authored by fedor.sergeev). Changed prior to commit: https://reviews.llvm.org/D39640?vs=121626=124363#toc Repository: rL LLVM

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

fedor.sergeev marked an inline comment as not done. fedor.sergeev added a comment. In https://reviews.llvm.org/D35755#930030, @ro wrote: > What's the status here? This patch is required for my WIP > sanitizers-on-Solaris work. since @tstellar just resolved the only remaining question I will

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

fedor.sergeev added a comment. In https://reviews.llvm.org/D34158#836026, @jyknight wrote: > In https://reviews.llvm.org/D34158#827178, @joerg wrote: > > > I had a long discussion with James about this on IRC without reaching a > > clear consensus. I consider forcing this behavior on all

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

fedor.sergeev marked an inline comment as not done. fedor.sergeev added inline comments. Comment at: lib/Driver/ToolChains/Gnu.h:253 +void AddDefaultGCCPrefixes(const llvm::Triple , + SmallVectorImpl , aaron.ballman wrote: >

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

fedor.sergeev updated this revision to Diff 110194. fedor.sergeev added a comment. ugh... reverting back to llvm::Triple, since plain Triple conflicts with clang::driver::Toolchain::Triple data member. Built/tested on Solaris11 x86/SPARC, Linux x86. https://reviews.llvm.org/D35755 Files:

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

fedor.sergeev updated this revision to Diff 110190. fedor.sergeev added a comment. auto changed to MultilibSet::IncludeDirsFunc. https://reviews.llvm.org/D35755 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Gnu.h lib/Driver/ToolChains/Solaris.cpp

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

fedor.sergeev added a comment. In https://reviews.llvm.org/D34158#834298, @mibintc wrote: > In fact I did have trouble writing the new test case to pass with the > gnu/Linux toolchain. In the file lib/Driver/ToolChains/Linux.cpp function > AddGnuIncludeArgs checks if GCCInstallation.isValid().

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

fedor.sergeev added a reviewer: tstellar. fedor.sergeev marked 11 inline comments as done. fedor.sergeev added inline comments. Comment at: lib/Driver/ToolChains/Gnu.cpp:1840 +// Yet, still look for RHEL devtoolsets +// (should it be done Linux-only??) +

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

fedor.sergeev updated this revision to Diff 109593. fedor.sergeev added a comment. Corrected comments as suggested by Aaron. Will be replying on other suggestions inline. https://reviews.llvm.org/D35755 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Gnu.h

[PATCH] D34158: For standards compatibility, preinclude if the file is available

fedor.sergeev added inline comments. Comment at: test/Driver/stdc-predef.c:15 + /* In this test, the file stdc-predef.h is missing from the installation */ +#if _STDC_PREDEF_H + #error "stdc-predef.h should not be included" I would rather see a real check on

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

fedor.sergeev added a comment. ping? https://reviews.llvm.org/D35755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34158: For standards compatibility, preinclude if the file is available

fedor.sergeev added a comment. In https://reviews.llvm.org/D34158#824079, @jyknight wrote: > In https://reviews.llvm.org/D34158#823316, @fedor.sergeev wrote: > > > Hmm... I tried this patch and now the following worries me: > > > > - it passes -finclude-if-exists stdc-predef.h on all platforms

[PATCH] D34158: For standards compatibility, preinclude if the file is available

fedor.sergeev added a comment. Hmm... I tried this patch and now the following worries me: - it passes -finclude-if-exists stdc-predef.h on all platforms (say, including my Solaris platform that has no system stdc-predef.h) - it searches all the paths, not just "system include" ones That

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

fedor.sergeev created this revision. General idea is to utilize generic (mostly Generic_GCC) code and get rid of Solaris-specific handling as much as possible. In particular: - scanLibDirForGCCTripleSolaris was removed, relying on generic CollectLibDirsAndTriples - findBiarchMultilibs is now

[PATCH] D35337: [Solaris] gcc runtime dropped support for .ctors, switch to .init_array

fedor.sergeev added a comment. Can anybody commit this for me, please? :-/ https://reviews.llvm.org/D35337 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35337: [Solaris] gcc runtime dropped support for .ctors, switch to .init_array

fedor.sergeev added inline comments. Comment at: lib/Driver/ToolChains/Gnu.cpp:2467 const Generic_GCC::GCCVersion = GCCInstallation.getVersion(); bool UseInitArrayDefault = getTriple().getArch() == llvm::Triple::aarch64 || davide wrote: > this is

[PATCH] D35337: [Solaris] gcc runtime dropped support for .ctors, switch to .init_array

fedor.sergeev updated this revision to Diff 106392. fedor.sergeev added a comment. Added Solaris targets to clang driver test checking for -fuse-init-array. https://reviews.llvm.org/D35337 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Solaris.cpp

[PATCH] D35337: [Solaris] gcc runtime dropped support for .ctors, switch to .init_array

fedor.sergeev added a comment. Note, that LLVM has already been changed to honor use-init-array on Solaris: https://reviews.llvm.org/rL305948 (before that change setting Options.UseInitArray in clang would not matter). https://reviews.llvm.org/D35337

[PATCH] D35337: [Solaris] gcc runtime dropped support for .ctors, switch to .init_array

fedor.sergeev created this revision. crtbegin.o from gcc toolchain as configured on latest Solaris (with --enable-initfini-array) does not have support for .ctors. Clang needs to switch to .init_array. Doing it unconditionally is fine since older Solaris configurations do support .init_array.

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

fedor.sergeev added a comment. > can you recommend someone to review the extra test changes? I'm rather new to the project and thus rather bad at finding reviewers. Also generally I do not consider myself qualified enough to be the only reviewer, though in this particular case I believe I spent

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

fedor.sergeev added a comment. LGTM wrt your update to sources. And sorry, I'm not that qualified to answer your question on failing tests. Probing existence of this header would make a sense, yet you are including it w/o a full path, so how are you going to find it for this probe?

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

fedor.sergeev added a comment. > docs are rather clear that this functionality is Linux-only Oh, well, gcc implementation is rather generic, it relies on gcc's config.gcc to detect glibc and then it adds a hook that unconditionally provides stdc-predef.h (TARGET_C_PREINCLUDE). Currently

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

fedor.sergeev added inline comments. Comment at: lib/Driver/ToolChains/Gnu.h:219-220 +void AddGnuIncludeArgs(const llvm::opt::ArgList , + llvm::opt::ArgStringList ) const; + To me this does not belong to GCC-Installation-Detector

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

fedor.sergeev added a comment. There is no /usr/include/stdc-predef.h on Solaris and I see no sense in adding this -include for anything except Linux (as docs are rather clear that this functionality is Linux-only). Checked gcc on Solaris11/12 both SPARC and X86 - none are doing stdc-predef.h