[libclc] [libclc] Add initial LIT tests (PR #87989)

@@ -1,3 +1,6 @@ -__kernel void foo(int *i) { +// RUN: %clang -emit-llvm -S -o - %s | FileCheck %s frasercrmck wrote: That's true, but I'm still sceptical that we can make the tests simple enough for `update_cc_test_checks` to be viable. We'd have to embed

[libclc] [libclc] Use a response file when building on Windows (PR #89756)

https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/89756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Use a response file when building on Windows (PR #89756)

@@ -88,10 +88,25 @@ function(link_bc) ${ARGN} ) + set( LINK_INPUT_ARG ${ARG_INPUTS} ) + if( WIN32 OR CYGWIN ) +# Create a response file in case the number of inputs exceeds command-line +# character limits on certain platforms. +file( TO_CMAKE_PATH

[libclc] [libclc] Use a response file when building on Windows (PR #89756)

https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/89756 We've recently seen the libclc llvm-link invocations become so long that they exceed the character limits on certain platforms. Using a 'response file' should solve this by offloading the list of inputs

[libclc] [libclc] Fix build with Unix Makefiles (PR #89147)

@@ -39,6 +39,10 @@ function(compile_to_bc) set( TARGET_ARG "-target" ${ARG_TRIPLE} ) endif() + # Ensure the directory we are told to output to exists + get_filename_component( ARG_OUTPUT_DIR ${ARG_OUTPUT} DIRECTORY ) frasercrmck wrote: Yeah, there

[libclc] [libclc] Fix build with Unix Makefiles (PR #89147)

https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/89147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Fix build with Unix Makefiles (PR #89147)

https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/89147 >From 0f102a202e4a80fbc106303df5005a2b7922b0cf Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Wed, 17 Apr 2024 22:28:03 +0100 Subject: [PATCH] [libclc] Fix build with Unix Makefiles Commit #87622 broke

[libclc] dc74c69 - [libclc] Provide a more helpful error when tools are missing

Author: Fraser Cormack Date: 2024-04-18T07:01:13+01:00 New Revision: dc74c69f016fa65949bf0cf691061e12bef93d29 URL: https://github.com/llvm/llvm-project/commit/dc74c69f016fa65949bf0cf691061e12bef93d29 DIFF:

[libclc] 0aeeff3 - [libclc] Allow building with pre-built tools

Author: Fraser Cormack Date: 2024-04-18T07:01:13+01:00 New Revision: 0aeeff3059e79b86f55ed92a4488bdee8fa66e12 URL: https://github.com/llvm/llvm-project/commit/0aeeff3059e79b86f55ed92a4488bdee8fa66e12 DIFF:

[libclc] 93d5119 - [libclc] Clarify option help message

Author: Fraser Cormack Date: 2024-04-18T07:01:13+01:00 New Revision: 93d51194b1df8229268953ec94063fc4194a320b URL: https://github.com/llvm/llvm-project/commit/93d51194b1df8229268953ec94063fc4194a320b DIFF:

[libclc] 06f54e7 - [libclc] Convert llvm-spirv to imported executable

Author: Fraser Cormack Date: 2024-04-18T07:01:13+01:00 New Revision: 06f54e7c2b4f26fbcad906a6b4aa2e46bf60b8af URL: https://github.com/llvm/llvm-project/commit/06f54e7c2b4f26fbcad906a6b4aa2e46bf60b8af DIFF:

[libclc] [libclc] Fix build with Unix Makefiles (PR #89147)

https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/89147 Commit #87622 broke the build. Ninja was happy with creating the output directories as necessary, but Unix Makefiles isn't. Ensure they are always created. Fixes #88626. >From

[libclc] [libclc] Add initial LIT tests (PR #87989)

@@ -1,3 +1,6 @@ -__kernel void foo(int *i) { +// RUN: %clang -emit-llvm -S -o - %s | FileCheck %s frasercrmck wrote: Fair enough, I hadn't really appreciated that `update_cc_test_checks` was orthogonal to all of these other LIT concepts like `REQUIRES` and

[libclc] [libclc] Add initial LIT tests (PR #87989)

@@ -1,3 +1,6 @@ -__kernel void foo(int *i) { +// RUN: %clang -emit-llvm -S -o - %s | FileCheck %s frasercrmck wrote: I wasn't so much thinking that it would pretend to be generic, but rather that it'd use a custom test format (something like

[libclc] [libclc] Add initial LIT tests (PR #87989)

@@ -1,3 +1,6 @@ -__kernel void foo(int *i) { +// RUN: %clang -emit-llvm -S -o - %s | FileCheck %s frasercrmck wrote: Ach I misunderstood how `update_cc_test_checks` works. It doesn't actually go through the regular LIT infrastructure, so we can't do anything

[libclc] [libclc] Add initial LIT tests (PR #87989)

@@ -1,3 +1,6 @@ -__kernel void foo(int *i) { +// RUN: %clang -emit-llvm -S -o - %s | FileCheck %s frasercrmck wrote: Yes, I was hoping to explore in that direction. I've kind of just copied the skeleton of the LIT tests we have downstream, but as you say, this

[libclc] [llvm] [libclc] Allow building with pre-built tools (PR #88922)

https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/88922 >From bff3b97b599e1c9529a95ead9d61f9ecc9cad129 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Tue, 16 Apr 2024 15:30:20 +0100 Subject: [PATCH 1/5] [libclc] Convert llvm-spirv to imported executable

[libclc] [libclc] Add initial LIT tests (PR #87989)

https://github.com/frasercrmck edited https://github.com/llvm/llvm-project/pull/87989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Add initial LIT tests (PR #87989)

https://github.com/frasercrmck edited https://github.com/llvm/llvm-project/pull/87989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [WIP] Libclc tests (PR #87989)

https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/87989 >From 9048dbc6547fa14c78649d02f27d68fc27ca7e70 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Thu, 4 Apr 2024 17:49:13 +0100 Subject: [PATCH] [libclc] Add initial LIT tests These tests aren't very

[libclc] [libclc] Allow building with pre-built tools (PR #88922)

https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/88922 Building the libclc project in-tree with debug tools can be very slow. This commit adds an option for a user to specify a dierctory from which to import (e.g., release-built) tools. All tools required by the

[libclc] 9d11128 - [libclc] Improve clarity of CMake foreach. NFC.

Author: Fraser Cormack Date: 2024-04-16T16:50:14+01:00 New Revision: 9d111286322ec99b32467eef3aeec6b588c49f18 URL: https://github.com/llvm/llvm-project/commit/9d111286322ec99b32467eef3aeec6b588c49f18 DIFF:

[libclc] 3d118f9 - [libclc] Fix dependencies between targets

Author: Fraser Cormack Date: 2024-04-16T15:20:26+01:00 New Revision: 3d118f92081ea0c7048749dc5d08c8e8217be4eb URL: https://github.com/llvm/llvm-project/commit/3d118f92081ea0c7048749dc5d08c8e8217be4eb DIFF:

[libclc] a0f8191 - [libclc] Give built bytecode objects a .bc extension. NFC

Author: Fraser Cormack Date: 2024-04-16T15:20:26+01:00 New Revision: a0f8191af3945482f0f7a7c8f030e8c519a795b7 URL: https://github.com/llvm/llvm-project/commit/a0f8191af3945482f0f7a7c8f030e8c519a795b7 DIFF:

[libclc] [WIP] Libclc tests (PR #87989)

https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/87989 >From c53dc3564822f305d09d19dc3b7327b33028fe11 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Thu, 4 Apr 2024 17:49:13 +0100 Subject: [PATCH] [libclc] Add initial LIT tests --- libclc/CMakeLists.txt

[libclc] [llvm] [libclc] Refactor build system to allow in-tree builds (PR #87622)

https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/87622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [llvm] [libclc] Refactor build system to allow in-tree builds (PR #87622)

https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/87622 >From 47cd6ddbf292fd8a50534e091ac64ebee3c40ee5 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Wed, 3 Apr 2024 16:09:30 +0100 Subject: [PATCH 1/4] [libclc] Refactor build system to allow in-tree builds

[libclc] [llvm] [libclc] Refactor build system to allow in-tree builds (PR #87622)

https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/87622 >From 47cd6ddbf292fd8a50534e091ac64ebee3c40ee5 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Wed, 3 Apr 2024 16:09:30 +0100 Subject: [PATCH 1/3] [libclc] Refactor build system to allow in-tree builds

[libclc] [llvm] [libclc] Refactor build system to allow in-tree builds (PR #87622)

https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/87622 >From 47cd6ddbf292fd8a50534e091ac64ebee3c40ee5 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Wed, 3 Apr 2024 16:09:30 +0100 Subject: [PATCH 1/2] [libclc] Refactor build system to allow in-tree builds

[libclc] [llvm] [libclc] Refactor build system to allow in-tree builds (PR #87622)

frasercrmck wrote: CC @mgorny - I was unsure whether you are actively using and interested `libclc` or you were just looking after build bots or some other reason. I've successfully built the SPIR-V libraries out-of-tree but another pair of eyes can't hurt. I was wondering - if we `libclc`

[libclc] [llvm] [libclc] Refactor build system to allow in-tree builds (PR #87622)

https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/87622 >From 47cd6ddbf292fd8a50534e091ac64ebee3c40ee5 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Wed, 3 Apr 2024 16:09:30 +0100 Subject: [PATCH] [libclc] Refactor build system to allow in-tree builds The

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

frasercrmck wrote: > Thanks. Unfortunately, I'm still getting a build failure: > > ``` > [1792/1922] cd /tmp/portage/dev-libs/libclc-19.0.0./work/libclc_build && > /usr/lib/llvm/17/bin/llvm-spirv --spirv-max-version=1.1 -o spirv-mesa3d-.spv > builtins.link.spirv-mesa3d- > FAILED:

[libclc] b439140 - [libclc] Fix more spirv build dependencies

Author: Fraser Cormack Date: 2024-04-08T16:51:30+01:00 New Revision: b439140e2982dd77ef28a9069e16ae77bbe2bc5a URL: https://github.com/llvm/llvm-project/commit/b439140e2982dd77ef28a9069e16ae77bbe2bc5a DIFF:

[libclc] [llvm] [WIP] Libclc tests (PR #87989)

https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/87989 >From b87c2862491aed03f883d6b124a845b0d7c47699 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Wed, 3 Apr 2024 16:09:30 +0100 Subject: [PATCH 1/4] [libclc] Refactor build system to allow in-tree builds

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

frasercrmck wrote: > > > > ``` > > > > set( spv_suffix ${arch_suffix}.spv ) > > > > add_custom_command( OUTPUT "${spv_suffix}" > > > > COMMAND ${LLVM_SPIRV} ${spvflags} -o "${spv_suffix}" > > > > ${builtins_opt_lib_tgt} > > > > DEPENDS ${builtins_link_lib_tgt} ) > >

[libclc] f46f646 - [libclc] Fix spirv build dependencies

Author: Fraser Cormack Date: 2024-04-08T15:48:15+01:00 New Revision: f46f6465062bd6ddc96e3838c50e1a0f85f92dd4 URL: https://github.com/llvm/llvm-project/commit/f46f6465062bd6ddc96e3838c50e1a0f85f92dd4 DIFF:

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

frasercrmck wrote: > > > ``` > > > set( spv_suffix ${arch_suffix}.spv ) > > > add_custom_command( OUTPUT "${spv_suffix}" > > > COMMAND ${LLVM_SPIRV} ${spvflags} -o "${spv_suffix}" > > > ${builtins_opt_lib_tgt} > > > DEPENDS ${builtins_link_lib_tgt} ) > > > ``` > > >

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

frasercrmck wrote: > ``` > set( spv_suffix ${arch_suffix}.spv ) > add_custom_command( OUTPUT "${spv_suffix}" > COMMAND ${LLVM_SPIRV} ${spvflags} -o "${spv_suffix}" > ${builtins_opt_lib_tgt} > DEPENDS ${builtins_link_lib_tgt} ) > ``` > > I think that ought to be

[libclc] [llvm] [WIP] Libclc tests (PR #87989)

https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/87989 None >From b87c2862491aed03f883d6b124a845b0d7c47699 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Wed, 3 Apr 2024 16:09:30 +0100 Subject: [PATCH 1/2] [libclc] Refactor build system to allow in-tree

[libclc] [llvm] [libclc] Refactor build system to allow in-tree builds (PR #87622)

https://github.com/frasercrmck edited https://github.com/llvm/llvm-project/pull/87622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [llvm] [libclc] Refactor build system to allow in-tree builds (PR #87622)

https://github.com/frasercrmck updated https://github.com/llvm/llvm-project/pull/87622 >From b87c2862491aed03f883d6b124a845b0d7c47699 Mon Sep 17 00:00:00 2001 From: Fraser Cormack Date: Wed, 3 Apr 2024 16:09:30 +0100 Subject: [PATCH] [libclc] Refactor build system to allow in-tree builds The

[libclc] [llvm] [libclc] Refactor build system to allow in-tree builds (PR #87622)

@@ -358,3 +399,7 @@ foreach( t ${LIBCLC_TARGETS_TO_BUILD} ) endif() endforeach( d ) endforeach( t ) + +if( NOT LIBCLC_STANDALONE_BUILD ) + add_subdirectory( test ) frasercrmck wrote: Ach yeah sorry, I have another path locally which adds some LIT tests

[libclc] [llvm] [libclc] Refactor build system to allow in-tree builds (PR #87622)

@@ -27,31 +36,51 @@ set( LIBCLC_TARGETS_TO_BUILD "all" option( ENABLE_RUNTIME_SUBNORMAL "Enable runtime linking of subnormal support." OFF ) -find_package(LLVM REQUIRED HINTS "${LLVM_CMAKE_DIR}") -include(AddLLVM) +if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

frasercrmck wrote: > This change broke standalone build against LLVM dylib — it now insists on > linking to non-existing static libraries: > > ``` > FAILED: prepare_builtins > : && /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -march=znver2 > --param=l1-cache-size=32

[libclc] 8461d90 - [libclc] Restore linking against dynamic libLLVM for out-of-tree builds

Author: Fraser Cormack Date: 2024-04-08T11:05:38+01:00 New Revision: 8461d901a770516cf2069fe3bce979a6f8fc8d76 URL: https://github.com/llvm/llvm-project/commit/8461d901a770516cf2069fe3bce979a6f8fc8d76 DIFF:

[libclc] 338ecfb - [libclc] Use VERSION_GREATER_EQUAL where appropriate. NFC

Author: Fraser Cormack Date: 2024-04-04T17:56:40+01:00 New Revision: 338ecfbac351e4b211836ad73d75bbdf729e9134 URL: https://github.com/llvm/llvm-project/commit/338ecfbac351e4b211836ad73d75bbdf729e9134 DIFF:

[libclc] [libclc] Track dependencies through dependency files (PR #86965)

https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/86965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Track dependencies through dependency files (PR #86965)

frasercrmck wrote: > The build here seems to be trying to define clc as a language, which then > results in needing to rely on language support magic like this. I think it > would be better if this did what rocm-device-libs does and treat these as > custom targets. I don't think it's

[libclc] [libclc] Track dependencies through dependency files (PR #86965)

https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/86965 This commit fixes the problem of missing build dependencies between libclc source files and their various includes (namely headers and .inc files). We would like to do this with compiler-generated

[libclc] [libclc] Make CMake messages better fit into LLVM (PR #86945)

https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/86945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Make CMake messages better fit into LLVM (PR #86945)

https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/86945 The libclc project is currently only properly supported as an external project. However, when trying to get it to also build in-tree, the CMake configuration messages it outputs stand out amongst the rest

[clang] 4b369ff - [analyzer][NFC] Fix unused variable warning

Author: Fraser Cormack Date: 2024-03-20T11:43:38Z New Revision: 4b369ff076d9205ddbcfcdef89276a737a83ce0e URL: https://github.com/llvm/llvm-project/commit/4b369ff076d9205ddbcfcdef89276a737a83ce0e DIFF: https://github.com/llvm/llvm-project/commit/4b369ff076d9205ddbcfcdef89276a737a83ce0e.diff

[libclc] [libclc] Convert tabs to spaces in CMake (PR #85634)

frasercrmck wrote: > > FWIW I don't think the build bots are actually building `libclc`. > > Locally, at least, it's not sufficient to specify > > `LLVM_ENABLE_PROJECTS=libclc` - you _also_ need > > `LLVM_EXTERNAL_PROJECTS=libclc`. Even then, it doesn't build for me > > in-tree, because it

[libclc] [libclc] Convert tabs to spaces in CMake (PR #85634)

https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/85634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Convert tabs to spaces in CMake (PR #85634)

frasercrmck wrote: FWIW I don't think the build bots are actually building `libclc`. Locally, at least, it's not sufficient to specify `LLVM_ENABLE_PROJECTS=libclc` - you _also_ need `LLVM_EXTERNAL_PROJECTS=libclc`. Even then, it doesn't build for me in-tree, because it assumes

[libclc] [libclc] Convert tabs to spaces in CMake (PR #85634)

frasercrmck wrote: @tstellar are you the code owner for `libclc`? https://github.com/llvm/llvm-project/pull/85634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Convert tabs to spaces in CMake (PR #85634)

https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/85634 Having a mix of tabs and spaces makes the diff of any changes to the build system noisier than necessary. This commit unifies them to two spaces. This includes some minor cosmetic changes such as with

[libclc] 37a3de1 - libclc: Fix signed integer underflow in abs_diff

Author: Fraser Cormack Date: 2023-08-31T14:28:16+01:00 New Revision: 37a3de1e2eedf848b8442217ef3790436f69a7db URL: https://github.com/llvm/llvm-project/commit/37a3de1e2eedf848b8442217ef3790436f69a7db DIFF:

[clang] 7793db3 - [OpenCL] Check for extension string extension lookup

Author: Erik Tomusk Date: 2020-11-27T13:16:39Z New Revision: 7793db35ca2c1fe63687c0a7140cbec540a9aded URL: https://github.com/llvm/llvm-project/commit/7793db35ca2c1fe63687c0a7140cbec540a9aded DIFF: https://github.com/llvm/llvm-project/commit/7793db35ca2c1fe63687c0a7140cbec540a9aded.diff LOG: