Re: r347720 - [RISCV] Mark unit tests as "requires: riscv-registered-target"

2018-12-05 Thread Grang, Mandeep Singh via cfe-commits
Hi Alex, Sorry, I missed this thread. I guess I was too quick to commit my patch. The actual problem seems to be something else due to which riscv32-toolchain.c fails on Windows. The fact that upstream bots seem to be fine could point to a bug in our internal code. Basically it is not able

Patch review please: D48862

2018-07-19 Thread Grang, Mandeep Singh via cfe-commits
Gentle reminder to the reviewers to please review my patch: https://reviews.llvm.org/D48862 [Fix lib paths for OpenEmbedded targets]. I wasn't sure who to add as reviewer for OpenEmbedded targets. So apologies if you are not the correct person to review this. Please feel free to add the correct

Re: r333978 - Reimplement the bittest intrinsic family as builtins with inline asm

2018-06-06 Thread Grang, Mandeep Singh via cfe-commits
@rnk I tried building spec2000/eon for Windows ARM64 and ran into these errors: use of undeclared identifier '_interlockedbittestandset_acq' use of undeclared identifier '_interlockedbittestandset_rel' use of undeclared identifier '_interlockedbittestandset_nf' I see that you have removed them

Re: [PATCH] D40073: [Analyzer] Non-determinism: don't sort indirect goto LabelDecl's by addresses

2017-11-21 Thread Grang, Mandeep Singh via cfe-commits
We have a buildbot setup to uncover such cases of non-determinism: http://lab.llvm.org:8011/builders/reverse-iteration The idea is to iterate unordered containers in reverse to weed out pointer ordering issues. Another instance of non-determinism is relative ordering of elements with the

Re: [PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

2017-08-09 Thread Grang, Mandeep Singh via cfe-commits
> Ah, OK. I'm still curious about whether this results in a loss of test coverage. Without this test, would the bug it was testing still be caught by some test failure in at least one of the forward or reverse iteration modes? Sorry ... I missed that. Yes, the reverse iteration buildbot

Re: [PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

2017-08-09 Thread Grang, Mandeep Singh via cfe-commits
In D35043 I have removed the llvm tests which use -reverse-iterate. This patch removes the clang tests. Should I post a later patch to change all "class PointerLikeTypeTraits" to "struct PointerLikeTypeTraits"? On 8/7/2017 2:50 PM, David Blaikie wrote: On Mon, Aug 7, 2017 at 12:08 PM