Re: [libcxx] r321963 - Add pre-C++11 is_constructible wrappers for 3 arguments

Merged to 6.0 in r322659. On Sun, Jan 7, 2018 at 5:45 PM, Dimitry Andric via cfe-commits wrote: > Author: dim > Date: Sun Jan 7 08:45:11 2018 > New Revision: 321963 > > URL: http://llvm.org/viewvc/llvm-project?rev=321963=rev > Log: > Add pre-C++11 is_constructible

[libcxx] r322659 - Merging r321963:

Author: hans Date: Wed Jan 17 06:26:10 2018 New Revision: 322659 URL: http://llvm.org/viewvc/llvm-project?rev=322659=rev Log: Merging r321963: r321963 | dim | 2018-01-07 08:45:11 -0800 (Sun, 07 Jan 2018) | 51 lines Add

Re: r322390 - [Lex] Avoid out-of-bounds dereference in LexAngledStringLiteral.

Merged in r322649. (Richard, please shout if you object to the merging; I figured since you lgtm'ed it, this would be fine.) On Fri, Jan 12, 2018 at 8:43 PM, Volodymyr Sapsai wrote: > Hans, I am nominating this change to be merged into 6.0.0 release branch. > > Thanks, >

Re: r322236 - In C++17, when instantiating an out-of-line definition of an inline static data

Merged to 6.0 in r322641. On Thu, Jan 11, 2018 at 12:08 AM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Wed Jan 10 15:08:26 2018 > New Revision: 322236 > > URL: http://llvm.org/viewvc/llvm-project?rev=322236=rev > Log: > In C++17, when instantiating

Re: [PATCH] D41837: Add Function multiversion to the release notes.

Did this functionality land before the 6.0 branch, that is, should we copy the release notes to the branch? Thanks Hans On Tue, Jan 9, 2018 at 12:37 AM, Erich Keane via Phabricator wrote: > This revision was automatically updated to reflect the committed changes. >

Re: r322350 - [ODRHash] Don't hash friend functions.

Merged in r322632. On Wed, Jan 17, 2018 at 9:52 AM, NAKAMURA Takumi via cfe-commits wrote: > That's good to hear. Thanks! > > > 2018年1月17日(水) 13:51 Richard Trieu : >> >> I feel it's best to merge this change into the release branch instead of >>

Re: Re: r322018 - [OPENMP] Current status of OpenMP support.

Merged to 6.0 in r322564. Thanks, Hans On Mon, Jan 8, 2018 at 8:21 PM, GMail wrote: > This is is the status of OpenMP support in 6.0. There is nothing new since > branching. > > - > Best regards, > Alexey Bataev > > 08.01.2018 14:09, Jonas Hahnfeld via

Re: r321816 - [OPENMP] Add debug info for generated functions.

Please file a merge request bug blocking PR35804 for what you'd like merged (unless you already have). Thanks, Hans On Mon, Jan 8, 2018 at 5:27 PM, Alexey Bataev via cfe-commits wrote: > Will add some more tests later today > - > Best regards, > Alexey

Re: r321754 - -gmodules: Emit debug info for implicit module imports via #include.

Merged to 6.0 in r322557. On Wed, Jan 3, 2018 at 8:10 PM, Adrian Prantl via cfe-commits wrote: > Author: adrian > Date: Wed Jan 3 11:10:21 2018 > New Revision: 321754 > > URL: http://llvm.org/viewvc/llvm-project?rev=321754=rev > Log: > -gmodules: Emit debug info for

Re: r321771 - [CGBuiltin] Handle unsigned mul overflow properly (PR35750)

Merged to 6.0 in r322555. On Thu, Jan 4, 2018 at 12:11 AM, Vedant Kumar via cfe-commits wrote: > Author: vedantk > Date: Wed Jan 3 15:11:32 2018 > New Revision: 321771 > > URL: http://llvm.org/viewvc/llvm-project?rev=321771=rev > Log: > [CGBuiltin] Handle unsigned

Re: r322518 - Revert 319303: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2

Merged to 6.0 in r322539. On Mon, Jan 15, 2018 at 10:16 PM, Erich Keane via cfe-commits wrote: > Author: erichkeane > Date: Mon Jan 15 13:16:25 2018 > New Revision: 322518 > > URL: http://llvm.org/viewvc/llvm-project?rev=322518=rev > Log: > Revert 319303: Add

Re: [clang-tools-extra] r321762 - [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc

Merged in r321800. Thanks, Hans On Thu, Jan 4, 2018 at 11:20 AM, Alexander Kornienko via cfe-commits wrote: > Yes, would be nice to include this into 6.0. > > On Wed, Jan 3, 2018 at 11:16 PM, Aaron Ballman > wrote: >> >> Hans, I'd like to

[libunwind] r321743 - Update PACKAGE_VERSION to 7.0.0svn

Author: hans Date: Wed Jan 3 08:59:48 2018 New Revision: 321743 URL: http://llvm.org/viewvc/llvm-project?rev=321743=rev Log: Update PACKAGE_VERSION to 7.0.0svn Modified: libunwind/trunk/CMakeLists.txt Modified: libunwind/trunk/CMakeLists.txt URL:

[libunwind] r321741 - Drop 'svn' suffix from the version number.

Author: hans Date: Wed Jan 3 08:58:46 2018 New Revision: 321741 URL: http://llvm.org/viewvc/llvm-project?rev=321741=rev Log: Drop 'svn' suffix from the version number. Modified: libunwind/branches/release_60/CMakeLists.txt Modified: libunwind/branches/release_60/CMakeLists.txt URL:

[libcxx] r321740 - Drop 'svn' suffix from the version number.

Author: hans Date: Wed Jan 3 08:58:30 2018 New Revision: 321740 URL: http://llvm.org/viewvc/llvm-project?rev=321740=rev Log: Drop 'svn' suffix from the version number. Modified: libcxx/branches/release_60/CMakeLists.txt Modified: libcxx/branches/release_60/CMakeLists.txt URL:

[libcxxabi] r321739 - Drop 'svn' suffix from the version number.

Author: hans Date: Wed Jan 3 08:58:21 2018 New Revision: 321739 URL: http://llvm.org/viewvc/llvm-project?rev=321739=rev Log: Drop 'svn' suffix from the version number. Modified: libcxxabi/branches/release_60/CMakeLists.txt Modified: libcxxabi/branches/release_60/CMakeLists.txt URL:

[libunwind] r321732 - Update docs version to 7.0

Author: hans Date: Wed Jan 3 07:58:08 2018 New Revision: 321732 URL: http://llvm.org/viewvc/llvm-project?rev=321732=rev Log: Update docs version to 7.0 Modified: libunwind/trunk/docs/conf.py Modified: libunwind/trunk/docs/conf.py URL:

[clang-tools-extra] r321730 - Docs, release notes: update version to 7.0.0

Author: hans Date: Wed Jan 3 07:53:24 2018 New Revision: 321730 URL: http://llvm.org/viewvc/llvm-project?rev=321730=rev Log: Docs, release notes: update version to 7.0.0 Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst clang-tools-extra/trunk/docs/conf.py Modified:

r321728 - Update docs version and clear release notes for 7.0.0

Author: hans Date: Wed Jan 3 07:49:39 2018 New Revision: 321728 URL: http://llvm.org/viewvc/llvm-project?rev=321728=rev Log: Update docs version and clear release notes for 7.0.0 Modified: cfe/trunk/docs/ReleaseNotes.rst cfe/trunk/docs/conf.py Modified: cfe/trunk/docs/ReleaseNotes.rst

[libcxxabi] r321726 - Update version to 7.0.0svn

Author: hans Date: Wed Jan 3 07:42:34 2018 New Revision: 321726 URL: http://llvm.org/viewvc/llvm-project?rev=321726=rev Log: Update version to 7.0.0svn Modified: libcxxabi/trunk/CMakeLists.txt Modified: libcxxabi/trunk/CMakeLists.txt URL:

[libcxx] r321725 - Update version to 7.0.0svn: cmake, include files and docs

Author: hans Date: Wed Jan 3 07:40:29 2018 New Revision: 321725 URL: http://llvm.org/viewvc/llvm-project?rev=321725=rev Log: Update version to 7.0.0svn: cmake, include files and docs Modified: libcxx/trunk/CMakeLists.txt libcxx/trunk/docs/conf.py libcxx/trunk/include/__config

[libunwind] r321724 - Creating release_60 branch off revision 321711

Author: hans Date: Wed Jan 3 06:54:55 2018 New Revision: 321724 URL: http://llvm.org/viewvc/llvm-project?rev=321724=rev Log: Creating release_60 branch off revision 321711 Added: libunwind/branches/release_60/ - copied from r321711, libunwind/trunk/

[libcxxabi] r321718 - Creating release_60 branch off revision 321711

Author: hans Date: Wed Jan 3 06:54:46 2018 New Revision: 321718 URL: http://llvm.org/viewvc/llvm-project?rev=321718=rev Log: Creating release_60 branch off revision 321711 Added: libcxxabi/branches/release_60/ - copied from r321711, libcxxabi/trunk/

[libcxx] r321717 - Creating release_60 branch off revision 321711

Author: hans Date: Wed Jan 3 06:54:46 2018 New Revision: 321717 URL: http://llvm.org/viewvc/llvm-project?rev=321717=rev Log: Creating release_60 branch off revision 321711 Added: libcxx/branches/release_60/ (props changed) - copied from r321711, libcxx/trunk/ Propchange:

Re: r321697 - [libclang] Support querying whether a declaration is invalid

I don't, but reverting your change made the test pass again. I was able to reproduce locally by adding -target ppc64le-unknown-linux to the run-line in test/Index/opencl-types.cl. On Wed, Jan 3, 2018 at 3:23 PM, Ivan Donchevskii wrote: > Hi! > I saw it but I don't see an

Re: r321697 - [libclang] Support querying whether a declaration is invalid

This caused failures on the buildbots. I've reverted it and the commits that depended on it in r321708. See that commit message for more details. On Wed, Jan 3, 2018 at 10:49 AM, Ivan Donchevskii via cfe-commits wrote: > Author: yvvan > Date: Wed Jan 3 01:49:31 2018

r321708 - Revert r321697 "[libclang] Support querying whether a declaration is invalid" and follow-ups.

Author: hans Date: Wed Jan 3 06:20:15 2018 New Revision: 321708 URL: http://llvm.org/viewvc/llvm-project?rev=321708=rev Log: Revert r321697 "[libclang] Support querying whether a declaration is invalid" and follow-ups. This broke test/Index/opencl-types.cl on several buildbots:

r321705 - UserManual: Update with the latest clang-cl flags

Author: hans Date: Wed Jan 3 05:20:25 2018 New Revision: 321705 URL: http://llvm.org/viewvc/llvm-project?rev=321705=rev Log: UserManual: Update with the latest clang-cl flags Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL:

Re: r319875 - Fix a bunch of wrong "tautological unsigned enum compare" diagnostics in C++.

I've committed a fix to pacify the test in r320405. On Wed, Dec 6, 2017 at 12:27 PM, Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Richard, > > This commit broke the tests on the builder: > > http://lab.llvm.org:8011/builders/llvm-clang-x86_64- >

r320405 - Fix warn-enum-compare.cpp on Windows

Author: hans Date: Mon Dec 11 10:58:18 2017 New Revision: 320405 URL: http://llvm.org/viewvc/llvm-project?rev=320405=rev Log: Fix warn-enum-compare.cpp on Windows It's been failing since r319875. Modified: cfe/trunk/test/SemaCXX/warn-enum-compare.cpp Modified:

Re: [PATCH] D40746: Correctly handle line table entries without filenames during AST serialization

+Tom I expect it's too late since 5.0.1 is virtually out the door already. On Mon, Dec 11, 2017 at 2:35 AM, Ivan Donchevskii via Phabricator < revi...@reviews.llvm.org> wrote: > yvvan added a comment. > > Can we still have it in 5.0? > > > Repository: > rL LLVM > >

Re: r320162 - Revert "Unify implementation of our two different flavours of -Wtautological-compare."

;> /home/seurer/llvm/llvm-test2/tools/clang/include/clang/AST/Expr.h:2745:17: >> warning: comparison of constant -1 with expression of type 'const >> clang::CastKind' is always true >> [-Wtautological-constant-out-of-range-compare] >> assert(kind != CK_Invalid &&a

Re: r320162 - Revert "Unify implementation of our two different flavours of -Wtautological-compare."

On Fri, Dec 8, 2017 at 11:10 AM, Hans Wennborg <h...@chromium.org> wrote: > On Fri, Dec 8, 2017 at 9:30 AM, Richard Smith via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> On 8 Dec 2017 08:54, "Hans Wennborg via cfe-commits" >> <cfe-commits@lists.

Re: r320162 - Revert "Unify implementation of our two different flavours of -Wtautological-compare."

On Fri, Dec 8, 2017 at 9:30 AM, Richard Smith via cfe-commits <cfe-commits@lists.llvm.org> wrote: > On 8 Dec 2017 08:54, "Hans Wennborg via cfe-commits" > <cfe-commits@lists.llvm.org> wrote: > > Author: hans > Date: Fri Dec 8 08:54:08 2017 > New Revision

Re: r320124 - Fold together the in-range and out-of-range portions of -Wtautological-compare.

Sorry, it seems it was r320124 that caused this; I shouldn't be sheriffing after-hours. I've reverted that one in r320162. On Thu, Dec 7, 2017 at 9:20 PM, Hans Wennborg wrote: > I've reverted in r320133 since it caused new warnings in Chromium that > I'm not sure were

r320162 - Revert "Unify implementation of our two different flavours of -Wtautological-compare."

Author: hans Date: Fri Dec 8 08:54:08 2017 New Revision: 320162 URL: http://llvm.org/viewvc/llvm-project?rev=320162=rev Log: Revert "Unify implementation of our two different flavours of -Wtautological-compare." > Unify implementation of our two different flavours of -Wtautological-compare. >

Re: r320124 - Fold together the in-range and out-of-range portions of -Wtautological-compare.

I've reverted in r320133 since it caused new warnings in Chromium that I'm not sure were intentional. See comment on the revert. On Thu, Dec 7, 2017 at 5:00 PM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Thu Dec 7 17:00:27 2017 > New Revision:

r320133 - Revert r320124 "Fold together the in-range and out-of-range portions of -Wtautological-compare."

Author: hans Date: Thu Dec 7 21:19:12 2017 New Revision: 320133 URL: http://llvm.org/viewvc/llvm-project?rev=320133=rev Log: Revert r320124 "Fold together the in-range and out-of-range portions of -Wtautological-compare." This broke Chromium: ../../base/trace_event/trace_log.cc:1545:29:

Re: r319875 - Fix a bunch of wrong "tautological unsigned enum compare" diagnostics in C++.

This made Clang start warning about unsigned vs enum compares on Windows. $ echo 'enum E { foo }; bool f(unsigned a, E b) { return a == b; }' | bin/clang -Wsign-compare -c -x c++ - -target i686-pc-win32 :1:52: warning: comparison of integers of different signs: 'unsigned int' and 'E'

r319707 - Correctly handle line table entries without filenames during AST serialization

Author: hans Date: Mon Dec 4 14:28:45 2017 New Revision: 319707 URL: http://llvm.org/viewvc/llvm-project?rev=319707=rev Log: Correctly handle line table entries without filenames during AST serialization The current code would hit an assert in ASTWriter when trying to write out the filename for

[clang-tools-extra] r319690 - Fix build after r319688: s/CPlusPlus1z/CPlusPlus17/

Author: hans Date: Mon Dec 4 12:38:21 2017 New Revision: 319690 URL: http://llvm.org/viewvc/llvm-project?rev=319690=rev Log: Fix build after r319688: s/CPlusPlus1z/CPlusPlus17/ Modified: clang-tools-extra/trunk/clang-tidy/modernize/UnaryStaticAssertCheck.cpp Modified:

r319386 - MS ABI: Treat explicit instantiation definitions of dllimport function templates as explicit instantiation decls (PR35435)

Author: hans Date: Wed Nov 29 15:44:11 2017 New Revision: 319386 URL: http://llvm.org/viewvc/llvm-project?rev=319386=rev Log: MS ABI: Treat explicit instantiation definitions of dllimport function templates as explicit instantiation decls (PR35435) This matches MSVC's behaviour, and we already

r318785 - Add -finstrument-function-entry-bare flag

Author: hans Date: Tue Nov 21 09:30:34 2017 New Revision: 318785 URL: http://llvm.org/viewvc/llvm-project?rev=318785=rev Log: Add -finstrument-function-entry-bare flag This is an instrumentation flag that's similar to -finstrument-functions, but it only inserts calls on function entry, the calls

Re: r318456 - Issue -Wempty-body warnings for else blocks

Reverted in r318667. See coments on the r318556 thread. On Thu, Nov 16, 2017 at 3:32 PM, Richard Smith via cfe-commits wrote: > This is kicking up false positives on code that does the following: > > #define USED(x) if(x);else > // ... > assert(x); > USED(x); > >

Re: r318556 - Loosen -Wempty-body warning

Reverted the original patch too, in r318667 since I assume that was breaking Ilya's build. Hopefully this is easy to fix and they can be re-landed together. On Mon, Nov 20, 2017 at 9:39 AM, Hans Wennborg wrote: > I've reverted in r318665 to get the buildbots green until this

r318667 - Revert r318456 "Issue -Wempty-body warnings for else blocks"

Author: hans Date: Mon Nov 20 09:48:54 2017 New Revision: 318667 URL: http://llvm.org/viewvc/llvm-project?rev=318667=rev Log: Revert r318456 "Issue -Wempty-body warnings for else blocks" This caused warnings also when the if or else comes from macros. There was an attempt to fix this in r318556,

Re: r318556 - Loosen -Wempty-body warning

I've reverted in r318665 to get the buildbots green until this is figured out. On Sat, Nov 18, 2017 at 11:55 AM, Hans Wennborg wrote: > We're still seeing some in macro-related code. From Chromium: > > ../../third_party/ffmpeg/libavcodec/bitstream.c(169,5): error: if >

r318665 - Revert r318556 "Loosen -Wempty-body warning"

Author: hans Date: Mon Nov 20 09:38:16 2017 New Revision: 318665 URL: http://llvm.org/viewvc/llvm-project?rev=318665=rev Log: Revert r318556 "Loosen -Wempty-body warning" It seems this somehow made -Wempty-body fire in some macro cases where it didn't before, e.g.

Re: r318556 - Loosen -Wempty-body warning

We're still seeing some in macro-related code. From Chromium: ../../third_party/ffmpeg/libavcodec/bitstream.c(169,5): error: if statement has empty body [-Werror,-Wempty-body] ff_dlog(NULL, "new table index=%d size=%d\n", table_index, table_size); ^

Re: r318536 - [OPENMP] Codegen for `target simd` construct.

Ah ok. Thanks for checking! On Fri, Nov 17, 2017 at 4:59 PM, Alexey Bataev wrote: > No, it is caused by some other changes. Seems to me, somebody changed the > interface of functions, but forgot to remove the variables that are not used > anymore. > The changes look good to

Re: r318536 - [OPENMP] Codegen for `target simd` construct.

I think this caused some unused variable warnings: ../tools/clang/lib/CodeGen/CGStmtOpenMP.cpp:360:25: warning: unused variable 'ExtInfo' [-Wunused-variable] FunctionType::ExtInfo ExtInfo; ^ 1 warning generated. [3049/3507] Building CXX object

r318578 - Fix some -Wunused-variable warnings

Author: hans Date: Fri Nov 17 16:49:18 2017 New Revision: 318578 URL: http://llvm.org/viewvc/llvm-project?rev=318578=rev Log: Fix some -Wunused-variable warnings Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp cfe/trunk/lib/CodeGen/CGStmt.cpp

r318314 - Try to fix test/SemaCXX/deleted-operator.cpp after r318309

Author: hans Date: Wed Nov 15 09:47:58 2017 New Revision: 318314 URL: http://llvm.org/viewvc/llvm-project?rev=318314=rev Log: Try to fix test/SemaCXX/deleted-operator.cpp after r318309 The number of 'built-in candidate' notes now varies since __float128 may or may not be a candidate depending on

r318309 - BuiltinOperatorOverloadBuilder: Don't consider types that are unavailable on the target (PR35174)

Author: hans Date: Wed Nov 15 09:11:53 2017 New Revision: 318309 URL: http://llvm.org/viewvc/llvm-project?rev=318309=rev Log: BuiltinOperatorOverloadBuilder: Don't consider types that are unavailable on the target (PR35174) In the PR, Clang ended up in a situation where it tried to mangle the

r318214 - Try to fix the instrument-functions tests

Author: hans Date: Tue Nov 14 15:10:04 2017 New Revision: 318214 URL: http://llvm.org/viewvc/llvm-project?rev=318214=rev Log: Try to fix the instrument-functions tests On e.g. PPC the return value and argument were marked 'signext'. This makes the test expectations a bit more flexible.

r318199 - Switch -mcount and -finstrument-functions to emit EnterExitInstrumenter attributes

Author: hans Date: Tue Nov 14 13:13:27 2017 New Revision: 318199 URL: http://llvm.org/viewvc/llvm-project?rev=318199=rev Log: Switch -mcount and -finstrument-functions to emit EnterExitInstrumenter attributes This updates -mcount to use the new attribute names (LLVM r318195), and switches over

r318108 - Update link to the Chromium Clang page

Author: hans Date: Mon Nov 13 15:27:53 2017 New Revision: 318108 URL: http://llvm.org/viewvc/llvm-project?rev=318108=rev Log: Update link to the Chromium Clang page Modified: cfe/trunk/www/related.html Modified: cfe/trunk/www/related.html URL:

r318109 - Update a link to the old code.google.com bug tracker

Author: hans Date: Mon Nov 13 15:27:54 2017 New Revision: 318109 URL: http://llvm.org/viewvc/llvm-project?rev=318109=rev Log: Update a link to the old code.google.com bug tracker Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp URL:

r318110 - Update link to protobuf

Author: hans Date: Mon Nov 13 15:27:55 2017 New Revision: 318110 URL: http://llvm.org/viewvc/llvm-project?rev=318110=rev Log: Update link to protobuf Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp URL:

Re: r315614 - [Sema] Diagnose tautological comparison with type's min/max values

On Sat, Nov 11, 2017 at 4:18 AM, Roman Lebedev wrote: > On Fri, Nov 10, 2017 at 9:14 PM, Hans Wennborg wrote: >> On Thu, Oct 12, 2017 at 2:33 PM, Roman Lebedev via cfe-commits >> wrote: >>> On Fri, Oct 13, 2017 at 12:12 AM,

r317944 - Remove declaration of EmitMCountInstrumentation(). NFC

Author: hans Date: Fri Nov 10 14:34:23 2017 New Revision: 317944 URL: http://llvm.org/viewvc/llvm-project?rev=317944=rev Log: Remove declaration of EmitMCountInstrumentation(). NFC The definition was removed in r280355. Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.h Modified:

Re: r315614 - [Sema] Diagnose tautological comparison with type's min/max values

On Thu, Oct 12, 2017 at 2:33 PM, Roman Lebedev via cfe-commits wrote: > On Fri, Oct 13, 2017 at 12:12 AM, Nico Weber wrote: >> Huh, I consider clang not warning on this a feature, not a bug. Why are we >> trying to match what gcc does here? >

Re: r316268 - [Sema] Fixes for enum handling for tautological comparison diagnostics

On Mon, Oct 23, 2017 at 2:02 PM, Roman Lebedev wrote: > On Mon, Oct 23, 2017 at 2:13 PM, Hans Wennborg wrote: > Hi. > >> This seems to have had the side effect of introducing a new warning in >> Chromium builds: >> >>

Re: r316268 - [Sema] Fixes for enum handling for tautological comparison diagnostics

This seems to have had the side effect of introducing a new warning in Chromium builds: ../../third_party/expat/files/lib/xmlparse.c(2429,24): error: comparison of integers of different signs: 'enum XML_Error' and 'unsigned int' [-Werror,-Wsign-compare] if (code > 0 && code <

r315330 - For dllexport class templates, export specializations of member functions (PR34849) (take 2)

Author: hans Date: Tue Oct 10 09:53:25 2017 New Revision: 315330 URL: http://llvm.org/viewvc/llvm-project?rev=315330=rev Log: For dllexport class templates, export specializations of member functions (PR34849) (take 2) This is a re-commit of r315025, but making sure to only apply this to

Re: r315251 - [Modules TS] Module ownership semantics for redeclarations.

Thanks for reverting. We saw build failures in Chromium too. E.g. from https://build.chromium.org/p/chromium.clang/builders/ToTLinux/builds/134: In file included from ../../third_party/breakpad/breakpad/src/common/linux/symbol_upload.cc:34:

r315025 - For dllexport class templates, export specializations of member functions (PR34849)

Author: hans Date: Thu Oct 5 14:45:27 2017 New Revision: 315025 URL: http://llvm.org/viewvc/llvm-project?rev=315025=rev Log: For dllexport class templates, export specializations of member functions (PR34849) Modified: cfe/trunk/lib/Sema/SemaDecl.cpp

Re: r314689 - Revert "[Sema] Warn on attribute nothrow conflicting with language specifiers"

This is https://bugs.llvm.org/show_bug.cgi?id=34805 On Mon, Oct 2, 2017 at 10:16 AM, Reid Kleckner via cfe-commits wrote: > Author: rnk > Date: Mon Oct 2 10:16:14 2017 > New Revision: 314689 > > URL: http://llvm.org/viewvc/llvm-project?rev=314689=rev > Log: > Revert

r314033 - clang-format plugin: Add missing NL (new line) at EOF (end of file)

Author: hans Date: Fri Sep 22 14:47:39 2017 New Revision: 314033 URL: http://llvm.org/viewvc/llvm-project?rev=314033=rev Log: clang-format plugin: Add missing NL (new line) at EOF (end of file) clang-format.exe removes trailing new lines at end of file. However, if no NL is found at EOF one

r313060 - clang-format-vs: Update the VSIX ID.

Author: hans Date: Tue Sep 12 11:38:34 2017 New Revision: 313060 URL: http://llvm.org/viewvc/llvm-project?rev=313060=rev Log: clang-format-vs: Update the VSIX ID. We're moving the extension to a new account on the VS Marketplace, and apparently it's not possible to re-upload an extension with an

Re: [libcxxabi] r308470 - Drop 'svn' suffix from version number.

, "cfe-commits on behalf of Dimitry Andric via cfe-commits" > <cfe-commits-boun...@lists.llvm.org on behalf of cfe-commits@lists.llvm.org> > wrote: > > On 19 Jul 2017, at 16:04, Hans Wennborg via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >

Re: r312750 - [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

On Fri, Sep 8, 2017 at 2:26 PM, Friedman, Eli <efrie...@codeaurora.org> wrote: > On 9/8/2017 2:18 PM, Hans Wennborg via cfe-commits wrote: >> >> On Fri, Sep 8, 2017 at 2:09 PM, Roman Lebedev <lebedev...@gmail.com> >> wrote: >>> >>> >>>

Re: r312750 - [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

On Fri, Sep 8, 2017 at 2:09 PM, Roman Lebedev wrote: > On Fri, Sep 8, 2017 at 11:45 PM, Hans Wennborg wrote: >> On Fri, Sep 8, 2017 at 4:48 AM, Sam McCall via cfe-commits >> wrote: >>> Nice fix! It catches a lot of new cases

Re: r312750 - [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

On Fri, Sep 8, 2017 at 4:48 AM, Sam McCall via cfe-commits wrote: > Nice fix! It catches a lot of new cases on our codebase, all technically > correct so far. > > A couple of issues though: > A) Rollout - until we've completely cleaned up, we need to disable >

[libcxxabi] r312553 - Creating release candidate final from release_500 branch

Author: hans Date: Tue Sep 5 11:20:11 2017 New Revision: 312553 URL: http://llvm.org/viewvc/llvm-project?rev=312553=rev Log: Creating release candidate final from release_500 branch Added: libcxxabi/tags/RELEASE_500/final/ - copied from r312552, libcxxabi/branches/release_50/

[libunwind] r312559 - Creating release candidate final from release_500 branch

Author: hans Date: Tue Sep 5 11:20:18 2017 New Revision: 312559 URL: http://llvm.org/viewvc/llvm-project?rev=312559=rev Log: Creating release candidate final from release_500 branch Added: libunwind/tags/RELEASE_500/final/ (props changed) - copied from r312558,

[libcxx] r312552 - Creating release candidate final from release_500 branch

Author: hans Date: Tue Sep 5 11:20:11 2017 New Revision: 312552 URL: http://llvm.org/viewvc/llvm-project?rev=312552=rev Log: Creating release candidate final from release_500 branch Added: libcxx/tags/RELEASE_500/final/ (props changed) - copied from r312551,

[libunwind] r312378 - Creating release candidate rc5 from release_500 branch

Author: hans Date: Fri Sep 1 14:03:03 2017 New Revision: 312378 URL: http://llvm.org/viewvc/llvm-project?rev=312378=rev Log: Creating release candidate rc5 from release_500 branch Added: libunwind/tags/RELEASE_500/rc5/ (props changed) - copied from r312377,

[libcxx] r312371 - Creating release candidate rc5 from release_500 branch

Author: hans Date: Fri Sep 1 14:02:55 2017 New Revision: 312371 URL: http://llvm.org/viewvc/llvm-project?rev=312371=rev Log: Creating release candidate rc5 from release_500 branch Added: libcxx/tags/RELEASE_500/rc5/ (props changed) - copied from r312370, libcxx/branches/release_50/

[libcxxabi] r312372 - Creating release candidate rc5 from release_500 branch

Author: hans Date: Fri Sep 1 14:02:56 2017 New Revision: 312372 URL: http://llvm.org/viewvc/llvm-project?rev=312372=rev Log: Creating release candidate rc5 from release_500 branch Added: libcxxabi/tags/RELEASE_500/rc5/ - copied from r312371, libcxxabi/branches/release_50/

Re: r312181 - Fix tests for ARM targets

I fixed them some more in r312193 :-) See e.g. here for the sample breakage: http://bb.pgr.jp/builders/test-clang-i686-linux-RA/builds/6961/steps/test_clang/logs/Clang%20%3A%3A%20CodeGen__profile-sample-accurate.c On Wed, Aug 30, 2017 at 3:30 PM, Douglas Yung via cfe-commits

r312193 - Fix the test fix from r312181

Author: hans Date: Wed Aug 30 16:26:38 2017 New Revision: 312193 URL: http://llvm.org/viewvc/llvm-project?rev=312193=rev Log: Fix the test fix from r312181 Modified: cfe/trunk/test/CodeGen/profile-sample-accurate.c cfe/trunk/test/CodeGen/thinlto-emit-llvm.c

r312149 - docs: typo fix

Author: hans Date: Wed Aug 30 11:35:44 2017 New Revision: 312149 URL: http://llvm.org/viewvc/llvm-project?rev=312149=rev Log: docs: typo fix Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL:

[libunwind] r312080 - Creating release candidate rc4 from release_500 branch

Author: hans Date: Tue Aug 29 16:49:14 2017 New Revision: 312080 URL: http://llvm.org/viewvc/llvm-project?rev=312080=rev Log: Creating release candidate rc4 from release_500 branch Added: libunwind/tags/RELEASE_500/rc4/ (props changed) - copied from r312079,

[libcxx] r312073 - Creating release candidate rc4 from release_500 branch

Author: hans Date: Tue Aug 29 16:49:07 2017 New Revision: 312073 URL: http://llvm.org/viewvc/llvm-project?rev=312073=rev Log: Creating release candidate rc4 from release_500 branch Added: libcxx/tags/RELEASE_500/rc4/ (props changed) - copied from r312072, libcxx/branches/release_50/

[libcxxabi] r312074 - Creating release candidate rc4 from release_500 branch

Author: hans Date: Tue Aug 29 16:49:07 2017 New Revision: 312074 URL: http://llvm.org/viewvc/llvm-project?rev=312074=rev Log: Creating release candidate rc4 from release_500 branch Added: libcxxabi/tags/RELEASE_500/rc4/ - copied from r312073, libcxxabi/branches/release_50/

Re: r311823 - Add flag to request Clang is ABI-compatible with older versions of itself

Merged in r312013. On Fri, Aug 25, 2017 at 6:06 PM, Richard Smith wrote: > Hi Hans, > > We should get this into Clang 5 so that people can opt out of the ABI bugfix > for passing C++ class types by value. > > On 25 August 2017 at 18:04, Richard Smith via cfe-commits >

Re: r311857 - Emit static constexpr member as available_externally definition

I reverted this in r311898 as it caused Chromium builds to fail with an assertion; see PR34348. On Sun, Aug 27, 2017 at 1:24 PM, Mehdi Amini via cfe-commits wrote: > Author: mehdi_amini > Date: Sun Aug 27 13:24:09 2017 > New Revision: 311857 > > URL:

r311898 - Revert r311857 "Emit static constexpr member as available_externally definition"

Author: hans Date: Mon Aug 28 10:53:00 2017 New Revision: 311898 URL: http://llvm.org/viewvc/llvm-project?rev=311898=rev Log: Revert r311857 "Emit static constexpr member as available_externally definition" It caused PR759744. > Emit static constexpr member as available_externally definition >

[libunwind] r311818 - Creating release candidate rc3 from release_500 branch

Author: hans Date: Fri Aug 25 15:51:25 2017 New Revision: 311818 URL: http://llvm.org/viewvc/llvm-project?rev=311818=rev Log: Creating release candidate rc3 from release_500 branch Added: libunwind/tags/RELEASE_500/rc3/ (props changed) - copied from r311817,

[libcxx] r311811 - Creating release candidate rc3 from release_500 branch

Author: hans Date: Fri Aug 25 15:51:17 2017 New Revision: 311811 URL: http://llvm.org/viewvc/llvm-project?rev=311811=rev Log: Creating release candidate rc3 from release_500 branch Added: libcxx/tags/RELEASE_500/rc3/ (props changed) - copied from r311810, libcxx/branches/release_50/

[libcxxabi] r311812 - Creating release candidate rc3 from release_500 branch

Author: hans Date: Fri Aug 25 15:51:17 2017 New Revision: 311812 URL: http://llvm.org/viewvc/llvm-project?rev=311812=rev Log: Creating release candidate rc3 from release_500 branch Added: libcxxabi/tags/RELEASE_500/rc3/ - copied from r311811, libcxxabi/branches/release_50/

Re: r311792 - [Format] Invert nestingAndIndentLevel pair in WhitespaceManager used for

Merged to 5.0 in r311800. On Fri, Aug 25, 2017 at 12:14 PM, Daniel Jasper via cfe-commits wrote: > Author: djasper > Date: Fri Aug 25 12:14:53 2017 > New Revision: 311792 > > URL: http://llvm.org/viewvc/llvm-project?rev=311792=rev > Log: > [Format] Invert

Re: r311695 - [ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the captured enclosing 'this' poin

r311799. Thanks! On Thu, Aug 24, 2017 at 7:14 PM, Richard Smith wrote: > Hi Hans, > > This fixes a regression in ubsan's handling of lambda expressions. Seems > like a reasonable candidate for Clang 5, but it is rather late in the day... > > > On 24 August 2017 at 13:10,

Re: r298574 - Fix issues in clang-format's AlignConsecutive modes.

This caused https://bugs.llvm.org/show_bug.cgi?id=33507 which is one of the last release blockers for 5.0.0. Can someone who's familiar with this code please take a look? On Thu, Aug 24, 2017 at 11:12 AM, Hans Wennborg wrote: > For reference, this was reviewed in

Re: r298574 - Fix issues in clang-format's AlignConsecutive modes.

For reference, this was reviewed in https://reviews.llvm.org/D21279 (Please always include review links in the future.) On Wed, Mar 22, 2017 at 7:51 PM, Nikola Smiljanic via cfe-commits wrote: > Author: nikola > Date: Wed Mar 22 21:51:25 2017 > New Revision: 298574 >

Re: r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

Merged to 5.0 in r311671. On Wed, Aug 23, 2017 at 2:24 PM, Adrian Prantl via cfe-commits wrote: > Author: adrian > Date: Wed Aug 23 14:24:12 2017 > New Revision: 311601 > > URL: http://llvm.org/viewvc/llvm-project?rev=311601=rev > Log: > Fix a bug in

Re: r309327 - Headers: fix _Unwind_{G,S}etGR for non-EHABI targets

Reverted from the 5.0 branch (together with r309226) in r311597. On Thu, Jul 27, 2017 at 3:08 PM, Hans Wennborg wrote: > Merged to 5.0 in r309328. > > On Thu, Jul 27, 2017 at 2:56 PM, Saleem Abdulrasool via cfe-commits > wrote: >> Author: compnerd

Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

s/gcc_personality_v0.c refers to >>>>> _Unwind_Exception as "struct _Unwind_Exception". With this change, it >>>>> is not a struct anymore on ARM. Should that code be fixed, or is it a >>>>> problem in this change? >>>>> >&g

Re: r311330 - Fixed a crash on replaying Preamble's PP conditional stack.

Thanks! r311591. On Wed, Aug 23, 2017 at 12:42 PM, Richard Smith <rich...@metafoo.co.uk> wrote: > LG for branch. > > On 23 August 2017 at 11:04, Hans Wennborg via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> Richard: ping? >> >> O

<    2   3   4   5   6   7   8   9   10   11   >