[PATCH] D151785: [clangd] Desugar template parameter aliases in type hints

kstoimenov added a comment. In D151785#4418037 , @zyounan wrote: > In D151785#4417973 , @kstoimenov > wrote: > >> Looks like this might have broken a couple of sanitizer builds. Here is one >> of them:

[PATCH] D151785: [clangd] Desugar template parameter aliases in type hints

kstoimenov added a comment. Looks like this might have broken a couple of sanitizer builds. Here is one of them: https://lab.llvm.org/buildbot/#/builders/5/builds/34387. Could you please revert or fix? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145822: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG100a3c397c20: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145822: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests

kstoimenov marked an inline comment as done. kstoimenov added a comment. In D145822#4185801 , @vitalybuka wrote: > what is about detect_leaks? Yes. I had to revert only this file because it broke a bunch of bots. Repository: rG LLVM Github Monorepo

[PATCH] D145822: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests

kstoimenov updated this revision to Diff 504264. kstoimenov edited the summary of this revision. kstoimenov added a comment. Moved UNSUPPORTED to one line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145822/new/ https://reviews.llvm.org/D145822

[PATCH] D145822: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests

kstoimenov created this revision. Herald added a subscriber: arphaman. Herald added a project: All. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145822 Files:

[PATCH] D145727: [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG011b4d4706ee: [HWASAN][LSAN] Disable tests which dont pass in HWASAN+LSAN mode (authored by kstoimenov). Repository: rG LLVM Github Monorepo

[PATCH] D145727: [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode

kstoimenov updated this revision to Diff 503915. kstoimenov added a comment. Removed debug print. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145727/new/ https://reviews.llvm.org/D145727 Files: clang/test/Driver/crash-diagnostics-dir-3.c

[PATCH] D145727: [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode

kstoimenov created this revision. Herald added subscribers: arphaman, emaste. Herald added a project: All. kstoimenov requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo

[PATCH] D145451: Disable tests which don't pass in HWASAN+LSAN mode

kstoimenov abandoned this revision. kstoimenov added a comment. I will send a different patch with LSAN_OPTIONS instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145451/new/ https://reviews.llvm.org/D145451

[PATCH] D145615: [LSAN] Disable leaks in test using environment variables instead of not running them with ASAN.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG50cd2c257cb4: [LSAN] Disable leaks in test using environment variables instead of not running… (authored by kstoimenov). Repository: rG LLVM

[PATCH] D145615: [LSAN] Disable leaks in test using environment variables instead of not running them with ASAN.

kstoimenov created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle,

[PATCH] D145451: Disable tests which don't pass in HWASAN+LSAN mode

kstoimenov created this revision. Herald added a subscriber: arphaman. Herald added a project: All. kstoimenov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov added inline comments. Comment at: compiler-rt/lib/asan/CMakeLists.txt:198 +ARCHS ${ASAN_SUPPORTED_ARCH} +OBJECT_LIBS RTAsan_static +CFLAGS ${ASAN_CFLAGS} thetruestblue wrote: > Can you explain the motivation here? > > RTAsan_static

[PATCH] D138329: [-Wunsafe-buffer-usage] Add a new recursive matcher to replace `forEachDescendant` in unsafe buffer check

kstoimenov added a comment. Is it possible these errors are due to your change: https://lab.llvm.org/buildbot/#/builders/5/builds/30522/steps/13/logs/stdio? If so please consider reverting/fixing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

kstoimenov accepted this revision. kstoimenov added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/Instrumentation/AddressSanitizer/global_with_comdat.ll:8 ; -; RUN: opt < %s -passes=asan -asan-globals-live-support=1 -S |

[PATCH] D132907: [msan] Add more specific messages for use-after-destroy

kstoimenov accepted this revision. kstoimenov added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGClass.cpp:1773 // function - EmitSanitizerDtorCallback(CGF, VTablePtr, PoisonSize); +

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

kstoimenov accepted this revision. kstoimenov added a comment. I think the name 'mainsrc' is slightly misleading because of the association with the 'main' function. Maybe something like primarysrc would be better to avoid this confusion? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

kstoimenov accepted this revision. kstoimenov added a comment. This revision is now accepted and ready to land. Please get approval from vitalybuka@ before submitting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

kstoimenov added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:48-50 + GVSanitizerMetadata Meta; + if (GV->hasSanitizerMetadata()) +Meta = GV->getSanitizerMetadata(); hctim wrote: > kstoimenov wrote: > > Would it make sense to create

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

kstoimenov added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:48-50 + GVSanitizerMetadata Meta; + if (GV->hasSanitizerMetadata()) +Meta = GV->getSanitizerMetadata(); Would it make sense to create two separate functions something

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

kstoimenov added a comment. This change is breaking memory sanitizer in some cases. We observed that when the argument is not actually removed the pass is dropping the noundef attribute. See the diff snippet below. Is that an intended behavior? We would like to revert this as it is breaking

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

kstoimenov accepted this revision. kstoimenov added a comment. This revision is now accepted and ready to land. LGTM, but get one from vitalybuka@ too. Sorry about delayed review, I missed it. Next time ping me if I don't respond within a day. Comment at:

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

kstoimenov added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadataFactory.h:33 + +class SanitizerMetadataFactory { + SanitizerMetadataFactory(const SanitizerMetadataFactory &) = delete; Not sure if this class follows the 'factory' design pattern,

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

kstoimenov added a comment. One meta-observation: can you split this into smaller patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124493/new/ https://reviews.llvm.org/D124493 ___ cfe-commits

[PATCH] D124679: [clangd] More precisely enable clang warnings through ClangTidy options

kstoimenov added inline comments. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:558 + TU.ClangTidyProvider = addClangArgs({"-Wunused"}, "*"); + EXPECT_THAT(*TU.build().getDiagnostics(), ElementsAre(UnusedFooWarning)); + // And we can explicitly exclude a

[PATCH] D122407: [ASan] Reland of D116182 to always link asan_static library.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd67e6972f85: [ASan] Reland of D116182 to always link asan_static library. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122407: [ASan] Reland of D116182 to always link asan_static library.

kstoimenov created this revision. Herald added a subscriber: mgorny. Herald added a project: All. kstoimenov requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D121405: [ASan] Moved optimized callbacks out of asan_static to avoid DSO size increase.

This revision was automatically updated to reflect the committed changes. Closed by commit rG035441ff3008: [ASan] Moved optimized callbacks out of asan_static to avoid DSO size increase. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121405: [ASan] Moved optimized callbacks out of asan_static to avoid DSO size increase.

kstoimenov created this revision. Herald added a subscriber: mgorny. Herald added a project: All. kstoimenov requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D120394: [asan] Allow -fsanitize-address-globals-dead-stripping with -fno-data-sections for ELF

kstoimenov accepted this revision. kstoimenov added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120394/new/ https://reviews.llvm.org/D120394 ___ cfe-commits mailing list

[PATCH] D120391: [Driver] Add -fno-sanitize-address-globals-dead-stripping

kstoimenov accepted this revision. kstoimenov added a comment. This revision is now accepted and ready to land. LGTM. But please wait for LTGM from vitalybuka@. Also there is internal asan-globals-live-support flag if you need it before this one lands. Repository: rG LLVM Github Monorepo

[PATCH] D118739: Revert "[ASan] Not linking asan_static library for DSO."

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7dd7ad827a0: Revert [ASan] Not linking asan_static library for DSO. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D118739: Revert "[ASan] Not linking asan_static library for DSO."

kstoimenov created this revision. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It turned out that this change is causing segfaults in some situations. This reverts commit cf730d8ce1341ba593144df2e2bc8411238e04c3

[PATCH] D118205: [ASan] Added a unit test for D118184.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69da422bdaa6: [ASan] Added a unit test for D118184. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118205: [ASan] Added a unit test for D118184.

kstoimenov updated this revision to Diff 403083. kstoimenov added a comment. Fixed order. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118205/new/ https://reviews.llvm.org/D118205 Files: clang/test/Driver/sanitizer-ld.c Index:

[PATCH] D118205: [ASan] Added a unit test for D118184.

kstoimenov created this revision. kstoimenov added a reviewer: kda. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To make sure the the libraries are there for executable and not there for DSOs. Repository: rG LLVM Github

[PATCH] D118184: [ASan] Not linking asan_static library for DSO.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf730d8ce134: [ASan] Not linking asan_static library for DSO. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D118184: [ASan] Not lininking asan_static library for DSO.

kstoimenov created this revision. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Whithout this change DSOs fail to link because of missing asan_report_(load|store)n functions. Repository: rG LLVM Github Monorepo

[PATCH] D116670: [ASan] Driver changes to always link-in asan_static library.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3b9edf8b8c3: [ASan] Driver changes to always link-in asan_static library. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D116670: [ASan] Driver changes to always link-in asan_static library.

kstoimenov updated this revision to Diff 397908. kstoimenov added a comment. Lint if statement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116670/new/ https://reviews.llvm.org/D116670 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D116670: [ASan] Driver changes to always link-in asan_static library.

kstoimenov created this revision. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This enables the changes from D116182 . Repository: rG LLVM Github Monorepo

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG027ffb173a68: [ASan] Moved optimized callbacks into a separate library. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 397613. kstoimenov added a comment. Removed driver part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: compiler-rt/lib/asan/CMakeLists.txt

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71b3bfde9cd2: [ASan] Moved optimized callbacks into a separate library. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov requested review of this revision. kstoimenov added a comment. Added empty asan_static_rtl.cpp to work around the Windows build problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 396083. kstoimenov added a comment. Fixed a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 396082. kstoimenov added a comment. s/set/append/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 396081. kstoimenov added a comment. Added asan_rtl_static.cpp empty file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files:

[PATCH] D116223: Revert "[ASan] Moved optimized callbacks into a separate library."

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4bf31659fac7: Revert [ASan] Moved optimized callbacks into a separate library. (authored by kstoimenov). Repository: rG LLVM Github Monorepo

[PATCH] D116223: Revert "[ASan] Moved optimized callbacks into a separate library."

kstoimenov created this revision. Herald added a subscriber: mgorny. kstoimenov requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This reverts commit ab3640aa0e8361921a5d0cdc393a5b75e78ec22b

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab3640aa0e83: [ASan] Moved optimized callbacks into a separate library. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov added a comment. Renamed it 'dso' to 'static'. I know it could be a little bit confusing. I was considering 'static_link' or 'always_static', but it seems too long. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 396031. kstoimenov marked an inline comment as done. kstoimenov added a comment. Remaned dso to static. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files:

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 395914. kstoimenov added a comment. Updated a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov created this revision. Herald added a subscriber: mgorny. kstoimenov requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This will allow linking in the callbacks directly instead of using PLT. Repository:

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kstoimenov marked an inline comment as done. Closed by commit rG3f1aca58df8f: [ASan] Added stack safety support in address sanitizer. (authored by kstoimenov).

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 384902. kstoimenov added a comment. Moved AddressSanitizer back to the loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files:

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 384877. kstoimenov marked 2 inline comments as done. kstoimenov added a comment. Fixed tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files:

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 384587. kstoimenov added a comment. Restored StackSafetyAnalysis.h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files:

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 384583. kstoimenov added a comment. After removing function pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files:

[PATCH] D112732: [ASan] Process functions in Asan module pass

This revision was automatically updated to reflect the committed changes. Closed by commit rGa55c4ec1cee7: [ASan] Process functions in Asan module pass (authored by kstoimenov). Changed prior to commit: https://reviews.llvm.org/D112732?vs=384544=384571#toc Repository: rG LLVM Github

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384544. kstoimenov added a comment. After merging D113072 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files:

[PATCH] D113131: [ASan] Process functions in Asan module pass.

kstoimenov created this revision. kstoimenov added a reviewer: vitalybuka. Herald added subscribers: ormris, hiraditya. kstoimenov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Re-land of D112732

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1189 +MPM.addPass(ModuleAddressSanitizerPass( +CompileKernel, Recover, ModuleUseAfterScope, UseOdrIndicator, +DestructorKind, UseAfterScope, UseAfterReturn));

[PATCH] D113129: Revert "[ASan] Process functions in Asan module pass"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3145323b549: Revert [ASan] Process functions in Asan module pass (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D113129: Revert "[ASan] Process functions in Asan module pass"

kstoimenov created this revision. Herald added subscribers: ormris, hiraditya. kstoimenov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This reverts commit 76ea87b94e5cba335d691e4e18e3464ad45c8b52

[PATCH] D112732: [ASan] Process functions in Asan module pass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76ea87b94e5c: [ASan] Process functions in Asan module pass (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384515. kstoimenov added a comment. After rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384488. kstoimenov marked 3 inline comments as done. kstoimenov added a comment. Moved module after function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384467. kstoimenov added a comment. Moved empty check to the top of the function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files:

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384465. kstoimenov added a comment. Moved module instumentation back ahead of function instrumentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files:

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:92 -struct AddressSanitizerOptions { - AddressSanitizerOptions() vitalybuka wrote: > Why do we need to remove AddressSanitizerOptions? Adding it back

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov updated this revision to Diff 383921. kstoimenov marked an inline comment as done. kstoimenov added a comment. Update after discussing with vitalybuka@. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov updated this revision to Diff 383819. kstoimenov added a comment. Fixed remaing 2 tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1289 + } + Modified |= ModuleSanitizer.instrumentModule(M); + if (Modified) At first I had module sanitizer run first, but some tests failed. Is it

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov updated this revision to Diff 383536. kstoimenov marked 2 inline comments as done. kstoimenov added a comment. Fixed test failures and crashes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov planned changes to this revision. kstoimenov added a comment. Tests are not passing. Hold off the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov updated this revision to Diff 383072. kstoimenov added a comment. Added AddressSanitizerOptions back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov updated this revision to Diff 383071. kstoimenov edited the summary of this revision. kstoimenov added a comment. Reverted pass builder. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files:

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov added inline comments. Comment at: llvm/include/llvm/Analysis/StackSafetyAnalysis.h:93 + bool invalidate(Module &, const PreservedAnalyses &, + ModuleAnalysisManager::Invalidator &) { +return false; eugenis wrote: > vitalybuka

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov updated this revision to Diff 383068. kstoimenov added a comment. Removed unrelated files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov created this revision. Herald added subscribers: ormris, hiraditya. kstoimenov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112732 Files:

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 382486. kstoimenov added a comment. s/I/LI/. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: llvm/include/llvm/Analysis/StackSafetyAnalysis.h

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov marked 2 inline comments as done. kstoimenov added a comment. PTAL. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1265 GlobalsMetadata ASanGlobalsMetadataAnalysis::run(Module ,

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 382483. kstoimenov added a comment. Removed {} after if. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: llvm/include/llvm/Analysis/StackSafetyAnalysis.h

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 382482. kstoimenov added a comment. Added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: llvm/include/llvm/Analysis/StackSafetyAnalysis.h

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 382481. kstoimenov marked 2 inline comments as done. kstoimenov added a comment. Fixed test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files:

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov added a comment. This should be good for re-review now. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 ___ cfe-commits mailing list

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:812 bool runOnFunction(Function ) override { +if (ClUseStackSafety) { + report_fatal_error("Stack safety analysis is not supported " fmayer wrote:

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 381391. kstoimenov added a comment. Added support for legacy pass manager and a test for it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files:

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov marked 4 inline comments as done. kstoimenov added inline comments. Comment at: clang/test/CodeGen/asan-stack-safety-analysis.c:1 +// REQUIRES: x86-registered-target + fmayer wrote: > fmayer wrote: > > Should this file be in llvm/test/Instrumentation/

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 381365. kstoimenov added a comment. Removed the top level flag and addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files:

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 380829. kstoimenov added a comment. Fixed the test to pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov created this revision. Herald added subscribers: ormris, dexonsmith, dang, hiraditya. kstoimenov requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Added and

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3f413962627: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 368959. kstoimenov added a comment. Fixed the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files:

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 368903. kstoimenov added a comment. Added a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files:

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 368663. kstoimenov added a comment. Upload after submitting the main patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files:

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG832aae738bec: [asan] Implemented intrinsic for the custom calling convention similar used by… (authored by kstoimenov). Repository: rG LLVM

  1   2   >