[PATCH] D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941

kzhuravl added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIMemoryLegalizer.cpp:524 + SIAtomicAddrSpace::NONE) + return enableSC0Bit(MI) | enableSC1Bit(MI); +return false; Pierre-vh wrote: > kzhuravl wrote: > > jmmartinez wrote: > > >

[PATCH] D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941

kzhuravl marked an inline comment as done. kzhuravl added a comment. In D149986#4334274 , @Pierre-vh wrote: > I think that if this is a new property of the GFX940/941 targets, and turning > it off shouldn't be possible, we shouldn't even bother with a

[PATCH] D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941

kzhuravl marked an inline comment as done. kzhuravl added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIMemoryLegalizer.cpp:524 + SIAtomicAddrSpace::NONE) + return enableSC0Bit(MI) | enableSC1Bit(MI); +return false; jmmartinez wrote: >

[PATCH] D149983: AMDGPU: Add basic gfx942 target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d0572797233: AMDGPU: Add basic gfx942 target (authored by kzhuravl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149982: AMDGPU: Add basic gfx941 target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fc70210a6a5: AMDGPU: Add basic gfx941 target (authored by kzhuravl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941

kzhuravl added a comment. In D149986#4329302 , @arsenm wrote: > Should this be a feature set by default in the subtarget constructor instead? > Should you be able to turn this off? Users should not be able to turn this off. If user wants it off, user

[PATCH] D149983: AMDGPU: Add basic gfx942 target

kzhuravl created this revision. kzhuravl added reviewers: arsenm, msearles, rampitec, t-tye. Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, foad, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, emaste. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay.

[PATCH] D149982: AMDGPU: Add basic gfx941 target

kzhuravl created this revision. kzhuravl added reviewers: arsenm, msearles, rampitec, t-tye. Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, foad, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, emaste. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay.

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

kzhuravl added a comment. Overall looks good. Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:299 + + Attrs.mRuntimeHandle = getEnqueuedBlockSymbolName(TM, Func); } Do we really need/want to update code object v2? CHANGES SINCE LAST ACTION

[PATCH] D146023: [AMDGPU] Remove Code Object V2

kzhuravl added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:1379 .. warning:: - Code object V2 is not the default code object version emitted by - this version of LLVM. + Code object V2 emission is no longer supported by this version of LLVM.

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

kzhuravl added a comment. In D145671#4181568 , @yaxunl wrote: > Did you go through the deprecation process for this option? We need to send a > documentation team first so that it is announced to the users. Then in the > next release we can deprecate

[PATCH] D124536: [AMDGPU] Add gfx11 subtarget ELF definition

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124536/new/ https://reviews.llvm.org/D124536

[PATCH] D124536: [AMDGPU] Add gfx11 subtarget ELF definition

kzhuravl requested changes to this revision. kzhuravl added a comment. This revision now requires changes to proceed. Need to update processor table: https://llvm.org/docs/AMDGPUUsage.html#processors Need to update EF_AMDGPU_MACH_AMDGCN table:

[PATCH] D124536: [AMDGPU] Add gfx11 subtarget ELF definition

kzhuravl added a comment. Looks like this change is missing doc updates? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124536/new/ https://reviews.llvm.org/D124536 ___ cfe-commits mailing list

[PATCH] D103658: CUDA/HIP: Change device-use-host-var.cu's NOT "external" check to include "addrspace"

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d9f8527dbfb: CUDA/HIP: Change device-use-host-var.cus NOT external check to include… (authored by kzhuravl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D103658: CUDA/HIP: Change device-use-host-var.cu's NOT "external" check to include "addrspace"

kzhuravl updated this revision to Diff 349732. kzhuravl marked an inline comment as done. kzhuravl added a comment. Address review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103658/new/ https://reviews.llvm.org/D103658 Files:

[PATCH] D103658: CUDA/HIP: Change device-use-host-var.cu's NOT "external" check to include "addrspace"

kzhuravl created this revision. kzhuravl added a reviewer: yaxunl. kzhuravl requested review of this revision. Herald added a subscriber: wdng. Otherwise it is causing one of our build jobs to fail, it is using "external" as directory, and NOT is failing because "external" is found in ModuleID.

[PATCH] D102306: Add gfx1034

kzhuravl added inline comments. Comment at: llvm/include/llvm/BinaryFormat/ELF.h:737 EF_AMDGPU_MACH_AMDGCN_GFX1033 = 0x039, + EF_AMDGPU_MACH_AMDGCN_GFX1034 = 0x03e, EF_AMDGPU_MACH_AMDGCN_GFX602= 0x03a, For future reference, MACH values

[PATCH] D102306: Add gfx1034

kzhuravl added a subscriber: t-tye. kzhuravl added a comment. In D102306#2760806 , @tra wrote: > In D102306#2760775 , @msearles > wrote: > >> In D102306#2758166 , >>

[PATCH] D96906: [AMDGPU] gfx90a support

kzhuravl added inline comments. Comment at: clang/include/clang/Driver/Options.td:3097-3101 +def mtgsplit : Flag<["-"], "mtgsplit">, Group, + HelpText<"Enable threadgroup split execution mode (AMDGPU only)">; +def mno_tgsplit : Flag<["-"], "mno-tgsplit">, Group, +

[PATCH] D96906: [AMDGPU] gfx90a support

kzhuravl added inline comments. Comment at: clang/include/clang/Driver/Options.td:3097-3101 +def mtgsplit : Flag<["-"], "mtgsplit">, Group, + HelpText<"Enable threadgroup split execution mode (AMDGPU only)">; +def mno_tgsplit : Flag<["-"], "mno-tgsplit">, Group, +

[PATCH] D96906: [AMDGPU] gfx90a support

kzhuravl added inline comments. Comment at: clang/include/clang/Driver/Options.td:3097-3101 +def mtgsplit : Flag<["-"], "mtgsplit">, Group, + HelpText<"Enable threadgroup split execution mode (AMDGPU only)">; +def mno_tgsplit : Flag<["-"], "mno-tgsplit">, Group, +

[PATCH] D96906: [AMDGPU] gfx90a support

kzhuravl added inline comments. Comment at: clang/include/clang/Driver/Options.td:3097-3101 +def mtgsplit : Flag<["-"], "mtgsplit">, Group, + HelpText<"Enable threadgroup split execution mode (AMDGPU only)">; +def mno_tgsplit : Flag<["-"], "mno-tgsplit">, Group, +

[PATCH] D96906: [AMDGPU] gfx90a support

kzhuravl added inline comments. Comment at: clang/include/clang/Driver/Options.td:3097-3101 +def mtgsplit : Flag<["-"], "mtgsplit">, Group, + HelpText<"Enable threadgroup split execution mode (AMDGPU only)">; +def mno_tgsplit : Flag<["-"], "mno-tgsplit">, Group, +

[PATCH] D96906: [AMDGPU] gfx90a support

kzhuravl added inline comments. Comment at: clang/include/clang/Driver/Options.td:3097-3101 +def mtgsplit : Flag<["-"], "mtgsplit">, Group, + HelpText<"Enable threadgroup split execution mode (AMDGPU only)">; +def mno_tgsplit : Flag<["-"], "mno-tgsplit">, Group, +

[PATCH] D96906: [AMDGPU] gfx90a support

kzhuravl added inline comments. Comment at: llvm/include/llvm/BinaryFormat/ELF.h:737 EF_AMDGPU_MACH_AMDGCN_FIRST = EF_AMDGPU_MACH_AMDGCN_GFX600, - EF_AMDGPU_MACH_AMDGCN_LAST = EF_AMDGPU_MACH_AMDGCN_GFX805, + EF_AMDGPU_MACH_AMDGCN_LAST = EF_AMDGPU_MACH_AMDGCN_GFX90A,

[PATCH] D96906: [AMDGPU] gfx90a support

kzhuravl added a comment. > The point is that nobody upstream even got a chance to chime in. We are and will be taking care of any feedback provided in this review post-commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96906/new/

[PATCH] D96906: [AMDGPU] gfx90a support

kzhuravl added inline comments. Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.workitem.id.ll:23 + +; CO-V3: .amdhsa_system_vgpr_workitem_id 0 +; PACKED-TID: .amdhsa_system_vgpr_workitem_id 0 foad wrote: > CO-V3 isn't tested by any RUN line. I think FileCheck

[PATCH] D93181: [NFC][AMDGPU] Reformat AMD GPU targets in cuda.cpp

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93181/new/ https://reviews.llvm.org/D93181

[PATCH] D93017: [AMDGPU] Add missing targets to amdgpu-features.cl

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93017/new/ https://reviews.llvm.org/D93017

[PATCH] D93018: [AMDGPU] Add missing targets to target-invalid-cpu-note.c

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93018/new/ https://reviews.llvm.org/D93018

[PATCH] D92441: Add CLangOffloadBundler documentation to Clang index

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92441/new/ https://reviews.llvm.org/D92441

[PATCH] D92434: [NFC][AMDGPU] AMDGPU code object V4 ABI documentation

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92434/new/ https://reviews.llvm.org/D92434

[PATCH] D91310: [AMDGPU] Add -mcode-object-version=n

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91310/new/ https://reviews.llvm.org/D91310 ___ cfe-commits mailing list

[PATCH] D90364: [AMDGPU] Update AMD GPU documentation

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90364/new/ https://reviews.llvm.org/D90364

[PATCH] D89484: [AMDGPU][HIP] Switch default DWARF version to 5

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89484/new/ https://reviews.llvm.org/D89484

[PATCH] D89478: AMDGPU: Make sure both cc1 and cc1as process -m[no-]code-object-v3

This revision was automatically updated to reflect the committed changes. Closed by commit rG67f189e93ce3: Make sure both cc1 and cc1as process -m[no-]code-object-v3 (authored by kzhuravl). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D89125: AMDGPU: Remove -mamdgpu-debugger-abi option

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2eaa914514c: AMDGPU: Remove -mamdgpu-debugger-abi option (authored by kzhuravl). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D89091: Regenerate ClangCommandLineReference.rst

This revision was automatically updated to reflect the committed changes. Closed by commit rGb581c5a42f05: Regenerate ClangCommandLineReference.rst (authored by kzhuravl). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D63256: [OpenCL] Split type and macro definitions into opencl-c-base.h

kzhuravl added inline comments. Comment at: cfe/trunk/lib/Headers/opencl-c.h:13638-13640 -#ifndef ATOMIC_VAR_INIT -#define ATOMIC_VAR_INIT(x) (x) -#endif //ATOMIC_VAR_INIT svenvh wrote: > yaxunl wrote: > > kzhuravl wrote: > > > Any reason this piece of code got

[PATCH] D63256: [OpenCL] Split type and macro definitions into opencl-c-base.h

kzhuravl added subscribers: b-sumner, kzhuravl. kzhuravl added a comment. + @b-sumner Comment at: cfe/trunk/lib/Headers/opencl-c.h:13638-13640 -#ifndef ATOMIC_VAR_INIT -#define ATOMIC_VAR_INIT(x) (x) -#endif //ATOMIC_VAR_INIT Any reason this piece of code got

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

kzhuravl accepted this revision. kzhuravl added a comment. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59008/new/ https://reviews.llvm.org/D59008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59494: AMDGPU: Add support for cross address space synchronization scopes (clang)

This revision was automatically updated to reflect the committed changes. Closed by commit rC356947: AMDGPU: Add support for cross address space synchronization scopes (clang) (authored by kzhuravl, committed by ). Herald added a subscriber: ebevhan. Herald added a project: clang. Repository:

[PATCH] D59494: AMDGPU: Add support for cross address space synchronization scopes (clang)

kzhuravl updated this revision to Diff 191193. kzhuravl marked an inline comment as done. kzhuravl added a comment. Address review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59494/new/ https://reviews.llvm.org/D59494 Files: lib/CodeGen/CGAtomic.cpp

[PATCH] D59494: AMDGPU: Add support for cross address space synchronization scopes (clang)

kzhuravl added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7976 + +Name = Twine(Twine(Name) + Twine("one-as")).str(); + } rampitec wrote: > I think subgroup is in the single address space even if sequentially > consistent. I have synced with

[PATCH] D59494: AMDGPU: Add support for cross address space synchronization scopes

kzhuravl created this revision. kzhuravl added reviewers: b-sumner, rampitec, t-tye. Herald added subscribers: jfb, tpr, dstuttard, yaxunl, wdng. kzhuravl added a comment. Backend change will be posted later today. I am currently working on adding backend tests. https://reviews.llvm.org/D59494

[PATCH] D59494: AMDGPU: Add support for cross address space synchronization scopes

kzhuravl added a comment. Backend change will be posted later today. I am currently working on adding backend tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59494/new/ https://reviews.llvm.org/D59494 ___ cfe-commits mailing list

[PATCH] D58847: AMDGPU: Fix the mapping of sub group sync scope

This revision was automatically updated to reflect the committed changes. Closed by commit rC355549: AMDGPU: Fix the mapping of sub group sync scope (authored by kzhuravl, committed by ). Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D58847: AMDGPU: Fix the mapping of sub group sync scope

kzhuravl created this revision. kzhuravl added reviewers: b-sumner, rampitec, t-tye. Herald added subscribers: jfb, tpr, dstuttard, yaxunl, wdng. Map memory_scope_sub_group to "wavefront" sync scope https://reviews.llvm.org/D58847 Files: lib/CodeGen/TargetInfo.cpp

[PATCH] D58526: AMDGPU: Don't emit debugger subtarget features

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58526/new/ https://reviews.llvm.org/D58526 ___ cfe-commits mailing list

[PATCH] D58526: AMDGPU: Don't emit debugger subtarget features

kzhuravl added inline comments. Comment at: test/Driver/amdgpu-features.c:4 // CHECK-MAMDGPU-DEBUGGER-ABI-0-0: the clang compiler does not support '-mamdgpu-debugger-abi=0.0' - -// RUN: %clang -### -target amdgcn -x cl -S -emit-llvm -mcpu=kaveri -mamdgpu-debugger-abi=1.0 %s

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM. Please make sure to update your commit message as your patch processes all m options now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

kzhuravl added a comment. Is it still code object v2 by default? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

kzhuravl added a comment. Can you add some tests? Preferably with -mxnack/-mno-xnack, -msram-ecc/-mno-sram-ecc, -mcode-object-v3/-mno-code-object-v3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

kzhuravl added a comment. https://github.com/llvm-mirror/clang/blob/master/lib/Driver/ToolChains/AMDGPU.cpp#L52 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977 ___

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

kzhuravl added a comment. Can you handle all features as follows instead of checking a particular option? ‘handleTargetFeaturesGroup( Args, Features, options::OPT_m_amdgpu_Features_Group);’ ? There is code in AMDGPU tool chain you can use as a reference. Repository: rC Clang CHANGES

[PATCH] D56525: [AMDGPU] Separate feature dot-insts

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56525/new/ https://reviews.llvm.org/D56525 ___

[PATCH] D53223: AMDGPU: Add sram-ecc feature options

This revision was automatically updated to reflect the committed changes. Closed by commit rL346178: AMDGPU: Add sram-ecc feature options (authored by kzhuravl, committed by ). Changed prior to commit: https://reviews.llvm.org/D53223?vs=169499=172665#toc Repository: rL LLVM

[PATCH] D53223: AMDGPU: Add sram-ecc feature options

This revision was automatically updated to reflect the committed changes. Closed by commit rC346178: AMDGPU: Add sram-ecc feature options (authored by kzhuravl, committed by ). Repository: rL LLVM https://reviews.llvm.org/D53223 Files: include/clang/Driver/Options.td

[PATCH] D53223: AMDGPU: Add sram-ecc feature options

kzhuravl added a comment. ping https://reviews.llvm.org/D53223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53223: AMDGPU: Add sram-ecc feature options

kzhuravl added a comment. ping https://reviews.llvm.org/D53223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53558: Add gfx909 to GPU Arch

kzhuravl added a comment. In https://reviews.llvm.org/D53558#1272673, @kzhuravl wrote: > Are changes for > https://github.com/llvm-mirror/clang/blob/master/lib/Basic/Targets/AMDGPU.cpp#L137 > in a separate review? (I could not locate it). https://reviews.llvm.org/rC345181 Repository: rC

[PATCH] D53558: Add gfx909 to GPU Arch

kzhuravl added a comment. Are changes for https://github.com/llvm-mirror/clang/blob/master/lib/Basic/Targets/AMDGPU.cpp#L137 in a separate review? (I could not locate it). Repository: rC Clang https://reviews.llvm.org/D53558 ___ cfe-commits

[PATCH] D53325: Disable code object version 3 for HIP toolchain

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D53325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50843: AMDGPU: Correct errors in device table

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D50843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50493: AMDGPU: Add another missing builtin

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D50493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50376: AMDGPU: Fix enabling denormals by default on pre-VI targets

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D50376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50320: AMDGPU: Add builtin for s_dcache_inv_vol

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D50320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50321: AMDGPU: Add builtin for s_dcache_wb

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D50321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43094: AMDGPU: Enable PIC by default for amdgcn

This revision was automatically updated to reflect the committed changes. Closed by commit rL325196: AMDGPU: Enable PIC by default for amdgcn (authored by kzhuravl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D36802: AMDGPU: Cleanup most of the macros

This revision was automatically updated to reflect the committed changes. Closed by commit rL325193: AMDGPU: Cleanup most of the macros (authored by kzhuravl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D36802?vs=134335=134336#toc

[PATCH] D36802: AMDGPU: Cleanup most of the macros

kzhuravl updated this revision to Diff 134335. kzhuravl edited the summary of this revision. kzhuravl added a comment. Address review feedback. https://reviews.llvm.org/D36802 Files: lib/Basic/Targets/AMDGPU.cpp lib/Basic/Targets/AMDGPU.h test/Driver/amdgpu-macros.cl Index:

[PATCH] D43094: AMDGPU: Enable PIC by default for amdgcn

kzhuravl added a comment. Ping. https://reviews.llvm.org/D43094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36802: AMDGPU: Cleanup most of the macros

kzhuravl added a comment. Ping. https://reviews.llvm.org/D36802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36802: AMDGPU: Cleanup most of the macros

kzhuravl updated this revision to Diff 133569. kzhuravl added a comment. Define only canonical names. https://reviews.llvm.org/D36802 Files: lib/Basic/Targets/AMDGPU.cpp lib/Basic/Targets/AMDGPU.h test/Driver/amdgpu-macros.cl Index: test/Driver/amdgpu-macros.cl

[PATCH] D40045: AMDGPU/GCN: Bring processors in sync with AMDGPUUsage

kzhuravl added a comment. In https://reviews.llvm.org/D40045#925400, @t-tye wrote: > LGTM except for Bonaire. Done. Also removed gfx800 as per latest docs. Repository: rL LLVM https://reviews.llvm.org/D40045 ___ cfe-commits mailing list

[PATCH] D40045: AMDGPU/GCN: Bring processors in sync with AMDGPUUsage

This revision was not accepted when it landed; it landed in state "Changes Planned". This revision was automatically updated to reflect the committed changes. kzhuravl marked an inline comment as done. Closed by commit rL324714: AMDGPU/GCN: Bring processors in sync with AMDGPUUsage (authored by

[PATCH] D43094: AMDGPU: Enable PIC by default for amdgcn

kzhuravl added a comment. I thought we could override `isPICDefault` in AMDGPUToolChain instead of doing what is posted. But AMDGPUToolChain is only created for AMDHSA OS. Do we want to enable PIC by default for all AMDGCNs? Or only for AMDHSA? https://reviews.llvm.org/D43094

[PATCH] D43094: AMDGPU: Enable PIC by default for amdgcn

kzhuravl created this revision. kzhuravl added reviewers: nhaehnle, t-tye, timcorringham, tpr, tstellar. Herald added subscribers: dstuttard, yaxunl, wdng. https://reviews.llvm.org/D43094 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/amdgcn-toolchain-pic.cl Index:

[PATCH] D36802: AMDGPU: Cleanup most of the macros

kzhuravl added a comment. Need to only define canonical names. https://reviews.llvm.org/D36802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39879: AMDGPU: Remove -mamdgpu-debugger-abi option

kzhuravl abandoned this revision. kzhuravl added a comment. Agreed to do it later. https://reviews.llvm.org/D39879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39879: AMDGPU: Remove -mamdgpu-debugger-abi option

kzhuravl added a comment. Ping. https://reviews.llvm.org/D39879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40045: AMDGPU/GCN: Bring processors in sync with AMDGPUUsage

kzhuravl created this revision. Herald added subscribers: tpr, dstuttard, yaxunl, nhaehnle, wdng. - Remove gfx804 - Remove gfx901 - Remove gfx903 https://reviews.llvm.org/D40045 Files: lib/Basic/Targets/AMDGPU.cpp test/Driver/amdgpu-mcpu.cl Index: test/Driver/amdgpu-mcpu.cl

[PATCH] D39878: AMDGPU: Add -mxnack/-mno-xnack options that set +/-xnack feature

This revision was automatically updated to reflect the committed changes. Closed by commit rL317917: AMDGPU: Add -mxnack/-mno-xnack options that set +/-xnack feature (authored by kzhuravl). Changed prior to commit: https://reviews.llvm.org/D39878?vs=122355=122489#toc Repository: rL LLVM

[PATCH] D39877: AMDGPU/NFC: Move getAMDGPUTargetFeatures to AMDGPU toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rL317909: AMDGPU/NFC: Move getAMDGPUTargetFeatures to AMDGPU toolchain (authored by kzhuravl). Changed prior to commit: https://reviews.llvm.org/D39877?vs=122354=122487#toc Repository: rL LLVM

[PATCH] D39879: AMDGPU: Remove -mamdgpu-debugger-abi option

kzhuravl created this revision. Herald added subscribers: tpr, dstuttard, yaxunl, nhaehnle, wdng. https://reviews.llvm.org/D39879 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/AMDGPU.cpp test/Driver/amdgpu-features.c Index: test/Driver/amdgpu-features.c

[PATCH] D39878: AMDGPU: Add -mxnack/-mno-xnack options that set +/-xnack feature

kzhuravl created this revision. Herald added subscribers: tpr, dstuttard, yaxunl, nhaehnle, wdng. https://reviews.llvm.org/D39878 Files: include/clang/Driver/Options.td test/Driver/amdgpu-features.c Index: test/Driver/amdgpu-features.c

[PATCH] D39877: AMDGPU/NFC: Move getAMDGPUTargetFeatures to AMDGPU toolchain

kzhuravl created this revision. Herald added subscribers: tpr, dstuttard, yaxunl, nhaehnle, wdng. https://reviews.llvm.org/D39877 Files: lib/Driver/ToolChains/AMDGPU.cpp lib/Driver/ToolChains/AMDGPU.h lib/Driver/ToolChains/Clang.cpp Index: lib/Driver/ToolChains/Clang.cpp

[PATCH] D39857: [AMDGPU] Late parsed / dependent arguments for AMDGPU kernel attributes

kzhuravl added a subscriber: cfe-commits. kzhuravl added a reviewer: aaron.ballman. kzhuravl added a comment. Hi Alex, can you rebase on top of trunk (I think you brought in some extra changes from hcc branch) and upload a full diff? Comment at:

[PATCH] D38698: AMDGPU: Add read_exec_lo/hi builtins

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D38698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37599: Add '\n' in ClangDataCollectorsEmitter

kzhuravl added a comment. In https://reviews.llvm.org/D37599#864376, @arphaman wrote: > LGTM. Do you have commit access? Yep, committed. Thanks. Repository: rL LLVM https://reviews.llvm.org/D37599 ___ cfe-commits mailing list

[PATCH] D37599: Add '\n' in ClangDataCollectorsEmitter

This revision was automatically updated to reflect the committed changes. Closed by commit rL312795: Add '\n' in ClangDataCollectorsEmitter (authored by kzhuravl). Changed prior to commit: https://reviews.llvm.org/D37599?vs=114269=114376#toc Repository: rL LLVM

[PATCH] D37599: Add '\n' in ClangDataCollectorsEmitter

kzhuravl created this revision. Herald added subscribers: ilya-biryukov, wdng. Otherwise it breaks our internal windows builders: StmtDataCollectors.inc: error C2220: warning treated as error - no 'object' file generated StmtDataCollectors.inc: warning C4335: Mac file format detected:

[PATCH] D36802: AMDGPU: Cleanup most of the macros

kzhuravl updated this revision to Diff 112761. kzhuravl marked an inline comment as done. kzhuravl retitled this revision from "AMDGPU: Insert __devicename__ macros" to "AMDGPU: Cleanup most of the macros". kzhuravl edited the summary of this revision. kzhuravl added a comment. fast fmaf macro

[PATCH] D36771: AMDGPU: add missing amdgcn processors and tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL311141: AMDGPU: add missing amdgcn processors and tests (authored by kzhuravl). Changed prior to commit: https://reviews.llvm.org/D36771?vs=111270=111595#toc Repository: rL LLVM

[PATCH] D36802: AMDGPU: Insert __devicename__ macros

kzhuravl added a comment. Do we need this for r600? https://reviews.llvm.org/D36802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36802: AMDGPU: Insert __devicename__ macros

kzhuravl created this revision. Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng. https://reviews.llvm.org/D36802 Files: lib/Basic/Targets/AMDGPU.cpp lib/Basic/Targets/AMDGPU.h test/Driver/amdgcn-mcpu-macro.cl test/Driver/r600-mcpu-macro.cl

[PATCH] D36771: AMDGPU: add missing amdgcn processors and tests

kzhuravl added a comment. In https://reviews.llvm.org/D36771#842837, @arsenm wrote: > We should also be defining __devicename__ macros. I opened a bug for this > last week https://reviews.llvm.org/D36802 https://reviews.llvm.org/D36771 ___

[PATCH] D36771: AMDGPU: add missing amdgcn processors and tests

kzhuravl created this revision. Herald added subscribers: tpr, dstuttard, yaxunl, nhaehnle, wdng. - gfx600 - gfx601 - gfx703 - gfx902 - gfx903 https://reviews.llvm.org/D36771 Files: lib/Basic/Targets/AMDGPU.cpp test/Driver/r600-mcpu.cl Index: test/Driver/r600-mcpu.cl

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

kzhuravl added a comment. Seems like SyncScope.h file is missing? https://reviews.llvm.org/D28691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >