[PATCH] D112119: [ObjC Availability] Add missing const to getVersion function of ObjCAvailabilityCheckExpr class

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1c9e7bdc921: [ObjC Availability] Add missing const to getVersion function of… (authored by lcs, committed by kyulee). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115979: [InstrProf] Don't profile merge by default in lightweight mode

kyulee added a comment. For clarification, the lightweight pgo does not support merging raw data from memory (at runtime) due to missing structural data, but it does support merging raw files offline. Would you update the comment or error message? Repository: rG LLVM Github Monorepo

[PATCH] D114565: [InstrProf] Attach debug info to counters

kyulee added a comment. This change for the profile writer looks good to me! Before signing it off, I'd like to hear any other suggestions or opinions from @davidxl @MaskRay @alanphipps since this is technically the very first change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D114565: [InstrProf] Attach debug info to counters

kyulee added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingWriter.c:299 + if (DebugInfoCorrelate) { +ProfDataIOVec IOVecData[] = { Should it be down after `__llvm_write_binary_ids` below although it doesn't do anything in general? I

[PATCH] D114565: [InstrProf] Attach debug info to counters

kyulee added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:961 + DB.finalize(); +} + } I think when `-debug-info-correlate` is used without debug info, we should fail or emit a warning here instead of silently

[PATCH] D114565: [InstrProf] Attach debug info to counters

kyulee added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:851 + addString(AnnotationDie, dwarf::DW_AT_const_value, Value->getString()); +else if (const auto *Expr = dyn_cast(ValueOp)) + addConstantValue( It checks an

[PATCH] D114565: [InstrProf] Attach debug info to counters

kyulee added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingWriter.c:273 - if (!DataSize) + if (!CountersSize) return 0; Is it no diff change? I wonder if there is a case where `CountersSize` is 0 but not `DataSize` from a value

[PATCH] D114268: [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde11de308b64: [InstrProf] Use i32 for GEP index from lowering llvm.instrprof.increment (authored by ellis, committed by kyulee). Repository: rG

[PATCH] D107024: [DIBuilder] Do not replace empty enum types

This revision was automatically updated to reflect the committed changes. Closed by commit rG47b239eb5a17: [DIBuilder] Do not replace empty enum types (authored by ellis, committed by kyulee). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87953: [xray] Function coverage groups

kyulee added a comment. I think it looks good to me. @MaskRay Any further feedback on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87953/new/ https://reviews.llvm.org/D87953 ___ cfe-commits

[PATCH] D87953: [xray] Function coverage groups

kyulee added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:814 +auto FuncGroups = CGM.getCodeGenOpts().XRayTotalFunctionGroups; +if (FuncGroups > 1) { + auto FuncName = ArrayRef(CurFn->getName().bytes_begin(), MaskRay wrote: >