[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

mibintc added a comment. In D72675#1919685 , @spatel wrote: > In D72675#1917844 , @wristow wrote: > > > Revisiting this patch. I think that before fixing the `-ffp-contract=off` > > problem I originally raised

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

mibintc added a comment. I ran into an obstacle trying to add Trailing storage onto binary operator. it will probably take me longer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75443/new/ https://reviews.llvm.org/D75443

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. @rjmccall Since CompoundAssignmentOperator derives from BinaryOperator, it's not simple to add Trailing storage here. I think I will have to fold CompoundAssignmentOperator into BinaryOperator and then add the 2 extra fields needed by CompoundAssignmentOperator into

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

mibintc added a comment. well, it would probably be quickest to separate the trailing storage into a separate patch. i'll try to get that submitted today. shall i submit that as a phabricator review or is there a different, preferred way to do that? Repository: rG LLVM Github Monorepo

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

mibintc added a comment. I'm working on a patch that will move FPOptions to Trailing storage, part of https://reviews.llvm.org/D72841 ; hope to have another revision uploaded today or tomorrow. I got feedback that moving the field to BinaryOperator isn't adequate. Repository: rG LLVM

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. In D72841#1911330 , @rjmccall wrote: > In D72841#1908084 , @mibintc wrote: > > > @rjmccall suggested that I needed to remove FPOptions from the Stmt class > > since the sizeof assertion

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. I got an email like this "Harbormaster failed remote builds in B48237 : Diff 248536!" but there is no further information. It builds OK from my workstation. I did have to paste the review because an upload to Phabricator exceeded the

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4085 // this should improve codegen just a little. -RHS = Visit(E->getRHS()); -LHS = EmitCheckedLValue(E->getLHS(), CodeGenFunction::TCK_Store); +

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 12 inline comments as done. mibintc added a comment. Herald added a subscriber: rnkovacs. some inline replies and comments Comment at: clang/include/clang/AST/Stmt.h:1104 +static_assert(sizeof(*this) <= 16, "changing bitfields changed

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

mibintc added a comment. Added a couple inline comments Comment at: clang/docs/ReleaseNotes.rst:62 + permit non-power of 2 integers, exposing the LLVM integer types. Since a major + motivating use case for these types is to limit 'bit' useage, these types don't +

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 246285. mibintc marked an inline comment as done. mibintc added a comment. This patch is code complete and ready for your review and consideration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 244894. mibintc added a comment. I found the problem in the #pragma float_control (push/pop) stack, it was just a dumb bug. I also added -include-pch test cases, and added code to ASTWriter ASTReader to preserve the floatcontrol pragma stack For 2 of the

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. @jsji Will your backend tolerate -ffp-contract=on if optimizations are not disabled, e.g. -O2? We are proposing that the default floating point model be -ffp-model=precise, and with precise model, the ffp-contract=on. However you are right we don't want the frontend

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. In D74436#1875273 , @jsji wrote: > This is also breaking test-suites in our internal buildbots .. > > This change is actually changing the default behavior: if user does NOT > supply `-ffp-contract`, it becomes

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc marked 2 inline comments as done. mibintc added a comment. some replies to Andy. I'll upload another patch here which passed check-all locally. then i'll re-commit it. Comment at: clang/docs/UsersManual.rst:1388 - * ``precise`` Disables optimizations that are not

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc updated this revision to Diff 244178. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/ppc-emmintrin.c

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

This revision was automatically updated to reflect the committed changes. mibintc marked 2 inline comments as done. Closed by commit rG3fcdf2fa945a: Change clang option -ffp-model=precise to select ffp-contract=on (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D74436: Change clang default to -ffp-model=precise

mibintc created this revision. mibintc added reviewers: andrew.w.kaylor, lebedev.ri, rjmccall, sepavloff. Herald added subscribers: kbarton, nemanjai. Herald added a project: clang. This patch establishes the default option for -ffp-model to select "precise". Further, -ffp-model=precise also

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. In D72841#1869931 , @lebedev.ri wrote: > I would think `contract` change can be separated from the rest of the > changes, and therefore should be a separate review (to reduce noise)? I split off that change to

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 243888. mibintc added a comment. Herald added subscribers: kbarton, jvesely, nemanjai. This patch is a work in progress. The problem that I want to work on next is that the scope is wrong when the pragma token is seen following the right brace of a function

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 6 inline comments as done. mibintc added a comment. In D72841#1842772 , @andrew.w.kaylor wrote: > It's not clear to me from reading this how the "precise" control is going to > work with relation to the fast math flags. I don't think MSVC

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 240638. mibintc added a comment. rebase per @sepavloff request Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 Files: clang/docs/LanguageExtensions.rst

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 3 inline comments as done. mibintc added a comment. In D72841#1833022 , @sepavloff wrote: > I don't see tests for correctness of the pragma stack (`pragma > float_control(... push)`, `pragma float_control(pop)`). Can you add them? I

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 240245. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 Files: clang/docs/LanguageExtensions.rst clang/include/clang/AST/Stmt.h

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 2 inline comments as done. mibintc added a comment. A couple inline replies to @sepavloff ; I'll be uploading another revision. Comment at: clang/lib/Parse/ParsePragma.cpp:2537 +if (!Actions.CurContext->isTranslationUnit()) { +//FIXME this seems to be the

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 5 inline comments as done. mibintc added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13129 if (FunctionDecl *F = dyn_cast(CurContext)) { + // If the expression occurs inside an internal global_var_init_function + // then the

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 239409. mibintc added a comment. Respond to review from @sepavloff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 Files: clang/docs/LanguageExtensions.rst

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:2537 +if (!Actions.CurContext->isTranslationUnit()) { +//FIXME this seems to be the wrong way to check file-scope +//since the token immediately following a

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 2 inline comments as done. mibintc added a comment. Added inline reply Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:111 // the corresponding enum in the IR. -static llvm::fp::RoundingMode ToConstrainedRoundingMD( +llvm::fp::RoundingMode

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 3 inline comments as done. mibintc added a comment. @sepavloff Thanks a lot for your comments. I added a few replies and I have one question, added inline. Comment at: clang/lib/Parse/ParsePragma.cpp:2522 + IdentifierInfo *II = Tok.getIdentifierInfo(); +

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc created this revision. mibintc added reviewers: andrew.w.kaylor, kpn, rjmccall, sepavloff. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Intel would like to support #pragma float_control which allows control over precision and exception behavior

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

mibintc added a comment. In D69272#1717021 , @kpn wrote: > Is there a way forward to support having the #pragma at the start of any > block inside a function? The effect won't be restricted to that block, true, > but the standard does say the #pragma is

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1790211 , @rupprecht wrote: > In D62731#1789122 , @rupprecht wrote: > > > In D62731#1788902 , > > @andrew.w.kaylor wrote: > > > > > In

[PATCH] D71671: [clang] Remove -Wexperimental-float-control.

mibintc added a comment. thanks for taking care of this. looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71671/new/ https://reviews.llvm.org/D71671 ___ cfe-commits mailing list

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1780597 , @cameron.mcinally wrote: > I don't see a problem with this, but it would be nice to make the > `-f[no-]trapping-math` command line option work. GNU compatibility is good. Thanks Cameron, I'll go that way

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1778597 , @michele.scandale wrote: > >> I've noticed you removed the change for `CompilerInvocation.cpp` about the > >> initialization of the codegen option `NoTrappingMath`. Was that an > >> accident? Thanks again

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1773854 , @michele.scandale wrote: > I've noticed you removed the change for `CompilerInvocation.cpp` about the > initialization of the codegen option `NoTrappingMath`. Was that an accident? I checked the old and new

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. I fixed the lit test problem and pushed it again commit 7f9b5138470db1dc58f3bc05631284c653c9ed7a Author: Melanie Blower Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. I reverted it again because build break on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 ___ cfe-commits mailing list

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc marked an inline comment as done. mibintc added a comment. I've pushed the updated patch, commit cdbed2dd856c14687efd741c2d8321686102acb8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc marked 9 inline comments as done. mibintc added a comment. I added inline comments describing what I did in this version of the patch to address the bug https://bugs.llvm.org/show_bug.cgi?id=44048 Comment at: clang/include/clang/AST/DeclBase.h:1539 +/// Indicates

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 231758. mibintc added a comment. This commit was reverted in 30e7ee3c4bac because a null deref error occurred in IRBuilder.h when setting strictfp attribute, see

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 230128. mibintc added a comment. Here's an update in response to comments from @michele.scandale I fixed the assertion error and added a test case I fixed the setting of ftrapping-math in CodeGenOpts I deleted an incorrect comment I added a diagnostic when

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc marked 4 inline comments as done. mibintc added a comment. inline replies to Michele, will upload a new patch shortly Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2408 +case options::OPT_frounding_math: + // The default setting for frounding-math is True

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1750412 , @kpn wrote: > Does anyone think a warning is appropriate because the new flags are > exercising experimental, incomplete code in both clang and llvm? The warning > would be removed when we believe the feature

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. I added a nullptr check in IRBuilder.h and a test case to cover the segfault reported in https://bugs.llvm.org/show_bug.cgi?id=44048 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 229893. mibintc added a reviewer: kpn. Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManual.rst

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc reopened this revision. mibintc added a comment. This revision is now accepted and ready to land. Reopening since patch was reverted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1750312 , @echristo wrote: > In D62731#1749916 , @mibintc wrote: > > > Thanks I see it, I'm working on a patch. Previously there was no support > > for frounding-math

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. The incorrect code is actually in the IRBuilder which is part of a different patch... In D62731#1750312 , @echristo wrote: > In D62731#1749916 , @mibintc wrote: > > > Thanks I see it, I'm

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. Thanks I see it, I'm working on a patch. Previously there was no support for frounding-math (unimplemented). This patch enables the option. In the IR builder, there's a call to a runtime function in the exception handler which is unexpectedly null. I start by adding a

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc closed this revision. mibintc added a comment. Don't know why the commit id didn't get linked when I pushed the change. Here's the closure info: commit af57dbf12e54f3a8ff48534bf1078f4de104c1cd Author: Melanie Blower

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

This revision was automatically updated to reflect the committed changes. Closed by commit rG759948467ea3: Reapply Fix crash on switch conditions of non-integer types in templates (authored by mibintc). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 227960. mibintc retitled this revision from "Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior" to "Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:133 + +llvm::ConstrainedFPIntrinsic::ExceptionBehavior +CodeGenFunction::ToConstrainedExceptMD(LangOptions::FPExceptionModeKind Kind) {

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 227532. mibintc added a comment. Made a couple functions static per @rjmccall request Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManual.rst

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 227527. mibintc added a comment. Recoded ToConstrainedRoundingMD and ToConstrainedExceptionMD as requested by @rjmccall CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManual.rst

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:133 + +llvm::ConstrainedFPIntrinsic::ExceptionBehavior +CodeGenFunction::ToConstrainedExceptMD(LangOptions::FPExceptionModeKind Kind) { I added these 2 functions, is this what you

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 227470. mibintc added a comment. Respond to recent code review from @rjmccall ; I modified the test cases and added functions for translating between the LangOptions enumeration and llvm enumeration for rounding-mode and exception-behavior. I wasn't able

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/include/clang/Driver/Options.td:1152 +def frounding_math : Flag<["-"], "frounding-math">, Group, Flags<[CC1Option]>; +def fno_rounding_math : Flag<["-"], "fno-rounding-math">, Group,

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked 5 inline comments as done. mibintc added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:238 CODEGENOPT(UnsafeFPMath , 1, 0) ///< Allow unsafe floating point optzns. +CODEGENOPT(RoundingFPMath, 1, 0) ///< Rounding floating point

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 227283. mibintc added a comment. I followed up on some code review remarks from @rjmccall. I dropped the CODEGEN option and fixed some code formatting. I changed the spelling of the enumeration values for RoundingMode and ExceptionMode to match those

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:238 CODEGENOPT(UnsafeFPMath , 1, 0) ///< Allow unsafe floating point optzns. +CODEGENOPT(RoundingFPMath, 1, 0) ///< Rounding floating point optzns. CODEGENOPT(UnwindTables ,

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1724290 , @rjmccall wrote: > Is the exception-strictness of `-frounding-math` actually considered to be > specified behavior, or is it just a consequence of the current > implementation? There are definitely some

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 226907. mibintc added a comment. In response to comments from @rjmccall I inserted into the UsersManual the one-line summary of frounding-math that had been omitted and changed the semantics of frounding-math to not also set exception-behavior to strict

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 226738. mibintc added a comment. I adopted the language that @rjmccall recommended for documenting frounding-math., also adding a sentence to describe effects on exception behavior control. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1318 + mode informs the compiler that it must not assume any particular + rounding mode. + rjmccall wrote: > rjmccall wrote: > > "represent *the* corresponding IEEE rounding rules" > A few

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. Ping. Hoping for code review so I can move this forward. Affirmative or negative, please let me know. Thank you! --Melanie Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked an inline comment as done. mibintc added a comment. I looked over the codegen testcase fpconstrained.c and it looks pretty good, so i think this is ready for your review comments. I'll be off the grid for a couple days but looking forward to receiving your feedback. I inserted

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked 5 inline comments as done. mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1330 + and ``fast``. + Details: + rjmccall wrote: > rjmccall wrote: > > "provided by other, single-purpose floating point options." > I don't know

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 224136. mibintc retitled this revision from "[RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior" to "Add support for options -frounding-math, ftrapping-math, -fp-model=, and

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 223940. mibintc added a comment. I added a test case to show the warning diagnostics when options conflicting with fp-model are provided. I fixed a couple bugs in RenderFloatingPointOptions when issueing diagnostics. still owe a test case showing how the

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 223911. mibintc added a comment. clean up some dead code Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManual.rst

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/include/clang/Driver/Options.td:927 def fdenormal_fp_math_EQ : Joined<["-"], "fdenormal-fp-math=">, Group, Flags<[CC1Option]>; +def ffp_model_EQ : Joined<["-"], "ffp-model=">, Group,

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1341 + has been selected, then the compiler will issue a diagnostic warning + that the override has occurred. + rjmccall wrote: > That's not

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 223908. mibintc added a comment. I made a couple wording changes suggested by @rjmccall Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManual.rst

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 223090. mibintc added a comment. In the previous review, @rjmccall asked me to redo the existing floating point option documentation before submitting this patch. I got the floating point documentation update committed, and I've worked on this patch more

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1663748 , @rjmccall wrote: > Hmm, you know, there are enough different FP options that I think we should > probably split them all out into their own section in the manual instead of > just listing them under "code

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1663748 , @rjmccall wrote: > Hmm, you know, there are enough different FP options that I think we should > probably split them all out into their own section in the manual instead of > just listing them under "code

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1314 + ``-ffp-model=strict``, or merely establish the rounding mode setting + parameter to the llvm floating point constrained intrinsics. +

[PATCH] D62731: [RFC] Add support for options -frounding-math -fp-model= and -fp-exception-behavior= : specify floating point behavior

mibintc updated this revision to Diff 219364. mibintc retitled this revision from "[RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior" to "[RFC] Add support for options -frounding-math -fp-model= and -fp-exception-behavior= : specify floating point

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 3 inline comments as done. mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1305 + and ``noexcept``. Note that -fp-model=[no]except can be combined with the + other three settings for this option. Details: +

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 217426. mibintc added a comment. I made a couple changes to the UserManual in response to @rjmccall review Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files:

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1305 + and ``noexcept``. Note that -fp-model=[no]except can be combined with the + other three settings for this option. Details: + rjmccall

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. ping, looking for a code review, especially from front end folks. thank you! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 ___ cfe-commits mailing

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 215666. mibintc marked an inline comment as not done. mibintc edited the summary of this revision. mibintc added a comment. I addressed some comments from @kpn: I corrected the documentation formatting and added some details, and used Diag instead of

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 3 inline comments as not done. mibintc added a comment. I added an inline reply and unmarked some things that had been inadvertently marked done. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:126 + case LangOptions::FPM_Precise: + case

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 3 inline comments as done. mibintc added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:126 + case LangOptions::FPM_Precise: + case LangOptions::FPM_Fast: +break; kpn wrote: > Wait, so "fast" and "precise" are the same

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 215225. mibintc added a comment. I added documentation for the new floating point options into clang/docs Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files:

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. Here's a summary of how the rm and eb options are set if user requests fp-model=strict, then the ConstrainedIntrinsic will be built with ( rmDynamic, ebStrict ) if user requests fp-model=except or fp-model=noexcept then the ConstrainedIntrinsic will be built with eb

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. In D62731#1620174 , @andrew.w.kaylor wrote: > I'm not entirely caught up on this review. I've only read the most recent > comments, but I think I've got enough context to comment on the metadata > arguments. > > Based only on

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. In D62731#1619908 , @lebedev.ri wrote: > In D62731#1619892 , @mibintc wrote: > > > Compared to the 2nd revision, this patch moves all the changes into clang, > > removing the FPState file.

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. In D62731#1603030 , @kpn wrote: > I actually don't have much of an opinion on what the command line argument > form should be. It may be helpful for it to be the same as one of the > commonly deployed compilers. The worst I

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. In D62731#1601408 , @kpn wrote: > In D62731#1601310 , @mibintc wrote: > > > I think it would be convenient to have an "unset" setting for the different > > constrained modes, otherwise you

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 214003. mibintc edited the summary of this revision. mibintc added a comment. Compared to the 2nd revision, this patch moves all the changes into clang, removing the FPState file. In the summary, I've copied information from Microsoft about the fp-model

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 3 inline comments as done. mibintc added a comment. Thanks for your review >>! In D62731#1601408 , @kpn wrote: > In D62731#1601310 , @mibintc wrote: > >> I think it would be convenient to have an

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

mibintc added a comment. The proposed llvm changes are now part of https://reviews.llvm.org/D62731 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53157/new/ https://reviews.llvm.org/D53157 ___ cfe-commits mailing list

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 211770. mibintc added a comment. Herald added subscribers: hiraditya, mgorny. The IRBuilder now has been taught about constrained fadd and friends. I simply updated my patches to work with the committed revision. Note that this diff now contains what was

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

mibintc added a comment. This works for me, I redid my patches adding fp-model options to work with this newest changeset, (but I haven't yet uploaded them.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53157/new/ https://reviews.llvm.org/D53157

[PATCH] D62730: [RFC] Alternate implementation of D53157 IRBuilder for Constrained FP using enumeration vs MDNode and add support for fp-model and fp-speculation language options

mibintc abandoned this revision. mibintc added a comment. I'm abandoning this patch in deference to @kpn 's patch under review D53157 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62730/new/ https://reviews.llvm.org/D62730

<    1   2   3   4   5   >