[libclc] [llvm] [libclc] Refactor build system to allow in-tree builds (PR #87622)

mgorny wrote: Yeah, things seem to build and install fine for me too, with this patch applied. https://github.com/llvm/llvm-project/pull/87622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

mgorny wrote: Yeah, it built this time for me too. Thanks, again! https://github.com/llvm/llvm-project/pull/87505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

mgorny wrote: Thanks. Unfortunately, I'm still getting a build failure: ``` [1792/1922] cd /tmp/portage/dev-libs/libclc-19.0.0./work/libclc_build && /usr/lib/llvm/17/bin/llvm-spirv --spirv-max-version=1.1 -o spirv-mesa3d-.spv builtins.link.spirv-mesa3d- FAILED: spirv-mesa3d-.spv

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

mgorny wrote: ``` set( spv_suffix ${arch_suffix}.spv ) add_custom_command( OUTPUT "${spv_suffix}" COMMAND ${LLVM_SPIRV} ${spvflags} -o "${spv_suffix}" ${builtins_opt_lib_tgt} DEPENDS ${builtins_link_lib_tgt} ) ``` I think that ought to be `DEPENDS

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

mgorny wrote: Thanks. This seems to fix that problem. However, now I'm seeing missing dep in build ordering: ``` [1793/1922] cd /tmp/portage/dev-libs/libclc-19.0.0./work/libclc_build && /usr/lib/llvm/17/bin/llvm-spirv --spirv-max-version=1.1 -o spirv-mesa3d-.spv

[libclc] [libclc] Fix a couple of issues preventing in-tree builds (PR #87505)

mgorny wrote: This change broke standalone build against LLVM dylib — it now insists on linking to non-existing static libraries: ``` FAILED: prepare_builtins : && /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -march=znver2 --param=l1-cache-size=32 --param=l1-cache-line-size=64 -O2 -pipe

[clang] [clang] [cmake] Add cmake module dir before using GetDarwinLinkerVersion (PR #86386)

https://github.com/mgorny closed https://github.com/llvm/llvm-project/pull/86386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [cmake] Add cmake module dir before using GetDarwinLinkerVersion (PR #86386)

mgorny wrote: Thanks! https://github.com/llvm/llvm-project/pull/86386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [cmake] Add cmake module dir before using GetDarwinLinkerVersion (PR #86386)

https://github.com/mgorny created https://github.com/llvm/llvm-project/pull/86386 Move the code adding top-level cmake/Modules directory to CMAKE_MODULE_PATH prior to including `GetDarwinLinkerVersion`, in order to fix standalone builds. Fixes a regression introduced by

[clang] [flang] [llvm] [Docs] Allow building man pages without myst_parser (PR #82402)

@@ -35,8 +35,16 @@ import sphinx -if sphinx.version_info >= (3, 0): -extensions.append("myst_parser") +# When building man pages, we do not use the markdown pages, +# So, we can continue without the myst_parser dependencies. +# Doing so reduces dependencies of some

[clang] [flang] [llvm] [Docs] Allow building man pages without myst_parser (PR #82402)

https://github.com/mgorny approved this pull request. Thank you. From a quick test run with and without `myst-parser`, this seems to work as intended. https://github.com/llvm/llvm-project/pull/82402 ___ cfe-commits mailing list

[clang] [flang] [llvm] [Docs] Allow building man pages without myst_parser (PR #82402)

https://github.com/mgorny edited https://github.com/llvm/llvm-project/pull/82402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [Documentation] Replace recommonmark by myst-parser (PR #65664)

mgorny wrote: I've adjusted the Gentoo packages, and can live with it. I just find it sad that even though there was an explicit comment on why the `ImportError` fallback was added, it was just removed without a second thought or even an attempt to communicate with me (given `git blame` would

[clang] [flang] [llvm] [Documentation] Replace recommonmark by myst-parser (PR #65664)

mgorny wrote: What used to work is that you could build manpages (that don't use any `.md` files) without installing additional dependencies. Now Sphinx requires myst-parser even when no `.md` files are used. *I* don't really care. However, Gentoo users do tend to complain whenever any single

[clang] [flang] [llvm] [Documentation] Replace recommonmark by myst-parser (PR #65664)

mgorny wrote: I'm sorry for being late to the party but what's the rationale for removing support for building manpages without myst-parser, that FWICS isn't used for manpages at all? I don't see any answer neither in the commit message, nor in this thread. It really feels like you've just

[openmp] [libcxx] [llvm] [compiler-rt] [libcxxabi] [clang] [mlir] [lld] [runtimes] Use LLVM libunwind from libc++abi by default (PR #77687)

mgorny wrote: FTR, this breaks standalone builds against installed LLVM's libunwind since `unwind_shared` target doesn't exist. However, as long as I can pass `-DLIBCXXABI_USE_LLVM_UNWINDER=OFF` that just does the right thing, it's fine with me.

[clang] [Clang] Remove NetBSD/i386 workaround for FP eval method with older versions (PR #74025)

https://github.com/mgorny approved this pull request. Code LGTM but please add a note to the release notes, as was requested. https://github.com/llvm/llvm-project/pull/74025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] 3bff90e - [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp

Author: Michał Górny Date: 2023-03-24T20:25:31+01:00 New Revision: 3bff90e7e84aad6f0fddaf1d17a7db011052b95d URL: https://github.com/llvm/llvm-project/commit/3bff90e7e84aad6f0fddaf1d17a7db011052b95d DIFF: https://github.com/llvm/llvm-project/commit/3bff90e7e84aad6f0fddaf1d17a7db011052b95d.diff

[clang] 0f8b995 - [clang] Fix linking to LLVMTestingAnnotations in standalone build

Author: Michał Górny Date: 2023-01-24T13:21:24+01:00 New Revision: 0f8b995b63620c3eb57610f958f66691d38d7185 URL: https://github.com/llvm/llvm-project/commit/0f8b995b63620c3eb57610f958f66691d38d7185 DIFF: https://github.com/llvm/llvm-project/commit/0f8b995b63620c3eb57610f958f66691d38d7185.diff

[clang] dab67c6 - [clang] [OpenMP] Test amdgcn_openmp_device_math_c.c test on 32-bit platforms

Author: Michał Górny Date: 2022-12-26T10:38:40+01:00 New Revision: dab67c66932b9149842f7c8431e951f952125fc0 URL: https://github.com/llvm/llvm-project/commit/dab67c66932b9149842f7c8431e951f952125fc0 DIFF: https://github.com/llvm/llvm-project/commit/dab67c66932b9149842f7c8431e951f952125fc0.diff

[clang] b3f94fe - [clang][Driver] allow tilde in user config dir

Author: Michał Górny Date: 2022-11-16T13:23:25+01:00 New Revision: b3f94fe1c3c4f4fd7a937288b5543c4067b3e2f2 URL: https://github.com/llvm/llvm-project/commit/b3f94fe1c3c4f4fd7a937288b5543c4067b3e2f2 DIFF: https://github.com/llvm/llvm-project/commit/b3f94fe1c3c4f4fd7a937288b5543c4067b3e2f2.diff

[clang] 20132d8 - Link libclangBasic against libatomic when necessary.

Author: Sam James Date: 2022-11-03T21:07:44+01:00 New Revision: 20132d8eaa68a6c53e152718beda1dc0f4c9ff6c URL: https://github.com/llvm/llvm-project/commit/20132d8eaa68a6c53e152718beda1dc0f4c9ff6c DIFF: https://github.com/llvm/llvm-project/commit/20132d8eaa68a6c53e152718beda1dc0f4c9ff6c.diff

[clang] 9dd01a5 - Harmonize cmake_policy() across standalone builds of all projects

Author: Michał Górny Date: 2022-10-28T08:46:48+02:00 New Revision: 9dd01a5241dc5b46e92485e05bc345221df8938c URL: https://github.com/llvm/llvm-project/commit/9dd01a5241dc5b46e92485e05bc345221df8938c DIFF: https://github.com/llvm/llvm-project/commit/9dd01a5241dc5b46e92485e05bc345221df8938c.diff

[clang] 88d7508 - Harmonize cmake_policy() across standalone builds of all projects

Author: Michał Górny Date: 2022-10-27T13:46:56+02:00 New Revision: 88d7508dc479210f07abccb17f0194b66264b125 URL: https://github.com/llvm/llvm-project/commit/88d7508dc479210f07abccb17f0194b66264b125 DIFF: https://github.com/llvm/llvm-project/commit/88d7508dc479210f07abccb17f0194b66264b125.diff

[clang] d3ce133 - [clang] Do not override libclang.so's SOVERSION if CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

Author: Michał Górny Date: 2022-10-12T07:14:28+02:00 New Revision: d3ce1339264dff3ea5571e9d5cf53d41e49a0879 URL: https://github.com/llvm/llvm-project/commit/d3ce1339264dff3ea5571e9d5cf53d41e49a0879 DIFF: https://github.com/llvm/llvm-project/commit/d3ce1339264dff3ea5571e9d5cf53d41e49a0879.diff

[clang] 2bb86b6 - [clang] Mention -Werror changes revived for Clang 16

Author: Sam James Date: 2022-10-10T21:44:30+02:00 New Revision: 2bb86b67447661077e30674eab7b8a27f8234b3f URL: https://github.com/llvm/llvm-project/commit/2bb86b67447661077e30674eab7b8a27f8234b3f DIFF: https://github.com/llvm/llvm-project/commit/2bb86b67447661077e30674eab7b8a27f8234b3f.diff

[clang-tools-extra] 77945a3 - [clang-tools-extra] [clangd] Respect llvm_shlib_dir in tests

Author: Michał Górny Date: 2022-10-04T22:12:37+02:00 New Revision: 77945a344c3dee3f9735744c8d4151ef2cec6a8d URL: https://github.com/llvm/llvm-project/commit/77945a344c3dee3f9735744c8d4151ef2cec6a8d DIFF: https://github.com/llvm/llvm-project/commit/77945a344c3dee3f9735744c8d4151ef2cec6a8d.diff

[clang-tools-extra] 52ce677 - [clang-tools-extra] [test] Use CLANG_NO_DEFAULT_CONFIG=1

Author: Michał Górny Date: 2022-10-04T20:08:56+02:00 New Revision: 52ce6776cf98e993c6ec04ae54b52e1354fff917 URL: https://github.com/llvm/llvm-project/commit/52ce6776cf98e993c6ec04ae54b52e1354fff917 DIFF: https://github.com/llvm/llvm-project/commit/52ce6776cf98e993c6ec04ae54b52e1354fff917.diff

[clang] 924996e - [clang] [Driver] Disable default configs via envvar during testing

Author: Michał Górny Date: 2022-09-30T09:11:50+02:00 New Revision: 924996e0a011eb833a72d2a2cac9b40fa8a42e34 URL: https://github.com/llvm/llvm-project/commit/924996e0a011eb833a72d2a2cac9b40fa8a42e34 DIFF: https://github.com/llvm/llvm-project/commit/924996e0a011eb833a72d2a2cac9b40fa8a42e34.diff

[clang] 052da73 - [clang] [test] Use --implicit-check-not in config-file3 tests

Author: Michał Górny Date: 2022-09-30T08:02:57+02:00 New Revision: 052da736e51db68202f20155792a692c93897100 URL: https://github.com/llvm/llvm-project/commit/052da736e51db68202f20155792a692c93897100 DIFF: https://github.com/llvm/llvm-project/commit/052da736e51db68202f20155792a692c93897100.diff

[clang] 1609a5d - [clang] [test] Use %clang_cc1 substitution consistently

Author: Michał Górny Date: 2022-09-29T20:59:00+02:00 New Revision: 1609a5d7715c06ff52c13af8b20ee64811a8ec7b URL: https://github.com/llvm/llvm-project/commit/1609a5d7715c06ff52c13af8b20ee64811a8ec7b DIFF: https://github.com/llvm/llvm-project/commit/1609a5d7715c06ff52c13af8b20ee64811a8ec7b.diff

[clang] 74085eb - [llvm] [lit] Move %clang_dxc substitution from clang/test

Author: Michał Górny Date: 2022-09-29T20:59:00+02:00 New Revision: 74085ebfb68e067ba6c21722ac02d2ffbb42a00c URL: https://github.com/llvm/llvm-project/commit/74085ebfb68e067ba6c21722ac02d2ffbb42a00c DIFF: https://github.com/llvm/llvm-project/commit/74085ebfb68e067ba6c21722ac02d2ffbb42a00c.diff

[clang] 063e17d - [clang] [Driver] More flexible rules for loading default configs

Author: Michał Górny Date: 2022-09-29T20:58:59+02:00 New Revision: 063e17d8b04b41cd8bd174aebb6603eb1a76d34a URL: https://github.com/llvm/llvm-project/commit/063e17d8b04b41cd8bd174aebb6603eb1a76d34a DIFF: https://github.com/llvm/llvm-project/commit/063e17d8b04b41cd8bd174aebb6603eb1a76d34a.diff

[clang] 8a774c3 - [clang] [Driver] Support multiple configuration files

Author: Michał Górny Date: 2022-09-21T13:14:36+02:00 New Revision: 8a774c35e9f8c6a200a8f4d00aae909840f5004a URL: https://github.com/llvm/llvm-project/commit/8a774c35e9f8c6a200a8f4d00aae909840f5004a DIFF: https://github.com/llvm/llvm-project/commit/8a774c35e9f8c6a200a8f4d00aae909840f5004a.diff

[clang] 3db2917 - [clang] [docs] Improve formatting & fix typo in config docs

Author: Michał Górny Date: 2022-09-21T07:26:56+02:00 New Revision: 3db2917e270673be281547ec80796dc6f254be82 URL: https://github.com/llvm/llvm-project/commit/3db2917e270673be281547ec80796dc6f254be82 DIFF: https://github.com/llvm/llvm-project/commit/3db2917e270673be281547ec80796dc6f254be82.diff

[clang] a7d2409 - [clang] [Driver] Do not transform explicit --config filename

Author: Michał Górny Date: 2022-09-20T07:58:27+02:00 New Revision: a7d2409bac7fd9ef6b8c362f1ab54a9b6339a69a URL: https://github.com/llvm/llvm-project/commit/a7d2409bac7fd9ef6b8c362f1ab54a9b6339a69a DIFF: https://github.com/llvm/llvm-project/commit/a7d2409bac7fd9ef6b8c362f1ab54a9b6339a69a.diff

[clang] daebf2c - [clang] Make config-related options CoreOptions

Author: Michał Górny Date: 2022-09-19T18:58:09+02:00 New Revision: daebf2c13ce27ac6a7403525cc7fcbc063eb892e URL: https://github.com/llvm/llvm-project/commit/daebf2c13ce27ac6a7403525cc7fcbc063eb892e DIFF: https://github.com/llvm/llvm-project/commit/daebf2c13ce27ac6a7403525cc7fcbc063eb892e.diff

[clang] 587729c - [clang] [Driver] Add an option to disable default config filenames

Author: Michał Górny Date: 2022-09-16T19:38:11+02:00 New Revision: 587729c3ad78aec6ec5a295331b16f21e340feb1 URL: https://github.com/llvm/llvm-project/commit/587729c3ad78aec6ec5a295331b16f21e340feb1 DIFF: https://github.com/llvm/llvm-project/commit/587729c3ad78aec6ec5a295331b16f21e340feb1.diff

[libunwind] 11c2ef5 - unwind: fix typo for __powerpc__

Author: Sam James Date: 2022-01-27T23:21:07+01:00 New Revision: 11c2ef5638c3cff489744f1d342cd92e2a864614 URL: https://github.com/llvm/llvm-project/commit/11c2ef5638c3cff489744f1d342cd92e2a864614 DIFF: https://github.com/llvm/llvm-project/commit/11c2ef5638c3cff489744f1d342cd92e2a864614.diff

[libunwind] cd20e57 - [unwind] fix build with GCC on PPC32

Author: Sam James Date: 2022-01-27T23:05:11+01:00 New Revision: cd20e579df07517a4ddbf6eef58b96d04f6bd9a9 URL: https://github.com/llvm/llvm-project/commit/cd20e579df07517a4ddbf6eef58b96d04f6bd9a9 DIFF: https://github.com/llvm/llvm-project/commit/cd20e579df07517a4ddbf6eef58b96d04f6bd9a9.diff

[clang] fd0b00b - [clang] [unitttests] Fix linking Basic test to LLVMTestingSupport

Author: Michał Górny Date: 2021-12-13T23:00:31+01:00 New Revision: fd0b00b5c60dcee1ac60e6121571e251fb242e63 URL: https://github.com/llvm/llvm-project/commit/fd0b00b5c60dcee1ac60e6121571e251fb242e63 DIFF: https://github.com/llvm/llvm-project/commit/fd0b00b5c60dcee1ac60e6121571e251fb242e63.diff

[clang] d99e946 - [clang] [clang-repl] Fix linking against LLVMLineEditor

Author: Michał Górny Date: 2021-08-05T16:51:47+02:00 New Revision: d99e9461b07988914cba573800cd1862f277e155 URL: https://github.com/llvm/llvm-project/commit/d99e9461b07988914cba573800cd1862f277e155 DIFF: https://github.com/llvm/llvm-project/commit/d99e9461b07988914cba573800cd1862f277e155.diff

[clang] 1862ffe - [clang] Fix a typo in the manual page: s/contraint/constraint.

Author: Frederic Cambus Date: 2021-07-29T20:34:43+02:00 New Revision: 1862ffe25a2e927ecae012f5f0c4cdf7c3fc1b67 URL: https://github.com/llvm/llvm-project/commit/1862ffe25a2e927ecae012f5f0c4cdf7c3fc1b67 DIFF:

[clang] bc96aa9 - [clang] Fix typos in Options.td and regen ClangCommandLineReference.rst.

Author: Frederic Cambus Date: 2021-07-29T20:33:39+02:00 New Revision: bc96aa9f2c9b25ae65a7e05dbbff8c28079db9c9 URL: https://github.com/llvm/llvm-project/commit/bc96aa9f2c9b25ae65a7e05dbbff8c28079db9c9 DIFF:

[clang-tools-extra] 632545e - [clang-tidy] Fix linking tests to LLVMTestingSupport

Author: Michał Górny Date: 2021-01-29T21:54:09+01:00 New Revision: 632545e8ce846ccaeca8df15a3dc5e36d01a1275 URL: https://github.com/llvm/llvm-project/commit/632545e8ce846ccaeca8df15a3dc5e36d01a1275 DIFF: https://github.com/llvm/llvm-project/commit/632545e8ce846ccaeca8df15a3dc5e36d01a1275.diff

[clang] 21c165d - [CMake] Pass bugreport URL to standalone clang build

Author: Michał Górny Date: 2020-08-02T08:32:05+02:00 New Revision: 21c165de2a1bcca9dceb452f637d9e8959fba113 URL: https://github.com/llvm/llvm-project/commit/21c165de2a1bcca9dceb452f637d9e8959fba113 DIFF: https://github.com/llvm/llvm-project/commit/21c165de2a1bcca9dceb452f637d9e8959fba113.diff

[clang-tools-extra] d4f298c - [clang-tools-extra] Prevent linking to duplicate .a libs and dylib

Author: Michał Górny Date: 2020-06-17T19:00:26+02:00 New Revision: d4f298c8206b435ce627b022efa0d5da620019cd URL: https://github.com/llvm/llvm-project/commit/d4f298c8206b435ce627b022efa0d5da620019cd DIFF: https://github.com/llvm/llvm-project/commit/d4f298c8206b435ce627b022efa0d5da620019cd.diff

[clang] cac8cd0 - [clang] [unittest/AST] Fix linking to LLVMTestingSupport

Author: Michał Górny Date: 2020-05-01T21:22:51+02:00 New Revision: cac8cd0a16e9c0410e33aaca93c760c503eeb68e URL: https://github.com/llvm/llvm-project/commit/cac8cd0a16e9c0410e33aaca93c760c503eeb68e DIFF: https://github.com/llvm/llvm-project/commit/cac8cd0a16e9c0410e33aaca93c760c503eeb68e.diff

Re: [PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

On Thu, 2019-12-12 at 14:47 -0800, Eric Christopher wrote: > As a quick note, this broke the test because you didn't update the line > numbers in the checks. > > Fixed thusly: > > echristo@athyra ~/r/llvm-project> git push > To github.com:llvm/llvm-project.git >6bed43f3c40..259a9b10390

Re: [PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

On Wed, 2019-08-07 at 17:10 -0300, Adhemerval Zanella wrote: > On 05/06/2019 05:19, Michał Górny via Phabricator via llvm-commits wrote: > > This revision was automatically updated to reflect the committed changes. > > Closed by commit rL362587: [clang] [test] Add a (xfailing) test for PR41027 >

Re: [PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

On Wed, 2019-08-07 at 17:10 -0300, Adhemerval Zanella wrote: > On 05/06/2019 05:19, Michał Górny via Phabricator via llvm-commits wrote: > > This revision was automatically updated to reflect the committed changes. > > Closed by commit rL362587: [clang] [test] Add a (xfailing) test for PR41027 >

Re: r344241 - [tests] Include Python binding tests in CMake rules

On Tue, 2019-01-15 at 13:10 -0500, Nico Weber wrote: > The tests probably shouldn't run when LLVM_ENABLE_PIC=OFF is set, since > they all fail there (due to lib/libclang.so not existing). Hmm, maybe we could make them conditional to the existence of libclang.so target? Would that work for you?

Re: [PATCH] D55828: [clang] [Driver] Disable -faddrsig by default on NetBSD

On Wed, 2018-12-19 at 21:51 +0100, Joerg Sonnenberger wrote: > On Tue, Dec 18, 2018 at 04:35:54PM +, Michał Górny via Phabricator via > cfe-commits wrote: > > mgorny created this revision. > > mgorny added reviewers: krytarowski, pcc. > > > > Avoid passing -faddrsig by default on NetBSD.

Re: [PATCH] D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds

W dniu pon, 02.10.2017 o godzinie 13∶33 -0700, użytkownik George Karpenkov napisał: > > On Oct 2, 2017, at 12:57 PM, Michał Górny via Phabricator > > wrote: > > > > mgorny added a comment. > > > > In https://reviews.llvm.org/D38444#886138, @george.karpenkov wrote: > >

Re: r294954 - Fix r291495 -- Normalize LLVM_CMAKE_PATH in clang standalone build.

W dniu 16.02.2017, czw o godzinie 08∶17 +, użytkownik NAKAMURA Takumi napisał: > Michał, > > It'd make sense to use file(TO_CMAKE_PATH). I forgot it. > I think get_file_component() satisfies in this case. Do you think to use > file(TO_CMAKE_PATH) anyways? > I'll wait for you as an opinion

Re: r294954 - Fix r291495 -- Normalize LLVM_CMAKE_PATH in clang standalone build.

W dniu 13.02.2017, pon o godzinie 14∶59 +, użytkownik NAKAMURA Takumi via cfe-commits napisał: > Author: chapuni > Date: Mon Feb 13 08:59:53 2017 > New Revision: 294954 > > URL: http://llvm.org/viewvc/llvm-project?rev=294954=rev > Log: > Fix r291495 -- Normalize LLVM_CMAKE_PATH in clang

[PATCH] D23835: [compiler-rt] tsan/tests: Add missing -I for top-level include directory

mgorny abandoned this revision. mgorny added a comment. In https://reviews.llvm.org/D23835#602545, @dvyukov wrote: > What is standalone build? A stand-alone build is a build performed outside LLVM source tree, e.g. out of split checkout, done against installed LLVM. In this case, with

[PATCH] D26900: [cmake] Obtain LLVM_CMAKE_PATH from llvm-config

mgorny created this revision. mgorny added reviewers: beanz, rnk, chapuni, chandlerc. mgorny added a subscriber: cfe-commits. Use the new --cmakedir option to obtain LLVM_CMAKE_PATH straight from llvm-config instead of reconstructing it locally. https://reviews.llvm.org/D26900 Files:

[PATCH] D24933: Enable configuration files in clang

mgorny added a comment. In https://reviews.llvm.org/D24933#600884, @sepavloff wrote: > > Whoever makes the `blah-clang` symlink should get to control what the > > default configuration for `blah-clang` is, I think. > > The patch is changed so that config file for `blah-clang` is searched for >

[PATCH] D25869: [Driver] Add unit tests for Distro detection

mgorny updated this revision to Diff 78625. mgorny added a comment. Added a test for Exherbo. https://reviews.llvm.org/D25869 Files: unittests/Driver/CMakeLists.txt unittests/Driver/DistroTest.cpp Index: unittests/Driver/DistroTest.cpp

[PATCH] D26887: [Driver] Fix finding multilib gcc install on Gentoo (with gcc-config)

mgorny created this revision. mgorny added reviewers: chandlerc, bruno, bkramer. mgorny added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert. Fix the gcc-config code to support multilib gcc installs properly. This solves two problems: -mx32 using the 64-bit gcc directory

[PATCH] D25869: [Driver] Add unit tests for Distro detection

mgorny added a comment. In https://reviews.llvm.org/D25869#56, @bruno wrote: > LGTM! Please add this before https://reviews.llvm.org/D26850, which should > contain a testcase on top of this! I should probably also copy here that as I've mentioned on https://reviews.llvm.org/D26850, this

[PATCH] D25869: [Driver] Add unit tests for Distro detection

mgorny updated this revision to Diff 78506. mgorny added a comment. Added tests for SUSE and Arch Linux (and found a bug for the former, https://reviews.llvm.org/D26850). https://reviews.llvm.org/D25869 Files: unittests/Driver/CMakeLists.txt unittests/Driver/DistroTest.cpp Index:

[PATCH] D25869: [Driver] Add unit tests for Distro detection

mgorny retitled this revision from "[Driver] Add unit tests for DetectDistro()" to "[Driver] Add unit tests for Distro detection". mgorny updated the summary for this revision. mgorny updated this revision to Diff 78494. mgorny added a comment. Ok, here are the tests updated for the new API.

[PATCH] D25949: [Driver] Refactor distro detection & classification as a separate API

mgorny updated this revision to Diff 78462. mgorny added a comment. Thanks for the review. I've rebased on top of current master (UbuntuZesty added), and now I will update the unit tests. https://reviews.llvm.org/D25949 Files: include/clang/Driver/Distro.h lib/Driver/CMakeLists.txt

[PATCH] D26763: [compiler-rt] [asan] Use __SSE2__ (rather than __i686__...) for SSE2 test

This revision was automatically updated to reflect the committed changes. Closed by commit rL287245: [tests] Use __SSE2__ (rather than __i686__...) for SSE2 ASAN test (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D26763?vs=78245=78391#toc Repository: rL LLVM

[PATCH] D26763: [compiler-rt] [asan] Use __SSE2__ (rather than __i686__...) for SSE2 test

mgorny added a comment. I did, even twice ;-). Thanks. https://reviews.llvm.org/D26763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux)

mgorny updated this revision to Diff 78378. mgorny marked 2 inline comments as done. mgorny added a comment. Updated the -print-libgcc-file-name test name. Additionally, I've added another subvariant of that test using i686-* target to ensure that the mapping works for that function too, in

[PATCH] D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux)

mgorny added inline comments. Comment at: test/Driver/print-libgcc-file-name-clangrt.c:11 // RUN: | FileCheck --check-prefix=CHECK-CLANGRT-I686 %s -// CHECK-CLANGRT-I686: libclang_rt.builtins-i686.a +// CHECK-CLANGRT-I686: libclang_rt.builtins-i386.a jroelofs

[PATCH] D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux)

mgorny updated this revision to Diff 78370. mgorny added a comment. Updated expected output for existing tests and added an additional test to linux-ld.c. https://reviews.llvm.org/D26796 Files: lib/Driver/ToolChain.cpp test/Driver/Inputs/basic_linux_tree/usr/i686-unknown-linux/lib/.keep

[PATCH] D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux)

mgorny created this revision. mgorny added reviewers: rsmith, compnerd, pcc, rengolin. mgorny added a subscriber: cfe-commits. Herald added a subscriber: dberris. Use llvm::Triple::getArchTypeName() when looking for compiler-rt libraries, rather than the exact arch string from the triple. This is

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

mgorny created this revision. mgorny added reviewers: samsonov, etienneb, beanz. mgorny added a subscriber: cfe-commits. Herald added subscribers: dberris, kubabrecka. Remove the explicit i686 target that is completely duplicate to the i386 target, with the latter being used more commonly. 1.

[PATCH] D26763: [compiler-rt] [asan] Use __SSE2__ (rather than __i686__...) for SSE2 test

mgorny created this revision. mgorny added a reviewer: kcc. mgorny added a subscriber: cfe-commits. Herald added subscribers: dberris, kubabrecka. Use the __SSE2__ to determine whether SSE2 is enabled in the ASAN tests rather than relying on either of the __i686__ and __x86_64__. The former is

[PATCH] D26115: [test] Correctly include build llvm_shlib_dir in stand-alone builds

This revision was automatically updated to reflect the committed changes. Closed by commit rL286952: [test] Correctly include build llvm_shlib_dir in stand-alone builds (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D26115?vs=76296=77982#toc Repository: rL LLVM

[PATCH] D26115: [test] Correctly include build llvm_shlib_dir in stand-alone builds

mgorny added inline comments. Comment at: test/lit.cfg:109 +if not llvm_shlib_dir: +lit_config.fatal('No LLVM shlib dir set!') llvm_libs_dir = getattr(config, 'llvm_libs_dir', None) beanz wrote: > Should this really be fatal? It seems to me in

[PATCH] D26115: [test] Correctly include build llvm_shlib_dir in stand-alone builds

mgorny added a comment. Ping. https://reviews.llvm.org/D26115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25949: [Driver] Refactor distro detection & classification as a separate API

mgorny added reviewers: rnk, hfinkel. mgorny added a comment. Ping. https://reviews.llvm.org/D25949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25686: [Driver] Support "hardfloat" vendor triples used by Gentoo

mgorny added a comment. Ping. https://reviews.llvm.org/D25686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25314: [libcxxabi] [cmake] Handle missing LIBUNWIND_* directories gracefully

mgorny added reviewers: phosek, mclow.lists. mgorny added a comment. Ping. https://reviews.llvm.org/D25314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24921: [cfe] [Headers] Fix inttypes.h macros visibility in C++ with C99-compliant libc

mgorny added reviewers: ddunbar, thakis. mgorny added a comment. Ping. https://reviews.llvm.org/D24921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24933: Enable configuration files in clang

mgorny added a comment. @sepavloff, my suggestion would be to rework the patch to the minimal, acceptable feature (i.e. executable-relative config), and then possibly send more patches for the additional features that require additional discussion. This way, we'll at least get something done

Re: [PATCH] Warning for main returning a bool.

On Fri, 14 Oct 2016 17:17:59 + Joshua Hurwitz via cfe-commits wrote: > See attached. > > Returning a bool from main is a special case of return type mismatch. The > common convention when returning a bool is that 'true' (== 1) indicates > success and 'false' (==

[PATCH] D24933: Enable configuration files in clang

mgorny added a comment. I don't agree with the argumentation of @hans; however, I have my own concerns. I personally dislike the idea of reusing command-line option format for this. While I can see this is the simplest solution, it brings at least a few problems and questions. I'm afraid that

[PATCH] D26082: Support for Python 3 in libclang python bindings

mgorny added a comment. A few comments/questions. However, please note that those are generic Python comments and I haven't used or tested the clang Python API yet. Comment at: bindings/python/clang/cindex.py:77 +# Python 3 strings are unicode, translate them to/from utf8 for

[PATCH] D24869: [cfe] [test] Fix detecting LLVM zlib support in stand-alone builds

This revision was automatically updated to reflect the committed changes. Closed by commit rL285741: [test] Fix detecting LLVM zlib support in stand-alone builds (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D24869?vs=72258=76625#toc Repository: rL LLVM

[PATCH] D26175: [Driver] Fall back to plain '-plugin LLVMgold.so' if no lib at std path

mgorny created this revision. mgorny added reviewers: rafael, beanz, chandlerc. mgorny added a subscriber: cfe-commits. Herald added subscribers: mehdi_amini, srhines, danalbert, tberghammer. Add a fallback to using plain '-plugin LLVMgold.so' when the plugin does not exist at the standard path.

[PATCH] D24869: [cfe] [test] Fix detecting LLVM zlib support in stand-alone builds

mgorny added a comment. Non-gentle ping? https://reviews.llvm.org/D24869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26115: [test] Correctly include build llvm_shlib_dir in stand-alone builds

mgorny created this revision. mgorny added reviewers: ddunbar, beanz. mgorny added a subscriber: cfe-commits. Add the build llvm_shlib_dir into LD_LIBRARY_PATH before the directory specified as llvm_libs_dir, in order to fix stand-alone builds attempting to use installed clang libraries. In case

[PATCH] D25008: [cmake] Split linked libraries into private & public, for linker script

mgorny added a comment. In https://reviews.llvm.org/D25008#581889, @Hahnfeld wrote: > What are the possibilities to proceed here? To be honest, I don't have any good idea besides renaming the library. Keeping two non-interchangeable libraries under the same name is bound to fail.

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

mgorny abandoned this revision. mgorny added a comment. Very well. I'll look into (ab)using the existing options to achieve the same result. Having stand-alone build systems, this should become easier these days, at least until some major change in runtime handling occurs.

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

mgorny added a comment. This really doesn't solve the problems we have. We don't want to build and install two almost-identical copies of compiler-rt and clang headers, when we can just build one and make clang use it. https://reviews.llvm.org/D23752

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

mgorny added a comment. In https://reviews.llvm.org/D23752#581416, @chandlerc wrote: > I don't get it. > > There is nothing "RUNTIMES" about it. And this variable is actually used to > produce real libraries: libclang, etc. > > It's just the LIBDIR_SUFFIX. That's it. The reason it is called >

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

mgorny added inline comments. Comment at: lib/Driver/Tools.cpp:2021 std::string Plugin = - ToolChain.getDriver().Dir + "/../lib" CLANG_LIBDIR_SUFFIX "/LLVMgold.so"; + ToolChain.getDriver().Dir + "/../lib" LLVM_RUNTIMES_LIBDIR_SUFFIX "/LLVMgold.so";

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

mgorny retitled this revision from "cmake: Supporting overriding runtime libdir via CLANG_LIBDIR_SUFFIX" to "[cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX". mgorny updated the summary for this revision. mgorny updated this revision to Diff 75996. mgorny added a comment. Here's the initial patch

[PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

mgorny abandoned this revision. mgorny added a comment. Works for me. I don't know if this even has a valid failure case, just felt uneasy about having the obviously-wrong path in code. https://reviews.llvm.org/D23754 ___ cfe-commits mailing list

[PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

mgorny added a comment. In https://reviews.llvm.org/D23754#580620, @chandlerc wrote: > I'm not sure it really makes sense for the Clang driver to go hunting for an > LLVMgold.so from an unrelated build of Clang and LLVM. > > The Clang driver is going to run a particular CC1 invocation, ask it

[PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

mgorny added a comment. In https://reviews.llvm.org/D23754#580441, @chandlerc wrote: > In https://reviews.llvm.org/D23754#580277, @mgorny wrote: > > > The difference is that LLVMgold.so is not used by LLVM or clang directly > > but by the system binutils, and so it must match the ABI of the

[PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

mgorny added a comment. In https://reviews.llvm.org/D23754#580268, @beanz wrote: > @mgorny, I don't think LLVMgold qualifies as a runtime in the traditional > sense. It more closely aligns with the tools vended by LLVM even though it is > a shared library not an executable. > > Runtime

[PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

mgorny added a reviewer: beanz. mgorny added a subscriber: beanz. mgorny added a comment. @beanz, could you also look at this one? I'd like to replace CLANG_LIBDIR_SUFFIX with the runtimes suffix, and for this I'd have to get rid of this CLANG_LIBDIR_SUFFIX occurrence as well. However, I don't

[PATCH] D25949: [Driver] Refactor distro detection & classification as a separate API

mgorny created this revision. mgorny added reviewers: bruno, bkramer. mgorny added a subscriber: cfe-commits. Herald added subscribers: modocache, beanz. Refactor the Distro enum along with helper functions into a full-fledged Distro class, inspired by llvm::Triple, and make it a public API. The

  1   2   3   >