Re: [PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

On Thu, 2020-06-04 at 13:06 +0300, Kadir Çetinkaya wrote: > Hi Mikael, > > sent out 4f4a8ae72e95f2c7fa5e4ca56dd6b1a83a304680, please let me know > if it helps! Hi, Yes, now it's silent. Thank you! /Mikael > > On Thu, Jun 4, 2020 at 12:40 PM Mikael Holmén via Phabricator < >

Re: [clang] 2214b90 - [clangd] Make signatureHelp work with stale preambles

On Thu, 2020-04-23 at 17:46 +0300, Kadir Çetinkaya wrote: > Thanks Mikael, sent out an ugly fix > at 89cb5d558895706e053bc3af972aa5b15aa82863 to get sanitizer build > bots running. > Nice, thanks! Now our buildbots went silent again. /Mikael > Will change the testing scheme for a proper fix. >

Re: [clang] 2214b90 - [clangd] Make signatureHelp work with stale preambles

Hi Kadir, I start seeing some sanitizer complaints with this commit for the following two testcases: ./ClangdTests/PreamblePatchTest.ContainsNewIncludes ./ClangdTests/PreamblePatchTest.IncludeParsing The complaints look like this:

Re: [clang-tools-extra] dffa9df - [clangd] Shard preamble symbols in dynamic index

On Fri, 2020-04-17 at 15:02 +0300, Kadir Çetinkaya wrote: > Thanks Mikael, > > 66b54d586fa73499714e2bfef3cedffeabb08f34 should fix this. > Yep, now it runs without complaints. Thanks! /Mikael > On Fri, Apr 17, 2020 at 2:42 PM Mikael Holmén < > mikael.hol...@ericsson.com> wrote: > > Hi Kadir,

Re: [clang-tools-extra] dffa9df - [clangd] Shard preamble symbols in dynamic index

Hi Kadir, I noticed in our buildbots that run with sanitizers that we got a new complaint with this commit. It's still there on current top-of-tree now so the fixes you pushed after this patch doesn't seem to address this one: ==89727==ERROR: LeakSanitizer: detected memory leaks Direct leak of

Re: [clang] a8c8b62 - [ObjC generics] Fix not inheriting type bounds in categories/extensions.

We see flakiness in the test in our bots too. Fails one time and then passes again. /Mikael On Mon, 2020-04-06 at 21:03 -0400, Nico Weber via cfe-commits wrote: > This isn't bot-dependent, it's been flaking on many different bots > over the last few days. Here's one from just now: >

Re: [clang] ec3060c - [AST] Refactor propagation of dependency bits. NFC

Hi Hokein, Ilya, Clang warns on this code when compiled without asserts: ../../clang/lib/AST/TemplateName.cpp:189:3: error: unannotated fall- through between switch labels [-Werror,-Wimplicit-fallthrough] default: ^ ../../clang/lib/AST/TemplateName.cpp:189:3: note: insert 'break;' to avoid

Re: r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

i, >> >> As Karl-Johan said I'll be out of office for a few days so please submit a >> fix if you can find the time. >> >> Thanks, >> Mikael >> >> Den 26 sep. 2019 15:39 skrev Hans Wennborg : >> >> On Thu, Sep 26, 2019 at 12:55 PM Mikael

Re: r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

Hi, As Karl-Johan said I'll be out of office for a few days so please submit a fix if you can find the time. Thanks, Mikael Den 26 sep. 2019 15:39 skrev Hans Wennborg : On Thu, Sep 26, 2019 at 12:55 PM Mikael Holmén via cfe-commits wrote: > > Hi Hans, > > I'm a bit suspicious agai

Re: r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

Hi Hans, I'm a bit suspicious against the part > This also revertes the part of r369938 which checked that -working-directory works. in this revert. You do: > + SmallString<128> Buf; > + if (!llvm::sys::fs::current_path(Buf)) > +Buf = "."; > + CDB << "{ \"directory\": \"" <<

Re: r372919 - [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

Fixed the testcase in r372944. On 2019-09-26 08:14, Mikael Holmén via cfe-commits wrote: > Hi, > > On 2019-09-26 03:16, Evgenii Stepanov via cfe-commits wrote: >> Hi, >> >> this change breaks the build with >> >> /var/lib/buildbot/sanitizer-buildbot6/sa

Re: r372919 - [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

Hi, On 2019-09-26 03:16, Evgenii Stepanov via cfe-commits wrote: > Hi, > > this change breaks the build with > > /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/clang/lib/Format/Format.cpp:737:44: > error: missing field 'SortPriority' initializer >

Re: [clang-tools-extra] r372693 - [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

Hi Adam, Is InfiniteLoopCheck.cpp missing? I get CMake Error at /data/repo/master/llvm/cmake/modules/AddLLVM.cmake:443 (add_library): Cannot find source file: InfiniteLoopCheck.cpp /Mikael On Tue, 2019-09-24 at 07:43 +, Adam Balogh via cfe-commits wrote: > Author:

Re: r365954 - Reland [clang] DirectoryWatcher

Hi, On 2019-07-15 20:26, Jan Korous wrote: > Hi Mikael, > > Thanks for the notice. > > How about this? > https://reviews.llvm.org/D64764 > Yes that works for me! Thanks! Mikael > Jan > >> On Jul 14, 2019, at 11:45 PM, Mikael Holmén >> mailto:mikael.hol...@ericsson.com>> wrote: >> >> Hi

Re: r365954 - Reland [clang] DirectoryWatcher

Hi Jan, > +elseif(CMAKE_SYSTEM_NAME MATCHES "Linux") > + check_include_files("sys/inotify.h" HAVE_INOTIFY) > + if(HAVE_INOTIFY) > +list(APPEND DIRECTORY_WATCHER_SOURCES linux/DirectoryWatcher-linux.cpp) > +find_package(Threads REQUIRED) > + endif() I don't think the above is

Re: r353729 - Attempt to pacify bots more after r353718 and r353725

PAssed on our bots too. Thanks! /Mikael On 2/13/19 10:03 PM, Galina Kistanova wrote: > Passed on llvm-clang-x86_64-expensive-checks-win and > llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast. > > http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/15787 >

Re: r353729 - Attempt to pacify bots more after r353718 and r353725

On 2/12/19 1:41 PM, Nico Weber wrote: > Thanks for reporting that this depends on the host compiler. > > I disabled the test again in r353836 and will look into why the output > is different depending on if host cc is gcc or clang. > Good. Thanks! When I've seen things like this before it's

Re: r353729 - Attempt to pacify bots more after r353718 and r353725

Same thing for me with our downstream build bots. When we compile clang with gcc 7.4 and then run the testcase I get this output define dso_local i64 @test__shiftleft128(i64 %l, i64 %h, i8 %d) local_unnamed_addr #0 { entry: %0 = zext i64 %l to i128 %1 = zext i64 %h to i128 %2 = shl

Re: [clang-tools-extra] r352494 - [clangd] Interfaces for writing code tweaks

On 1/30/19 10:41 AM, Ilya Biryukov wrote: > Should be fixed by r352612, let me know if it pops up again. > This was a use after move, probably gcc and clang prefer different > evaluation order, hence the difference in behaviours. Awesome! Now it passes also when I compile with gcc. Thanks,

Re: [clang-tools-extra] r352494 - [clangd] Interfaces for writing code tweaks

Hi Ilya, I've no idea why, but when I compile this commit with gcc (7.4.0) the test fixits-command.test fails, and the output from clangd is rather different from when I compile it with clang (3.6.0). So I run build-all/bin/clangd -lit-test <

Re: r348276 - [AST][NFC] Make ArrayTypeTraitExpr non polymorphic

On 12/12/18 2:17 PM, Bruno Ricci wrote: > > > On 12/12/2018 07:27, Mikael Holmén wrote: >> Hi, >> >> On 12/11/18 5:49 PM, Bruno Ricci wrote: >>> Hi Mikael, >>> >>> I can indeed reproduce this with gcc 5.5.0 when doing a Release >>> build with assertions. I cannot reproduce this with gcc 6.5.0

Re: r348276 - [AST][NFC] Make ArrayTypeTraitExpr non polymorphic

Hi, On 12/11/18 5:49 PM, Bruno Ricci wrote: > Hi Mikael, > > I can indeed reproduce this with gcc 5.5.0 when doing a Release > build with assertions. I cannot reproduce this with gcc 6.5.0 > (also with a Release build with assertions), nor can I reproduce > this with clang 7 (also with a Release

Re: r348276 - [AST][NFC] Make ArrayTypeTraitExpr non polymorphic

Hi Bruno, I've no idea if this is really related to your change, but with this commit, the following starts crashing: clang-tidy -allow-enabling-analyzer-alpha-checkers -checks='-*,clang-analyzer-*' ./reduced.c -- It seems like it recurses forever for some reason, and then we run out of

Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

-and-standard-library suggests that even clang 3.1 should work. /Mikael > > Thanks. > > Jan > >> On Nov 28, 2018, at 8:59 AM, Yvan Roux > <mailto:yvan.r...@linaro.org>> wrote: >> >> On Wed, 28 Nov 2018 at 09:56, Mikael Holmén via cfe-co

Re: r345099 - [analyzer] Trust summaries for OSObject::retain and OSObject::release

l.hol...@ericsson.com>> wrote: >> >> Hi again, >> >> Do you have any opinion about the below valgrind complaint that starts >> appearing with this patch? >> >> valgrind still complains on it on current trunk. >> >> I see it when compiling with

Re: [clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

Hi Jan, This code doesn't compile with clang 3.6.0: ../tools/clang/tools/extra/clangd/Protocol.cpp:456:10: error: no viable conversion from 'json::Object' to 'llvm::json::Value' return result; ^~ ../include/llvm/Support/JSON.h:291:3: note: candidate constructor not viable: no

Re: [clang-tools-extra] r347498 - [clangd] Add support for hierarchical documentSymbol

On 11/26/18 12:41 PM, Ilya Biryukov wrote: > Sorry about that, should be fixed in r347539. > Yep, thanks! /Mikael > On Mon, Nov 26, 2018 at 8:10 AM Mikael Holmén > mailto:mikael.hol...@ericsson.com>> wrote: > > Hi Ilya, > > This patch doesn't compile for me with clang 3.6.0. I

Re: r345099 - [analyzer] Trust summaries for OSObject::retain and OSObject::release

, Mikael Holmén via cfe-commits wrote: > Hi George, > > I noticed that valgrind started complaining in one case with this patch. > > I've no idea if it's really due to something in the patch or if it's > something old that surfaced or if it's a false flag. > > Anyway, with

Re: [clang-tools-extra] r347498 - [clangd] Add support for hierarchical documentSymbol

Hi Ilya, This patch doesn't compile for me with clang 3.6.0. I get: ../tools/clang/tools/extra/clangd/Protocol.cpp:474:10: error: no viable conversion from 'json::Object' to 'llvm::json::Value' return Result; ^~ ../include/llvm/Support/JSON.h:291:3: note: candidate constructor

Re: r345099 - [analyzer] Trust summaries for OSObject::retain and OSObject::release

Hi George, I noticed that valgrind started complaining in one case with this patch. I've no idea if it's really due to something in the patch or if it's something old that surfaced or if it's a false flag. Anyway, with this patch the following valgrind clang-tidy

Re: [PATCH] D53651: [clangd] Use thread pool for background indexing.

On 11/7/18 11:31 AM, Sam McCall wrote: > I'll send a patch shortly to unbreak this. > > Is emitting a warning a problem for you? (i.e. do you build with -Werror) Yes "unfortunately" we use -Werror. > I'd like to do something like #ifdef SCHED_IDLE ... #else #warning "old > libc?" #endif >

Re: [PATCH] D53651: [clangd] Use thread pool for background indexing.

Hi, On 11/7/18 11:03 AM, Sam McCall wrote: > On Wed, Nov 7, 2018 at 10:32 AM Mikael Holmén via Phabricator > mailto:revi...@reviews.llvm.org>> wrote: > > uabelho added a comment. > > Hi, > > I've got a post-review comment about the use of SCHED_IDLE vs the > needed gcc

Re: [clang-tools-extra] r344650 - [clang-doc] Add unit tests for serialization

On 10/17/2018 08:30 PM, Julie Hockett wrote: > https://reviews.llvm.org/D53381 should fix this -- thanks for the note! Yep, thanks! /Mikael > > Julie > > On Wed, Oct 17, 2018 at 1:58 AM Mikael Holmén > mailto:mikael.hol...@ericsson.com>> wrote: > > Hi Julie, > > clang 3.6.0

Re: [clang-tools-extra] r344650 - [clang-doc] Add unit tests for serialization

Hi Julie, clang 3.6.0 complains on this commit: /usr/bin/clang++ -march=corei7 -DGTEST_HAS_RTTI=0 -DGTEST_HAS_TR1_TUPLE=0 -DGTEST_LANG_CXX11=1 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/tools/extra/unittests/clang-doc

Re: [clang-tools-extra] r343848 - [clang-tidy] Replace deprecated std::ios_base aliases

Hi Jonas, Bence, On 10/08/2018 08:22 AM, Mikael Holmén via cfe-commits wrote: > Hi Jonas, > > I get the follwing warning/error when compiling this commit with clang 3.6: > > ../tools/clang/tools/extra/clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.cpp:21:5: > error: sug

Re: [clang-tools-extra] r343848 - [clang-tidy] Replace deprecated std::ios_base aliases

Hi Jonas, I get the follwing warning/error when compiling this commit with clang 3.6: ../tools/clang/tools/extra/clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.cpp:21:5: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] "::std::ios_base::io_state",

Re: [clang-tools-extra] r343576 - [clangd] Cache FS stat() calls when building preamble.

Hi Eric, I fixed a compilation warning introduced with this patch in r343661. Regards, Mikael On 10/02/2018 12:43 PM, Eric Liu via cfe-commits wrote: Author: ioeric Date: Tue Oct 2 03:43:55 2018 New Revision: 343576 URL: http://llvm.org/viewvc/llvm-project?rev=343576=rev Log: [clangd] Cache

Re: [clang-tools-extra] r341375 - [clangd] Define a compact binary serialization fomat for symbol slab/index.

On 09/05/2018 03:26 PM, Sam McCall wrote: Ah, thanks! Fixed in r341467. I'd guess this was a GCC bug, because GCC >=6 accepts it: https://godbolt.org/z/Yb5gBT Yep works now. Thanks! /Mikael On Wed, Sep 5, 2018 at 2:21 PM Mikael Holmén > wrote:

Re: [clang-tools-extra] r341375 - [clangd] Define a compact binary serialization fomat for symbol slab/index.

On 09/05/2018 12:41 PM, Sam McCall wrote: Thanks. Unclear to me whether it's the enum class or the anonymous namespace that's triggering this (I believe) compiler bug, but r341459 may help... Still doesn't work. In file included from

Re: [clang-tools-extra] r341375 - [clangd] Define a compact binary serialization fomat for symbol slab/index.

On 09/05/2018 09:56 AM, Sam McCall wrote: Sorry! r341451 should fix this, will keep an eye on the buildbots. Now it compiles with clang 3.6.0 but with gcc 5.4.0 it fails with /proj/bbi_twh/wh_bbi/x86_64-Linux2/bbigcc/1.5.4.0/crosscompiler/bin/g++

Re: [clang-tools-extra] r341375 - [clangd] Define a compact binary serialization fomat for symbol slab/index.

Hi Sam, This doesn't compile for me. Both clang 3.6.0 and gcc 5.4.0 complain: [1/6] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/clangDaemon.dir/index/Serialization.cpp.o FAILED: tools/clang/tools/extra/clangd/CMakeFiles/clangDaemon.dir/index/Serialization.cpp.o

Re: [clang-tools-extra] r336318 - [clangd] Treat class constructor as in the same scope as the class in ranking.

Ah, already fixed in r336329 I see. On 07/05/2018 12:56 PM, Mikael Holmén via cfe-commits wrote: Hi Eric, I get the following with this patch: /proj/flexasic/app/clang/3.6/bin/clang++  -march=corei7 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS

Re: [clang-tools-extra] r336318 - [clangd] Treat class constructor as in the same scope as the class in ranking.

Hi Eric, I get the following with this patch: /proj/flexasic/app/clang/3.6/bin/clang++ -march=corei7 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/tools/extra/clangd -I../tools/clang/tools/extra/clangd

Re: r335740 - [analyzer] Allow registering custom statically-linked analyzer checkers

Hi, I get the same compilation error when I compile with clang 3.6.0. Revert? Regards, Mikael On 06/28/2018 03:16 AM, via cfe-commits wrote: Hi, this commit also broke our internal bot for a different reason: FAILED: /usr/lib/ccache/clang++   -DGTEST_HAS_RTTI=0 -DGTEST_HAS_TR1_TUPLE=0

Re: r334935 - [analyzer] Checker for uninitialized C++ objects

Hi Kristof, Building without asserts (-DNDEBUG) I get the following warning/error with this commit: [3082/3387] Building CXX object tools/clang/lib/StaticAnalyzer/Checkers...eFiles/clangStaticAnalyzerCheckers.dir/UninitializedObjectChecker.cpp. FAILED:

Re: [clang-tools-extra] r330245 - [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file.

Thanks! On 04/19/2018 03:39 PM, Haojian Wu wrote: Thanks! I didn't see this warning when running check-clang-tools on my machine. Fixed in r330327. On Thu, Apr 19, 2018 at 7:39 AM, Mikael Holmén > wrote: Hi, On

Re: [clang-tools-extra] r330245 - [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file.

Hi, On 04/18/2018 10:54 AM, Haojian Wu via cfe-commits wrote: Author: hokein Date: Wed Apr 18 01:54:28 2018 New Revision: 330245 URL: http://llvm.org/viewvc/llvm-project?rev=330245=rev Log: [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file. Summary: Fix

Re: r329780 - [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option)

Hi Adam and Artem, If I run clang-tidy -header-filter=.\*

Re: [clang-tools-extra] r329448 - [clang-tidy] Check if grand-..parent's virtual method was called instead of overridden parent's.

Hi Zivony, From this patch: > +void ParentVirtualCallCheck::check(const MatchFinder::MatchResult ) { > + const auto *MatchedDecl = Result.Nodes.getNodeAs("call"); > + assert(MatchedDecl); > + The code above yields a warning when compiled without asserts since MatchedDecl is not used

Re: [clang-tools-extra] r328270 - [clang-doc] Reland "[clang-doc] Setup clang-doc frontend framework"

Hi Julie If I compile without asserts this patch gives me ../tools/clang/tools/extra/clang-doc/BitcodeWriter.cpp:260:15: error: unused variable 'BlockIdName' [-Werror,-Wunused-variable] const auto = BlockIdNameMap[BID]; ^ 1 error generated. Regards, Mikael On 03/23/2018

Re: r327345 - [analyzer] Destroy and lifetime-extend inlined function return values properly.

Hi Artem, This commit gives the following warning: ../tools/clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:283:23: error: unused variable 'RCC' [-Werror,-Wunused-variable] if (const auto *RCC = dyn_cast(CC)) { ^ 1 error generated. Regards, Mikael On 03/13/2018

Re: [clang-tools-extra] r320486 - [clangd] Introduce a "Symbol" class.

On 12/13/2017 02:09 AM, Evgenii Stepanov via cfe-commits wrote: Hi, this does not compile for me because of a tag mismatch: clang-tools-extra/clangd/index/Index.h:52:10: error: class 'DenseMapInfo' was previously declared as a struct [-Werror,-Wmismatched-tags] friend class

Re: r304852 - Improve error recovery for missing 'template' keyword in contexts where the

Hi Richard, See below. On 06/07/2017 02:29 AM, Richard Smith via cfe-commits wrote: Author: rsmith Date: Tue Jun 6 19:29:44 2017 New Revision: 304852 URL: http://llvm.org/viewvc/llvm-project?rev=304852=rev Log: Improve error recovery for missing 'template' keyword in contexts where the

Re: r302572 - Suppress all uses of LLVM_END_WITH_NULL. NFC.

On 05/10/2017 09:37 AM, Mikael Holmén via cfe-commits wrote: Hi, This commit gives a warning with clang 3.6: In file included from ../tools/clang/lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp:17: ../tools/clang/lib/StaticAnalyzer/Checkers/SelectorExtras.h:23:40: error: braces

Re: r302572 - Suppress all uses of LLVM_END_WITH_NULL. NFC.

Hi, This commit gives a warning with clang 3.6: In file included from ../tools/clang/lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp:17: ../tools/clang/lib/StaticAnalyzer/Checkers/SelectorExtras.h:23:40: error: braces around scalar initializer [-Werror] SmallVector

Re: r295114 - Improve diagnostic reporting when using __declspec without enabling __declspec as a keyword.

Hi, Saw now that it's already been fixed. Sorry for the spam :/ Regards, Mikael On 02/15/2017 07:39 AM, Mikael Holmén wrote: Hi Aaron, On 02/14/2017 11:47 PM, Aaron Ballman via cfe-commits wrote: Author: aaronballman Date: Tue Feb 14 16:47:20 2017 New Revision: 295114 URL:

Re: r295114 - Improve diagnostic reporting when using __declspec without enabling __declspec as a keyword.

Hi Aaron, On 02/14/2017 11:47 PM, Aaron Ballman via cfe-commits wrote: Author: aaronballman Date: Tue Feb 14 16:47:20 2017 New Revision: 295114 URL: http://llvm.org/viewvc/llvm-project?rev=295114=rev Log: Improve diagnostic reporting when using __declspec without enabling __declspec as a

Re: r292562 - clang-format: fix fallback style set to "none" not always formatting

Hi, On 01/20/2017 02:20 PM, Antonio Maiorano wrote: Hi Mikael, Just to be sure, did you build clang-format before running this test? Yes I did. I compiled a clean trunk, ran the test, got the failure. Possibly related, one of the tests I added was just removed for being redundant:

Re: r292562 - clang-format: fix fallback style set to "none" not always formatting

Hi Antonio, The test case Clang :: Format/style-on-command-line.cpp fails for me since this commit. test/Format/style-on-command-line.cpp:40:13: error: expected string not found in input // CHECK10: {{^int\* i;$}} ^ :1:1: note: scanning from here // RUN: clang-format

Re: r281785 - CodeGen: Add more checks to nobuiltin.c test, add a negative test.

Hi, On 09/17/2016 12:05 AM, Peter Collingbourne via cfe-commits wrote: Author: pcc Date: Fri Sep 16 17:05:53 2016 New Revision: 281785 URL: http://llvm.org/viewvc/llvm-project?rev=281785=rev Log: CodeGen: Add more checks to nobuiltin.c test, add a negative test. Modified:

Re: r275368 - Add C++ dependencies to xray runtime

On 07/14/2016 02:10 PM, Dean Michael Berris wrote: Thanks Mikael -- this has been fixed in r275377 (http://reviews.llvm.org/rL275377). Yes, now it compiled. Thank you! /Mikael On Thu, Jul 14, 2016 at 7:30 PM Mikael Holmén >

Re: r275368 - Add C++ dependencies to xray runtime

Hi, Your commit Add C++ dependencies to xray runtime Doesn't compile with gcc. At least 5.3 and 4.8.4 complains about this change: + if (Args.hasArg(options::OPT_fxray_instrument, + options::OPT_fnoxray_instrument, false)) { +CmdArgs.push_back("-fxray-instrument");