[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov added a comment. @aeubanks Thank you very much for the re-landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128830/new/ https://reviews.llvm.org/D128830 ___ cfe-commits mailing list

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

This revision was automatically updated to reflect the committed changes. Closed by commit rGb10a341aa5b0: [Pipelines] Introduce DAE after ArgumentPromotion (authored by psamolysov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128830/new/

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov added a comment. @aeubanks Thank you for the investigation! I believe this patch can be re-landed after D132764 is committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128830/new/

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov added a comment. No problem, I've reverted the commit while I need some time to build `clang` with the reverted commit even for make it clear the commit is guilty. I'm sorry. It's very interesting, in @mstorsjo case, a function from the standard `C` library is used: `strtof`. When I

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov added a comment. @mstorsjo Thank you very much for the information. Unfortunately, our tests didn't catch this problem. I've reproduced this on Windows even w/o mingw. Some time is required for triaging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov added a comment. Colleagues, thank you for the discussion. @aprantl @Michael137 Thank you very much for the patch and the test changes and confirmation. I've pushed the patch again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov added a comment. I tried to triage a bit. The test `lldb\test\API\functionalities\unused-inlined-parameters\TestUnusedInlinedParameters.py` compiles the code in `main.c` with `-O1` and generates the following IR for the `@f` function: ; Function Attrs: alwaysinline nounwind

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov added a comment. @Michael137 Thank you very much for the information! I'm not sure, but it looks like the introduced change of the `readnone` attribute to `readonly` might make impact on DWARF. Unfortunately, I have no idea should this changes in DWARF be fixed or just it is enough

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov added a comment. @aeubanks Thank you very much for the benchmark results and review. I've landed the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128830/new/ https://reviews.llvm.org/D128830

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f20dcbf708c: [Pipelines] Introduce DAE after ArgumentPromotion (authored by psamolysov). Changed prior to commit:

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov added a comment. In D128830#3647168 , @aeubanks wrote: > ... but let me run some internal benchmarks on this patch @aeubanks Sorry for the late answer. Did you have a chance to run the benchmarks? If so, could you share the results?

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov updated this revision to Diff 443860. psamolysov added a comment. Return the `PostOrderFunctionAttrsPass` pass back on its original place in the pipeline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128830/new/

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov added a comment. @aeubanks Hmm, if I correctly get your comment, I should revert this patch to the state before the proposed solution with moving the `PostOrderFunctionAttrsPass` at the end of the `buildInlinerPipeline` function regardless of the `readonly` instead of `readnone`

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov updated this revision to Diff 443661. psamolysov added a comment. [Pipelines] Fix the Clang :: CodeGenCoroutines/coro-elide.cpp Now, the `%_Z5task1v.Frame` type doesn't contain a field of the `%_Z5task0v.Frame` one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov updated this revision to Diff 443631. psamolysov added a comment. @aeubanks Thank you for the great explanation. I've applied your suggestion and re-uploaded the patch. The test `unused-nonnull.ll` has been fixed with keeping the `readnone` attribute. Repository: rG LLVM Github

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

psamolysov updated this revision to Diff 441462. psamolysov added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix `Clang :: CodeGen/thinlto-distributed-newpm.ll` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123026: [clang][NFC] Extract EmitAssemblyHelper::shouldEmitRegularLTOSummary

psamolysov-intel marked an inline comment as done. psamolysov-intel added a comment. Colleagues, could you help me with landing? @tejohnson has approved the patch (if I applied the suggestion as it was expected, thank you @tejohnson!) CHANGES SINCE LAST ACTION

[PATCH] D123026: [clang][NFC] Extract EmitAssemblyHelper::shouldEmitRegularLTOSummary

psamolysov-intel updated this revision to Diff 420888. psamolysov-intel retitled this revision from "[clang][NFC] Extract the EmitAssemblyHelper::shouldEmitLTOSummary method" to "[clang][NFC] Extract EmitAssemblyHelper::shouldEmitRegularLTOSummary". psamolysov-intel edited the summary of this

[PATCH] D123026: [clang][NFC] Extract the EmitAssemblyHelper::shouldEmitLTOSummary method

psamolysov-intel updated this revision to Diff 420831. psamolysov-intel retitled this revision from "[clang][NFC] Extract the EmitAssemblyHelper::emitLTOSummary method" to "[clang][NFC] Extract the EmitAssemblyHelper::shouldEmitLTOSummary method". psamolysov-intel edited the summary of this

[PATCH] D123026: [clang][NFC] Extract the EmitAssemblyHelper::emitLTOSummary method

psamolysov-intel added a comment. Colleagues, could you review this small non-functional change. After the `TargetTruiple` member has been extracted, it becomes clear that there is some code duplication in the `BackendUtil.cpp` source file. I think this is a good idea to eliminate this code

[PATCH] D123026: [clang][NFC] Extract the EmitAssemblyHelper::emitLTOSummary method

psamolysov-intel created this revision. psamolysov-intel added reviewers: tejohnson, ddunbar, tobiasvk, tobiasvk_caf, paulkirth, greened. psamolysov-intel added a project: clang. Herald added subscribers: ormris, inglorion. Herald added a project: All. psamolysov-intel requested review of this

[PATCH] D122587: [clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member

psamolysov-intel added a comment. All tests have been passed. Could anyone with the committer privileges help me with landing, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122587/new/ https://reviews.llvm.org/D122587

[PATCH] D122587: [clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member

psamolysov-intel added a comment. Thank you @tejohnson for the approve. If there are no objections from someone could you (or another committer) help me with the landing, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122587/new/

[PATCH] D122587: [clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member

psamolysov-intel added a comment. I see some code duplication on lines 1056-1065 and 1472-1481, I have a fix for this and going to open a new review after this patch will be landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122587/new/

[PATCH] D122587: [clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member

psamolysov-intel created this revision. psamolysov-intel added reviewers: tejohnson, ddunbar, tobiasvk, tobiasvk_caf. psamolysov-intel added a project: clang. Herald added a subscriber: ormris. Herald added a project: All. psamolysov-intel requested review of this revision. Herald added a

[PATCH] D71746: Fix the "TypeError: a bytes-like object is required, not 'str'" in exploded-graph-rewriter.py on Python 3.5+

psamolysov added a comment. @NoQ Could you commit, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71746/new/ https://reviews.llvm.org/D71746 ___ cfe-commits mailing list

[PATCH] D71746: Fix the "TypeError: a bytes-like object is required, not 'str'" in exploded-graph-rewriter.py on Python 3.5+

psamolysov created this revision. psamolysov added reviewers: dergachev.a, clang. psamolysov added a project: clang. Herald added a subscriber: cfe-commits. When I run the 'exploded-graph-rewriter.py' tool on Windows using Python 3.5 and above, the following error and stack trace occurs:

[PATCH] D69427: Fix compilation error in clangd/refactor/tweaks/ExpandAutoType.cpp

psamolysov added a comment. I have no commit access, can anyone land this small fix, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69427/new/ https://reviews.llvm.org/D69427 ___ cfe-commits

[PATCH] D69427: Fix compilation error in clangd/refactor/tweaks/ExpandAutoType.cpp

psamolysov created this revision. psamolysov added projects: clang, clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. During the compilation of the `clangd/refactor/tweaks/ExpandAutoType.cpp`, MSVC returns the following