r291124 - [OpenMP] Add fields for flags in the offload entry descriptor.

2017-01-05 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Jan 5 10:02:49 2017 New Revision: 291124 URL: http://llvm.org/viewvc/llvm-project?rev=291124=rev Log: [OpenMP] Add fields for flags in the offload entry descriptor. Summary: This patch adds two fields to the offload entry descriptor. One field is meant to signal

r289458 - Fix typo and remove unnecessary statement.

2016-12-12 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Mon Dec 12 13:26:31 2016 New Revision: 289458 URL: http://llvm.org/viewvc/llvm-project?rev=289458=rev Log: Fix typo and remove unnecessary statement. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp URL:

r289450 - Fix format and a few typos in comments.

2016-12-12 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Mon Dec 12 12:00:20 2016 New Revision: 289450 URL: http://llvm.org/viewvc/llvm-project?rev=289450=rev Log: Fix format and a few typos in comments. Modified: cfe/trunk/include/clang-c/Index.h cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D26774: [CUDA] Driver changes to support CUDA compilation on MacOS.

2016-11-17 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Justin, Thanks for the patch. Comment at: clang/lib/Driver/Driver.cpp:479 +// the device toolchain we create depends on both. +ToolChain * = ToolChains[CudaTriple.str() + "/" + HostTriple.str()]; +if (!CudaTC) { I am

r285925 - Rename the version of ConstructJob for multiple outputs to ConstructJobMultipleOutputs.

2016-11-03 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Nov 3 10:41:50 2016 New Revision: 285925 URL: http://llvm.org/viewvc/llvm-project?rev=285925=rev Log: Rename the version of ConstructJob for multiple outputs to ConstructJobMultipleOutputs. It was causing trouble with the GCC bots. Modified:

r285408 - Define extra variable in OpenMP offloading driver tests.

2016-10-28 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Fri Oct 28 10:42:38 2016 New Revision: 285408 URL: http://llvm.org/viewvc/llvm-project?rev=285408=rev Log: Define extra variable in OpenMP offloading driver tests. Modified: cfe/trunk/test/Driver/openmp-offload.c Modified: cfe/trunk/test/Driver/openmp-offload.c URL:

[PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

2016-10-28 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Michael, In https://reviews.llvm.org/D21845#581988, @mkuron wrote: > I think `OffloadAction::DeviceDependences::add(..., ..., > /*BoundArch=*/nullptr, Action::OFK_OpenMP)` is never sufficient. The invalid > `BoundArch` eventually ends up in

r285404 - Change OpenMP offload driver tests so that it doesn't use the full file path during tests.

2016-10-28 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Fri Oct 28 10:11:50 2016 New Revision: 285404 URL: http://llvm.org/viewvc/llvm-project?rev=285404=rev Log: Change OpenMP offload driver tests so that it doesn't use the full file path during tests. This was causing failures on windows bots. Modified:

[PATCH] D9888: [OPENMP] Driver support for OpenMP offloading

2016-10-28 Thread Samuel Antao via cfe-commits
sfantao abandoned this revision. sfantao marked 8 inline comments as done. sfantao added a comment. Hi Jonas, In https://reviews.llvm.org/D9888#581809, @Hahnfeld wrote: > I think these changes have been contributed to trunk in multiple commits so > this can be closed? You're right, this can

[PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

2016-10-27 Thread Samuel Antao via cfe-commits
sfantao added a comment. A PR was generated as requested by Hal explaining why we do not generate jobs for NVPTX targets yet. https://llvm.org/bugs/show_bug.cgi?id=30812 https://reviews.llvm.org/D21845 ___ cfe-commits mailing list

r285327 - Use -fopenmp=libomp in all OpenMP offloading tests.

2016-10-27 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Oct 27 13:29:57 2016 New Revision: 285327 URL: http://llvm.org/viewvc/llvm-project?rev=285327=rev Log: Use -fopenmp=libomp in all OpenMP offloading tests. This will make sure the right features are being tested even for machines that default to libgomp. Modified:

[PATCH] D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions.

2016-10-27 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 76069. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21857 Files: include/clang/Driver/Action.h include/clang/Driver/Driver.h include/clang/Driver/Tool.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/Tool.cpp

r285326 - [Driver][OpenMP] Add support to create jobs for unbundling actions.

2016-10-27 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Oct 27 13:14:55 2016 New Revision: 285326 URL: http://llvm.org/viewvc/llvm-project?rev=285326=rev Log: [Driver][OpenMP] Add support to create jobs for unbundling actions. Summary: This patch adds the support to create jobs for the `OffloadBundlingAction` which will

r285325 - [Driver][OpenMP] Add support to create jobs for bundling actions.

2016-10-27 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Oct 27 13:04:42 2016 New Revision: 285325 URL: http://llvm.org/viewvc/llvm-project?rev=285325=rev Log: [Driver][OpenMP] Add support to create jobs for bundling actions. Summary: This patch adds the support to create a job for the `OffloadBundlingAction` which will

[PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

2016-10-27 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 76064. sfantao marked an inline comment as done. sfantao added a comment. - Add comment explaing that the bundler tool can detect if the input file is a bundle or not. https://reviews.llvm.org/D21853 Files: include/clang/Driver/Action.h

r285324 - [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

2016-10-27 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Oct 27 13:00:51 2016 New Revision: 285324 URL: http://llvm.org/viewvc/llvm-project?rev=285324=rev Log: [Driver][OpenMP] Update actions builder to create unbundling action when necessary. Summary: Each time that offloading support is requested by the user and the input

r285323 - [Driver][OpenMP] Update actions builder to create bundling action when necessary.

2016-10-27 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Oct 27 12:50:43 2016 New Revision: 285323 URL: http://llvm.org/viewvc/llvm-project?rev=285323=rev Log: [Driver][OpenMP] Update actions builder to create bundling action when necessary. Summary: In order to save the user from dealing with multiple output files (for host

r285320 - [Driver][OpenMP] Add logic for offloading-specific argument translation.

2016-10-27 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Oct 27 12:39:44 2016 New Revision: 285320 URL: http://llvm.org/viewvc/llvm-project?rev=285320=rev Log: [Driver][OpenMP] Add logic for offloading-specific argument translation. Summary: This patch includes support for argument translation that is specific of a given

r285319 - [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

2016-10-27 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Oct 27 12:31:22 2016 New Revision: 285319 URL: http://llvm.org/viewvc/llvm-project?rev=285319=rev Log: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains. Summary: This patch adds logic to create jobs for OpenMP offloading

[PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

2016-10-27 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 76062. sfantao added a comment. - Capitalize Clang in the regression test too. https://reviews.llvm.org/D21847 Files: include/clang/Driver/Options.td lib/Driver/Driver.cpp lib/Driver/Tools.cpp test/Driver/openmp-offload.c Index:

[PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

2016-10-27 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 76061. sfantao marked 2 inline comments as done. sfantao added a comment. - Capitalize Clang in linker script comment and explain that the linker script dump option is required to test the driver with -###. https://reviews.llvm.org/D21847 Files:

r285314 - [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

2016-10-27 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Oct 27 12:08:03 2016 New Revision: 285314 URL: http://llvm.org/viewvc/llvm-project?rev=285314=rev Log: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions. Summary: This patch adds a new specialized action builder to create OpenMP offloading

r285311 - [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

2016-10-27 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Oct 27 11:38:05 2016 New Revision: 285311 URL: http://llvm.org/viewvc/llvm-project?rev=285311=rev Log: [Driver][OpenMP] Create tool chains for OpenMP offloading kind. Summary: This patch adds new logic to create the necessary tool chains to support offloading for

r285307 - [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

2016-10-27 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Oct 27 11:29:20 2016 New Revision: 285307 URL: http://llvm.org/viewvc/llvm-project?rev=285307=rev Log: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver. Summary: This creates a tool selector in the driver that replaces the existing one. The goal is to

[PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

2016-10-26 Thread Samuel Antao via cfe-commits
sfantao added a comment. In https://reviews.llvm.org/D18172#580276, @jlebar wrote: > Hi, Samuel. > > This change introduced a new crash / assertion failure in the driver. > > $ echo | llvm-run clang -emit-llvm -c -x cuda - -o /dev/null > > > Before this patch, we get an error (perhaps not

r285264 - Remove check for -o option in offloading actions builder.

2016-10-26 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Wed Oct 26 20:08:58 2016 New Revision: 285264 URL: http://llvm.org/viewvc/llvm-project?rev=285264=rev Log: Remove check for -o option in offloading actions builder. This check is also present when jobs are built, so the offloading builder check is not needed anymore.

r285263 - Fix bug when compiling CUDA code with -emit-llvm and -o.

2016-10-26 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Wed Oct 26 19:53:34 2016 New Revision: 285263 URL: http://llvm.org/viewvc/llvm-project?rev=285263=rev Log: Fix bug when compiling CUDA code with -emit-llvm and -o. In this case the device code is not injected into an host action and therefore the user should get an error

[PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

2016-10-26 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Justin Thanks for letting me know. I'm looking into it. Thanks again, Samuel Repository: rL LLVM https://reviews.llvm.org/D18172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

2016-10-25 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 75741. sfantao marked 3 inline comments as done. sfantao added a comment. - Fix typos and use StringRef() instead of const char * to follow what the Driver does today when it comes to specify the bound architectures. https://reviews.llvm.org/D21853 Files:

[PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

2016-10-25 Thread Samuel Antao via cfe-commits
sfantao marked 7 inline comments as done. sfantao added a comment. Hi Hal, Thanks for the review! Comments inlined. Comment at: include/clang/Driver/Action.h:504 + /// unbundling action. + struct DependingActionInfoTy final { +/// \brief The tool chain of the depending

[PATCH] D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation.

2016-10-25 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Hal, Thanks for the review! Comment at: lib/Driver/ToolChains.cpp:2854 + case options::OPT_shared: + case options::OPT_static: + case options::OPT_fPIC: hfinkel wrote: > And also? > > case options::OPT_dynamic:

[PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

2016-10-25 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Hal, Thanks for the review! Comments inlined. Comment at: lib/Driver/Tools.cpp:334 + LksStream << " OpenMP Offload Linker Script.\n"; + LksStream << "*/\n"; + LksStream << "TARGET(binary)\n"; hfinkel wrote: > We should also say

[PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

2016-10-25 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 75730. sfantao marked 3 inline comments as done. sfantao added a comment. - Address Hal Finkel comments - fix comments/fix linker script comment. https://reviews.llvm.org/D21847 Files: include/clang/Driver/Options.td lib/Driver/Driver.cpp

[PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

2016-10-25 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 75722. sfantao marked 7 inline comments as done. sfantao added a comment. - Fix typos and add test tht checks phases when OpenMP and CUDA are used simultaneously. https://reviews.llvm.org/D21845 Files: lib/Driver/Driver.cpp

[PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

2016-10-25 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Hal, Thanks for the review! Fixed the typos in the new diff. Comment at: lib/Driver/Driver.cpp:1949 +SpecializedBuilders.push_back(new OpenMPActionBuilder(C, Args, Inputs)); + // hfinkel wrote: > Since we can have both

[PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

2016-10-25 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Hal, Thanks for the review! Comment at: include/clang/Basic/DiagnosticDriverKinds.td:163 +def err_drv_expecting_fopenmp_with_fopenmp_targets : Error< + "The option -fopenmp-targets must be used in conjunction with a -fopenmp option compatible

[PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

2016-10-25 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 75705. sfantao marked an inline comment as done. sfantao added a comment. - Address Hal Finkel comments - make diagnostic message more informative. https://reviews.llvm.org/D21843 Files: include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

2016-10-25 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 75698. sfantao marked 10 inline comments as done. sfantao added a comment. - Address Hal Finkel suggestions - rename functions/reorder code/fix comments. https://reviews.llvm.org/D21840 Files: include/clang/Driver/Action.h lib/Driver/Driver.cpp Index:

[PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

2016-10-25 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Hal, Thanks for the review! In https://reviews.llvm.org/D21840#555719, @hfinkel wrote: > The naming here is a bit hard to follow, we have 'dependent action', > 'dependency action', 'depending action', and I think they're all supposed to > mean the same thing. Only

[PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

2016-09-30 Thread Samuel Antao via cfe-commits
This revision was automatically updated to reflect the committed changes. sfantao marked an inline comment as done. Closed by commit rL282865: [CUDA][OpenMP] Add a generic offload action builder (authored by sfantao). Changed prior to commit: https://reviews.llvm.org/D18172?vs=72117=73060#toc

r282865 - [CUDA][OpenMP] Add a generic offload action builder

2016-09-30 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Fri Sep 30 10:34:19 2016 New Revision: 282865 URL: http://llvm.org/viewvc/llvm-project?rev=282865=rev Log: [CUDA][OpenMP] Add a generic offload action builder Summary: This patch proposes a new class to generate and record action dependences related with offloading. The

Re: [PATCH] D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions.

2016-09-21 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 72126. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21857 Files: include/clang/Driver/Action.h include/clang/Driver/Driver.h include/clang/Driver/Tool.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/Tool.cpp

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

2016-09-21 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 72125. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21856 Files: include/clang/Driver/Action.h include/clang/Driver/ToolChain.h lib/Driver/Action.cpp lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp lib/Driver/Tools.h

Re: [PATCH] D21852: [Driver][OpenMP] Update actions builder to create bundling action when necessary.

2016-09-21 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 72123. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21852 Files: include/clang/Driver/Action.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

Re: [PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

2016-09-21 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 72124. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21853 Files: include/clang/Driver/Action.h include/clang/Driver/Types.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp lib/Driver/Types.cpp

Re: [PATCH] D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation.

2016-09-21 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 72122. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21848 Files: include/clang/Driver/Compilation.h include/clang/Driver/ToolChain.h lib/Driver/Compilation.cpp lib/Driver/Driver.cpp lib/Driver/MSVCToolChain.cpp

Re: [PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

2016-09-21 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 72121. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21847 Files: include/clang/Driver/Options.td lib/Driver/Driver.cpp lib/Driver/Tools.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

Re: [PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

2016-09-21 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 72119. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21843 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/Action.h include/clang/Driver/Driver.h lib/Driver/Action.cpp lib/Driver/Driver.cpp

Re: [PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

2016-09-21 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 72120. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21845 Files: lib/Driver/Driver.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c === ---

Re: [PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

2016-09-21 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 72118. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21840 Files: include/clang/Driver/Action.h lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp === ---

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

2016-09-21 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 72117. sfantao added a comment. - Rebase. https://reviews.llvm.org/D18172 Files: include/clang/Driver/Compilation.h lib/Driver/Driver.cpp lib/Driver/Types.cpp test/Driver/cuda-bindings.cu test/Driver/cuda-phases.cu Index:

r281923 - Reorder initializers in CallStackFrame so that we don't get a warning.

2016-09-19 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Mon Sep 19 13:13:13 2016 New Revision: 281923 URL: http://llvm.org/viewvc/llvm-project?rev=281923=rev Log: Reorder initializers in CallStackFrame so that we don't get a warning. Modified: cfe/trunk/lib/AST/ExprConstant.cpp Modified: cfe/trunk/lib/AST/ExprConstant.cpp

Re: [PATCH] D24165: [clang-offload-bundler] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

2016-09-02 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Eugene, The patch looks good to me. You may wait for someone that could okay the patch to take a look too. Thanks, Samuel Repository: rL LLVM https://reviews.llvm.org/D24165 ___ cfe-commits mailing list

Re: [PATCH] D24165: [clang-offload-bundler] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

2016-09-02 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Eugene, The patch looks good to me. You may wait for someone that could okay the patch to take a look too. Thanks, Samuel Repository: rL LLVM https://reviews.llvm.org/D24165 ___ cfe-commits mailing list

r279653 - Fix offload bundler tests so that diagnostic can start with caps.

2016-08-24 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Wed Aug 24 13:52:18 2016 New Revision: 279653 URL: http://llvm.org/viewvc/llvm-project?rev=279653=rev Log: Fix offload bundler tests so that diagnostic can start with caps. Windows require that. Modified: cfe/trunk/test/Driver/clang-offload-bundler.c Modified:

r279635 - Add target REQUIRES directives to offload bundler test.

2016-08-24 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Wed Aug 24 10:47:06 2016 New Revision: 279635 URL: http://llvm.org/viewvc/llvm-project?rev=279635=rev Log: Add target REQUIRES directives to offload bundler test. Modified: cfe/trunk/test/Driver/clang-offload-bundler.c Modified:

r279634 - [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

2016-08-24 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Wed Aug 24 10:39:07 2016 New Revision: 279634 URL: http://llvm.org/viewvc/llvm-project?rev=279634=rev Log: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format. Summary: This patch adds the capability to bundle object files in

r279632 - clang-offload-bundler - offload files bundling/unbundling tool

2016-08-24 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Wed Aug 24 10:21:05 2016 New Revision: 279632 URL: http://llvm.org/viewvc/llvm-project?rev=279632=rev Log: clang-offload-bundler - offload files bundling/unbundling tool Summary: One of the goals of programming models that support offloading (e.g. OpenMP) is to enable

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

2016-08-24 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Jonas, Thanks again for the review! Comment at: test/CMakeLists.txt:27-33 @@ -26,8 +26,9 @@ list(APPEND CLANG_TEST_DEPS clang clang-headers clang-format c-index-test diagtool clang-tblgen + clang-offload-bundler )

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

2016-08-24 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 69124. sfantao marked an inline comment as done. sfantao added a comment. - Add clang-offload bundler as dependency to clang. https://reviews.llvm.org/D13909 Files: test/CMakeLists.txt test/Driver/clang-offload-bundler.c tools/CMakeLists.txt

r278811 - Reorder stderr redirection in test command.

2016-08-16 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Tue Aug 16 09:38:39 2016 New Revision: 278811 URL: http://llvm.org/viewvc/llvm-project?rev=278811=rev Log: Reorder stderr redirection in test command. Modified: cfe/trunk/test/Driver/cuda-detect.cu Modified: cfe/trunk/test/Driver/cuda-detect.cu URL:

r278806 - Add empty --gcc-toolchain empty to cuda-detect test.

2016-08-16 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Tue Aug 16 09:31:39 2016 New Revision: 278806 URL: http://llvm.org/viewvc/llvm-project?rev=278806=rev Log: Add empty --gcc-toolchain empty to cuda-detect test. Unless we overload the default gcc toolchain with an empty string the system root used in the tests will be

Re: [PATCH] D23526: [CUDA] Collapsed offload actions should not be top-level jobs.

2016-08-15 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Art, Thanks for the patch! That looks good. https://reviews.llvm.org/D23526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21851: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

2016-08-15 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 68089. sfantao marked an inline comment as done. sfantao added a comment. - Remove redundant return statement. https://reviews.llvm.org/D21851 Files: test/Driver/clang-offload-bundler.c test/Driver/clang-offload-bundler.c.o

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

2016-08-15 Thread Samuel Antao via cfe-commits
sfantao added a comment. Hi Jonas, Thanks for the review! Comment at: test/CMakeLists.txt:27-33 @@ -26,8 +26,9 @@ list(APPEND CLANG_TEST_DEPS clang clang-headers clang-format c-index-test diagtool clang-tblgen + clang-offload-bundler )

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

2016-08-15 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 68086. sfantao marked 5 inline comments as done. sfantao added a comment. - Fix comments and diagnostics. https://reviews.llvm.org/D13909 Files: test/CMakeLists.txt test/Driver/clang-offload-bundler.c tools/CMakeLists.txt

r278140 - [CUDA] Regression test to make sure C++ include path are forwarded to host and device frontends.

2016-08-09 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Tue Aug 9 12:27:24 2016 New Revision: 278140 URL: http://llvm.org/viewvc/llvm-project?rev=278140=rev Log: [CUDA] Regression test to make sure C++ include path are forwarded to host and device frontends. Summary: Add test to detect the C++ include paths are passed to both

Re: [PATCH] D22946: [CUDA] Regression test to make sure C++ include path are forwarded to host and device frontends.

2016-08-09 Thread Samuel Antao via cfe-commits
sfantao added inline comments. Comment at: test/Driver/cuda-detect.cu:75-77 @@ -74,1 +74,5 @@ +// Verify that compiler accepts CUDA syntax with "-x cuda-cpp-output". +// RUN: %clang -Werror -fsyntax-only -x cuda-cpp-output -c %s +// +// Verify that C++ include paths are passed

Re: [PATCH] D22946: [CUDA] Regression test to make sure C++ include path are forwarded to host and device frontends.

2016-08-09 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 67366. sfantao marked an inline comment as done. sfantao added a comment. - Remove redundant test - copied by mistake. https://reviews.llvm.org/D22946 Files: test/Driver/cuda-detect.cu Index: test/Driver/cuda-detect.cu

Re: [PATCH] D22946: [CUDA] Regression test to make sure C++ include path are forwarded to host and device frontends.

2016-08-09 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 67335. sfantao marked an inline comment as done. sfantao added a comment. - Move CUDA C++ include path tests to cuda-detect.cu. Address other Art's comments. https://reviews.llvm.org/D22946 Files: test/Driver/cuda-detect.cu Index:

Re: [PATCH] D22946: [CUDA] Regression test to make sure C++ include path are forwarded to host and device frontends.

2016-08-08 Thread Samuel Antao via cfe-commits
sfantao added a comment. Friendly ping. Thanks! https://reviews.llvm.org/D22946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

2016-07-29 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 66189. sfantao added a comment. - Remove duplicate keyword in linker script. https://reviews.llvm.org/D21847 Files: include/clang/Driver/Options.td lib/Driver/Driver.cpp lib/Driver/Tools.cpp test/Driver/openmp-offload.c Index:

[PATCH] D22946: [CUDA] Regression test to make sure C++ include path are forwarded to host and device frontends.

2016-07-28 Thread Samuel Antao via cfe-commits
sfantao created this revision. sfantao added a reviewer: tra. sfantao added a subscriber: cfe-commits. Add test to detect the C++ include paths are passed to both CUDA host and device frontends. https://reviews.llvm.org/D22946 Files: test/Driver/cuda-simple.cu Index:

Re: [PATCH] D22518: Refactor how include paths are appended to the command arguments.

2016-07-28 Thread Samuel Antao via cfe-commits
sfantao added a comment. In https://reviews.llvm.org/D22518#500066, @tra wrote: > Samuel, the patch breaks CUDA. With the patch clang no longer adds include > paths to standard c++ library during device-side compilation. > if you run "clang++ -### -c -x cuda /dev/null" you will see that host

r277064 - [CUDA] Unswitch enumerators in the selection of the offloading tool chain.

2016-07-28 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Jul 28 17:42:42 2016 New Revision: 277064 URL: http://llvm.org/viewvc/llvm-project?rev=277064=rev Log: [CUDA] Unswitch enumerators in the selection of the offloading tool chain. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL:

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

2016-07-28 Thread Samuel Antao via cfe-commits
sfantao added a comment. Any more comments on this patch or depending ones? Thanks! Samuel https://reviews.llvm.org/D18172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation.

2016-07-28 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 66021. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21848 Files: include/clang/Driver/Compilation.h include/clang/Driver/ToolChain.h lib/Driver/Compilation.cpp lib/Driver/Driver.cpp lib/Driver/MSVCToolChain.cpp

Re: [PATCH] D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions.

2016-07-28 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 66029. sfantao added a comment. - Fix type qualifier. - Rebase. https://reviews.llvm.org/D21857 Files: include/clang/Driver/Action.h include/clang/Driver/Driver.h include/clang/Driver/Tool.h lib/Driver/Action.cpp lib/Driver/Driver.cpp

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

2016-07-28 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 66028. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21856 Files: include/clang/Driver/Action.h include/clang/Driver/ToolChain.h lib/Driver/Action.cpp lib/Driver/ToolChain.cpp lib/Driver/Tools.cpp lib/Driver/Tools.h

Re: [PATCH] D21852: [Driver][OpenMP] Update actions builder to create bundling action when necessary.

2016-07-28 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 66026. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21852 Files: include/clang/Driver/Action.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

Re: [PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

2016-07-28 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 66027. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21853 Files: include/clang/Driver/Action.h include/clang/Driver/Types.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp lib/Driver/Types.cpp

Re: [PATCH] D21851: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

2016-07-28 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 66025. sfantao added a comment. - Refactor code to dump contents of temporary file instead of creating the actual file in dry-run mode. - Rebase. https://reviews.llvm.org/D21851 Files: test/Driver/clang-offload-bundler.c

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

2016-07-28 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 66023. sfantao added a comment. - Fix bug in conditional. - Rebase. https://reviews.llvm.org/D13909 Files: test/CMakeLists.txt test/Driver/clang-offload-bundler.c tools/CMakeLists.txt tools/clang-offload-bundler/CMakeLists.txt

Re: [PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

2016-07-28 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 66020. sfantao added a comment. - Add option to dump and test the linker script contents. - Rebase. https://reviews.llvm.org/D21847 Files: include/clang/Driver/Options.td lib/Driver/Driver.cpp lib/Driver/Tools.cpp test/Driver/openmp-offload.c

Re: [PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

2016-07-28 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 66019. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21845 Files: lib/Driver/Driver.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c === ---

Re: [PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

2016-07-28 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 66018. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21843 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/Action.h include/clang/Driver/Driver.h lib/Driver/Action.cpp lib/Driver/Driver.cpp

Re: [PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

2016-07-28 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 66017. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21840 Files: include/clang/Driver/Action.h lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp === ---

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

2016-07-28 Thread Samuel Antao via cfe-commits
sfantao updated this revision to Diff 66016. sfantao added a comment. - Remove redundant phases from cuda-phases.cu and use DAG check. - Rebase. https://reviews.llvm.org/D18172 Files: include/clang/Driver/Compilation.h lib/Driver/Driver.cpp test/Driver/cuda-phases.cu Index:

r276996 - [CUDA] Remove duplicated test that should have been removed in r276995.

2016-07-28 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Jul 28 11:18:31 2016 New Revision: 276996 URL: http://llvm.org/viewvc/llvm-project?rev=276996=rev Log: [CUDA] Remove duplicated test that should have been removed in r276995. Removed: cfe/trunk/test/Driver/cuda_phases.cu Removed:

r276995 - [CUDA] Rename cuda_phases.cu test to cuda-phases.cu to be consistent with the other tests.

2016-07-28 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Jul 28 11:12:30 2016 New Revision: 276995 URL: http://llvm.org/viewvc/llvm-project?rev=276995=rev Log: [CUDA] Rename cuda_phases.cu test to cuda-phases.cu to be consistent with the other tests. Added: cfe/trunk/test/Driver/cuda-phases.cu Added:

r276988 - [OpenMP] Change name of variable in mappble expression.

2016-07-28 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Jul 28 10:31:29 2016 New Revision: 276988 URL: http://llvm.org/viewvc/llvm-project?rev=276988=rev Log: [OpenMP] Change name of variable in mappble expression. This attempts to fix a failure in Windows bots pottentially related with a reserved keyword. Modified:

r276983 - [OpenMP] Fix link command pattern in offloading interoperability test.

2016-07-28 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Jul 28 09:56:19 2016 New Revision: 276983 URL: http://llvm.org/viewvc/llvm-project?rev=276983=rev Log: [OpenMP] Fix link command pattern in offloading interoperability test. It was causing a few bots to fail. Modified:

r276981 - [OpenMP] Do not use default argument in lambda from mappable expressions handlers.

2016-07-28 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Jul 28 09:47:35 2016 New Revision: 276981 URL: http://llvm.org/viewvc/llvm-project?rev=276981=rev Log: [OpenMP] Do not use default argument in lambda from mappable expressions handlers. Windows bots were complaining about that. Modified:

r276979 - [OpenMP][CUDA] Do not forward OpenMP flags for CUDA device actions.

2016-07-28 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Jul 28 09:29:18 2016 New Revision: 276979 URL: http://llvm.org/viewvc/llvm-project?rev=276979=rev Log: [OpenMP][CUDA] Do not forward OpenMP flags for CUDA device actions. Summary: This patch prevents OpenMP flags from being forwarded to CUDA device commands. That was

r276978 - [OpenMP] Code generation for the is_device_ptr clause

2016-07-28 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Jul 28 09:25:09 2016 New Revision: 276978 URL: http://llvm.org/viewvc/llvm-project?rev=276978=rev Log: [OpenMP] Code generation for the is_device_ptr clause Summary: This patch adds support for the is_device_ptr clause. It expands SEMA to use the mappable expression

r276977 - [OpenMP] Codegen for use_device_ptr clause.

2016-07-28 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Thu Jul 28 09:23:26 2016 New Revision: 276977 URL: http://llvm.org/viewvc/llvm-project?rev=276977=rev Log: [OpenMP] Codegen for use_device_ptr clause. Summary: This patch adds support for the use_device_ptr clause. It includes changes in SEMA that could not be tested

[PATCH] D22895: [OpenMP][CUDA] Do not forward OpenMP flags for CUDA device actions.

2016-07-27 Thread Samuel Antao via cfe-commits
sfantao created this revision. sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0, tra. sfantao added subscribers: cfe-commits, caomhin. This patch prevents OpenMP flags from being forwarded to CUDA device commands. That was causing the CUDA frontend to attempt to

r276934 - [OpenMP] Add support to map member expressions with references to pointers.

2016-07-27 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Wed Jul 27 17:52:16 2016 New Revision: 276934 URL: http://llvm.org/viewvc/llvm-project?rev=276934=rev Log: [OpenMP] Add support to map member expressions with references to pointers. Summary: This patch add support to map pointers through references in class members.

r276933 - [OpenMP] Add support for mapping array sections through pointer references.

2016-07-27 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Wed Jul 27 17:49:49 2016 New Revision: 276933 URL: http://llvm.org/viewvc/llvm-project?rev=276933=rev Log: [OpenMP] Add support for mapping array sections through pointer references. Summary: This patch fixes a bug in the map of array sections whose base is a reference to

r276929 - Refactor how include paths are appended to the command arguments.

2016-07-27 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Wed Jul 27 17:46:31 2016 New Revision: 276929 URL: http://llvm.org/viewvc/llvm-project?rev=276929=rev Log: Refactor how include paths are appended to the command arguments. Summary: This patch aims at removing redundancy in the way include paths for the regular and

  1   2   3   4   5   >