[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

sthibaul added a comment. I try to make Hurd.cpp close to Linux.cpp in general, yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101324/new/ https://reviews.llvm.org/D101324 ___ cfe-commits mailing

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

sthibaul added a comment. No, for now it only supports i686. This part is actually already being tested by hurd.cpp, /usr/include/i386-gnu wouldn't be getting included otherwise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101324/new/

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul marked an inline comment as done. sthibaul added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:3014 llvm::opt::ArgStringList ) const { - addGCCLibStdCxxIncludePaths(DriverArgs, CC1Args); + if

[PATCH] D101347: hurd: Clean up test

sthibaul updated this revision to Diff 340879. sthibaul added a comment. Rebase on refreshed D101331 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101347/new/ https://reviews.llvm.org/D101347 Files:

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul updated this revision to Diff 340878. sthibaul added a comment. Rebase on newer D101317 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101331/new/ https://reviews.llvm.org/D101331 Files:

[PATCH] D101317: hurd: Fix i386 research path

sthibaul added inline comments. Comment at: clang/test/Driver/hurd.c:2 // RUN: %clang -no-canonical-prefixes %s -### 2>&1 \ // RUN: --target=i386-pc-gnu \ // RUN: --sysroot=%S/Inputs/basic_hurd_tree \ MaskRay wrote: > While we currently detects

[PATCH] D101317: hurd: Fix i386 research path

sthibaul updated this revision to Diff 340875. sthibaul marked an inline comment as done. sthibaul added a comment. Fix triplet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101317/new/ https://reviews.llvm.org/D101317 Files:

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul updated this revision to Diff 340871. sthibaul marked 2 inline comments as done. sthibaul added a comment. Rather use i686-gnu triplet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101331/new/ https://reviews.llvm.org/D101331 Files:

[PATCH] D101317: hurd: Fix i386 research path

sthibaul added a comment. @MaskRay could you review this one as well? Most others are based on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101317/new/ https://reviews.llvm.org/D101317 ___

[PATCH] D101347: hurd: Clean up test

sthibaul updated this revision to Diff 340769. sthibaul added a comment. Retrigger buildable with the dep Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101347/new/ https://reviews.llvm.org/D101347 Files:

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul updated this revision to Diff 340765. sthibaul added a comment. Fix clang-tidy warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101331/new/ https://reviews.llvm.org/D101331 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D101347: hurd: Clean up test

sthibaul created this revision. sthibaul requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - We dropped windows support - Upgrade to current gcc 10 version Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101347 Files:

[PATCH] D101317: hurd: Fix i386 research path

sthibaul updated this revision to Diff 340751. sthibaul added a comment. Retrigger buildable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101317/new/ https://reviews.llvm.org/D101317 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D101317: hurd: Fix i386 research path

sthibaul updated this revision to Diff 340749. sthibaul added a comment. Retrigger buildable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101317/new/ https://reviews.llvm.org/D101317 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

sthibaul added a comment. FI, I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101324/new/ https://reviews.llvm.org/D101324 ___ cfe-commits mailing list

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul added inline comments. Comment at: clang/test/Driver/hurd.cpp:4 +// RUN: %clang -no-canonical-prefixes %s -### 2>&1 \ +// RUN: --target=i386-pc-gnu \ +// RUN: --sysroot=%S/Inputs/basic_hurd_tree \ MaskRay wrote: > The target should exactly match

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul updated this revision to Diff 340703. sthibaul marked 6 inline comments as done. sthibaul added a comment. Move all tests to hurd.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101331/new/ https://reviews.llvm.org/D101331 Files:

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul marked 4 inline comments as done. sthibaul added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:3014 llvm::opt::ArgStringList ) const { - addGCCLibStdCxxIncludePaths(DriverArgs, CC1Args); + if

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul updated this revision to Diff 340700. sthibaul marked 3 inline comments as done. sthibaul added a comment. Fix GCCInstallation.isValid use in Generic_GCC::addLibStdCxxIncludePaths Fix test further Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul marked 2 inline comments as done. sthibaul added inline comments. Comment at: clang/test/Driver/hurd.cpp:1 +// RUN: %clang -no-canonical-prefixes %s -### 2>&1 \ +// RUN: --target=i386-pc-gnu \ MaskRay wrote: > I think we need -NEXT patterns to

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul updated this revision to Diff 340689. sthibaul added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101331/new/ https://reviews.llvm.org/D101331 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul created this revision. sthibaul requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow-up of e92d2b80c6c9 ("[Driver] Detect libstdc++ include paths

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

sthibaul created this revision. sthibaul requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow-up of 35dd6470de84 for the Hurd case, to avoid the

[PATCH] D101317: hurd: Fix i386 research path

sthibaul created this revision. sthibaul requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. f26341840253 ("[Driver] Gnu.cpp: remove obsoleted i386 triple detection from

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul added a comment. @MaskRay : Samuel Thibault CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul added a comment. Thanks! I don't have commit access, could somebody commit this for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___ cfe-commits mailing list

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul added a comment. ping @phosek ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul updated this revision to Diff 256436. sthibaul marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/Gnu.h

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul marked 2 inline comments as done. sthibaul added a comment. In D73845#1971282 , @MaskRay wrote: > Moving functions from Linux.cpp to Gnu.cpp is definitely appropriate. Have > you made any adjustment? No, it's really pure code move (and the

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul added a comment. Hello, any news on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul added a comment. > I however didn't find how to specify in phabricator a dependency between the > two diffs, is that supported in phabricator? Ah, it can be set as child revision after creating the diff, done so. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul updated this revision to Diff 243378. sthibaul retitled this revision from "[Gnu toolchain] Look at standard GCC multilib/multiarch paths by default" to "[Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu". CHANGES SINCE LAST ACTION

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul marked an inline comment as done. sthibaul added a comment. >> I feel like in this specific case it may be worth splitting this into two >> patches: > > Alright, doing so. It is now on https://reviews.llvm.org/D74282 I however didn't find how to specify in phabricator a dependency

[PATCH] D73845: [Gnu toolchain] Look at standard GCC multilib/multiarch paths by default

sthibaul added a comment. > I feel like in this specific case it may be worth splitting this into two > patches: Alright, doing so. > isn't Hurd only limited to one GCC target triple (i386-gnu) for the time > being? Right now, yes, but we'll want to bootstrap a 64bit port sooner or later.

[PATCH] D73845: [Gnu toolchain] Look at standard GCC multilib/multiarch paths by default

sthibaul updated this revision to Diff 243359. sthibaul added a comment. Herald added a subscriber: ormris. Right, here is an updated patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D73845: [Gnu toolchain] Look at standard GCC multilib/multiarch paths by default

sthibaul added a comment. There is no behavior change, I checked for no regression on GNU/Linux with ninja check-all. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___

[PATCH] D73845: [Gnu toolchain] Look at standard GCC multilib/multiarch paths by default

sthibaul created this revision. sthibaul added reviewers: kristina, sammccall, lebedev.ri. Herald added subscribers: cfe-commits, krytarowski, arichardson, emaste. Herald added a project: clang. The current code for GNU/Linux is actually completely generic, and can be moved to Gnu, so it can

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul added a comment. > Let me know if you need this committed. Yes, please commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69758/new/ https://reviews.llvm.org/D69758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul added a comment. (I don't see anything looking like what you have, so can't investigate) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69758/new/ https://reviews.llvm.org/D69758 ___ cfe-commits mailing list

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul added a comment. I am actually getting many failures with ninja check-all on my build box: Expected Passes: 56258 Expected Failures : 203 Unsupported Tests : 1485 Unexpected Failures: 164 I have attached the whole check log: F11178531: check.log

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul added a comment. Which checksuite are you running? I had been using ninja check-all, and I do indeed get unexpected failures, but exactly the same set of failures as when building against master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69758/new/

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul marked an inline comment as done. sthibaul added a comment. > [Gnu toolchain] > maybe this can be removed in the title? I thought that commits usually have such kind of title prefixes? Comment at: clang/lib/Driver/ToolChains/Linux.cpp:36 /// /// Debian-based

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul added a comment. I have updated the patch to the latest git and re-ran checks. Could somebody have a look at it please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69758/new/ https://reviews.llvm.org/D69758 ___ cfe-commits

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul updated this revision to Diff 235644. sthibaul marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69758/new/ https://reviews.llvm.org/D69758 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/Gnu.h

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul updated this revision to Diff 229192. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69758/new/ https://reviews.llvm.org/D69758 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/Gnu.h clang/lib/Driver/ToolChains/Hurd.cpp

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul marked 3 inline comments as done. sthibaul added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2623 + int MaxVersion = 0; + std::string MaxVersionString = ""; + for (llvm::vfs::directory_iterator LI = vfs.dir_begin(base, EC), LE;

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul marked an inline comment as done. sthibaul added a comment. Not sure what NFCI means, but for Linux the behavior should just not change at all, and the testsuite indeed behaved exactly the same on Linux indeed. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2623 +

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul created this revision. sthibaul added a reviewer: kristina. Herald added a project: clang. Herald added a subscriber: cfe-commits. Linux' current addLibCxxIncludePaths and addLibStdCxxIncludePaths are actually almost non-Linux-specific at all, and can be reused almost as such for all gcc

[PATCH] D69754: [hurd] Add --build-id option when enabled

sthibaul created this revision. sthibaul added a reviewer: kristina. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D69754 Files: clang/lib/Driver/ToolChains/Hurd.cpp Index: clang/lib/Driver/ToolChains/Hurd.cpp

[PATCH] D54379: Add Hurd toolchain support to Clang

sthibaul added a comment. I don't have this issue with make check-all in clang/. Just to make sure: are the .keep files of the patch getting created? Otherwise the i386-gnu/ directories will not get created and then it's not surprising that clang doesn't add them to the research paths.

[PATCH] D54379: Add Hurd toolchain support to Clang

sthibaul added a comment. I have added static and shared library tests > a short unit test with regards to creating the actual target instance) I'm not sure what you mean? The tests create an actual binary for the target. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D54379: Add Hurd toolchain support to Clang

sthibaul updated this revision to Diff 175188. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54379/new/ https://reviews.llvm.org/D54379 Files: lib/Basic/Targets.cpp lib/Basic/Targets/OSTargets.h lib/Driver/CMakeLists.txt lib/Driver/Driver.cpp

[PATCH] D54379: Add Hurd toolchain support to Clang

sthibaul updated this revision to Diff 175186. sthibaul marked 4 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54379/new/ https://reviews.llvm.org/D54379 Files: lib/Basic/Targets.cpp lib/Basic/Targets/OSTargets.h

[PATCH] D54379: Add Hurd toolchain support to Clang

sthibaul added a comment. (there still needs to be work on the test part) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54379/new/ https://reviews.llvm.org/D54379 ___ cfe-commits mailing list

[PATCH] D54379: Add Hurd toolchain support to Clang

sthibaul marked 13 inline comments as done. sthibaul added a comment. I'll update the diff according to the comments. Comment at: lib/Driver/ToolChains/Hurd.cpp:74 + + // Similar to the logic for GCC above, if we currently running Clang inside + // of the requested system

[PATCH] D54379: Add Hurd toolchain support to Clang

sthibaul updated this revision to Diff 174536. sthibaul added a comment. I have added a few checks (the ld.so dynamic linker specification, the ../lib32 paths, and /usr/lib/i386-gnu) About negative tests, what kind of invalid input are you thinking about? Repository: rC Clang

[PATCH] D54379: Add Hurd toolchain support to Clang

sthibaul marked 5 inline comments as done. sthibaul added a comment. I believe this version handles all the comments. I could run this with check-all on a linux-amd64 box. Repository: rC Clang https://reviews.llvm.org/D54379 ___ cfe-commits

[PATCH] D54379: Add Hurd toolchain support to Clang

sthibaul updated this revision to Diff 174526. sthibaul edited the summary of this revision. Repository: rC Clang https://reviews.llvm.org/D54379 Files: lib/Basic/Targets.cpp lib/Basic/Targets/OSTargets.h lib/Driver/CMakeLists.txt lib/Driver/Driver.cpp

[PATCH] D54379: Add Hurd toolchain support to Clang

sthibaul added a comment. > In general when structuring your code, the performance penalty for other > targets when the conditions that can be easily tested are not met should > pretty much be close to nonexistent. I would suggest keeping that in mind > when submitting revisions. I know, as

[PATCH] D54379: Add Hurd toolchain support to Clang

sthibaul marked 9 inline comments as done. sthibaul added inline comments. Comment at: lib/Basic/Targets/OSTargets.h:283 +Builder.defineMacro("__GLIBC__"); +Builder.defineMacro("__ELF__"); +if (Opts.POSIXThreads) kristina wrote: > `__MACH__` and

[PATCH] D54379: Add Hurd support

sthibaul updated this revision to Diff 173604. sthibaul added a comment. Herald added a subscriber: srhines. This includes version finding the gcc Hurd triplet (i[3456]-gnu) in the Gcc detector. Repository: rC Clang https://reviews.llvm.org/D54379 Files: lib/Basic/Targets.cpp

[PATCH] D54379: Add Hurd support

sthibaul updated this revision to Diff 173601. Repository: rC Clang https://reviews.llvm.org/D54379 Files: lib/Basic/Targets.cpp lib/Basic/Targets/OSTargets.h lib/Driver/CMakeLists.txt lib/Driver/Driver.cpp lib/Driver/ToolChains/Clang.cpp lib/Driver/ToolChains/Gnu.cpp

[PATCH] D54379: Add Hurd support

sthibaul updated this revision to Diff 173599. sthibaul added a comment. In this version, the Driver introduces the "-hurd-" part Repository: rC Clang https://reviews.llvm.org/D54379 Files: lib/Basic/Targets.cpp lib/Basic/Targets/OSTargets.h lib/Driver/CMakeLists.txt

[PATCH] D54379: Add Hurd support

sthibaul added inline comments. Comment at: lib/Driver/ToolChains/Hurd.cpp:136 + + // Add an include of '/include' directly. This isn't provided by default by + // system GCCs, but is often used with cross-compiling GCCs, and harmless to krytarowski wrote: >

[PATCH] D54379: Add Hurd support

sthibaul updated this revision to Diff 173515. https://reviews.llvm.org/D54379 Files: lib/Basic/Targets.cpp lib/Basic/Targets/OSTargets.h lib/Driver/CMakeLists.txt lib/Driver/Driver.cpp lib/Driver/ToolChains/Clang.cpp lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Hurd.cpp

[PATCH] D54379: Add Hurd support

sthibaul marked 3 inline comments as done. sthibaul added a comment. I commented one of them, and will fix the rest. Comment at: lib/Driver/ToolChains/Hurd.cpp:36 + // clever. + switch (TargetTriple.getArch()) { + default: kristina wrote: > Does this need a

[PATCH] D54379: Add Hurd support

sthibaul added a comment. The Hurd::Hurd constructor would actually need to do the same gcc inclusion path detection as on Linux, but let's leave this aside for now, this commit is enough for a build without libc++. Repository: rC Clang https://reviews.llvm.org/D54379

[PATCH] D54379: Add Hurd support

sthibaul created this revision. sthibaul added a reviewer: rengolin. Herald added subscribers: cfe-commits, fedor.sergeev, krytarowski, mgorny. Repository: rC Clang https://reviews.llvm.org/D54379 Files: lib/Basic/Targets.cpp lib/Basic/Targets/OSTargets.h lib/Driver/CMakeLists.txt