[PATCH] D134821: [flang][driver] Allow main program to be in an archive

2023-04-28 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. In D134821#4304690 , @awarzynski wrote: > I've just reverted this patch - for context please see > https://reviews.llvm.org/D149429. > > @sunshaoce This was committed >

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

2023-04-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG876df74dd471: [flang][driver] Allow main program to be in an archive (authored by sunshaoce). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

2023-04-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. Any further suggestions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

2023-04-25 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 516651. sunshaoce added a comment. Address @awarzynski's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

2023-04-24 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 516476. sunshaoce added a comment. This revision is now accepted and ready to land. Herald added subscribers: pcwang-thead, s.egerton, simoncook, asb. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

2023-04-24 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. I would like to help land this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 ___ cfe-commits mailing list

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-19 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a subscriber: DavidSpickett. sunshaoce added inline comments. Comment at: flang/test/Driver/code-gen-rv64.f90:1 +! Test -emit-obj (RISC-V 64) + mamrami wrote: > sunshaoce wrote: > > awarzynski wrote: > > > mamrami wrote: > > > > Hi :) > > > > It

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-16 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added inline comments. Comment at: flang/test/Driver/code-gen-rv64.f90:1 +! Test -emit-obj (RISC-V 64) + awarzynski wrote: > mamrami wrote: > > Hi :) > > It seems like the test fails: > >

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-15 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sunshaoce marked an inline comment as done. Closed by commit rG36278b735fa1: [Flang][RISCV] Emit target features for RISC-V (authored by sunshaoce). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-14 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 505363. sunshaoce added a comment. Address @MaskRay's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145883/new/ https://reviews.llvm.org/D145883 Files: clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-14 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. Any other opinions? If not, I will land it later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145883/new/ https://reviews.llvm.org/D145883 ___ cfe-commits mailing list

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added inline comments. Comment at: flang/test/Driver/code-gen-rv64.f90:7 +! RUN: %flang_fc1 -triple riscv64-unknown-linux-gnu \ +! RUN: -target-feature +d -target-feature +c -emit-obj %s -o %t.o +! RUN: llvm-readelf -h %t.o | FileCheck %s awarzynski

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504756. sunshaoce marked 2 inline comments as done. sunshaoce added a comment. Add `target-cpu-features-invalid.f90` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145883/new/ https://reviews.llvm.org/D145883

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce marked 5 inline comments as done. sunshaoce added inline comments. Comment at: flang/test/Driver/target-cpu-features.f90:33 ! RUN: -o /dev/null -S %s 2>&1 | FileCheck %s -check-prefix=CHECK-INVALID-CPU ! RUN: %flang_fc1 -triple aarch64-linux-gnu -target-feature

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added inline comments. Comment at: flang/test/Driver/code-gen-rv64.f90:12 + +! CHECK: Flags: 0x5, RVC, double-float ABI +end program awarzynski wrote: > awarzynski wrote: > > For those of us less familiar with RISC-V - could you explain what's > >

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504695. sunshaoce added a comment. Add `REQUIRES` in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145883/new/ https://reviews.llvm.org/D145883 Files: clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504672. sunshaoce marked an inline comment as done. sunshaoce added a comment. Address @awarzynski's comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145883/new/

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504616. sunshaoce added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145883/new/ https://reviews.llvm.org/D145883 Files: clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504548. sunshaoce added a comment. Based on everyone's comments, I merged the test into `target-cpu-features.f90` and only kept the generic `-target-feature`. At the same time, I removed the `switch (TC.getArch())` and passed the test on x86 and RISC-V

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-12 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce created this revision. sunshaoce added reviewers: awarzynski, klausler, clementval, sscalpone, craig.topper, jrtc27, kito-cheng. Herald added subscribers: VincentWu, vkmr, evandro, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, simoncook,

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb1fdcd5fbc09: [Flang] Allow compile *.f03, *.f08 file (authored by sunshaoce). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504372. sunshaoce added a comment. Fix the issue of failing in the MSVC environment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845 Files:

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce reopened this revision. sunshaoce added a comment. This revision is now accepted and ready to land. Sorry! My previous tests were not comprehensive enough, which resulted in failures in the MSVC environment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sunshaoce marked an inline comment as done. Closed by commit rG171794de533b: [Flang] Allow compile *.f03, *.f08 file (authored by sunshaoce). Repository: rG LLVM

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504363. sunshaoce marked 2 inline comments as done. sunshaoce added a comment. Sorry, I just missed a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504362. sunshaoce added a comment. Address @awarzynski's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845 Files: clang/lib/Driver/Types.cpp

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504360. sunshaoce added a comment. Remove -flang-experimental-exec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845 Files: clang/lib/Driver/Types.cpp

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. Before $ /home/sunshaoce/dev/llvm-project/build/bin/flang-new /home/sunshaoce/dev/llvm-project/build/temp.f03 -flang-experimental-exec -o temp.out -### flang-new version 17.0.0 (https://github.com/llvm/llvm-project.git 890e6c871d31dca9e461c01118cf25fb303b9cad)

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504359. sunshaoce added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845 Files: clang/lib/Driver/Types.cpp flang/test/Driver/f03-suffix.f03

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce created this revision. sunshaoce added reviewers: awarzynski, klausler, clementval, sscalpone. Herald added a project: All. sunshaoce requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Fix issue #61260 Repository: rG

[PATCH] D141698: doc: Rewrite opening paragraph of CFI Design Doc

2023-02-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. I tend to keep it as it is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141698/new/ https://reviews.llvm.org/D141698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143478: [RFC][Flang][driver] Try to support `flang -fc1as`

2023-02-08 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce abandoned this revision. sunshaoce added a comment. A better implementation is in D143572 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143478/new/ https://reviews.llvm.org/D143478

[PATCH] D143478: [RFC][Flang][driver] Try to support `flang -fc1as`

2023-02-07 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 495522. sunshaoce added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143478/new/ https://reviews.llvm.org/D143478 Files: clang/include/clang/Driver/Options.h

[PATCH] D143478: [RFC][Flang][driver] Try to support `flang -fc1as`

2023-02-07 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. In D143478#4109412 , @clementval wrote: > There should be some tests. I'm not sure how to check the generated binaries, can you provide a test case for reference? Thanks! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D143478: [RFC][Flang][driver] Try to support `flang -fc1as`

2023-02-07 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. In D143478#4109479 , @awarzynski wrote: > Thanks for working on this! Before diving any deeper > > - Does LLVM Flang require `flang-new -fc1as`? > - If yes, why can't Flang and Clang share it? > > For better visibility, I

[PATCH] D143478: [RFC][Flang][driver] Try to support `flang -fc1as`

2023-02-07 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce created this revision. sunshaoce added reviewers: rovka, kiranchandramohan, Leporacanthicus, awarzynski, sscalpone, liaolucy. Herald added projects: Flang, All. sunshaoce requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, MaskRay. Herald added a

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

2022-10-25 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoP.td:599 + Sched<[]>; +def UKSTSA32 : RVPBinary<0b1110001, 0b011, "ukstsa32">, + Sched<[]>; `0b011` should be `0b010`.

[PATCH] D121670: [RISCV] Add zihintntl instructions

2022-08-21 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7167a4207ee2: [RISCV] Add zihintntl instructions (authored by sunshaoce). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

2022-07-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. In D95588#3641900 , @Jim wrote: > In D95588#3622052 , @sunshaoce wrote: > >> Hello @Jim! We are developing the P extension, are you still maintaining >> this patch? Or would you mind

[PATCH] D128604: [RISCV] Support Zbpbo extension v0.9.11

2022-07-10 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 443555. sunshaoce added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files: clang/include/clang/Basic/BuiltinsRISCV.def

[PATCH] D108189: [RISCV] Support experimental 'P' extension 0.9.11

2022-07-10 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 443552. sunshaoce added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108189/new/ https://reviews.llvm.org/D108189 Files: clang/test/Driver/riscv-arch.c

[PATCH] D128604: [RISCV] Support Zbpbo extension

2022-07-03 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 441931. sunshaoce added a comment. Rebase on D99158 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files:

[PATCH] D108189: [RISCV] Support experimental 'P' extension 0.9.11

2022-07-03 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 441925. sunshaoce added a comment. Support for P extension version 0.9.11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108189/new/ https://reviews.llvm.org/D108189 Files: clang/test/Driver/riscv-arch.c

[PATCH] D128604: [RISCV] Support Zbpbo extension

2022-07-02 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 441872. sunshaoce added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files: clang/include/clang/Basic/BuiltinsRISCV.def

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

2022-06-30 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. Hello @Jim! We are developing the P extension, are you still maintaining this patch? Or would you mind co-development together? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/ https://reviews.llvm.org/D95588

[PATCH] D128604: [RISCV] Support Zbpbo extension

2022-06-29 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 441052. sunshaoce added a comment. Add alias instructions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files: clang/include/clang/Basic/BuiltinsRISCV.def

[PATCH] D128604: [RISCV] Support Zbpbo extension

2022-06-28 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 440714. sunshaoce marked an inline comment as done. sunshaoce added a comment. Address @craig.topper's comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/

[PATCH] D128604: [RISCV] Support Zbpbo extension

2022-06-28 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 440613. sunshaoce added a comment. Rebased on D128644 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files:

[PATCH] D128604: [WIP][RISCV] Support Zbpbo extension

2022-06-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 440324. sunshaoce added a comment. Herald added a subscriber: jdoerfert. Fully supported Zbpbo v0.9.11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files:

[PATCH] D128604: [RISCV] Support Zbpbo extension

2022-06-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:352 MinorStr = In.take_while(isDigit); -In = In.substr(MajorStr.size() + 1); +In = In.substr(MajorStr.size() + MinorStr.size() - 1); Modifications here have been

[PATCH] D128604: [WIP][RISCV] Support Zbpbo extension

2022-06-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 440267. sunshaoce added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files: clang/include/clang/Basic/BuiltinsRISCV.def

[PATCH] D128604: [WIP][RISCV] Support Zbpbo extension

2022-06-26 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce created this revision. sunshaoce added reviewers: asb, craig.topper, jrtc27, Jim, luismarques, kito-cheng, frasercrmck. Herald added subscribers: VincentWu, luke957, StephenFan, vkmr, evandro, apazos, sameer.abuasal, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D121670: [RISCV] Add zihintntl instructions

2022-06-21 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 438563. sunshaoce added a comment. Herald added a subscriber: shiva0217. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121670/new/ https://reviews.llvm.org/D121670 Files:

[PATCH] D127589: [Driver][test] Make RISCV tests robust with PATH=

2022-06-15 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe180cc5ff1a1: [Driver][test] Make RISCV tests robust with PATH= (authored by sunshaoce). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D127684: [NFC] Use `https` instead of `http` in the `LLVM.org` URLs

2022-06-14 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce abandoned this revision. sunshaoce added a comment. Thanks for comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127684/new/ https://reviews.llvm.org/D127684 ___ cfe-commits mailing list

[PATCH] D127684: [NFC] Use `https` instead of `http` in the urls

2022-06-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce created this revision. Herald added subscribers: libc-commits, libcxx-commits, jsji, Enna1, bzcheeseman, kosarev, jsilvanus, mattd, gchakrabarti, hsmhsm, ThomasRaoux, pmatos, asb, ayermolo, awarzynski, sdasgup3, asavonic, carlosgalvezp, jeroen.dobbelaere, abrachet, wenzhicui, wrengr,

[PATCH] D127589: [RISCV] Compatible with more RISCV related ld in the test

2022-06-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 436469. sunshaoce added a comment. Address @StephenFan's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127589/new/ https://reviews.llvm.org/D127589 Files: clang/test/Driver/riscv64-toolchain.c

[PATCH] D127589: [RISCV] Compatible with more RISCV related ld in the test

2022-06-12 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce created this revision. Herald added subscribers: VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D125157: [RISCV][NFC] Add more tests for clang driver.

2022-05-09 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added inline comments. Comment at: clang/test/Driver/riscv-arch.c:583 +// RV32-ZHINX-BADVERS: unsupported version number 0.1 for extension 'zhinx' \ No newline at end of file Add a newline here. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D121670: [RISCV] Add zihintntl instructions

2022-03-16 Thread Shao-Ce SUN via Phabricator via cfe-commits
s updated this revision to Diff 415703. s added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add preprocessor test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121670/new/ https://reviews.llvm.org/D121670

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-03-04 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa9c8bab0c7a: [RISCV] Support k-ext clang intrinsics (authored by achieveartificialintelligence). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-03-03 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 412698. achieveartificialintelligence marked 7 inline comments as done. achieveartificialintelligence added a comment. Address @craig.topper's comments. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-03-01 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e38b295435b: [RISCV] add the MC layer support of Zfinx extension (authored by achieveartificialintelligence). Herald added a project: All.

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-28 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 411959. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Address @craig.topper's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-28 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. Are there any other errors now? @krasimir @nikic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 411734. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Address @jrtc27's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 411719. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files:

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. Can you help test if this patch works fine now? @krasimir Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-02-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 411676. achieveartificialintelligence added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files:

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-02-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 411675. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Thanks for @craig.topper's detailed advice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-02-25 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 411379. achieveartificialintelligence added a comment. Ping & Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files:

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-25 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 411375. achieveartificialintelligence added a comment. Thanks for @craig.topper's patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files:

[PATCH] D117740: [NFC][clang] Simplify `isOneOf` function

2022-02-24 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa8b4b9104c8f: [NFC][clang] Simplify `isOneOf` function (authored by achieveartificialintelligence). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-24 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. In D93298#3342452 , @krasimir wrote: > @achieveartificialintelligence any progress with the problematic IR? Have you > been able to reproduce using nikic's reduced example? Sorry, I don't have a solution

[PATCH] D117740: [NFC][clang] Simplify `isOneOf` function

2022-02-23 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117740/new/ https://reviews.llvm.org/D117740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-02-21 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 410444. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files:

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-18 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. @krasimir Since I don't have a rust environment, can you help me to test if D120130 works? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-17 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. Thanks all! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits mailing list

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-17 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. achieveartificialintelligence marked an inline comment as done. Closed by commit rG7798ecca9c3d: [RISCV] add the MC layer support of Zfinx extension (authored by

[PATCH] D119846: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`

2022-02-15 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. In D119846#3325334 , @skan wrote: > @achieveartificialintelligence Please explain why a patch is reverted in the > commit message next time. OK, thanks for your guidance! Repository: rG LLVM Github

[PATCH] D119846: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`

2022-02-15 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe25c06cc5bd: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter` (authored by achieveartificialintelligence). Repository: rG

[PATCH] D119846: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`

2022-02-15 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: grosbach, Eugene.Zelenko, asb, jrtc27, craig.topper. Herald added subscribers: ayermolo, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, frasercrmck, rdzhabarov, tatianashp,

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-02-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 408319. achieveartificialintelligence marked 4 inline comments as done. achieveartificialintelligence added a comment. Address @craig.topper's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-02-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 408310. achieveartificialintelligence added a comment. Ping & Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files:

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:557 + +let RegInfos = RegInfoByHwMode<[RV64], [RegInfo<64, 64, 64>]> in +def GPRPF64 :

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-10 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:555 +def GPRF64 : RegisterClass<"RISCV", [f64], 64, (add GPR)>; +def GPRPF64 : RegisterClass<"RISCV", [f64], 64, (add +X10_PD, X12_PD, X14_PD, X16_PD,

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-10 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 407482. achieveartificialintelligence marked 2 inline comments as done. achieveartificialintelligence added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-02-04 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 405997. achieveartificialintelligence added a comment. Amend tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files:

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-02-04 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 405989. achieveartificialintelligence marked 3 inline comments as done. achieveartificialintelligence added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-04 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. In D93298#3296515 , @luismarques wrote: > Assuming this will be merged soon, do you want to submit a backport request > for the 14.0 branch? Yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-02-03 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 405605. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files:

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-01 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 404910. achieveartificialintelligence added a comment. Separate the Zhinxmin and Zhinx extensions. Inspired by D118581 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117740: [NFC][clang] Simplify `isOneOf` function

2022-01-31 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117740/new/ https://reviews.llvm.org/D117740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D118578: [RISCV] Make Zfhmin in march imply F.

2022-01-31 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence accepted this revision. achieveartificialintelligence added a comment. This revision is now accepted and ready to land. LGTM. I think this is indeed a better way to implement `Zfhmin`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-01-24 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 402739. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. @asb Thank you very much! Could you please take a look at what needs to be modified now? Repository: rG LLVM

[PATCH] D113237: [RISCV] Support I extension version 2.1

2022-01-24 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. > @achieveartificialintelligence Do you know what is the relation between your > patch and D115921 ? This commit doesn't depend on D115921 , but if D115921

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-01-20 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 401528. achieveartificialintelligence added a comment. Address @craig.topper's comments. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

2022-01-19 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/vloxseg-rv32.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py -; RUN: llc -mtriple=riscv32 -mattr=+d,+experimental-zvlsseg,+zfh \ +; RUN: llc

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-01-19 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. Ping. Any other suggestions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits mailing list

[PATCH] D117740: [NFC][clang] Simplify `isOneOf` function

2022-01-19 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: alexfh, danielmarjamaki. achieveartificialintelligence requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

  1   2   >