[PATCH] D155544: [AIX][TLS] Add -maix-small-local-exec-tls option.

2023-07-21 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp accepted this revision as: stefanp. stefanp added a comment. This revision is now accepted and ready to land. I think this patch makes sense to me. LGTM. Comment at: llvm/test/CodeGen/PowerPC/check-aix-small-local-exec-tls-opt.ll:15 + +; Make sure that the test was

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

2023-03-31 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp added a comment. Overall I think that this looks fine to me as well. I had a couple of minor comments and you may decide that you don't need to do either one so if that's the case just mention why in a comment and I will approve the patch. Comment at:

[PATCH] D140104: [clang][dataflow] Remove unused argument in getNullability

2022-12-16 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:9072 auto GetNullability = [](QualType Ty) { +Optional Kind = Ty->getNullability(); merrymeerkat wrote: > barannikov88 wrote: > > This now gives a warning > >

[PATCH] D135834: [PowerPC] Fix parameters for __builtin_crypto_vsbox

2022-10-14 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6897dbc46329: [PowerPC] Fix parameters for __builtin_crypto_vsbox (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135834/new/

[PATCH] D135834: [PowerPC] Fix parameters for __builtin_crypto_vsbox

2022-10-12 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp created this revision. stefanp added reviewers: lei, nemanjai. Herald added subscribers: shchenz, kbarton. Herald added a project: All. stefanp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The documentation specifies that the

[PATCH] D135300: [PowerPC] Fix types for vcipher builtins.

2022-10-06 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e2e1fc90a01: [PowerPC] Fix types for vcipher builtins. (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135300: [PowerPC] Fix types for vcipher builtins.

2022-10-05 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp created this revision. stefanp added reviewers: nemanjai, lei. Herald added subscribers: shchenz, kbarton. Herald added a project: All. stefanp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The documentation specifies that the

[PATCH] D110771: [PowerPC] Fix __builtin_ppc_load2r to return short instead of int.

2021-10-04 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4fc2f4979cf5: [PowerPC] Fix __builtin_ppc_load2r to return short instead of int. (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110771: [PowerPC] Fix __builtin_ppc_load2r to return short instead of int.

2021-10-04 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp updated this revision to Diff 376857. stefanp added a comment. Rebased and added signext test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110771/new/ https://reviews.llvm.org/D110771 Files:

[PATCH] D110771: [PowerPC] Fix __builtin_ppc_load2r to return short instead of int.

2021-09-29 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp created this revision. stefanp added reviewers: lei, nemanjai. Herald added subscribers: shchenz, kbarton, hiraditya. stefanp requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. This patch fixes the return value of the builtin

[PATCH] D110653: [PowerPC] The builtins load8r and store8r are Power 7 plus.

2021-09-29 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb4e44c4e7da: [PowerPC] The builtins load8r and store8r are Power 7 plus. (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D110653: [PowerPC] The builtins load8r and store8r are Power 7 plus.

2021-09-28 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp created this revision. stefanp added reviewers: nemanjai, lei. Herald added subscribers: shchenz, kbarton, hiraditya. stefanp requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. This patch makes sure that the builtins

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

2021-08-12 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp accepted this revision. stefanp added a comment. Thank you for adding the `DiagGroup`. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://reviews.llvm.org/D107002 ___

[PATCH] D107461: [PowerPC] Do not define __PRIVILEGED__

2021-08-11 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa614a28772cb: [PowerPC] Do not define __PRIVILEGED__ (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107461: [PowerPC] Do not define __PRIVILEGED__

2021-08-09 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp updated this revision to Diff 365278. stefanp added a comment. Revewiers had a good catch where I forgot to add an equals sign to check in the test case. I've fixed that test now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107461/new/

[PATCH] D107461: [PowerPC] Do not define __PRIVILEGED__

2021-08-04 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp created this revision. stefanp added reviewers: nemanjai, lei. Herald added subscribers: shchenz, kbarton. stefanp requested review of this revision. Herald added a project: clang. We do not want to define __PRIVILEGED__. There is no use case for the definition and gcc does not define it.

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

2021-07-20 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02cd937945f8: [PowerPC][Builtins] Added a number of builtins for compatibility with XL. (authored by stefanp). Changed prior to commit:

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

2021-07-16 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp marked an inline comment as not done. stefanp added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9732 "argument should be an 8-bit value shifted by a multiple of 8 bits, or in the form 0x??FF">; +def

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

2021-07-16 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp updated this revision to Diff 359459. stefanp added a comment. Addressed a number of comments. Replaced with Ops[0], Ops[1] where possible. Rebased on top of the patch that defines SemaValueIsRunOfOnes. That patch is now comitted anyway. Merged a number of the test files. I was not able

[PATCH] D106065: [Clang] Add an empty builtins.h file.

2021-07-16 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0bf4b81d57b0: [Clang] Add an empty builtins.h file. (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106065: [Clang] Add an empty builtins.h file.

2021-07-15 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp marked an inline comment as not done. stefanp added inline comments. Comment at: clang/test/Headers/builtins-header.c:1 +// RUN: %clang_cc1 -triple powerpc64-unknown-unknown -ffreestanding -emit-llvm -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple

[PATCH] D106065: [Clang] Add an empty builtins.h file.

2021-07-15 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp updated this revision to Diff 359186. stefanp added a comment. Added comment to the builtins.h file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106065/new/ https://reviews.llvm.org/D106065 Files: clang/lib/Headers/CMakeLists.txt

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

2021-07-15 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp updated this revision to Diff 359054. stefanp added a comment. Realized after I updated the patch that I got the darn tests wrong. I've updated the patch and fixed that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104386/new/

[PATCH] D106065: [Clang] Add an empty builtins.h file.

2021-07-15 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp created this revision. stefanp added reviewers: nemanjai, lei. Herald added a subscriber: mgorny. stefanp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On Power PC some legacy compilers included a number of builtins in a

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

2021-07-15 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp updated this revision to Diff 358915. stefanp added a comment. Sorry for letting this patch sit for so long. I have updated the tests to simplify them so that we only include the intrinsics (As per a comment). This reduces quite a bit of clutter. Added Sema Checking for the builtins

[PATCH] D105236: [PowerPC] Implement Load and Reserve and Store Conditional Builtins

2021-07-05 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp accepted this revision. stefanp added a comment. Thank you! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236 ___ cfe-commits mailing list

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

2021-07-05 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp added a comment. Overall I think this is fine. I just have a few nits. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-LoadReseve-StoreCond.c:11 +int test_lwarx(volatile int* a) { + // CHECK: entry: + // CHECK: %0 = bitcast i32* %a to i8* Please

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

2021-06-29 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90dfd059198e: [Clang] Add option to handle behaviour of vector bool/vector pixel. (authored by stefanp). Repository: rG LLVM Github Monorepo

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

2021-06-29 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp updated this revision to Diff 355320. stefanp added a comment. Removed the lines that specified that checks were auto generated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103615/new/ https://reviews.llvm.org/D103615 Files:

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

2021-06-29 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp updated this revision to Diff 355315. stefanp added a comment. Updated test cases to avoid failures on non assert builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103615/new/ https://reviews.llvm.org/D103615 Files:

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

2021-06-29 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp added a comment. In D103615#2847650 , @dblaikie wrote: > In D103615#2847118 , @bmahjour > wrote: > >> In D103615#2847047 , @stefanp >> wrote: >> >>> I'm sorry I

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

2021-06-29 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp reopened this revision. stefanp added a comment. This revision is now accepted and ready to land. I'm sorry I missed the asserts requirement. I will recommit this patch after I add `REQUIRES: asserts`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

2021-06-28 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc3fe847f9d90: [Clang] Add option to handle behaviour of vector bool/vector pixel. (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

2021-06-24 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp updated this revision to Diff 354422. stefanp added a comment. Updated the name of the option to cover all of the inconsistencies for vector pixel/bool. Future patches will continue to use this option to define the behaviour of these two types. Reworded the warning message. Added

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

2021-06-18 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp updated this revision to Diff 353126. stefanp added a comment. Moved if statement out of switch and added the Default=Mixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103615/new/ https://reviews.llvm.org/D103615 Files:

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

2021-06-16 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp created this revision. stefanp added reviewers: nemanjai, lei. Herald added subscribers: shchenz, kbarton. stefanp requested review of this revision. Herald added a project: clang. Added a number of different builtins that exist in the XL compiler. Most of these builtins already exist in

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

2021-06-11 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp updated this revision to Diff 351467. stefanp added a comment. Updated the name of the option to vector-compare compat. Added clang test lines to the test cases. Added deprecation warnings to the current default behaviour of vector bool and vector pixel. Repository: rG LLVM Github

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

2021-06-11 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp added a comment. In D103615#2799498 , @bmahjour wrote: > As far as I can see, there is no good reason for the special treatment of > vector bool/pixel going forward. Could we drop this special treatment, or at > least change the default to use

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

2021-06-03 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp created this revision. stefanp added reviewers: nemanjai, lei, rsmith. Herald added subscribers: dexonsmith, dang. stefanp requested review of this revision. Herald added a project: clang. Added the option -vector-abi-compat=[default,gcc,xl]. The default behavior for clang is for all

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

2021-05-27 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62b5df7fe2b3: [PowerPC] Added multiple PowerPC builtins (authored by quinnp, committed by stefanp). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

2021-05-27 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp updated this revision to Diff 348387. stefanp added a comment. Updated author to Quinn. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

2021-05-27 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp updated this revision to Diff 348341. stefanp added a comment. Rebased revision to top of trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D99193: [PowerPC] Add mprivileged option

2021-03-24 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91f4c1113350: [PowerPC] Add mprivileged option (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99185: [PowerPC] Change option to mrop-protect

2021-03-24 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0e4f5f3ea6e1: [PowerPC] Change option to mrop-protect (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99185/new/

[PATCH] D99193: [PowerPC] Add mprivileged option

2021-03-23 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp created this revision. stefanp added a reviewer: nemanjai. Herald added subscribers: jansvoboda11, dang, shchenz, kbarton, hiraditya. stefanp requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Add an option to tell the compiler

[PATCH] D99185: [PowerPC] Change option to mrop-protect

2021-03-23 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp created this revision. stefanp added a reviewer: nemanjai. Herald added subscribers: jansvoboda11, dang, shchenz, kbarton, hiraditya. stefanp requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. In order to have the same option on

[PATCH] D98546: [PowerPC] Add __PCREL__ when PC Relative is enabled.

2021-03-15 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG86f2a3d17878: [PowerPC] Add __PCREL__ when PC Relative is enabled. (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98546/new/

[PATCH] D98546: [PowerPC] Add __PCREL__ when PC Relative is enabled.

2021-03-12 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp created this revision. stefanp added a reviewer: nemanjai. Herald added subscribers: shchenz, kbarton. stefanp requested review of this revision. Herald added a project: clang. This patch adds the __PCREL__ define when PC Relative addressing is enabled. Repository: rG LLVM Github

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

2021-03-12 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp accepted this revision. stefanp added a comment. This revision is now accepted and ready to land. Thank you for adding this! Other than one minor nit I think this LGTM. Feel free to address nits on commits. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8834

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

2021-03-01 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp added a comment. Comments relate to just cleaning up the patch a little. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8593 + return !convertToNonDenormSingle(ArgAPFloat); +} + I'm wondering if it would not be better to just inline this.

[PATCH] D96512: [PowerPC] Add option for ROP Protection

2021-02-18 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb80357d46e22: [PowerPC] Add option for ROP Protection (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96512: [PowerPC] Add option for ROP Protection

2021-02-17 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp updated this revision to Diff 324408. stefanp added a comment. Added missing FeatureROPProtection to P8AdditionalFeatures. The P9 and P10 features list will inherit from the P8 list. Repository:

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

2021-02-16 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp requested changes to this revision. stefanp added inline comments. This revision now requires changes to proceed. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.h:1321 bool convertToNonDenormSingle(APFloat ); + bool checkNonDenormCannotConvertToSingle(APInt ); +

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

2021-02-16 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp accepted this revision as: stefanp. stefanp added a comment. This revision is now accepted and ready to land. I just have one final nit otherwise LGTM. Feel free to fix that on commit. Please wait a couple of days and see if @MaskRay has any further comments. Comment

[PATCH] D96512: [PowerPC] Add option for ROP Protection

2021-02-11 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp created this revision. stefanp added reviewers: lei, nemanjai. Herald added subscribers: dang, shchenz, kbarton, hiraditya. Herald added a reviewer: jansvoboda11. stefanp requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Added

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

2021-02-04 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp added a comment. Just nits this time around. Comment at: lld/ELF/Driver.cpp:765 +// instructions in stubs. +static bool getP10StubOpt(opt::InputArgList ) { + Conanap wrote: > For this function here, I realize we can inline all the ifs into a giant >

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit P10 instructions from stubs

2021-02-01 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp added a comment. There is one more thing that does not look quite right. It may be an encoding problem for one of the instructions. I found it in the test but you will have to trace it back to the place where it is generated in order to fix it. Comment at:

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit P10 instructions from stubs

2021-01-27 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp added a comment. I have a few comments. Most of them are nits but there is a functional issue as well. For the testing: Do we have a test for the `PPC64R2SaveStub` in the situation where the offset fits in 34 bits? Comment at: lld/ELF/Driver.cpp:768 + // This

[PATCH] D91279: [PowerPC] DForm instructions should be preferred when using zero register

2020-11-18 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp added a comment. In D91279#2400854 , @stefanp wrote: > In D91279#2390160 , @shchenz wrote: > >> Using dform with offset 0 can save one register r0/X0, this is benefit for >> register allocation? But adding

[PATCH] D91279: [PowerPC] DForm instructions should be preferred when using zero register

2020-11-17 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp added a comment. In D91279#2390160 , @shchenz wrote: > Using dform with offset 0 can save one register r0/X0, this is benefit for > register allocation? But adding it in `PPCPreEmitPeephole` pass which is > after register allocation will make

[PATCH] D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp

2020-10-09 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0741a2c9caca: [Clang][unittests][NFC] Break up test in Callbacks.cpp (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp

2020-10-08 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp updated this revision to Diff 296970. stefanp added a comment. Added the missing header file. Added the license comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 Files:

[PATCH] D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp

2020-10-06 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp added a comment. Related to this please see Nemanja's comment on https://reviews.llvm.org/D82485. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 ___

[PATCH] D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp

2020-10-06 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp created this revision. stefanp added a reviewer: nemanjai. Herald added a subscriber: mgorny. Herald added a project: clang. stefanp requested review of this revision. The Callbacks.cpp test was taking a long time to compile on some build bots causing timeouts. This patch splits up that

[PATCH] D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins

2020-07-17 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp accepted this revision as: stefanp. stefanp added a comment. LGTM. Please wait for Lei to give the approval as well before you commit. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll:2 +; NOTE: Assertions have been autogenerated by

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

2020-07-16 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp added a comment. Just a few nits for this patch. Comment at: clang/lib/Headers/altivec.h:17158 +static __inline__ vector signed __int128 __ATTRS_o_ai +vec_sl(vector signed __int128 __a, vector unsigned __int128 __b) { + return __builtin_altivec_vslq((vector unsigned

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

2020-07-16 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp added a comment. The title of the patch mentions both zero extend and sign extend. However, it seems that we only have instructions for the zero extend case. Is that right? I see both types of tests in: `test/CodeGen/builtins-ppc-p10vector.c` But I only see codegen tests for the zreo

[PATCH] D80757: [PowerPC] Add clang option -m[no-]pcrel

2020-06-01 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp accepted this revision as: stefanp. stefanp added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80757/new/ https://reviews.llvm.org/D80757 ___ cfe-commits mailing list

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

2020-05-26 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp accepted this revision. stefanp added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/ https://reviews.llvm.org/D80020 ___ cfe-commits mailing list

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

2020-05-26 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp accepted this revision. stefanp added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/ https://reviews.llvm.org/D80020 ___ cfe-commits mailing list

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

2020-05-19 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp added a comment. Most of my comments are related to the fact that we are now inserting P10 between P9 and Future and so a few things need to change for the Future code to sit on top of P10 now.

[PATCH] D77542: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint

2020-05-19 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp accepted this revision as: stefanp. stefanp added a comment. Other than the two missing `K`s in the test case as Amy pointed out LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77542/new/ https://reviews.llvm.org/D77542

[PATCH] D70262: [PowerPC] Add new Future CPU for PowerPC

2019-11-21 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5fcf89f77893: [PowerPC] Add new Future CPU for PowerPC (authored by stefanp). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D48184: [Power9] [CLANG] Add __float128 exponent GET and SET builtins

2018-09-24 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC342911: [Power9] [CLANG] Add __float128 exponent GET and SET builtins (authored by stefanp, committed by ). Herald added subscribers: cfe-commits, jsji, kristina. Changed prior to commit:

[PATCH] D48482: [Power9] [CLANG] Add __float128 support for trunc to double round to odd

2018-07-09 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC336596: [Power9] [CLANG] Add __float128 support for trunc to double round to odd (authored by stefanp, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D47548: [Power9] Add __float128 builtins for Round To Odd

2018-07-09 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC336579: [Power9] Add __float128 builtins for Round To Odd (authored by stefanp, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D47548 Files:

[PATCH] D48088: [PowerPC] The __float128 type should only be available on Power9

2018-06-13 Thread Stefan Pintilie via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC334613: [PowerPC] The __float128 type should only be available on Power9 (authored by stefanp, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang