[PATCH] D135658: demangle OptFunction trace names

Trass3r updated this revision to Diff 488959. Trass3r added a comment. I can only refer to my last comment, even in latest trunk that code is still active for the codegen passes. But meanwhile I found the corresponding new code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135658: demangle OptFunction trace names

Trass3r added a comment. Well last time I checked it this code was still in use. When is it going to be deleted? Also the test has value to ensure the new pass manager emits these entries as before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135658: demangle OptFunction trace names

Trass3r added a comment. Yeah it was conscious at least. No strong opinion on that though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135658/new/ https://reviews.llvm.org/D135658 ___ cfe-commits

[PATCH] D138300: [clangd] Support type hints for `decltype(expr)` in variable declarations

Trass3r added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:315 + addTypeHint(D->getLocation(), + llvm::cast(T)->getUnderlyingType(), + /*Prefix=*/": "); Should use dyn_cast instead of is+cast I

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r added a comment. Yeah quite complex: https://godbolt.org/z/8T5Pqadro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131295/new/ https://reviews.llvm.org/D131295 ___ cfe-commits mailing list

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r added a comment. Thanks, it seems to be that simple case, but I still see multiple lenses when I add template int Foo::foo() { return 0; } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131295/new/

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r added a comment. One remaining issue is multiple lenses for template code like template int i = 0; template int i<0>; template int i<1>; template int i<2>; template struct Foo { int foo(); // I see 3 codelenses here }; template struct Foo<0>; template

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

Trass3r added a comment. `Andreas Hollandt ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137917/new/ https://reviews.llvm.org/D137917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

Trass3r added a comment. Thanks could you also commit it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137917/new/ https://reviews.llvm.org/D137917 ___ cfe-commits mailing list

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

Trass3r added a comment. I only came across it when testing a PCH build. https://github.com/Trass3r/llvm-project/actions/runs/3423679621/jobs/5702548183 Warning: (1,9): warning: definition of macro '_GNU_SOURCE' does not match definition in precompiled header [-Wclang-cl-pch] It was set for

[PATCH] D137920: [nfc] Mark classes final as reported by -Wsuggest-final-types

Trass3r updated this revision to Diff 475114. Trass3r added a comment. fix build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137920/new/ https://reviews.llvm.org/D137920 Files: clang/include/clang/AST/Decl.h

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

Trass3r added inline comments. Comment at: clang/CMakeLists.txt:417 -add_definitions( -D_GNU_SOURCE ) - Found when building with clang-cl. It's already handled correctly in the llvm config file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D137920: [nfc] Mark classes final as reported by -Wsuggest-final-types

Trass3r added a comment. See https://github.com/llvm/llvm-project/issues/57525. The change is focused on those cases reported by gcc, i.e. with actual devirtualization potential. It needs to be carefully checked if some of those shouldn't be final (and could we somehow mark those as intended

[PATCH] D137920: [nfc] Mark classes final as reported by -Wsuggest-final-types

Trass3r created this revision. Herald added subscribers: steakhal, pmatos, asb, abrachet, frasercrmck, ThomasRaoux, martong, phosek, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, mstorsjo, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27,

[PATCH] D137919: [clangd] use fine-grained code action kinds

Trass3r added a comment. RFC. First described in https://github.com/clangd/clangd/issues/1326. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137919/new/ https://reviews.llvm.org/D137919 ___ cfe-commits

[PATCH] D137919: [clangd] use fine-grained code action kinds

Trass3r created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. Trass3r requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

Trass3r created this revision. Herald added a project: All. Trass3r requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137917 Files: clang/CMakeLists.txt

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:348 +"code-lens", cat(Features), desc("Enable preview of CodeLens feature"), +init(true), Hidden, +}; I guess we should rather make it opt-in and gather some

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r added inline comments. Comment at: clang-tools-extra/clangd/CodeLens.cpp:93 + if (auto Loc = declToLocation(P->getCanonicalDecl())) +Super.locations.emplace_back(*Loc); +} As noted in the previous PR it may be of low value, I guess only

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r updated this revision to Diff 473662. Trass3r edited the summary of this revision. Trass3r added a comment. remove bases codelens for classes fix lit test exclude self from ref count Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131295/new/

[PATCH] D135658: demangle OptFunction trace names

Trass3r added a comment. @thakis ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135658/new/ https://reviews.llvm.org/D135658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136022: [clang] Add time profile for constant evaluation

Trass3r added a comment. Thanks for this! When I experimented with this for #42754 I also came across functions like Expr::isConstantInitializer

[PATCH] D135657: add time traces for AST serialization

Trass3r added a comment. `Andreas Hollandt ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135657/new/ https://reviews.llvm.org/D135657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline

Trass3r marked 5 inline comments as done. Trass3r added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7787-7788 +/// void f() {} +/// void g(); +/// }; +/// \endcode aaron.ballman wrote: > I think it'd be interesting to

[PATCH] D135657: add time traces for AST serialization

Trass3r added a comment. Thanks, could you also commit it? I don't have the rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135657/new/ https://reviews.llvm.org/D135657 ___ cfe-commits mailing

[PATCH] D135657: add time traces for AST serialization

Trass3r added a comment. It looks like this: F24958018: image.png F24958020: image.png There is a generic test for the TimeTraceScope functionality. Other than that there's only this one I found in

[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline

Trass3r added a comment. In D135690#3862112 , @aaron.ballman wrote: > Pretty sure that was after `/Zc:inline` (IIRC that existed in MSVC 2015 which > was roughly when I recall we were hitting this). I see, yeah `/Zc:inline` got added slightly earlier:

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

Trass3r added a comment. https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 ___ cfe-commits

[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline

Trass3r added a comment. In D135690#3858541 , @aaron.ballman wrote: > In D135690#3856863 , @Trass3r wrote: > >> Didn't realize it has a big cost. Looking inside the `AST_MATCHER` and >> `REGISTER_MATCHER`

[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline

Trass3r added a comment. In D135690#3852362 , @aaron.ballman wrote: > what's the need for adding this matcher? Do you plan to use it for some > in-tree needs? We usually only add new matchers where there's an immediate > need for them because of how

[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline

Trass3r added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7791 +/// functionDecl(isEffectivelyInline()) will match f(). +AST_MATCHER(FunctionDecl, isEffectivelyInline) { return Node.isInlined(); } + Is there any value in adding

[PATCH] D135658: demangle OptFunction trace names

Trass3r updated this revision to Diff 466946. Trass3r added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135658/new/ https://reviews.llvm.org/D135658

[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline

Trass3r created this revision. Trass3r added a reviewer: ziqingluo-90. Herald added a project: All. Trass3r updated this revision to Diff 466881. Trass3r added a comment. Trass3r updated this revision to Diff 466882. Trass3r published this revision for review. Herald added a project: clang. Herald

[PATCH] D135657: add time traces for AST serialization

Trass3r updated this revision to Diff 466921. Trass3r retitled this revision from "add time traces for loading PCH files" to "add time traces for AST serialization". Trass3r edited the summary of this revision. Trass3r added a reviewer: jansvoboda11. Trass3r added a comment. rebased

[PATCH] D135657: add time traces for loading PCH files

Trass3r created this revision. Herald added a project: All. Trass3r requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fills gaps in the time trace when precompiled headers are involved. Repository: rG LLVM Github Monorepo

[PATCH] D132919: [clangd] Enable folding ranges by default.

Trass3r added a comment. Whenever I tried this option in the past it crashed clangd. I recommend doing some more testing before flipping the switch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132919/new/ https://reviews.llvm.org/D132919

[PATCH] D130689: [LLVM] Update C++ standard to 17

Trass3r added a comment. In D130689#3707296 , @mehdi_amini wrote: > land the change, wait for a couple of hours to ensure that all bots have > picked up the revision, then revert There should be a better way than this. Comprehensive pre-merge testing

[PATCH] D130689: [LLVM] Update C++ standard to 17

Trass3r added a comment. Also fails on gcc 11.2: https://github.com/Trass3r/llvm-project/runs/7703302032 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 ___

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r added a comment. I just searched again and found https://reviews.llvm.org/D91930. But seems like it never got updated with the latest code contained in here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131295/new/

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar, mgorny. Herald added a project: All. Trass3r edited the summary of this revision. Trass3r edited projects, added clang-tools-extra; removed All. Trass3r edited subscribers, added: sammccall;

[PATCH] D63085: Provide a fix-it hint for -Wswitch, which adds missing cases. If there are >3 cases, the inserted text will contain newlines so it will not be shown in console output (but will be appl

Trass3r added a comment. That's the general approach for clang-tidy use too, rely on clang-format for formatting the fixes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63085/new/ https://reviews.llvm.org/D63085 ___

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

Trass3r added a comment. Hmm just a few curious questions from the sidelines. Why a "custom system" instead of something -ftime-trace based? How much overhead does this introduce, esp. for normal use-cases? What's the gain? The information is very coarse and general-purpose system profiling

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

Trass3r added a comment. Herald added a project: All. @sammccall pls merge Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120258/new/ https://reviews.llvm.org/D120258 ___ cfe-commits mailing list

[PATCH] D120416: [clangd] Function return type hints: support lambdas, don't duplicate "->"

Trass3r added inline comments. Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:626 +auto f4() -> auto* { return "foo"; } + // `auto` conversion operator Should there be a test for `void` too or does it just work? Repository: rG

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

Trass3r added a comment. In D120258#3340717 , @sammccall wrote: > (I think this patch is good to go now, ready for a stamp if anyone agrees > :-)). I agree. There's still D120258#3336114 but I don't have the

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

Trass3r added a comment. In D120258#3340357 , @sammccall wrote: > I'll just suppress the hint here, ParamVarDecl::getLocation() appears to > incorrectly point at the rparen and it's not obvious what we're hinting > without a name in any case. I guess

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

Trass3r added a comment. For a callback like [](auto) {...} the inlay hint is displayed after the `)`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120258/new/ https://reviews.llvm.org/D120258 ___

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

Trass3r added a comment. > I don't have a good sense for how common the "multiple instantiations, same > type" scenario is; perhaps @Trass3r has an opinion on that. Hmm you said the function needs to be defined in the cpp file, right? Then I guess lambdas are indeed the main use-case. I've

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

Trass3r added a comment. No apparent differences. Is there a way to automatically reduce it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120258/new/ https://reviews.llvm.org/D120258 ___ cfe-commits

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

Trass3r added a comment. Looks like this only covers a subset. I see hints for some generic lambdas but not for others while hovering over auto reveals the type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120258/new/

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

Trass3r added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:491 + // We'll examine visible specializations and see if they yield a unique type. + bool VisitParmVarDecl(ParmVarDecl *PVD) { +if (!PVD->getType()->isDependentType()) Since this

[PATCH] D119537: [clangd] Treat 'auto' params as deduced if there's a single instantiation.

Trass3r added a comment. Is it intentional that the resolved type is not shown in the variable hover: param payload Type: const auto & // In subscribe::(anonymous class)::operator() const auto& payload Only when hovering over `auto`? type-alias auto struct Foo Repository: rG

[PATCH] D52296: [Clang] - Add '-gsplit-dwarf[=split, =single]' version for '-gsplit-dwarf' option.

Trass3r added a comment. Herald added a subscriber: dang. In D52296#1285328 , @grimar wrote: > In D52296#1284130 , @probinson wrote: > > > Only DWARF supports this, correct? > > > I am not aware of any kind of

[PATCH] D32435: clang-cl: Add support for /permissive-

Trass3r added a comment. Has this ever gotten anywhere? I think the correct mapping would be something like -fno-ms-compatibility -fno-delayed-template-parsing, not sure about -fms-volatile -fms-extensions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32435/new/

[PATCH] D47196: [Time-report ](2): Recursive timers in Clang

Trass3r added a comment. Is this still in progress? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47196/new/ https://reviews.llvm.org/D47196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org