[PATCH] D102715: Fix LIT failure on native aix

This revision was automatically updated to reflect the committed changes. Closed by commit rGd74b6635ef38: Fix LIT failure on native aix (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102715/new/

[PATCH] D102715: Fix LIT failure on native aix

Xiangling_L added inline comments. Comment at: clang/test/Sema/struct-packed-align.c:170 +#elif defined(_AIX) +// On AIX, [bool, char, short] bitfields have the same alignment as unsigned +// int. aaron.ballman wrote: > Xiangling_L wrote: > > aaron.ballman

[PATCH] D102715: Fix LIT failure on native aix

Xiangling_L updated this revision to Diff 346503. Xiangling_L marked an inline comment as done. Xiangling_L edited the summary of this revision. Xiangling_L added a comment. Adjust the comment; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102715/new/ https://reviews.llvm.org/D102715

[PATCH] D102715: [AIX] Fix LIT failure on native aix

Xiangling_L marked an inline comment as done. Xiangling_L added inline comments. Comment at: clang/test/Sema/struct-packed-align.c:170 +#elif defined(_AIX) +// On AIX, [bool, char, short] bitfields have the same alignment as unsigned +// int. aaron.ballman

[PATCH] D102715: [AIX] Fix LIT failure on native aix

Xiangling_L updated this revision to Diff 346462. Xiangling_L added a comment. Adjusted the testcase so that it also tests the property well on aix; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102715/new/ https://reviews.llvm.org/D102715 Files:

[PATCH] D102715: [AIX] Fix LIT failure on native aix

Xiangling_L updated this revision to Diff 346308. Xiangling_L added a comment. Add comments to the block; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102715/new/ https://reviews.llvm.org/D102715 Files: clang/test/Sema/struct-packed-align.c Index:

[PATCH] D102715: [AIX] Fix LIT failure on native aix

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, sfertile, jasonliu, daltenty. Xiangling_L requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0921655b1ff: [AIX] Implement AIX special bitfield related alignment rules (authored by Xiangling_L). Changed prior to commit:

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L updated this revision to Diff 345530. Xiangling_L added a comment. Rebased on the latest master and updated the testcase accordingly; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87029/new/ https://reviews.llvm.org/D87029 Files: clang/lib/AST/RecordLayoutBuilder.cpp

[PATCH] D99291: [AIX] Support init priority attribute

This revision was automatically updated to reflect the committed changes. Xiangling_L marked an inline comment as done. Closed by commit rGd5085617986e: [AIX] Support init priority attribute (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99291: [AIX] Support init priority attribute

Xiangling_L marked an inline comment as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:663 + // Create our global prioritized cleanup function. + if (!PrioritizedCXXStermFinalizers.empty()) { jasonliu wrote: > Just

[PATCH] D99291: [AIX] Support init priority attribute

Xiangling_L updated this revision to Diff 58. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Add assertion to make sure we have correct priority value in range; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99291/new/ https://reviews.llvm.org/D99291

[PATCH] D99291: [AIX] Support init priority attribute

Xiangling_L created this revision. Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast, ZarkoCA, xingxue. Herald added a reviewer: aaron.ballman. Xiangling_L requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

Xiangling_L updated this revision to Diff 330415. Xiangling_L added a comment. Bring back two forward declarations to avoid changing pervasive `SmallVector` to `llvm::SmallVector` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98552/new/ https://reviews.llvm.org/D98552 Files:

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

Xiangling_L added inline comments. Comment at: clang/include/clang/Basic/LLVM.h:71 using llvm::SmallString; - using llvm::SmallVector; - using llvm::SmallVectorImpl; It's my bad to not wait for a build finished before updating the patch, I saw a lot of

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

Xiangling_L updated this revision to Diff 330369. Xiangling_L marked 2 inline comments as done. Xiangling_L added a comment. Herald added a subscriber: jansvoboda11. Addressed the comments; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98552/new/

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

Xiangling_L marked 2 inline comments as done. Xiangling_L added inline comments. Comment at: clang/include/clang/Basic/LLVM.h:25 #include "llvm/ADT/None.h" +// Add this header as a workaround to unblock the XL build compiler issue. +#include "llvm/ADT/SmallVector.h"

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

Xiangling_L added a comment. In D98552#2623399 , @jsji wrote: > If we use this workaround, can we also revert > 561fb7f60ab631e712c3fb6bbeb47061222c6818 > and >

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

Xiangling_L created this revision. Xiangling_L added reviewers: rzurob, hubert.reinterpretcast, jsji, lei, cebowleratibm. Herald added a subscriber: dexonsmith. Xiangling_L requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously we

[PATCH] D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG561fb7f60ab6: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX (authored by Xiangling_L). Repository: rG LLVM Github Monorepo

[PATCH] D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX

Xiangling_L added a comment. In D98265#2614245 , @craig.topper wrote: > Maybe this needs to be addressed in the forward declaration in > clang/include/clang/Basic/LLVM.h ? Yeah, adding an additional llvm namespace is a certain another way to

[PATCH] D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX

Xiangling_L created this revision. Xiangling_L added reviewers: daltenty, hubert.reinterpretcast, cebowleratibm, jsji, Whitney. Xiangling_L requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LLVM is recommending to use SmallVector (that is,

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87029/new/ https://reviews.llvm.org/D87029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b1e2fc89327: [FE] Manipulate the first byte of guard variable type in both load and store… (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

Xiangling_L added inline comments. Comment at: clang/test/CodeGenCXX/global-init.cpp:84 // CHECK-NEXT: store i32 [[CALL]], i32* @_ZN5test41xE - // CHECK-NEXT: store i64 1, i64* @_ZGVN5test41xE + // CHECK-NEXT: store i8 1, i8* bitcast (i64* @_ZGVN5test41xE to i8*)

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

Xiangling_L updated this revision to Diff 320881. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Addressed the comments related to test formatting; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95822/new/ https://reviews.llvm.org/D95822 Files:

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

Xiangling_L updated this revision to Diff 320879. Xiangling_L marked 2 inline comments as done. Xiangling_L added a comment. Remove redundant file; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95822/new/ https://reviews.llvm.org/D95822 Files: clang/lib/CodeGen/ItaniumCXXABI.cpp

[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

Xiangling_L marked 2 inline comments as done. Xiangling_L added inline comments. Comment at: clang/test/CodeGenCXX/global-init.cpp:84 // CHECK-NEXT: store i32 [[CALL]], i32* @_ZN5test41xE - // CHECK-NEXT: store i64 1, i64* @_ZGVN5test41xE + // CHECK-NEXT: store i8 1, i8*

[PATCH] D95822: [FE][AIX] Use i8 as guard variable type in both load and store operation

Xiangling_L marked 2 inline comments as done. Xiangling_L added inline comments. Comment at: clang/test/CodeGenCXX/aix-static-init-temp-spec-and-inline-var.cpp:193 // CHECK: %1 = call i32 @atexit(void ()* @__dtor__ZN5test12t1IiEE) -// CHECK: store i64 1, i64*

[PATCH] D95822: [FE][AIX] Use i8 as guard variable type in both load and store operation

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, jasonliu, abhina.sreeskantharajan. Herald added a subscriber: jfb. Xiangling_L requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For static init, use i8

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

This revision was automatically updated to reflect the committed changes. Xiangling_L marked 8 inline comments as done. Closed by commit rGf0abe2aeaca7: [Frontend] Add pragma align natural and sort out pragma pack stack effect (authored by Xiangling_L). Changed prior to commit:

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L updated this revision to Diff 315855. Xiangling_L marked 4 inline comments as done. Xiangling_L added a comment. Rebased on latest master; Addressed the comments; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87702/new/ https://reviews.llvm.org/D87702 Files:

[PATCH] D93901: [NFC] Renaming PackStack to AlignPackStack

This revision was automatically updated to reflect the committed changes. Closed by commit rGe97071d79520: [NFC] Renaming PackStack to AlignPackStack (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93901/new/

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L updated this revision to Diff 315126. Xiangling_L marked 5 inline comments as done. Xiangling_L added a comment. Addressed the comments; Rebased the patch on latest master; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87702/new/ https://reviews.llvm.org/D87702 Files:

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L marked 9 inline comments as done. Xiangling_L added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:893 +def warn_pragma_pack_identifer_not_supported : Warning< + "specifying an identifier within pragma pack is not supported, identifier

[PATCH] D93901: [NFC] Renaming PackStack to AlignPackStack

Xiangling_L updated this revision to Diff 314911. Xiangling_L marked 3 inline comments as done. Xiangling_L added a comment. Add pre-committing tests with the incorrect behaviour as part of the NFC patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93901/new/

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L updated this revision to Diff 314141. Xiangling_L marked 6 inline comments as done. Xiangling_L added a comment. - used memcpy to burn AlignPackInfo into uint32_t and vice versa; - named XL on AIX stack effect and related options after "xl" instead of "aix" - adjusted natural align

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L updated this revision to Diff 313986. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Rebase on renaming NFC patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87702/new/ https://reviews.llvm.org/D87702

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L marked 2 inline comments as done. Xiangling_L added inline comments. Comment at: clang/include/clang/Sema/Sema.h:637 PragmaStack VtorDispStack; - // #pragma pack. - // Sentinel to represent when the stack is set to mac68k alignment. - static const unsigned

[PATCH] D93901: [NFC] Renaming PackStack to AlignPackStack

Xiangling_L created this revision. Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast, efriedma, jyknight, aaron.ballman. Xiangling_L requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch renames `PackStack` and related

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L added inline comments. Comment at: clang/test/Layout/aix-bitfield-alignment.cpp:1 +// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -fdump-record-layouts \ +// RUN: -fsyntax-only -faix-pragma-pack -x c++ %s | \ sfertile wrote: > I suggest we

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L updated this revision to Diff 308648. Xiangling_L marked 3 inline comments as done. Xiangling_L added a comment. Split testcases; Simplified code; Don't need to respect attribute align within typedef when the alignment value is less than bitcontainer size; CHANGES SINCE LAST ACTION

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L updated this revision to Diff 308065. Xiangling_L added a comment. Adjusted the logic of operator == for class AlignPackInfo; Removed mac68k sentinel; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87702/new/ https://reviews.llvm.org/D87702 Files:

[PATCH] D92117: [AIX] Enabling vector types for AIX

Xiangling_L accepted this revision. Xiangling_L added a comment. This revision is now accepted and ready to land. Just a minor suggestion: Maybe `Enabling return and argument vector types for AIX` is more accurate. Otherwise, LGTM. Comment at:

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L updated this revision to Diff 307685. Xiangling_L added a comment. Update the logic to tell if two AlignPackInfo are equal; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87702/new/ https://reviews.llvm.org/D87702 Files: clang/include/clang/Basic/Attr.td

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L added inline comments. Comment at: clang/include/clang/Sema/Sema.h:637 PragmaStack VtorDispStack; - // #pragma pack. - // Sentinel to represent when the stack is set to mac68k alignment. - static const unsigned kMac68kAlignmentSentinel = ~0U; - PragmaStack

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L updated this revision to Diff 307617. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Herald added a subscriber: dexonsmith. Addressed the comments; Handle PCH for AIX; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87702/new/

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

Xiangling_L accepted this revision. Xiangling_L added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89684/new/ https://reviews.llvm.org/D89684 ___ cfe-commits mailing list

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4624 + + if (Triple.isOSAIX()) { +if (Args.hasArg(options::OPT_maltivec) && line 4624 to line 4635 can be simplified to : ``` if (Triple.isOSAIX() &&

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

Xiangling_L added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:186 LANGOPT(PPCIEEELongDouble, 1, 0, "use IEEE 754 quadruple-precision for long double") +LANGOPT(EnableAIXExtendedAltivecABI, 1, 0, "__EXTABI__ predefined macro")

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

Xiangling_L added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1443 + if (Arg *A = + Args.getLastArg(OPT_mabi_EQ_vec_default, OPT_mabi_EQ_vec_extabi)) { ZarkoCA wrote: > Xiangling_L wrote: > > Should we also check if target

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4616 + if (Args.hasArg(options::OPT_maltivec) && + (Triple.isOSAIX() || Triple.isOSBinFormatXCOFF())) { +for (const Arg *A : Args) { ZarkoCA wrote: > Xiangling_L

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG17497ec514f7: [AIX][FE] Support constructor/destructor attribute (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4616 + if (Args.hasArg(options::OPT_maltivec) && + (Triple.isOSAIX() || Triple.isOSBinFormatXCOFF())) { +for (const Arg *A : Args) { I am wondering what cases are not

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L updated this revision to Diff 305526. Xiangling_L marked 2 inline comments as done. Xiangling_L added a comment. Update testcases; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https://reviews.llvm.org/D90892 Files: clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L marked 5 inline comments as done. Xiangling_L added inline comments. Comment at: clang/test/CodeGen/aix-constructor-attribute.cpp:8 -int foo() __attribute__((constructor(180))); +// CHECK: @llvm.global_ctors = appending global [3 x { i32, void ()*, i8* }] [{ i32,

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e407afd9bd3: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link… (authored by Xiangling_L). Changed prior to commit: https://reviews.llvm.org/D91361?vs=305160=305501#toc

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

Xiangling_L updated this revision to Diff 305160. Xiangling_L added a comment. Remove the `if` condition and tweak the comments; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91361/new/ https://reviews.llvm.org/D91361 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:137 -if (D.CCCIsCXX()) +if (D.CCCIsCXX() || D.CCCIsCC()) CmdArgs.push_back(Args.MakeArgString( daltenty wrote: > I think that rather that adding CC, we should

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L updated this revision to Diff 304896. Xiangling_L added a comment. Fix minor issues in the testcase; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https://reviews.llvm.org/D90892 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CodeGenFunction.h

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

Xiangling_L created this revision. Xiangling_L added reviewers: daltenty, hubert.reinterpretcast, stevewan, xingxue. Herald added a project: clang. Herald added a subscriber: cfe-commits. Xiangling_L requested review of this revision. In order to support __attribute__((__constructor__)) and

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L updated this revision to Diff 304616. Xiangling_L added a comment. Add testcases to both CodeGen and CodeGenCXX folder; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https://reviews.llvm.org/D90892 Files:

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L added a comment. In D90892#2386908 , @aaron.ballman wrote: > I think this generally seems reasonable, but I'm far from an AIX expert so > you should wait a few days in case other reviewers have feedback. Thanks for reviews. And @sfertile

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L updated this revision to Diff 304256. Xiangling_L added a comment. Address comments; Move testcases to CodeGen folder instead of CodeGenCXX since ctor/dtor attribute should work in both C++ mode; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L marked 2 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + void AddGlobalDtor(llvm::Function *Dtor, int Priority = 65535, + bool IsDtorAttrFunc = false);

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L marked 5 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + void AddGlobalDtor(llvm::Function *Dtor, int Priority = 65535, + bool IsDtorAttrFunc = false);

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L marked 6 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + void AddGlobalDtor(llvm::Function *Dtor, int Priority = 65535, + bool IsDtorAttrFunc = false);

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L updated this revision to Diff 303272. Xiangling_L added a comment. Remove unused function parameters; Move testcases to CodeGenCXX folder; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https://reviews.llvm.org/D90892 Files: clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, jasonliu, yusra.syeda, aaron.ballman, sfertile, hfinkel. Herald added a project: clang. Herald added a subscriber: cfe-commits. Xiangling_L requested review of this revision. Support

[PATCH] D90187: [NFC] Remove max_align.c LIT testcase

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG357715ce97d0: [NFC] Remove max_align.c LIT testcase (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90063: [AIX] Also error on -G for link-only step

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d4aebbb9d99: [AIX] Also error on -G for link-only step (authored by Xiangling_L). Changed prior to commit: https://reviews.llvm.org/D90063?vs=300391=300782#toc Repository: rG LLVM Github Monorepo

[PATCH] D90187: [NFC] Remove max_align.c LIT testcase

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, jasonliu, daltenty. Herald added a project: clang. Herald added a subscriber: cfe-commits. Xiangling_L requested review of this revision. Since we fixed the definition of `SuitableAlign` here:

[PATCH] D90063: [AIX] Also error on -G for link-only step

Xiangling_L updated this revision to Diff 300391. Xiangling_L added a comment. Fixed the duplication in the testcase; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90063/new/ https://reviews.llvm.org/D90063 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D89910: [AIX] Let alloca return 16 bytes alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG05bef88eb3ec: [AIX] Let alloca return 16 bytes alignment (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89910/new/

[PATCH] D90063: [AIX] Also error on -G for link-only step

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, daltenty, jasonliu. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. Xiangling_L requested review of this revision. The change in [[ https://reviews.llvm.org/D89897 |

[PATCH] D89897: [AIX] Emit error for -G option on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ba98433971f: [AIX] Emit error for -G option on AIX (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89897/new/

[PATCH] D88659: [NFC] Fix the definition of SuitableAlign

Xiangling_L closed this revision. Xiangling_L added a comment. Manually close the revision after landing it upstream. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88659/new/ https://reviews.llvm.org/D88659 ___ cfe-commits mailing list

[PATCH] D89910: [AIX] Let alloca return 16 bytes alignment

Xiangling_L updated this revision to Diff 300043. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Add one case to the test; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89910/new/ https://reviews.llvm.org/D89910 Files: clang/lib/Basic/Targets/PPC.h

[PATCH] D89910: [AIX] Let alloca return 16 bytes alignment

Xiangling_L marked an inline comment as done. Xiangling_L added inline comments. Comment at: clang/test/CodeGen/aix_alloca_align.c:11 +void foo() { + char *ptr1 = (char *)alloca(sizeof(char) * 9); +} hubert.reinterpretcast wrote: > I'm not entirely sure, but

[PATCH] D89897: [AIX] Emit error for -G option on AIX

Xiangling_L updated this revision to Diff 21. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Fix the formatting issues; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89897/new/ https://reviews.llvm.org/D89897 Files:

[PATCH] D89897: [AIX] Emit error for -G option on AIX

Xiangling_L marked 3 inline comments as done. Xiangling_L added inline comments. Comment at: clang/test/Driver/aix-err-options.c:1 +// RUN: %clang -target powerpc32-ibm-aix-xcoff -### -S -emit-llvm -G 0 2>&1 %s | \ +// RUN: FileCheck -check-prefix=CHECK32 %s

[PATCH] D89910: [AIX] Let alloca return 16 bytes alignment

Xiangling_L updated this revision to Diff 299975. Xiangling_L marked 3 inline comments as done. Xiangling_L added a comment. Fixed the testcase formatting issues; Fixed the `BIGGEST_ALIGNMENT` value in testcases; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89910/new/

[PATCH] D89897: [AIX] Emit error for -G option on AIX

Xiangling_L marked an inline comment as done. Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4924 + if (RawTriple.isOSAIX()) +if (Arg *A = Args.getLastArg(options::OPT_G)) { jasonliu wrote: > Question: When do we

[PATCH] D89910: [AIX] Let alloca return 16 bytes alignment

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, jasonliu, ZarkoCA. Herald added subscribers: cfe-commits, dexonsmith, kbarton, nemanjai. Herald added a project: clang. Xiangling_L requested review of this revision. On AIX, to support vector types, which

[PATCH] D89897: [AIX] Emit error for -G option on AIX

Xiangling_L created this revision. Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast, daltenty. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. Xiangling_L requested review of this revision. 1. Emit error for -G driver option on AIX 2.

[PATCH] D88659: [FE]Split SuitableAlign into two parts

Xiangling_L updated this revision to Diff 299404. Xiangling_L added a comment. Herald added a subscriber: dexonsmith. Edit the definition of `SuitableAlign`; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88659/new/ https://reviews.llvm.org/D88659 Files:

[PATCH] D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs.

Xiangling_L added inline comments. Herald added a subscriber: dexonsmith. Comment at: llvm/lib/CodeGen/CommandFlags.cpp:489 Options.FloatABIType = getFloatABIForCalls(); + Options.AIXExtendedAltivecABI = getAIXExtendedAltivecABI(); Options.NoZerosInBSS =

[PATCH] D88659: [FE]Split SuitableAlign into two parts

Xiangling_L added a comment. Hi @jyknight , are you okay with us changing the "definition" of SuitableAlign without sending a note to the mailing list? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88659/new/ https://reviews.llvm.org/D88659

[PATCH] D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs.

Xiangling_L added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2868 +Only supported On AIX. Specify usage of volatile and nonvolatile vector registers, the extended vector ABI on AIX. Defaults to '-mnovecnvol' when Altivec is enabled. +

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI and add clang and llvm option

Xiangling_L added a comment. I am wondering can we split the option related changes to a separate patch for reviews? That would make current patch a bit easier to review and faster to be committed as two small pieces. If it's possible, I am thinking we can try to split it up to the following

[PATCH] D88659: [FE]Split SuitableAlign into two parts

Xiangling_L added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88659/new/ https://reviews.llvm.org/D88659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L marked 8 inline comments as done. Xiangling_L added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:340 +LANGOPT(AIXPragmaPack, 1, 0, "AIX #pragma pack handling") + jasonliu wrote: > Not sure if AIXPragmaPack is the best name

[PATCH] D89064: [AIX] Support two itanium alignment LIT testcases for AIX using regex

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c10d6508f54: [AIX] Support two itanium alignment LIT testcases for AIX using regex (authored by Xiangling_L). Changed prior to commit: https://reviews.llvm.org/D89064?vs=297848=297950#toc Repository:

[PATCH] D89064: [AIX] Disable two itanium alignment LIT testcases

Xiangling_L updated this revision to Diff 297848. Xiangling_L added a comment. Use regex to match AIX layout dumping format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89064/new/ https://reviews.llvm.org/D89064 Files: clang/test/Layout/itanium-pack-and-align.cpp

[PATCH] D89064: [AIX] Disable two itanium alignment LIT testcases

Xiangling_L added a comment. In D89064#2320133 , @hubert.reinterpretcast wrote: > Can we use a regex to make this also work in AIX? Sure we can also do that. May I ask is that because we prefer letting AIX support as many LIT testcases as possible?

[PATCH] D89064: [AIX] Disable two itanium alignment LIT testcases

Xiangling_L created this revision. Xiangling_L added reviewers: daltenty, hubert.reinterpretcast, stevewan. Herald added a project: clang. Herald added a subscriber: cfe-commits. Xiangling_L requested review of this revision. AIX has different layout dumping format from other itanium abis. And

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L updated this revision to Diff 296972. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Remove emit errors for oversized long long bitfield and related testcase; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87029/new/

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L marked an inline comment as done. Xiangling_L added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:16447 + +bool AIXBitfieldViolation = false; +if (const BuiltinType *BTy = FieldTy.getTypePtr()->getAs()) { sfertile wrote: >

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L updated this revision to Diff 296497. Xiangling_L marked 4 inline comments as done. Xiangling_L added a comment. - Fixed the bug of getting underlying type of enum; - Fixed the bug to respect align attribute; - Add more testcases; Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:16447 + +bool AIXBitfieldViolation = false; +if (const BuiltinType *BTy = FieldTy.getTypePtr()->getAs()) { sfertile wrote: > Can this change can be split out into its own patch?

  1   2   3   >