[PATCH] D101139: Create install targets for scan-build-py.

2021-05-13 Thread Yu Shan via Phabricator via cfe-commits
aabbaabb updated this revision to Diff 345329. aabbaabb added a comment. put libs in 'lib' folder, 'analyze-*' and 'scan-*' compiler wrappers to 'libexec', also copy the resources in 'libscanbuild' Tests: To install: DESTDIR=${INSTALL_DIR} ninja install-scan-build-py -j1000 Test at source

[PATCH] D101139: Create install targets for scan-build-py.

2021-05-12 Thread Yu Shan via Phabricator via cfe-commits
aabbaabb updated this revision to Diff 344904. aabbaabb marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/tools/CMakeLists.txt

[PATCH] D101139: Create install targets for scan-build-py.

2021-05-06 Thread Yu Shan via Phabricator via cfe-commits
aabbaabb updated this revision to Diff 343541. aabbaabb marked 3 inline comments as done. aabbaabb added a comment. Renamed lib to libexec and add custom rules to copy files to build output. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139

[PATCH] D101139: Create install targets for scan-build-py.

2021-05-03 Thread Yu Shan via Phabricator via cfe-commits
aabbaabb marked an inline comment as done. aabbaabb added inline comments. Comment at: clang/tools/scan-build-py/CMakeLists.txt:8 + "bin/intercept-cc" + "bin/scan-build") + wanders wrote: > This overwrites the "bin/scan-build" that was installed from the

[PATCH] D101139: Create install targets for scan-build-py.

2021-05-03 Thread Yu Shan via Phabricator via cfe-commits
aabbaabb updated this revision to Diff 342529. aabbaabb added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Rename scan-build to scan-build-py during install to prevent overwriting pearl implementation. CHANGES SINCE LAST ACTION

[PATCH] D101139: Create install targets for scan-build-py.

2021-04-28 Thread Yu Shan via Phabricator via cfe-commits
aabbaabb added a comment. In D101139#2721880 , @phosek wrote: > In D101139#2718112 , @aabbaabb > wrote: > >> In D101139#2718057 , @phosek wrote: >> >>> In

[PATCH] D101139: Create install targets for scan-build-py.

2021-04-28 Thread Yu Shan via Phabricator via cfe-commits
aabbaabb updated this revision to Diff 341352. aabbaabb edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/tools/CMakeLists.txt

[PATCH] D101139: Create install targets for scan-build-py.

2021-04-26 Thread Yu Shan via Phabricator via cfe-commits
aabbaabb added a comment. In D101139#2718057 , @phosek wrote: > In D101139#2713530 , @aabbaabb > wrote: > >> The python script assumes relative directory while finding things. For >> example, for resources

[PATCH] D101139: Create install targets for scan-build-py.

2021-04-23 Thread Yu Shan via Phabricator via cfe-commits
aabbaabb added a comment. In D101139#2713450 , @phosek wrote: > I don't think this is sufficient. First, we want to be explicit and always > list individual files to install, we don't use patterns. Second, since > libscanbuild is a library, it

[PATCH] D101139: Create install targets for scan-build-py.

2021-04-23 Thread Yu Shan via Phabricator via cfe-commits
aabbaabb added a comment. The python script assumes relative directory while finding things. For example, for resources folder, it uses os.path.join(this_dir, 'resources') in report.py, which means resource need to be in the same dir as report.py. Similarly for the libscanbuild. it assumes the

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

2020-11-02 Thread Yu Shan via Phabricator via cfe-commits
aabbaabb added a comment. I think there are also some patches that only exist here not on that repo so there is no strict upstream/downstream, just two forked versions. Since in our use case, we would likely use this version instead of the python version (easier to update/maintain), I suggest

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

2020-11-02 Thread Yu Shan via Phabricator via cfe-commits
aabbaabb added a comment. kindly ping for help to submit this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90362/new/ https://reviews.llvm.org/D90362 ___ cfe-commits mailing list

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

2020-10-29 Thread Yu Shan via Phabricator via cfe-commits
aabbaabb added a comment. Gabor or Petr, Can any one of you help me commit this change? Not sure if I could commit myself. In D90362#2361400 , @xazax.hun wrote: > I know that the current situation is a mess, but there is an alternative > version of

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

2020-10-29 Thread Yu Shan via Phabricator via cfe-commits
aabbaabb added a comment. Differential Revision: https://reviews.llvm.org/D90362 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90362/new/ https://reviews.llvm.org/D90362 ___ cfe-commits mailing list

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

2020-10-28 Thread Yu Shan via Phabricator via cfe-commits
aabbaabb created this revision. aabbaabb added reviewers: xazax.hun, phosek. Herald added subscribers: cfe-commits, rnkovacs, whisperity. Herald added a project: clang. aabbaabb requested review of this revision. Excluded folders in scan build is turned to absolute path before comapre to 'file'