[PATCH] D154301: Fix aggregate CTAD with string literals adding extra const

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92f4bf268998: Fix aggregate CTAD with string literals adding extra const (authored by MitalAshok, committed by ychen). Repository: rG LLVM Github

[PATCH] D154301: Fix aggregate CTAD with string literals adding extra const

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. LGTM. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154301/new/ https://reviews.llvm.org/D154301

[PATCH] D154301: Fix aggregate CTAD with string literals adding extra const

ychen added a comment. `clang/test/SemaTemplate/aggregate-deduction-candidate.cpp` seems need updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154301/new/ https://reviews.llvm.org/D154301 ___

[PATCH] D154301: Fix aggregate CTAD with string literals adding extra const

ychen added a comment. Thanks for catching this. The change LGTM. I think this is https://wg21.link/cwg2681. Could you please move the test to `clang/test/CXX/drs/dr26xx.cpp` and keep only these tests that are in the DR? Then you could run `clang/www/make_cxx_dr_status` to update

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG632dd6a4ca00: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1 (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 535936. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclBase.h

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added a comment. In D139837#4460664 , @cor3ntin wrote: > Thanks a lot for working on this! > Do you need Aaron or myself to commit this for you? If so, which name / mail > do you want us to use? That's okay. I'm doing the rebase and I could

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added inline comments. Comment at: clang/docs/ReleaseNotes.rst:98 +- Implemented `P1816R0: `_ and `P2082R1: `_, + which allows CTAD for aggregates (parenthesized aggregate-initialization is not supported).

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 535883. ychen marked 4 inline comments as done. ychen added a comment. - address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files:

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 535132. ychen marked 3 inline comments as done. ychen added a comment. - address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files:

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 534778. ychen added a comment. - add a DeductionCandidate parameter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files: clang/docs/ReleaseNotes.rst

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added a comment. In D139837#4449327 , @cor3ntin wrote: > @ychen You probably want to update the description, i think it's updated (you > implemented ctad for parenthesized ctrs) Thanks for the remainder, Corentin. Hopefully, this will be ready to

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 534601. ychen added a comment. - remove extra headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files: clang/docs/ReleaseNotes.rst

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1987 + void setDeductionCandidateKind(DeductionCandidateKind K) { +FunctionDeclBits.DeductionCandidateKind = static_cast(K); } shafik wrote: > aaron.ballman wrote: > > Er, seems a

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 533674. ychen marked 7 inline comments as done. ychen added a comment. - address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files:

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen marked an inline comment as done. ychen added inline comments. Comment at: clang/test/SemaTemplate/aggregate-deduction-candidate.cpp:101 + + template struct E { +T t; shafik wrote: > I would also like to see this test: > > ``` > template > struct I

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 530057. ychen added a comment. - add one extra test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files: clang/docs/ReleaseNotes.rst

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added a comment. In D139837#4401134 , @cor3ntin wrote: > I think this looks good but I'll let @aaron.ballman do the final approval. Thanks for the review @cor3ntin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1059-1062 +case CodeSynthesisContext::BuildingDeductionGuides: + assert( + false && + "failed building deduction guides, add meaningful diagnostics here");

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 528918. ychen added a comment. - address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files: clang/docs/ReleaseNotes.rst

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:1689 +/// (used during overload resolution). +uint64_t DeductionCandidateKind : 2; aaron.ballman wrote: > Best not to give this the same name as a type (I don't care which one

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 528268. ychen marked 14 inline comments as done. ychen added a comment. - address existing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files:

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 524045. ychen added a comment. - fix - Address comments - fix - - adjust test check for Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files:

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 521978. ychen added a comment. - Fix bitfield on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files: clang/docs/ReleaseNotes.rst

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 521965. ychen marked an inline comment as done. ychen added a comment. - add release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files:

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 521964. ychen added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files: clang/include/clang/AST/DeclBase.h clang/include/clang/AST/DeclCXX.h

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 521963. ychen marked 3 inline comments as done. ychen added a comment. Address all comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files:

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen marked 9 inline comments as done. ychen added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:10338 +Context.getRValueReferenceType(ElementTypes[i]); + else if (isa(ListInit->getInit(i))) +// This deviates from the

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added a comment. Sorry for the long delay guys. I'll update the patch this weekend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 ___ cfe-commits

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

ychen abandoned this revision. ychen added a comment. Superseded by D127233 , D127259 , rG7f8d844df5e9 Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe423885e272c: [CodeGen] guarantee templated static variables are initialized in the reverse… (authored by ychen). Repository: rG LLVM Github

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

ychen updated this revision to Diff 502068. ychen added a comment. This revision is now accepted and ready to land. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127259/new/ https://reviews.llvm.org/D127259 Files:

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

ychen added a comment. In D127259#4156314 , @erichkeane wrote: > I don't see much compile-time concerns myself, Indeed.

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added a comment. In D139837#4067208 , @ayzhao wrote: > Thanks for your effort on this! > > FYI I landed parenthesized aggregate initialization in D141546 > , so CTAD for that feature should no longer > be

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 483735. ychen added a comment. - update cxx_status.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files: clang/include/clang/AST/DeclBase.h

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added a comment. In D139837#3989814 , @cor3ntin wrote: > Hey. Thanks a lot for working on this. > I did a first pass, looking at mostly style issues, looking at conformance > will probably take me a lot more time, but i think this looks pretty

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 482331. ychen marked 2 inline comments as done. ychen added a comment. - Address Corentin's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files:

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen updated this revision to Diff 482088. ychen added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 Files: clang/include/clang/AST/DeclBase.h clang/include/clang/AST/DeclCXX.h

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen created this revision. ychen added reviewers: aaron.ballman, erichkeane, rsmith. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D136120: [Clang] follow-up D128745, remove ClangABICompat checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG40e99473170f: [Clang] follow-up D128745, remove ClangABICompat checks (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136120/new/

[PATCH] D136120: [Clang] follow-up D128745, remove ClangABICompat checks

ychen updated this revision to Diff 472727. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136120/new/ https://reviews.llvm.org/D136120 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateDeduction.cpp

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

ychen accepted this revision as: ychen. ychen added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136975/new/ https://reviews.llvm.org/D136975 ___ cfe-commits mailing list

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

ychen added a comment. In D136975#3899717 , @erichkeane wrote: > In D136975#3899703 , @ychen wrote: > >> Thanks for the patch. It looks good to me. >> >> About >> >>> Note that we DO need to be careful to make

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

ychen added a comment. Thanks for the patch. It looks good to me. About > Note that we DO need to be careful to make sure we still check > constraints properly that are caused by a previous constraint, but not > derived from (such as when a check causes us to check special member > function

[PATCH] D136545: [Clang] use non-instantiated function declaration for constraints partial ordering

This revision was automatically updated to reflect the committed changes. Closed by commit rGe18c2c5548f6: [Clang] use non-instantiated function declaration for constraints partial… (authored by ychen). Changed prior to commit: https://reviews.llvm.org/D136545?vs=470546=471902#toc Repository:

[PATCH] D136744: [Clang] perform "maximum TLS alignment" check for template instantiation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d086cce8b92: [Clang] perform maximum TLS alignment check for template instantiation (authored by ychen). Repository: rG LLVM Github Monorepo

[PATCH] D136744: [Clang] perform "maximum TLS alignment" check for template instantiation

ychen added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14038-14039 + + if (!Context.getTargetInfo().isTLSSupported()) +return; + mizvekov wrote: > Is this needed? It seems `getMaxTLSAlign()` will return 0 in that case anyway. It is checked in

[PATCH] D136744: [Clang] perform "maximum TLS alignment" check for template instantiation

ychen updated this revision to Diff 470858. ychen added a comment. Herald added a reviewer: aaron.ballman. - remove unnecessary check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136744/new/ https://reviews.llvm.org/D136744 Files:

[PATCH] D136744: [Clang] perform "maximum TLS alignment" check for template instantiation

ychen created this revision. ychen added reviewers: probinson, mizvekov. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. follow up d30e2eefc3cf8dfd2210aefd62f13a6e7c011b43 Repository: rG LLVM Github

[PATCH] D136545: [Clang] use non-instantiated function declaration for constraints partial ordering

ychen updated this revision to Diff 470546. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136545/new/ https://reviews.llvm.org/D136545 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaConcept.cpp

[PATCH] D136545: [Clang] use non-instantiated function declaration for constraints partial ordering

ychen added inline comments. Comment at: clang/test/CXX/over/over.match/over.match.best/p2.cpp:10 }; - bool k1 = A() < A(); // not ordered by constraints: prefer non-rewritten form - bool k2 = A() < A(); // prefer more-constrained 'operator<=>' erichkeane

[PATCH] D136545: [Clang] use non-template function declaration for constraints partial ordering

ychen added a comment. In D136545#3877899 , @royjacobson wrote: > LGTM, thanks for picking it up! I wonder how much effect this has on > compilation times given that `SubsumptionCache` caches subsumption by the > `Decl *` pair... It seems neutral

[PATCH] D136545: [Clang] use non-template function declaration for constraints partial ordering

ychen updated this revision to Diff 470374. ychen marked an inline comment as done. ychen added a comment. - do the same when 1. taking the address of a non-template function 2. computing SMF eligibility. - restore removed test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

ychen added inline comments. Comment at: clang/include/clang/Sema/Sema.h:2569 + enum class TypeAccessKind { Explicit, Implicit, Typename }; + QualType getTypeDeclType(DeclContext *LookupCtx, TypeAccessKind AK, mizvekov wrote: > ychen wrote: > > I find it

[PATCH] D136120: [Clang] follow-up D128745, remove ClangABICompat checks

ychen added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136120/new/ https://reviews.llvm.org/D136120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

ychen added a comment. Looks straightforward to me with one suggestion. Is the CI fail related? Comment at: clang/include/clang/Sema/Sema.h:2569 + enum class TypeAccessKind { Explicit, Implicit, Typename }; + QualType getTypeDeclType(DeclContext *LookupCtx, TypeAccessKind

[PATCH] D136545: [Clang] use non-template function declaration for constraints partial ordering

ychen updated this revision to Diff 469963. ychen added a comment. - add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136545/new/ https://reviews.llvm.org/D136545 Files: clang/docs/ReleaseNotes.rst

[PATCH] D136545: [Clang] use non-template function declaration for constraints partial ordering

ychen added inline comments. Comment at: clang/test/CXX/over/over.match/over.match.best/p2.cpp:10 }; - bool k1 = A() < A(); // not ordered by constraints: prefer non-rewritten form - bool k2 = A() < A(); // prefer more-constrained 'operator<=>' Remove this

[PATCH] D136545: [Clang] use non-template function declaration for constraints partial ordering

ychen created this revision. ychen added reviewers: erichkeane, royjacobson, mizvekov. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per wordings in -

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added inline comments. Comment at: clang/test/CXX/over/over.match/over.match.best/p1-2a.cpp:106 template - constexpr int goo(const int b) requires AtLeast2 { + constexpr int goo(const int b) requires AtLeast2 { // expected-note {{candidate function}} return 2;

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG340eac01f7da: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained… (authored by ychen). Repository: rG LLVM Github Monorepo

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. @mizvekov Thanks for the review and provided valuable feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 ___ cfe-commits mailing

[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6bca52be0349: [Clang] update cxx_dr_status.html by running make_cxx_dr_status (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status

ychen updated this revision to Diff 468631. ychen added a comment. - DR2565 is fully implemented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136133/new/ https://reviews.llvm.org/D136133 Files: clang/test/CXX/drs/dr25xx.cpp

[PATCH] D136120: [Clang] follow-up D128745, remove ClangABICompat checks

ychen updated this revision to Diff 468630. ychen added a comment. - update Release notes - remove obsolete CodeGen tests which was used to test ClangABICompat checks, similar Sema tests are already in place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status

ychen added inline comments. Comment at: clang/test/CXX/drs/dr25xx.cpp:3 -namespace dr2565 { // dr252: 16 +namespace dr2565 { // dr2565: partial template erichkeane wrote: > If you could add a comment explaining this status for me, I would be grateful: > >

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. In D128750#3864612 , @mizvekov wrote: > Is the pre-commit CI failure here related to the patch? Seems not. It should've been fixed by 606245ad542491400a5475c796df86a99f5c8c12

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 468602. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclTemplate.h

[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status

ychen updated this revision to Diff 468430. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136133/new/ https://reviews.llvm.org/D136133 Files: clang/test/CXX/drs/dr25xx.cpp clang/test/CXX/drs/dr2xx.cpp

[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status

ychen created this revision. ychen added reviewers: royjacobson, erichkeane. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For https://github.com/llvm/llvm-project/issues/58382 Repository: rG LLVM

[PATCH] D136120: [Clang] follow-up D128745, remove all ClangABICompat checks

ychen created this revision. ychen added reviewers: aaron.ballman, erichkeane, hubert.reinterpretcast. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per discussions in D128745

[PATCH] D134507: [Clang] add missing ClangABICompat check

ychen added a comment. In D134507#3856956 , @tahonermann wrote: >> Per further discussions in D128745 , this >> is not needed. > > I agree that the code change is not needed. I think it is worth keeping the > test

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5511-5539 + template ::value, bool> = true> + bool operator()(T1 *PS1, T2 *PS2) { +return hasEqualTemplateArgumentList( +PS1->getTemplateArgsAsWritten()->arguments(), +

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 468286. ychen added a comment. - use getTemplateArgs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clang/docs/ReleaseNotes.rst

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5511-5539 + template ::value, bool> = true> + bool operator()(T1 *PS1, T2 *PS2) { +return hasEqualTemplateArgumentList( +PS1->getTemplateArgsAsWritten()->arguments(), +

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 467845. ychen added a comment. - skip non-dependent NTTP comparison because they're equivalent (match GCC) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files:

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. In D128750#3854675 , @hubert.reinterpretcast wrote: >> I reached out to the GCC author to confirm that the committee acknowledges >> that there should be a change to temp.func.order p6.2.1, but no consensus on >> what changes to

[PATCH] D134507: [Clang] add missing ClangABICompat check

ychen abandoned this revision. ychen added a comment. Per further discussions in D128745 , this is not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134507/new/ https://reviews.llvm.org/D134507

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3851458 , @rjmccall wrote: > Was this change in LLVM 15, or is it still unreleased? This is still unreleased. It will be released in Clang16. In D128745#3852409 ,

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. @mizvekov it turns out I don't need that code anymore. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 ___ cfe-commits mailing

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 467031. ychen added a comment. - remove dead code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clang/docs/ReleaseNotes.rst

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

ychen accepted this revision as: ychen. ychen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135045/new/ https://reviews.llvm.org/D135045

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3850667 , @hubert.reinterpretcast wrote: > In D128745#3834435 , @ychen wrote: > >> New flag or not, as long as we allow users to use the old behavior, it is >> already

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. Hi @mizvekov , after D135088 , this patch is ready. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

ychen added inline comments. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1612 + time_t TT = *getPreprocessorOpts().SourceDateEpoch; + std::tm *TM = std::gmtime(); Result = asctime(TM); MaskRay wrote: > ychen wrote: > > To be consistent with

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

ychen added a comment. Looks good to me except for one nit. And the test still fails on Windows for some reason. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1612 + time_t TT = *getPreprocessorOpts().SourceDateEpoch; + std::tm *TM = std::gmtime(); Result =

[PATCH] D135115: [clang-format] update --files help description

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c94f75f00af: [clang-format] update --files help description (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135115: [clang-format] update --files help description

ychen added a comment. In D135115#3839547 , @HazardyKnusperkeks wrote: > Except for the `@` part. (Which also isn't handles by clang-format, or > is it?) It is not. It is handled by the LLVM commandline library.

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

ychen added inline comments. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1092 +TT = *PP.getPreprocessorOpts().SourceDateEpoch; +TM = std::gmtime(); + } else { MaskRay wrote: > ychen wrote: > > MaskRay wrote: > > > ychen wrote: > > > > Why not use

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

ychen added inline comments. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1092 +TT = *PP.getPreprocessorOpts().SourceDateEpoch; +TM = std::gmtime(); + } else { MaskRay wrote: > ychen wrote: > > Why not use localtime as the else branch? > > > > As

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 465549. ychen added a comment. - rebased on D135088 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files:

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 465547. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclTemplate.h

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 465543. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclTemplate.h

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

ychen added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4313 +// 253402300799 is the UNIX timestamp of -12-31T23:59:59Z. +if (StringRef(Epoch).getAsInteger(10, V) || V > 253402300799) +

[PATCH] D134772: [Clang] Make constraints of auto part of NTTP instead of AutoType

ychen abandoned this revision. ychen added a comment. D135088 was landed instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134772/new/ https://reviews.llvm.org/D134772

[PATCH] D135115: [clang-format] update --files help description

ychen updated this revision to Diff 465151. ychen added a comment. - make corresponding change in the commandline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135115/new/ https://reviews.llvm.org/D135115 Files: clang/docs/ClangFormat.rst

[PATCH] D135115: [clang-format] update --files help description

ychen updated this revision to Diff 465134. ychen added a comment. - address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135115/new/ https://reviews.llvm.org/D135115 Files: clang/docs/ClangFormat.rst Index:

[PATCH] D135088: [Clang] make canonical AutoType constraints-free

This revision was automatically updated to reflect the committed changes. ychen marked an inline comment as done. Closed by commit rG5d69937b9f9c: [Clang] make canonical AutoType constraints-free (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3834454 , @tahonermann wrote: > Is it known what gcc and Microsoft maintainers are going to do with these > DRs? I don't see any recent changes in gcc, but the following is > interesting... It's hard to tell if they

  1   2   3   4   5   6   7   >