Author: Pierre Gousseau
Date: 2020-04-08T15:22:44+01:00
New Revision: 937e63b8d5e961c2a7da25558bbcdd5388182b67
URL:
https://github.com/llvm/llvm-project/commit/937e63b8d5e961c2a7da25558bbcdd5388182b67
DIFF:
Author: Pierre Gousseau
Date: 2020-04-07T11:25:08+01:00
New Revision: 08fab9ebecf72a682279d75489dc2460121cbeed
URL:
https://github.com/llvm/llvm-project/commit/08fab9ebecf72a682279d75489dc2460121cbeed
DIFF:
Author: pgousseau
Date: Fri Apr 12 07:14:58 2019
New Revision: 358285
URL: http://llvm.org/viewvc/llvm-project?rev=358285=rev
Log:
[asan] Add gcc 8's driver option -fsanitize=pointer-compare and
-fsanitize=pointer-substract.
Disabled by default as this is still an experimental feature.
Author: pgousseau
Date: Tue Apr 2 08:20:26 2019
New Revision: 357480
URL: http://llvm.org/viewvc/llvm-project?rev=357480=rev
Log:
[Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4.
Can be safely enabled on PS4.
Reviewed By: probinson
Differential Revision:
Author: pgousseau
Date: Fri Mar 1 02:05:15 2019
New Revision: 355190
URL: http://llvm.org/viewvc/llvm-project?rev=355190=rev
Log:
[Driver] Allow enum SanitizerOrdinal to represent more than 64 different
sanitizer checks, NFC.
enum SanitizerOrdinal has reached maximum capacity, this change
Author: pgousseau
Date: Tue Feb 26 05:50:29 2019
New Revision: 354875
URL: http://llvm.org/viewvc/llvm-project?rev=354875=rev
Log:
revert r354873 as this breaks lldb builds.
Modified:
cfe/trunk/include/clang/Basic/Attr.td
cfe/trunk/include/clang/Basic/Sanitizers.def
Author: pgousseau
Date: Tue Feb 26 05:30:14 2019
New Revision: 354873
URL: http://llvm.org/viewvc/llvm-project?rev=354873=rev
Log:
[Driver] Allow enum SanitizerOrdinal to represent more than 64 different
sanitizer checks, NFC.
enum SanitizerOrdinal has reached maximum capacity, this change
Author: pgousseau
Date: Thu Jan 24 03:44:24 2019
New Revision: 352042
URL: http://llvm.org/viewvc/llvm-project?rev=352042=rev
Log:
Test commit: fix typo.
Modified:
cfe/trunk/lib/Driver/SanitizerArgs.cpp
Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp
URL:
Author: pgousseau
Date: Tue Dec 18 09:03:35 2018
New Revision: 349508
URL: http://llvm.org/viewvc/llvm-project?rev=349508=rev
Log:
[Driver][PS4] Do not implicitly link against asan or ubsan if -nostdlib or
-nodefaultlibs on PS4.
NFC for targets other than PS4.
Respect -nostdlib and
Author: pgousseau
Date: Wed Jun 6 07:04:15 2018
New Revision: 334096
URL: http://llvm.org/viewvc/llvm-project?rev=334096=rev
Log:
[Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4.
NFC for targets other than PS4.
Simplify users' workflow when enabling asan or ubsan and
Author: pgousseau
Date: Tue Sep 6 05:48:27 2016
New Revision: 280702
URL: http://llvm.org/viewvc/llvm-project?rev=280702=rev
Log:
[clang-cl] Check that we are in clang cl mode before enabling support for the
CL environment variable.
Checking for the type of the command line tokenizer should
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280702: [clang-cl] Check that we are in clang cl mode before
enabling support for the… (authored by pgousseau).
Changed prior to commit:
https://reviews.llvm.org/D23503?vs=68020=70376#toc
Repository:
pgousseau created this revision.
pgousseau added reviewers: rsmith, majnemer.
pgousseau added subscribers: cfe-commits, wristow, gbedwell, probinson.
Checking for the type of the command line tokenizer should not be the criteria
to enable support for the CL environment variable, this change
pgousseau closed this revision.
pgousseau added a comment.
Committed in https://reviews.llvm.org/rL275415
https://reviews.llvm.org/D22310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pgousseau added a comment.
In https://reviews.llvm.org/D22310#484017, @bkramer wrote:
> lg
Thanks for the review!
https://reviews.llvm.org/D22310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: pgousseau
Date: Thu Jul 14 08:58:27 2016
New Revision: 275415
URL: http://llvm.org/viewvc/llvm-project?rev=275415=rev
Log:
The test added in r275267 does not work on read-only checkouts because of the
use of touch -m -t.
Following Tom Rybka suggestion, the test files are now copied to a
pgousseau created this revision.
pgousseau added a reviewer: rsmith.
pgousseau added subscribers: cfe-commits, trybka, bruno, gbedwell, wristow,
probinson.
The test added in r275267 does not work on read-only checkouts because of the
use of touch -t.
Following Tom Rybka suggestion, the test
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275261: [PCH] Fix timestamp check on windows hosts.
(authored by pgousseau).
Changed prior to commit:
http://reviews.llvm.org/D20867?vs=59887=63794#toc
Repository:
rL LLVM
Author: pgousseau
Date: Wed Jul 13 06:58:28 2016
New Revision: 275261
URL: http://llvm.org/viewvc/llvm-project?rev=275261=rev
Log:
[PCH] Fix timestamp check on windows hosts.
On Linux, if the timestamp of a header file, included in the pch, is modified,
then including the pch without
pgousseau added a comment.
In http://reviews.llvm.org/D20867#482465, @rsmith wrote:
> You have two independent functional changes in this patch: one adds a flag to
> control the emission of timestamps into PCH files, and the other re-enables
> timestamp checking on Win32. Please separate them
pgousseau added a comment.
Ping!
http://reviews.llvm.org/D20867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pgousseau added a comment.
Ping!
http://reviews.llvm.org/D20867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pgousseau added a comment.
Ping!
http://reviews.llvm.org/D20867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pgousseau added a comment.
Ping!
http://reviews.llvm.org/D20867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pgousseau added a comment.
> > Are you asking for the 2 seconds tolerance to be part of this patch?
>
> > Or, as it seems the main problem here is the lack of a reproducible, are
> > you ok with the idea of committing this patch first, to see if the
> > inconsistent time stamps is still an
It seems Phabricator did not picked up Richard's message so I have manually
copied and replied to it via Phabricator's web interface.
Cheers,
Pierre
On 6 June 2016 at 21:53, Richard Smith <rich...@metafoo.co.uk> wrote:
> On Wed, Jun 1, 2016 at 8:33 AM, pierre gousseau via cfe-commit
pgousseau added a comment.
> > On Linux, if the timestamp of a header file, included in the pch, is
> > modified, then including the pch without regenerating it causes a fatal
> > error, which is reasonable.
>
> > On Windows the check is ifdefed out, allowing the compilation to continue
>
pgousseau updated this revision to Diff 59887.
pgousseau added a comment.
Following Bruno's comment:
- Remove call to sleep using touch -m -a -t
http://reviews.llvm.org/D20867
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/FrontendOptions.h
pgousseau added inline comments.
Comment at: test/PCH/include-timestamp.cpp:8
@@ +7,3 @@
+// RUN: sleep 1
+// RUN: not %clang_cc1 -include-pch %t %s 2>&1 | FileCheck
-check-prefix=CHECK-TIMESTAMP %s
+
Without the sleep the test fails for me, as it seems the call
pgousseau updated this revision to Diff 59355.
pgousseau added a comment.
Following Bruno's comments:
- Update input files' name to match http://reviews.llvm.org/D20243 review.
- Add llvm-bcanalyzer checks
http://reviews.llvm.org/D20867
Files:
include/clang/Driver/CC1Options.td
pgousseau created this revision.
pgousseau added reviewers: rsmith, thakis.
pgousseau added subscribers: cfe-commits, wristow, probinson, gbedwell, bruno,
cameron314.
On Linux, if the timestamp of a header file, included in the pch, is modified,
then including the pch without regenerating it
pgousseau added a comment.
In http://reviews.llvm.org/D20243#437192, @thakis wrote:
> Hm, the ASTReader code this works around is over 6 years old (r100866). Maybe
> we could try enabling the access time check instead?
Yes the issue described in ASTReader lacks a reproducible so it makes
pgousseau updated this revision to Diff 58207.
pgousseau added a comment.
Moving REQUIRE line higher following Bruno's comments.
http://reviews.llvm.org/D20243
Files:
lib/Frontend/FrontendActions.cpp
lib/Serialization/ASTReader.cpp
test/PCH/Inputs/pragma-once2-pch.h
pgousseau added a comment.
In http://reviews.llvm.org/D20243#433615, @thakis wrote:
> Did you see http://reviews.llvm.org/D19815 ? Does that help? Warren might
> have opinions on this.
Yes thanks, I agree with Warren, this is a separate issue.
In the test I am adding I avoid the issue that
pgousseau updated this revision to Diff 57324.
pgousseau added a comment.
Add newlines and change test's name following Paul's comments.
http://reviews.llvm.org/D20243
Files:
lib/Frontend/FrontendActions.cpp
lib/Serialization/ASTReader.cpp
test/PCH/Inputs/pragma-once2-pch.h
pgousseau added a comment.
In http://reviews.llvm.org/D20243#429811, @probinson wrote:
> Please make sure the test files have newlines at the end.
> "touch-pragma-once.cpp" should probably be named something like
> "pragma-once-timestamp.cpp".
Will fix thanks!
pgousseau created this revision.
pgousseau added a reviewer: rsmith.
pgousseau added a subscriber: cfe-commits.
On Linux, if a header file included in the pch is modified then a fatal error
is emitted, which is reasonable.
On Windows the check is ifdefed out, allowing the compilation to continue
pgousseau accepted this revision.
pgousseau added a comment.
This revision is now accepted and ready to land.
LGTM!
Thanks Artom for finding the bug and new test case, sorry for missing those in
my patch!
Removing "!IsNotTruncated" is definitely worth trying.
Please commit if code owners are
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257464: [analyzer] Evaluate integral casts as cast symbols
if truncations are detected. (authored by pgousseau).
Changed prior to commit:
http://reviews.llvm.org/D12901?vs=43120=44613#toc
Repository:
Author: pgousseau
Date: Tue Jan 12 04:07:56 2016
New Revision: 257464
URL: http://llvm.org/viewvc/llvm-project?rev=257464=rev
Log:
[analyzer] Evaluate integral casts as cast symbols if truncations are detected.
The current workaround for truncations not being modelled is that the
evaluation of
Author: pgousseau
Date: Tue Jan 12 04:40:45 2016
New Revision: 257467
URL: http://llvm.org/viewvc/llvm-project?rev=257467=rev
Log:
[analyzer] Fix RangeConstraintManager's pinning of single value ranges.
This fix a bug in RangeSet::pin causing single value ranges to be considered
non
pgousseau added a comment.
In http://reviews.llvm.org/D12901#320680, @zaks.anna wrote:
> > This patch also fixes a bug in 'RangeSet::pin' causing single value ranges
> > to not be considered conventionally ordered.
>
>
> Can that fix be submitted as a separate patch? Is there a test for it?
pgousseau added a comment.
In http://reviews.llvm.org/D13731#302989, @zaks.anna wrote:
> Pierre,
>
> Have you seen the post about API Notes?
> http://llvm.cc/t/cfe-dev-clang-and-swift/331
>
> I believe using API notes would be a better approach for adding annotations.
> By the time the static
Author: pgousseau
Date: Thu Nov 26 16:08:58 2015
New Revision: 254181
URL: http://llvm.org/viewvc/llvm-project?rev=254181=rev
Log:
Test commit
Remove tabs.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp
Modified:
pgousseau added a comment.
Ping!
http://reviews.llvm.org/D13731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pgousseau added a comment.
Ping!
http://reviews.llvm.org/D13731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pgousseau updated this revision to Diff 38438.
pgousseau added a comment.
Following Anna's review:
Remove unnecessary AST walk over declarations by reusing already captured
declarations.
Add handling of merge conflicts using Sema merge methods.
Add condition at the end of
pgousseau updated this revision to Diff 37765.
pgousseau added a comment.
Following Gabor's review:
Remove changes to UncheckedReturn checker.
Add a test using the NonNullParamChecker checker.
Abstract the origin of the attributes.
An analyzer option "faux-attributes" is added. This is 'false'
pgousseau updated this revision to Diff 37466.
pgousseau added a comment.
Fix incorrect caching of model files declarations.
http://reviews.llvm.org/D13731
Files:
include/clang/Analysis/AnalysisContext.h
include/clang/Analysis/CodeInjector.h
pgousseau added a comment.
In http://reviews.llvm.org/D13731#267905, @xazax.hun wrote:
> Hi!
Hi! Thank you for reviewing.
> I have some high level questions and notes about this patch.
>
> I implemented the function modelling as a Google Summer of Code project and
> Ted Kremenek was my
pgousseau created this revision.
pgousseau added a subscriber: cfe-commits.
Dear All,
I would like to propose a patch for specifying function attributes in .model
files to be used by the analyzer checkers.
There are a number of checkers (such as UncheckedReturn) that contain hardcoded
list of
pgousseau added a comment.
In http://reviews.llvm.org/D12901#262270, @zaks.anna wrote:
> I agree with Gabor. We should investigate how we can model the overflow on a
> cast correctly.
Yes I agree with Gabor too. I meant this change as a temporary workaround only,
I will investigate the
pgousseau added a comment.
For some reasons the patch file I get from the "download raw diff link" does
not contain the diff for the added .keep files? But the .keep files show up in
phabricator, so I guess it is a phabricator issue?
Repository:
rL LLVM
http://reviews.llvm.org/D13482
pgousseau added a comment.
Ping !
http://reviews.llvm.org/D12901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pgousseau updated this revision to Diff 35604.
pgousseau added a comment.
Following Gabor's review:
Add a test factoring 'index + 1' in an extra variable.
Let me know if this looks reasonable ?
Regards,
Pierre
http://reviews.llvm.org/D12901
Files:
pgousseau added a comment.
In http://reviews.llvm.org/D12571#252366, @dcoughlin wrote:
> Looks good to me! Thanks Pierre! I will commit.
Much appreciated thanks !
http://reviews.llvm.org/D12571
___
cfe-commits mailing list
pgousseau updated this revision to Diff 35505.
pgousseau added a comment.
Following Devin's review:
Fix a comment in 'IsFirstBufInBound'.
Remove incorrect assertion expecting 'RegionOffset::getOffset' to only return
positives values.
Add test cases for regions having negatives offsets.
Updated
pgousseau added a comment.
In http://reviews.llvm.org/D12901#248842, @xazax.hun wrote:
> Hi!
>
> Thank you for the patch!
Thanks for reviewing !
> What happens if you factor the "index + 1" expression out into a separate
> variable?
> E.g.: unsigned temp = index + 1; and use temp in the
pgousseau added a comment.
In http://reviews.llvm.org/D12571#248464, @dcoughlin wrote:
> Here is a reduced test case:
Very useful thanks !
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:198
@@ +197,3 @@
+
+ // Return true if the destination buffer of the copy
pgousseau added a comment.
Ping !
http://reviews.llvm.org/D12571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pgousseau updated this revision to Diff 34900.
pgousseau added a comment.
Added some comments.
http://reviews.llvm.org/D12901
Files:
lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp
lib/StaticAnalyzer/Core/SimpleConstraintManager.h
pgousseau added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:843
@@ +842,3 @@
+ if (!Length)
+return true;
+
dcoughlin wrote:
> There doesn't seem to be a test that cares about this returning true (as
> compared to false).
pgousseau updated the summary for this revision.
pgousseau updated this revision to Diff 34359.
pgousseau added a comment.
Following Devin's review:
Correct test for unknown length and unknown destination buffer.
Add comment to 'IsFirstBufInBound' behavior regarding unknown states.
Remove
pgousseau created this revision.
pgousseau added reviewers: ayartsev, zaks.anna, dcoughlin, xazax.hun, ClockMan.
pgousseau added a subscriber: cfe-commits.
Fix assertions kindly reported by Gabor Horvath and Piotr Zegar caused by
commit r246345 and reverted in r246479.
Original review in
pgousseau added a comment.
In http://reviews.llvm.org/D11832#235301, @dcoughlin wrote:
> I will commit. Thanks for your work on this, Pierre!
Much appreciated ! Thanks for your help.
Repository:
rL LLVM
http://reviews.llvm.org/D11832
___
pgousseau updated this revision to Diff 32955.
pgousseau added a comment.
Encapsulate 'RegionAndSymbolInvalidationTraits' by overriding 'AddToWorkList'
following Anton's review.
Also as pointed out by Devin's review:
Add tests cases and handling for regions, bindings in super regions, and
pgousseau added a comment.
In http://reviews.llvm.org/D11832#224929, @dcoughlin wrote:
You should consider what should happen when the memcpy may write past the end
of the fixed-size array and add tests that specify correct behavior for these
cases. An important example is:
struct Foo {
67 matches
Mail list logo
