[PATCH] D100671: [ADT] Factor out in_place_t and expose in Optional ctor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf5247c9347d: [ADT] Factor out in_place_t and expose in Optional ctor (authored by scott.linder). Changed prior to commit:

[PATCH] D100671: [ADT] Factor out in_place_t and expose in Optional ctor

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good, thanks! Probably skip the other two in_place_* until we have a use for them. Comment at: llvm/include/llvm/ADT/STLForwardCompat.h:53-73 + +template +struct

[PATCH] D100671: [ADT] Factor out in_place_t and expose in Optional ctor

scott.linder updated this revision to Diff 345475. scott.linder added a comment. Add constexpr convenience variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100671/new/ https://reviews.llvm.org/D100671 Files:

[PATCH] D100671: [ADT] Factor out in_place_t and expose in Optional ctor

dexonsmith added a comment. In D100671#2696123 , @scott.linder wrote: > In D100671#2695923 , @dblaikie > wrote: > >> This usage doesn't seem to quite match the standard - which provides an >> existing instance

[PATCH] D100671: [ADT] Factor out in_place_t and expose in Optional ctor

scott.linder added a comment. In D100671#2695923 , @dblaikie wrote: > This usage doesn't seem to quite match the standard - which provides an > existing instance of in_place_t for callers to use: > > std::optional o4(std::in_place, {'a', 'b', 'c'}); >

[PATCH] D100671: [ADT] Factor out in_place_t and expose in Optional ctor

dblaikie added a comment. This usage doesn't seem to quite match the standard - which provides an existing instance of in_place_t for callers to use: std::optional o4(std::in_place, {'a', 'b', 'c'}); (to quote https://en.cppreference.com/w/cpp/utility/optional/optional ) Probably good to

[PATCH] D100671: [ADT] Factor out in_place_t and expose in Optional ctor

scott.linder created this revision. Herald added a subscriber: dexonsmith. scott.linder requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100671 Files: