[PATCH] D102306: Add gfx1034

kzhuravl added inline comments. Comment at: llvm/include/llvm/BinaryFormat/ELF.h:737 EF_AMDGPU_MACH_AMDGCN_GFX1033 = 0x039, + EF_AMDGPU_MACH_AMDGCN_GFX1034 = 0x03e, EF_AMDGPU_MACH_AMDGCN_GFX602= 0x03a, For future reference, MACH values

[PATCH] D102306: Add gfx1034

kzhuravl added a subscriber: t-tye. kzhuravl added a comment. In D102306#2760806 , @tra wrote: > In D102306#2760775 , @msearles > wrote: > >> In D102306#2758166 , >>

[PATCH] D102306: Add gfx1034

tra added a comment. In D102306#2760775 , @msearles wrote: > In D102306#2758166 , > @JonChesterfield wrote: > >> Is there documentation for the mapping from product names to gfx numbers? > > See the Processors

[PATCH] D102306: Add gfx1034

msearles added a comment. In D102306#2758166 , @JonChesterfield wrote: > Is there documentation for the mapping from product names to gfx numbers? See the Processors section of https://llvm.org/docs/AMDGPUUsage.html Repository: rG LLVM Github

[PATCH] D102306: Add gfx1034

JonChesterfield added a comment. Is there documentation for the mapping from product names to gfx numbers? It's possible to work it out from roct's topology.cpp and the pci.ids table, but hopefully there's a table we could point users to as well. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D102306: Add gfx1034

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG464e4dc50f4e: [AMDGPU] Add gfx1034 target (authored by aakanksha555). Herald added a project: OpenMP. Herald added a subscriber: openmp-commits.

[PATCH] D102306: Add gfx1034

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102306/new/ https://reviews.llvm.org/D102306 ___ cfe-commits mailing list

[PATCH] D102306: Add gfx1034

aakanksha555 updated this revision to Diff 345226. Herald added a subscriber: emaste. Herald added a reviewer: MaskRay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102306/new/ https://reviews.llvm.org/D102306 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp

[PATCH] D102306: Add gfx1034

foad added a comment. Can you also check for updates in: clang/lib/Basic/Cuda.cpp openmp/libomptarget/plugins/amdgpu/impl/get_elf_mach_gfx_name.cpp llvm/test/CodeGen/AMDGPU/directive-amdgcn-target.ll llvm/test/tools/llvm-objdump/ELF/AMDGPU/subtarget.ll

[PATCH] D102306: Add gfx1034

aakanksha555 created this revision. aakanksha555 added reviewers: msearles, kzhuravl, rampitec. Herald added subscribers: dexonsmith, kerbowa, rupprecht, hiraditya, nhaehnle, jvesely, arsenm, jholewinski. Herald added a reviewer: jhenderson. aakanksha555 requested review of this revision. Herald