This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
NeHuang marked an inline comment as done.
Closed by commit rG26ea4a443243: [PowerPC] Add PowerPC "__stbcx"
builtin and intrinsic for XL compatibility (authored by NeHua
Conanap added inline comments.
Comment at: clang/lib/Sema/SemaChecking.cpp:3437
case PPC::BI__builtin_ppc_icbt:
+ case PPC::BI__builtin_ppc_stbcx:
return SemaFeatureCheck(*this, TheCall, "isa-v207-instructions",
would prefer if this joined the list of `s
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM aside from a small nit.
Comment at: clang/lib/Basic/Targets/PPC.cpp:124
Builder.defineMacro("__stfiw", "__builtin_ppc_stfiw");
+ Builder.defineMacro("__stbcx", "
NeHuang marked an inline comment as done.
NeHuang added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-pwr8.c:31
+ return __builtin_ppc_stbcx(c_addr, c);
+}
lei wrote:
> Why not just add this tc to
> `clang/test/CodeGen/builtins-ppc-xlcom
NeHuang updated this revision to Diff 360803.
NeHuang added a comment.
- Addressed review comments from Lei
- Rebased the patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106484/new/
https://reviews.llvm.org/D106484
Files:
clang/include/clang
lei added inline comments.
Comment at: clang/include/clang/Basic/BuiltinsPPC.def:116
BUILTIN(__builtin_ppc_fres, "ff", "")
+BUILTIN(__builtin_ppc_stbcx, "icD*i", "")
maybe move this up to where `__builtin_ppc_stdcx` is defined. To match what
you did in `PPC.
NeHuang created this revision.
NeHuang added reviewers: nemanjai, PowerPC.
NeHuang added a project: LLVM.
Herald added subscribers: shchenz, kbarton, hiraditya.
NeHuang requested review of this revision.
Herald added a project: clang.
Herald added subscribers: llvm-commits, cfe-commits.
This patch
