Re: [PATCH] D10677: Allow deque to handle incomplete types

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I think I've cleared up my own confusion. LGTM. Repository: rL LLVM http://reviews.llvm.org/D10677 ___ cfe-commits mailing list

Re: [PATCH] D10677: Allow deque to handle incomplete types

eugenis closed this revision. eugenis added a comment. Thanks! Landed as r252350. Repository: rL LLVM http://reviews.llvm.org/D10677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D10677: Allow deque to handle incomplete types

eugenis added a comment. Hi Eric, could you please clarify what exactly you are looking for here? Repository: rL LLVM http://reviews.llvm.org/D10677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D10677: Allow deque to handle incomplete types

> I'm pretty sure it only affects template evaluation order, and does not change the mangling of any name. I agree it doesn't change the mangling of any name. I just want to make sure that moving the initializer won't result in incompatible code gen. I'm sure I'm insane for being concerned about

Re: [PATCH] D10677: Allow deque to handle incomplete types

eugenis added a comment. What kind of confirmation are you looking for? I've compiled the following code with 2 versions of : one as in this review, another the same but with __block_size initializers moved back into respective classes. Resulting object files are identical. #include int

Re: [PATCH] D10677: Allow deque to handle incomplete types

eugenis updated this revision to Diff 37795. eugenis marked 3 inline comments as done. Repository: rL LLVM http://reviews.llvm.org/D10677 Files: include/__config include/deque test/libcxx/containers/sequences/deque/incomplete.pass.cpp Index:

Re: [PATCH] D10677: Allow deque to handle incomplete types

eugenis added a comment. In http://reviews.llvm.org/D10677#266595, @EricWF wrote: > For the most part this looks good. I'm a touch concerned though about the > changes to the static initialization. The initializer is moved from within > the function body to outside it. Could you have somebody

Re: [PATCH] D10677: Allow deque to handle incomplete types

EricWF added a comment. For the most part this looks good. I'm a touch concerned though about the changes to the static initialization. The initializer is moved from within the function body to outside it. Could you have somebody confirm this won't affect the existing ABI?

Re: [PATCH] D10677: Allow deque to handle incomplete types

eugenis set the repository for this revision to rL LLVM. eugenis updated this revision to Diff 37310. eugenis added a comment. Using new ABI version macros to enable this feature in unstable or future ABI only. PTAL. Repository: rL LLVM http://reviews.llvm.org/D10677 Files: