[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe57e1e4e0026: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate… (authored by bsmith). Changed prior to commit:

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. thanks @bsmith, just left one minor nit but otherwise LGTM Comment at: clang/test/CodeGen/attr-arm-sve-vector-bits-cast.c:10 typedef svint32_t fixed_int32_t

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

bsmith updated this revision to Diff 363093. bsmith marked an inline comment as done. bsmith added a comment. - Update comment to reflect changes - Add new test for lax casting via memory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106860/new/

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

junparser added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2102 + Src = Builder.CreateBitCast(Src, SrcTy); +} if (ScalableSrc->getElementType() == FixedDst->getElementType()) { bsmith wrote: > junparser wrote: > > I

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

bsmith added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2102 + Src = Builder.CreateBitCast(Src, SrcTy); +} if (ScalableSrc->getElementType() == FixedDst->getElementType()) { junparser wrote: > I think this may also

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

junparser added inline comments. Herald added a subscriber: ctetreau. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2102 + Src = Builder.CreateBitCast(Src, SrcTy); +} if (ScalableSrc->getElementType() == FixedDst->getElementType()) { I

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

c-rhodes added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2110-2129 // Perform VLAT <-> VLST bitcast through memory. // TODO: since the llvm.experimental.vector.{insert,extract} intrinsics // require the element types of the vectors to

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

bsmith added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2110-2129 // Perform VLAT <-> VLST bitcast through memory. // TODO: since the llvm.experimental.vector.{insert,extract} intrinsics // require the element types of the vectors to be

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

c-rhodes added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2065 if (const auto *FixedSrc = dyn_cast(SrcTy)) { if (const auto *ScalableDst = dyn_cast(DstTy)) { +// If we are casting a fixed i8 vector to a scalable 16 x i1 predicate

[PATCH] D106860: [clang][AArch64][SVE] Avoid going through memory for fixed/scalable predicate casts

bsmith created this revision. bsmith added reviewers: paulwalker-arm, peterwaller-arm, eli.friedman, junparser. Herald added subscribers: psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. bsmith requested review of this revision. Herald added a project: clang. Herald added a