glider updated this revision to Diff 366591.
glider added a comment.
Updated patch description
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108029/new/
https://reviews.llvm.org/D108029
Files:
clang/include/clang/Basic/Attr.td
glider added a subscriber: krytarowski.
glider marked 2 inline comments as done.
glider added a comment.
+krytarowski FYI
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108029/new/
https://reviews.llvm.org/D108029
glider marked 2 inline comments as done.
glider added inline comments.
Comment at: clang/include/clang/Basic/AttrDocs.td:2601-2602
+
+This is not the same as ``__attribute__((no_sanitize(...)))``, which depending
+on the tool may still insert instrumentation to prevent false
glider updated this revision to Diff 366570.
glider added a comment.
Renamed no_sanitizer_instrumentation to disable_sanitizer_instrumentation
Added bitcode attribute declaration and missing handling of the new attribute
in switches.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
eugenis added a comment.
The new attribute should be very rare, and not something that a typical end
user should even know about.
That's why I'd prefer if the name reflected how the attribute affects code
generation rather than user-visible behavior: disable_sanitizer_instrumentation
sounds
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/AttrDocs.td:2601-2602
+
+This is not the same as ``__attribute__((no_sanitize(...)))``, which depending
+on the tool may still insert instrumentation to prevent false positive reports.
+ }];
melver added inline comments.
Comment at: clang/include/clang/Basic/AttrDocs.td:2601-2602
+
+This is not the same as ``__attribute__((no_sanitize(...)))``, which depending
+on the tool may still insert instrumentation to prevent false positive reports.
+ }];
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/AttrDocs.td:2601-2602
+
+This is not the same as ``__attribute__((no_sanitize(...)))``, which depending
+on the tool may still insert instrumentation to prevent false positive reports.
+ }];
glider added inline comments.
Comment at: clang/include/clang/Basic/AttrDocs.td:2601-2602
+
+This is not the same as ``__attribute__((no_sanitize(...)))``, which depending
+on the tool may still insert instrumentation to prevent false positive reports.
+ }];
aaron.ballman requested changes to this revision.
aaron.ballman added inline comments.
This revision now requires changes to proceed.
Comment at: clang/include/clang/Basic/AttrDocs.td:2601-2602
+
+This is not the same as ``__attribute__((no_sanitize(...)))``, which depending
+on
dvyukov accepted this revision.
dvyukov added inline comments.
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:524
+bool CodeGenFunction::ShouldSkipSanitizerInstrumentation() {
+ if (!CurFuncDecl)
+return false;
When is CurFuncDecl nullptr? Maybe we
melver accepted this revision.
melver added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/include/llvm/AsmParser/LLToken.h:222
kw_nosanitize_coverage,
+ kw_no_sanitizer_instrumentation,
kw_null_pointer_is_valid,
LLVM
glider updated this revision to Diff 366256.
glider added a comment.
Added a comment to clang/lib/CodeGen/CodeGenFunction.h
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108029/new/
https://reviews.llvm.org/D108029
Files:
glider created this revision.
glider added reviewers: eugenis, melver, browneee, dvyukov.
Herald added subscribers: ormris, dexonsmith, jdoerfert, steven_wu, hiraditya.
Herald added a reviewer: aaron.ballman.
glider requested review of this revision.
Herald added projects: clang, LLVM.
Herald
14 matches
Mail list logo
