[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

GMNGeoffrey added a comment. In D112883#3101685 , @GMNGeoffrey wrote: > In D112883#3101665 , @chandlerc > wrote: > >> However, I thought with Bazel having a consistent repo name was important to >> allow cross-

Re: [PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

SGTM If you're coming here because it breaks your build please let us know :-) smime.p7s Description: S/MIME Cryptographic Signature ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

chandlerc added a comment. In D112883#3101685 , @GMNGeoffrey wrote: >> Is this breaking actual users? I wouldn't expect it to break unless they >> depend on this target. > > I don't know :-) I just know that people have sent me patches to remove the >

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

GMNGeoffrey added a comment. In D112883#3101665 , @chandlerc wrote: > In D112883#3101645 , @GMNGeoffrey > wrote: > >> :-( Did you try the separate library with `strip_include_prefix`? > > I can add a separate

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

chandlerc added a comment. In D112883#3101645 , @GMNGeoffrey wrote: > :-( Did you try the separate library with `strip_include_prefix`? I can add a separate library to do that. It would still expose all consumers to `Opcodes.inc` instead of only ex

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

GMNGeoffrey added inline comments. Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:711 +# headers such as `CXXABI.h`. +"-I$(GENDIR)/external/llvm-project/clang/lib/AST", +"-I$(GENDIR)/external/llvm-project/clang/lib/AST/Interp",

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

GMNGeoffrey added a comment. :-( Did you try the separate library with `strip_include_prefix`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112883/new/ https://reviews.llvm.org/D112883 ___ cfe-commi

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1fdd745d510: Re-introduce `copts` hacks for lib/AST includes. (authored by chandlerc). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. :( LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112883/new/ https://reviews.llvm.org/D112883 ___ cfe-commits mailing list cfe-commit

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

chandlerc created this revision. chandlerc added reviewers: GMNGeoffrey, dblaikie. Herald added a subscriber: mcrosier. chandlerc requested review of this revision. Sadly, these are necessary AFAICT. There is a file `lib/AST/CXXABI.h`. On case insensitive file systems like macOS this will collide