[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov added inline comments. Comment at: compiler-rt/lib/asan/CMakeLists.txt:198 +ARCHS ${ASAN_SUPPORTED_ARCH} +OBJECT_LIBS RTAsan_static +CFLAGS ${ASAN_CFLAGS} thetruestblue wrote: > Can you explain the motivation here? > > RTAsan_static object

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

thetruestblue added inline comments. Herald added a project: All. Comment at: compiler-rt/lib/asan/CMakeLists.txt:198 +ARCHS ${ASAN_SUPPORTED_ARCH} +OBJECT_LIBS RTAsan_static +CFLAGS ${ASAN_CFLAGS} Can you explain the motivation here? RTAsan_static o

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG027ffb173a68: [ASan] Moved optimized callbacks into a separate library. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 397613. kstoimenov added a comment. Removed driver part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: compiler-rt/lib/asan/CMakeLists.txt compiler-rt

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71b3bfde9cd2: [ASan] Moved optimized callbacks into a separate library. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov requested review of this revision. kstoimenov added a comment. Added empty asan_static_rtl.cpp to work around the Windows build problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 396083. kstoimenov added a comment. Fixed a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/te

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 396082. kstoimenov added a comment. s/set/append/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 396081. kstoimenov added a comment. Added asan_rtl_static.cpp empty file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: clang/lib/Driver/ToolChains/Comm

Re: [PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

I got a couple of options myself: adan_instrumentation asan_fast_path asan_mini What do you think? On Wed, Dec 22, 2021, 3:30 PM Evgenii Stepanov via Phabricator < revi...@reviews.llvm.org> wrote: > eugenis added a comment. > > I don't like the name "asan_dso". DSO means "dynamic shared object

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab3640aa0e83: [ASan] Moved optimized callbacks into a separate library. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov added a comment. Renamed it 'dso' to 'static'. I know it could be a little bit confusing. I was considering 'static_link' or 'always_static', but it seems too long. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://revie

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 396031. kstoimenov marked an inline comment as done. kstoimenov added a comment. Remaned dso to static. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: cl

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

eugenis added a comment. Maybe `asan_client` (like `stats_client` above), or `asan_inline`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 ___ cfe-commits mail

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

eugenis added a comment. I don't like the name "asan_dso". DSO means "dynamic shared object", and this is the very opposite of that. Maybe "asan_private" or "asan_helper"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.l

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. I suspect Driver part is going to be reverted a couple of time. Maybe extract it into a separate patch? Comment at: compiler-rt/lib/asan/CMakeLists.txt:167 if(APP

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov updated this revision to Diff 395914. kstoimenov added a comment. Updated a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116182/new/ https://reviews.llvm.org/D116182 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov created this revision. Herald added a subscriber: mgorny. kstoimenov requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This will allow linking in the callbacks directly instead of using PLT. Repository: rG