[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

ormris added a comment. Hi Shangwu, I've reverted this change to unblock the buildbots and our internal CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119207/new/ https://reviews.llvm.org/D119207 ___

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

dyung added a comment. In D119207#3330494 , @shangwuyao wrote: > In D119207#3330385 , @dyung wrote: > >> Hi, the test you added is failing on the PS4 Linux bot, can you take a look? >> >> https://lab.llvm.org/bui

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao added a comment. In D119207#3330385 , @dyung wrote: > Hi, the test you added is failing on the PS4 Linux bot, can you take a look? > > https://lab.llvm.org/buildbot/#/builders/139/builds/17199 Looks like the compiled SPIR-V is slightly differe

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

dyung added a comment. Hi, the test you added is failing on the PS4 Linux bot, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/17199 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119207/new/ https://reviews.llvm.org/D11920

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

jlebar added a comment. commit 9de4fc0f2d3b60542956f7e5254951d049edeb1f (HEAD -> main, origin/main, origin/HEAD) Author: Shangwu Yao Date: Thu Feb 17 09:38:06 2022 -0800 [CUDA][SPIRV] Assign global address space to CUDA kernel arguments This patch converts CUDA pointer

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9de4fc0f2d3b: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments (authored by shangwuyao, committed by jle

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

jlebar added a comment. In D119207#3327476 , @shangwuyao wrote: > Thanks for the review, if it looks good, can we get this to land now? > Otherwise more comments are welcome! I'll land this for you! At some point you should get commit access yourself,

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao added a comment. Thanks for the review, if it looks good, can we get this to land now? Otherwise more comments are welcome! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119207/new/ https://reviews.llvm.org/D119207

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10322 ABIArgInfo SPIRVABIInfo::classifyKernelArgumentType(QualType Ty) const { - if (getContext().getLangOpts().HIP) { + if (getContext().getLangOpts().CUDAIsDevice) { // Coerce pointer arguments w

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10322 ABIArgInfo SPIRVABIInfo::classifyKernelArgumentType(QualType Ty) const { - if (getContext().getLangOpts().HIP) { + if (getContext().getLangOpts().CUDAIsDevice) { // Coerce pointer argumen