[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d59cfc67ead: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also (authored by vtjnash). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119591/new/

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. LGTM this time. Thanks very much for the rework! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119591/new/

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash added a comment. Okay, this should work now for those cases! Sorry, I kept thinking it was clang/examples that was broken, and missed that it was clang/test that was failing, so I failed to see what I needed to fix there too, so that we were not trying to build the tests in

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash updated this revision to Diff 409241. vtjnash added a comment. add one more missing case to check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119591/new/ https://reviews.llvm.org/D119591 Files: clang/CMakeLists.txt

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

simon_tatham added a comment. I ran another test of this patch, by trying the cross product of the following cmake configuration choices (on a build targeting Windows, with `LLVM_ENABLE_PROJECTS=clang`): - `LLVM_EXPORT_SYMBOLS_FOR_PLUGINS` set to each of `ON` and `OFF` - `CLANG_BUILD_EXAMPLES`

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash updated this revision to Diff 408498. vtjnash added a comment. fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119591/new/ https://reviews.llvm.org/D119591 Files: clang/CMakeLists.txt

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash added a comment. We are not going to start exporting plugin support if the user explicitly disabled it with CLANG_PLUGIN_SUPPORT=OFF, but why is it trying to read that directory at all, when it should be disallowed by this PR unless CLANG_PLUGIN_SUPPORT=ON Repository: rG LLVM

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash updated this revision to Diff 408491. vtjnash added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119591/new/ https://reviews.llvm.org/D119591 Files: clang/CMakeLists.txt

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

simon_tatham added a comment. I gave this patch a test against our downstream code, and found that it doesn't stop me needing the change I suggested in D119199 : in `clang/tools/driver/CMakeLists.txt`, I had to change if(CLANG_PLUGIN_SUPPORT)

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, mgorny. vtjnash requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The clang-analyzer plugins are