[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added a comment. In D119910#3364920 , @ychen wrote: > In D119910#3364892 , @thakis wrote: > >> Looks like this breaks tests on mac and win: >> http://45.33.8.238/win/54551/step_7.txt >>

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added a comment. In D119910#3364892 , @thakis wrote: > Looks like this breaks tests on mac and win: > http://45.33.8.238/win/54551/step_7.txt > http://45.33.8.238/macm1/29590/step_7.txt > > Please take a look, and revert for now if it takes a while

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

thakis added a comment. Looks like this breaks tests on mac and win: http://45.33.8.238/win/54551/step_7.txt http://45.33.8.238/macm1/29590/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG731347431976: [clang][debug] port clang-cl /JMC flag to ELF (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added inline comments. Comment at: llvm/test/Instrumentation/JustMyCode/jmc-instrument-elf.ll:1 -; REQUIRES: system-windows -; RUN: opt -jmc-instrument -mtriple=x86_64-pc-windows-msvc -S < %s | FileCheck %s -; RUN: opt -jmc-instrument -mtriple=aarch64-pc-windows-msvc -S

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added inline comments. Comment at: llvm/test/Instrumentation/JustMyCode/jmc-instrument-elf.ll:1 -; REQUIRES: system-windows -; RUN: opt -jmc-instrument -mtriple=x86_64-pc-windows-msvc -S < %s | FileCheck %s -; RUN: opt -jmc-instrument -mtriple=aarch64-pc-windows-msvc -S

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

rnk added inline comments. Comment at: llvm/test/Instrumentation/JustMyCode/jmc-instrument-elf.ll:1 -; REQUIRES: system-windows -; RUN: opt -jmc-instrument -mtriple=x86_64-pc-windows-msvc -S < %s | FileCheck %s -; RUN: opt -jmc-instrument -mtriple=aarch64-pc-windows-msvc -S <

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added inline comments. Comment at: llvm/test/Instrumentation/JustMyCode/jmc-instrument-elf.ll:1 -; REQUIRES: system-windows -; RUN: opt -jmc-instrument -mtriple=x86_64-pc-windows-msvc -S < %s | FileCheck %s -; RUN: opt -jmc-instrument -mtriple=aarch64-pc-windows-msvc -S

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks like I hit submit too early... I wanted to say the path thing is a pre-existing issue, and it seems reasonable to address that as a separate patch. If you don't have plans to do a follow up

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

rnk added inline comments. Comment at: llvm/lib/CodeGen/JMCInstrumenter.cpp:72 SmallString<256> FilePath(SP.getDirectory()); sys::path::append(FilePath, SP.getFilename()); sys::path::native(FilePath); These sys::path calls introduce host-dependence, and

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen marked 2 inline comments as done. ychen added a comment. @rnk, thanks for taking a look. Patch updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119910/new/ https://reviews.llvm.org/D119910

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen updated this revision to Diff 413146. ychen added a comment. Herald added a subscriber: dang. - Address Reid's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119910/new/ https://reviews.llvm.org/D119910 Files:

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5372 + // This controls whether or not we perform JustMyCode instrumentation. + if (TC.getTriple().isOSBinFormatELF() && Args.hasArg(options::OPT_fjmc)) { +if (DebugInfoKind >=

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

rnk added inline comments. Herald added a project: All. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5372 + // This controls whether or not we perform JustMyCode instrumentation. + if (TC.getTriple().isOSBinFormatELF() && Args.hasArg(options::OPT_fjmc)) { +if

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added a comment. Gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119910/new/ https://reviews.llvm.org/D119910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added a comment. RFC sent: https://discourse.llvm.org/t/rfc-just-my-code-stepping-for-non-msvc-debuggers/60279 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119910/new/ https://reviews.llvm.org/D119910

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added a comment. > - how does that work, actually? How does it differentiate between "my" code > and "code that happens to be compiled in the current CU" (e.g. the STL). > What's the significance of the funky `___x@c` symbols? The non-user code is specified by a config file

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

labath added a comment. Not my usual wheelhouse, but since I'm here, here are some of my thoughts: - reusing the existing solution/code seems like a good idea -- no need to reinvent the wheel - how does that work, actually? How does it differentiate between "my" code and "code that happens to

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen created this revision. ychen added reviewers: hans, rnk, aganea, JDevlieghere, labath. Herald added a subscriber: hiraditya. ychen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The motivation is to enable the