[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3445124 , @aaron.ballman wrote: > In D121556#3444837 , @void wrote: > >> In D121556#334 , @MaskRay >> wrote: >> >>> In

[PATCH] D121556: [randstruct] Add randomize structure layout support

aaron.ballman added a comment. In D121556#3444837 , @void wrote: > In D121556#334 , @MaskRay wrote: > >> In D121556#3444260 , @void wrote: >> >>> In D121556#3444221

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#334 , @MaskRay wrote: > In D121556#3444260 , @void wrote: > >> In D121556#3444221 , @MaskRay >> wrote: >> >>> In D121556#3444131

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added a comment. In D121556#3444260 , @void wrote: > In D121556#3444221 , @MaskRay wrote: > >> In D121556#3444131 , @void wrote: >> >>> In D121556#3444021

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3444221 , @MaskRay wrote: > In D121556#3444131 , @void wrote: > >> In D121556#3444021 , @MaskRay >> wrote: >> >>>

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added a comment. In D121556#3444131 , @void wrote: > In D121556#3444021 , @MaskRay wrote: > >> 7aa8c38a9e190aea14116028c38b1d9f54cbb0b3 >>

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3444021 , @MaskRay wrote: > 7aa8c38a9e190aea14116028c38b1d9f54cbb0b3 > still > uses `std::shuffle`, not incorporating the `llvm::shuffle` fixes I

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3444026 , @MaskRay wrote: > In D121556#3444015 , @void wrote: > >> In D121556#3444006 , @MaskRay >> wrote: >> >>> The relanded form

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added a comment. In D121556#3444015 , @void wrote: > In D121556#3444006 , @MaskRay wrote: > >> The relanded form still lacks the -f option testing I requested. > > The unit test tests the

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added a comment. 7aa8c38a9e190aea14116028c38b1d9f54cbb0b3 still uses `std::shuffle`, not incorporating the `llvm::shuffle` fixes I did. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3444006 , @MaskRay wrote: > The relanded form still lacks the -f option testing I requested. The unit test tests the `-frandomize-layout-seed=` option already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added inline comments. Comment at: clang/unittests/AST/RandstructTest.cpp:154-158 +#ifdef _WIN32 + const field_names Expected = {"lettuce", "bacon", "mayonnaise", "tomato"}; +#else + const field_names Expected = {"mayonnaise", "bacon", "tomato", "lettuce"}; +#endif

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added a comment. The relanded form still lacks the -f option testing I requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 ___ cfe-commits

[PATCH] D121556: [randstruct] Add randomize structure layout support

jyknight added inline comments. Comment at: clang/unittests/AST/RandstructTest.cpp:154-158 +#ifdef _WIN32 + const field_names Expected = {"lettuce", "bacon", "mayonnaise", "tomato"}; +#else + const field_names Expected = {"mayonnaise", "bacon", "tomato", "lettuce"}; +#endif

[PATCH] D121556: [randstruct] Add randomize structure layout support

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7aa8c38a9e19: [randstruct] Add randomize structure layout support (authored by connorkuehl, committed by void).

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4244 + if (const Arg *A = Args.getLastArg(OPT_frandomize_layout_seed_file_EQ)) { +std::ifstream SeedFile(A->getValue(0)); aaron.ballman wrote: > MaskRay wrote: > > void

[PATCH] D121556: [randstruct] Add randomize structure layout support

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4244 + if (const Arg *A = Args.getLastArg(OPT_frandomize_layout_seed_file_EQ)) { +std::ifstream SeedFile(A->getValue(0)); MaskRay wrote: > void wrote: > > MaskRay

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4244 + if (const Arg *A = Args.getLastArg(OPT_frandomize_layout_seed_file_EQ)) { +std::ifstream SeedFile(A->getValue(0)); void wrote: > MaskRay wrote: > > Why is

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 421692. void added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Decl.h

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4244 + if (const Arg *A = Args.getLastArg(OPT_frandomize_layout_seed_file_EQ)) { +std::ifstream SeedFile(A->getValue(0)); MaskRay wrote: > Why is

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3440383 , @MaskRay wrote: > Windows test is still failing after the std::shuffle => llvm::shuffle change, > guess time for revert. > > ../../clang/unittests/AST/RandstructTest.cpp(165): error: Expected equality > of

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added inline comments. Comment at: clang/lib/AST/Randstruct.cpp:156 + // Produce the new ordering of the elements from the Buckets. + SmallVector FinalOrder; + for (const std::unique_ptr : Buckets) { Comment at:

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added a comment. Windows test is still failing after the std::shuffle => llvm::shuffle change, guess time for revert. ../../clang/unittests/AST/RandstructTest.cpp(165): error: Expected equality of these values: Expected Which is: { "lettuce", "bacon", "mayonnaise", "tomato"

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added a comment. You can use llvm::shuffle to avoid STL impl difference Comment at: clang/lib/AST/Randstruct.cpp:160 +if (!B->isBitfieldRun()) + std::shuffle(std::begin(RandFields), std::end(RandFields), RNG); + `llvm::shuffle` to avoid

[PATCH] D121556: [randstruct] Add randomize structure layout support

thakis added a comment. Why? This is a fairly small CL. It should be easy to reland, and there shouldn't be any rebasing pain. You should at least check with your reviewers that they're fine relanding this without test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3440308 , @thakis wrote: > It's more important to remove it from the cmakelists file than to delete the > source file ;) > > Please revert the whole thing instead of just removing the test coverage > though. You can

[PATCH] D121556: [randstruct] Add randomize structure layout support

thakis added a comment. It's more important to remove it from the cmakelists file than to delete the source file ;) Please revert the whole thing instead of just removing the test coverage though. You can reland when the test is figured out, and that makes sure this doesn't stay in without

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3440290 , @thakis wrote: > Looks like this breaks tests on mac: http://45.33.8.238/macm1/32938/step_7.txt > > Please take a look, and revert for now if it takes a while to fix. Ugh! This sucks. I just removed the test

[PATCH] D121556: [randstruct] Add randomize structure layout support

thakis added a comment. Looks like this breaks tests on mac: http://45.33.8.238/macm1/32938/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3440089 , @dyung wrote: > Hi, the test you added is failing on the PS4 Windows bot > https://lab.llvm.org/buildbot/#/builders/216/builds/2647. > > Can you take a look? Crud! I thought I got all of the Windows issues.

[PATCH] D121556: [randstruct] Add randomize structure layout support

dyung added a comment. Hi, the test you added is failing on the PS4 Windows bot https://lab.llvm.org/buildbot/#/builders/216/builds/2647. Can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/

[PATCH] D121556: [randstruct] Add randomize structure layout support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f0587d0c668: [randstruct] Add randomize structure layout support (authored by connorkuehl, committed by void). Repository: rG LLVM Github

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3438722 , @aaron.ballman wrote: > Precommit CI is failing on one test: > > Failed Tests (1): > > Clang :: Misc/pragma-attribute-supported-attributes-list.test > > but with that test fixed, this LGTM! (Feel free to land

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 421616. void added a comment. Fix simple test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Decl.h

[PATCH] D121556: [randstruct] Add randomize structure layout support

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Precommit CI is failing on one test: Failed Tests (1): Clang :: Misc/pragma-attribute-supported-attributes-list.test but with that test fixed, this LGTM! (Feel free to land

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 421416. void added a comment. Fix bad formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Decl.h

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 421358. void added a comment. Make the randomize_layout and no_randomize_layout attributes mutually exclutsive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files:

[PATCH] D121556: [randstruct] Add randomize structure layout support

aaron.ballman added a comment. Recap: aside from the function merging behavior and the possible question about assertions in tests, I think this is ready to go. Comment at: clang/lib/Sema/SemaDecl.cpp:27 #include "clang/AST/NonTrivialTypeVisitor.h" +#include

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:27 #include "clang/AST/NonTrivialTypeVisitor.h" +#include "clang/AST/Randstruct.h" #include "clang/AST/StmtCXX.h" aaron.ballman wrote: > Is this include necessary? Yes. There's a call to

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 420972. void marked 3 inline comments as done. void added a comment. Don't re-randomize a structure. Also some minor style changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/

[PATCH] D121556: [randstruct] Add randomize structure layout support

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Randstruct.h:31-35 +using llvm::SmallVectorImpl; + +bool randomizeStructureLayout(const ASTContext , llvm::StringRef Name, + llvm::ArrayRef Fields, +

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8550-8556 + case ParsedAttr::AT_RandomizeLayout: +handleSimpleAttribute(S, D, AL); +break; + case ParsedAttr::AT_NoRandomizeLayout: +// Drop the "randomize_layout" attribute if it's on the

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 420332. void added a comment. Second attempt to fix Windows errors. Expecting one more iteration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files:

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 420312. void added a comment. First pass at fixing the Windows unit test errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files: clang/docs/ReleaseNotes.rst

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 420307. void added a comment. - Add an entry in the Release Notes. - Change the command line flags to better match the attribute naming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/

[PATCH] D121556: [randstruct] Add randomize structure layout support

nickdesaulniers added a comment. In D121556#3427620 , @void wrote: > In D121556#3419184 , @aaron.ballman > wrote: > >> Generally I think things are looking pretty good, but there's still an open >> question and

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3427604 , @xbolva00 wrote: > Release note is missing Sorry about that. I'll add one with the next update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3419184 , @aaron.ballman wrote: > Generally I think things are looking pretty good, but there's still an open > question and Precommit CI is still failing on Windows: > > Failed Tests (7): > Clang-Unit :: >

[PATCH] D121556: [randstruct] Add randomize structure layout support

xbolva00 added a comment. Release note is missing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 420294. void marked an inline comment as done. void added a comment. Simplify the attributes by using an accessor instead of a separate "no_ranomize_layout" attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3419184 , @aaron.ballman wrote: > Generally I think things are looking pretty good, but there's still an open > question and Precommit CI is still failing on Windows: > > Failed Tests (7): > Clang-Unit :: >

[PATCH] D121556: [randstruct] Add randomize structure layout support

aaron.ballman added a comment. Generally I think things are looking pretty good, but there's still an open question and Precommit CI is still failing on Windows: Failed Tests (7): Clang-Unit :: AST/./ASTTests.exe/StructureLayoutRandomization.AnonymousStructsAndUnionsRetainFieldOrder

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. Friendly ping for review. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 419282. void added a comment. Moved the randomization to a better spot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files: clang/include/clang/AST/Decl.h

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 418480. void added a comment. - Make sure the command line seed is properly passed on to each front-end level. - Some general cleanups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 418356. void marked 2 inline comments as done. void added a comment. Move casting check into the SemaCast where it belongs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added inline comments. Comment at: clang/include/clang/AST/Decl.h:2842 mutable unsigned CachedFieldIndex : 30; + mutable unsigned OriginalFieldIndex : 30; aaron.ballman wrote: > It's unfortunate that every field node in the AST is now going to be 4

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 418307. void marked 5 inline comments as done. void added a comment. Add "err_" prefix to error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files:

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 418305. void added a comment. Herald added a subscriber: MaskRay. Fix how the command line flags are handled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files:

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 416808. void added a comment. Move SEED into LangOpts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files: clang/include/clang/AST/Decl.h

[PATCH] D121556: [randstruct] Add randomize structure layout support

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Randstruct.h:34 + +extern std::string SEED; + void wrote: > aaron.ballman wrote: > > Doing this with a global variable is unfortunate; it could make things > > harder when we multithread

[PATCH] D121556: [randstruct] Add randomize structure layout support

void marked 7 inline comments as done. void added inline comments. Comment at: clang/include/clang/AST/Decl.h:4067 + + void setIsRandomized(bool V) const { RecordDeclBits.IsRandomized = V; } + aaron.ballman wrote: > A setter that is marked `const` does not

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 416354. void marked 3 inline comments as done. void added a comment. General cleanup of code. Removing unneeded headers and comments. Removing a "const" from a setter. Not defining this for MS's declspecs or making the attributes keywords. Repository: rG

[PATCH] D121556: [randstruct] Add randomize structure layout support

aaron.ballman added a comment. Thank you for working on this new security feature! I like it and I think it's heading in the right direction. Can you please add a release note for the new functionality? This is missing tests for the Driver diagnostics, the Sema diagnostics (including existing

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added reviewers: jfb, connorkuehl, rsmith, timpugh. void added subscribers: connorkuehl, Dan, xbolva00, shawnl, dexonsmith, daloni, hintonda, riccibruno, vlad.tsyrklevich, ebevhan, kees, pcc, nickdesaulniers. void added a comment. This is a soft reworking of @connorkuehl's work in

[PATCH] D121556: [randstruct] Add randomize structure layout support

void created this revision. Herald added subscribers: dang, jdoerfert, mgorny. Herald added a reviewer: aaron.ballman. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Randstruct feature is a