[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

kadircet added a comment. Hi @Abpostelnicu, as @nridge pointed out. we're actively working on the library pieces of include-cleaner and applications of the library aren't the focus yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121593/new/

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

nridge added a comment. In D121593#3896892 , @Abpostelnicu wrote: > was there any progress on this so far? This would be really useful to be a > clang-tidy check. My impression is that it's actively being worked on:

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

Abpostelnicu added a comment. @sammccall was there any progress on this so far? This would be really useful to be a clang-tidy check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121593/new/ https://reviews.llvm.org/D121593

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

xbolva00 added a comment. Any progress? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121593/new/ https://reviews.llvm.org/D121593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

sammccall added a comment. We'd like to proceed here by extracting the include-cleaner functionality from clangd into a library. It would be used by: - clangd - a new clang-tidy check - possibly a standalone tool, if clang-tidy doesn't fit well into the cleanup workflow - some out-of-tree

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

xbolva00 added a comment. This sounds really cool! >> Overall I suspect making this a tidy check would make it more useful to more >> people. Yup, it would be super useful addition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121593/new/

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

sammccall added a comment. This is exciting! We weren't sure how much effort to put into decoupling this from clangd, whether there'd be interest in such a standalone tool. Some thoughts at a high level: --- Eventually we should separate this from clangd. I don't think it necessarily needs

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

kbobyrev added a comment. Hi! I'm glad you're excited about IncludeCleaner and having a tool to try it out seems like a cool idea! > I'm not sure why include-cleaner wasn't integrated in clang-tidy, but I > suspect there's a good reason. The problem with IncludeCleaner as of right now is that

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

serge-sans-paille created this revision. serge-sans-paille added reviewers: kbobyrev, sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added subscribers: cfe-commits, MaskRay,