[PATCH] D122885: [clang] Draft: Implement P1703R1

urnathan requested changes to this revision. urnathan added a comment. This revision now requires changes to proceed. Either update this when you're ready, or abandon and create a new one for 1857. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122885: [clang] Draft: Implement P1703R1

iains added a comment. FWIW probably these 5 patches are pretty independent of changes to the preprocessor... ... the first four of those are extremely unlikely to clash - since they are concerned with the driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122885: [clang] Draft: Implement P1703R1

ChuanqiXu added a comment. In D122885#3431618 , @tbaeder wrote: > What patches are you talking about exactly? I mean D121588 D121589 D121590

[PATCH] D122885: [clang] Draft: Implement P1703R1

tbaeder added a comment. What patches are you talking about exactly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122885/new/ https://reviews.llvm.org/D122885 ___ cfe-commits mailing list

[PATCH] D122885: [clang] Draft: Implement P1703R1

ChuanqiXu added a comment. BTW, I think it is helpful to add @iains's patches as parent versions to avoid conflicting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122885/new/ https://reviews.llvm.org/D122885

[PATCH] D122885: [clang] Draft: Implement P1703R1

tbaeder added a comment. In D122885#3426070 , @urnathan wrote: > Ah, I'd had a thinko about what 1703 was. that's superseded by > p1757wg21.link/p1857. That's what is needed. (your patch > makes more sense in the 1703 context) Ha, okay. Yes, that

[PATCH] D122885: [clang] Draft: Implement P1703R1

urnathan added a comment. Ah, I'd had a thinko about what 1703 was. that's superseded by p1757. That's what is needed. (your patch makes more sense in the 1703 context) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122885/new/

[PATCH] D122885: [clang] Draft: Implement P1703R1

urnathan added a comment. oh, also in 'import "bob";', "bob" needs to be lexed as a #include name, not a string. (and likewise 'import ;') Hence treating these lines in the preprocessor in directive-processing-mode was the way GCC went. Comment at:

[PATCH] D122885: [clang] Draft: Implement P1703R1

urnathan added a comment. I can;t really tell what you're doing. C++20 lexes import () declarations as preprocessor directives. the parser must also recognize only such declarations that came through from lexing such directives. It is unrelated to #import. GCC's implementation drops the

[PATCH] D122885: [clang] Draft: Implement P1703R1

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, iains, urnathan, ChuanqiXu. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As in: