[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

whisperity added a comment. In D124447#3651074 , @whisperity wrote: > I will attempt to write a concise response to this today (and tomorrow)! > Sorry, I was away travelling to and doing post-action bureaucracy of > conferences the past few weeks.

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

whisperity added a comment. In D124447#3645197 , @sammccall wrote: > In D124447#3608747 , @aaron.ballman > wrote: > >> In general, I think this is looking pretty close to good. Whether clang-tidy >> should get

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

sammccall added a comment. In D124447#3608747 , @aaron.ballman wrote: > In general, I think this is looking pretty close to good. Whether clang-tidy > should get this functionality in this form or not is a bit less clear to me. > *I* think it's

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

kadircet added a comment. The idea looks great in general, I didn't get a chance to look at all the details but this also creates some concerns for integrations of clang-tidy checks in other environments (like clangd or tidy running in distributed systems) as the workflow actually needs to be

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

aaron.ballman added a comment. In general, I think this is looking pretty close to good. Whether clang-tidy should get this functionality in this form or not is a bit less clear to me. *I* think it's helpful functionality and the current approach is reasonable, but I think it might be

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

whisperity added a comment. In D124447#3506536 , @whisperity wrote: > In D124447#3493996 , @whisperity > wrote: > >> In D124447#3493446 , >> @aaron.ballman wrote: >>

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

whisperity added a comment. In D124447#3493996 , @whisperity wrote: > In D124447#3493446 , @aaron.ballman > wrote: > >> precommit CI is showing a fair amount of failures that I believe are related >> to your

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

whisperity added a comment. In D124447#3493446 , @aaron.ballman wrote: > precommit CI is showing a fair amount of failures that I believe are related > to your patch. It was me who helped @bahramib to rebase and split a much larger and more

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

aaron.ballman added a reviewer: alexfh. aaron.ballman added a comment. Thanks, I think this is a neat idea! I haven't had the chance to review thoroughly yet, but wanted to point out that precommit CI is showing a fair amount of failures that I believe are related to your patch. Repository:

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

martong added a comment. Very good, this is a great initiative! Also, the quality of this patch is high, docs are great, even the release notes are updated. I would accept if I were that confident in Clang-tidy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

bahramib created this revision. bahramib added reviewers: aaron.ballman, njames93, whisperity, martong. bahramib added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, arphaman, rnkovacs, xazax.hun. Herald added a project: All. bahramib requested review of this revision.