[PATCH] D127874: [analyzer] Reimplement UnreachableCodeChecker using worklists

2022-07-07 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. In D127874#3628112 , @martong wrote: >> I don't think any of the issues mentioned in this patch relates to strongly >> connected components, thus I don't think I can answer to this question. > > In your example above, repeated

[PATCH] D127874: [analyzer] Reimplement UnreachableCodeChecker using worklists

2022-07-04 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. In D127874#3628112 , @martong wrote: >> I don't think any of the issues mentioned in this patch relates to strongly >> connected components, thus I don't think I can answer to this question. > > In your example above, repeated

[PATCH] D127874: [analyzer] Reimplement UnreachableCodeChecker using worklists

2022-07-04 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. > I don't think any of the issues mentioned in this patch relates to strongly > connected components, thus I don't think I can answer to this question. In your example above, repeated here: #6(entry) #2(goto a;) | |^ #5(goto end;) |

[PATCH] D127874: [analyzer] Reimplement UnreachableCodeChecker using worklists

2022-06-16 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. In D127874#3588786 , @martong wrote: >> If some checker placed a sink node into some block, the successors of the >> sink block was marked unreachable previously. This leads to an unpleasant >> situation from the user's point

[PATCH] D127874: [analyzer] Reimplement UnreachableCodeChecker using worklists

2022-06-16 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. > If some checker placed a sink node into some block, the successors of the > sink block was marked unreachable previously. This leads to an unpleasant > situation from the user's point of view since a different bugreport gets > correlated with the FPs caused by the

[PATCH] D127874: [analyzer] Reimplement UnreachableCodeChecker using worklists

2022-06-15 Thread Balázs Benics via Phabricator via cfe-commits
steakhal created this revision. steakhal added reviewers: NoQ, martong, balazske, ASDenysPetrov, Szelethus, frederic-tingaud-sonarsource. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All.