[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

tianshilei1992 added a comment. Herald added subscribers: ekilmer, jplehr, StephenFan. This patch breaks the assumption that some projects are supposed to support to be built as a standalone project. For example, we do have a standalone release for OpenMP

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

Ericson2314 added a comment. @sebastian-ne Thanks. Your commit 100% makes it better than it was (straight typo on my part), so I cherry-picked it to `release/15.x`: 2647f7274782e4a529d7c3a9920de86ddfe72324 @sylvestre.ledru

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

sebastian-ne added a comment. I pushed a potential fix (removing the backslash) in 50716ba2b337afe46ac256cc91673dc27356a776 . I don’t know which buildbots to look at though, it looks like the OpenMP ones all succeed. PS:

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

sebastian-ne added inline comments. Comment at: openmp/runtime/src/CMakeLists.txt:383 \"${alias}${LIBOMP_LIBRARY_SUFFIX}\" WORKING_DIRECTORY -\"\$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${OPENMP_INSTALL_LIBDIR}\")") +\"\$ENV{DESTDIR}\${outdir}\")")

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

sylvestre.ledru added a comment. Same, it broke apt.llvm.org It is installing some of the libs in debian/tmp/libgomp.so instead of debian/tmp/usr/lib/llvm-15/lib/libgomp.so I think it should be indeed revert (and in the branch 15 too) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

Ericson2314 added a comment. Hmm I am getting failed builds from this one but not quite sure what the problem is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130545/new/ https://reviews.llvm.org/D130545

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28e665fa054d: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs (authored by Ericson2314). Repository: rG LLVM Github

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

Ericson2314 added inline comments. Comment at: openmp/CMakeLists.txt:3 -# Add cmake directory to search for custom cmake functions. -set(CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake ${CMAKE_MODULE_PATH}) +set(LLVM_COMMON_CMAKE_UTILS ${CMAKE_CURRENT_SOURCE_DIR}/../cmake)

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

sebastian-ne accepted this revision. sebastian-ne added a comment. This revision is now accepted and ready to land. Looks good to me Comment at: openmp/CMakeLists.txt:3 -# Add cmake directory to search for custom cmake functions. -set(CMAKE_MODULE_PATH

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

Ericson2314 updated this revision to Diff 447569. Ericson2314 added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, sstefan1. Herald added a project: LLVM. Add another fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

Ericson2314 created this revision. Ericson2314 added reviewers: sebastian-ne, beanz, phosek, sterni, lebedev.ri. Herald added a subscriber: mgorny. Herald added a project: All. Ericson2314 requested review of this revision. Herald added projects: clang, OpenMP. Herald added subscribers: