[PATCH] D132398: Allow constant static members to be used with 'this'

2023-02-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D132398#4150851 , @cor3ntin wrote: > Given this has not made progress in a while, I think we should try to > implement > https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2280r4.html instead > of this

[PATCH] D132398: Allow constant static members to be used with 'this'

2023-02-24 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. Herald added a subscriber: ChuanqiXu. Given this has not made progress in a while, I think we should try to implement https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2280r4.html instead of this approach, as I'm not sure if that's strictly conforming, and a

[PATCH] D132398: Allow constant static members to be used with 'this'

2022-08-26 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8458 + Info.AccessingStaticConstantDataMember); + if(Info.InConstantContext) +Info.AccessingStaticConstantDataMember = true; When not in a constant-context, what

[PATCH] D132398: Allow constant static members to be used with 'this'

2022-08-26 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added reviewers: aaron.ballman, clang-language-wg. aaron.ballman added a comment. Thanks for this! Can you add some more details to the patch description so it's more clear from there why the patch is necessary? Also, can you add a release note for the fix? I'm pretty sure the

[PATCH] D132398: Allow constant static members to be used with 'this'

2022-08-23 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 454947. usaxena95 added a comment. Format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132398/new/ https://reviews.llvm.org/D132398 Files: clang/lib/AST/ExprConstant.cpp