[PATCH] D134654: [clang] Detect header loops

urnathan added a comment. In D134654#4645969 , @cor3ntin wrote: > @aaron.ballman @urnathan What is the status of this PR? I'd kind of forgotten about it. Did get a query from, I think, boost about how I detected the loops I reported -- which was by

[PATCH] D134654: [clang] Detect header loops

cor3ntin added a comment. @aaron.ballman @urnathan What is the status of this PR? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134654/new/ https://reviews.llvm.org/D134654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134654: [clang] Detect header loops

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:323 "whitespace recommended after macro name">; +def warn_include_cycle : Warning<"#include cycle">, + InGroup>, DefaultIgnore; urnathan wrote: > urnathan

[PATCH] D134654: [clang] Detect header loops

urnathan added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:323 "whitespace recommended after macro name">; +def warn_include_cycle : Warning<"#include cycle">, + InGroup>, DefaultIgnore; philnik wrote: > aaron.ballman wrote:

[PATCH] D134654: [clang] Detect header loops

philnik added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:323 "whitespace recommended after macro name">; +def warn_include_cycle : Warning<"#include cycle">, + InGroup>, DefaultIgnore; aaron.ballman wrote: > urnathan wrote:

[PATCH] D134654: [clang] Detect header loops

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:323 "whitespace recommended after macro name">; +def warn_include_cycle : Warning<"#include cycle">, + InGroup>, DefaultIgnore; urnathan wrote: > aaron.ballman

[PATCH] D134654: [clang] Detect header loops

urnathan marked 2 inline comments as done. urnathan added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:323 "whitespace recommended after macro name">; +def warn_include_cycle : Warning<"#include cycle">, + InGroup>, DefaultIgnore;

[PATCH] D134654: [clang] Detect header loops

urnathan updated this revision to Diff 465007. urnathan marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134654/new/ https://reviews.llvm.org/D134654 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/include/clang/Lex/Preprocessor.h

[PATCH] D134654: [clang] Detect header loops

urnathan updated this revision to Diff 465006. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134654/new/ https://reviews.llvm.org/D134654 Files: clang/include/clang/Basic/FileEntry.h clang/lib/Lex/PPDirectives.cpp clang/lib/Lex/PPLexerChange.cpp Index:

[PATCH] D134654: [clang] Detect header loops

aaron.ballman added inline comments. Comment at: clang/test/Preprocessor/warn-loop-macro-1.h:3 +#define LOOP_MACRO_1 +// expected-warning@+1 {{#include cycle}} +#include "warn-loop-macro-1.h" erichkeane wrote: > aaron.ballman wrote: > > For example, as a user, I

[PATCH] D134654: [clang] Detect header loops

erichkeane added inline comments. Comment at: clang/test/Preprocessor/warn-loop-macro-1.h:3 +#define LOOP_MACRO_1 +// expected-warning@+1 {{#include cycle}} +#include "warn-loop-macro-1.h" aaron.ballman wrote: > For example, as a user, I would look at this