[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

2022-12-08 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D135269#3982103 , @jrbyrnes wrote: > In D135269#3981856 , @yaxunl wrote: > >> In D135269#3981561 , @nikic wrote: >> >>> Checking back here

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

2022-12-08 Thread Jeffrey Byrnes via Phabricator via cfe-commits
jrbyrnes added a comment. In D135269#3981856 , @yaxunl wrote: > In D135269#3981561 , @nikic wrote: > >> Checking back here again on whether there is any progress on finding the >> root cause of the issue. If no

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

2022-12-08 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a subscriber: jrbyrnes. yaxunl added a comment. In D135269#3981561 , @nikic wrote: > Checking back here again on whether there is any progress on finding the root > cause of the issue. If no progress is expected in the near future, I'd ask

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

2022-12-08 Thread Nikita Popov via Phabricator via cfe-commits
nikic added a comment. Checking back here again on whether there is any progress on finding the root cause of the issue. If no progress is expected in the near future, I'd ask for this patch to be reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

2022-10-18 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D135269#3863470 , @nikic wrote: > Checking back here, have you made any progress on reducing the issue? > > cc @arsenm for awareness No. I am busy with other work and have not got time to get back on it. Repository: rG

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

2022-10-17 Thread Nikita Popov via Phabricator via cfe-commits
nikic added subscribers: arsenm, nikic. nikic added a comment. Checking back here, have you made any progress on reducing the issue? cc @arsenm for awareness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135269/new/

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

2022-10-07 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG107ee2613063: [AMDGPU] Disable bool range metadata to workaround backend issue (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

2022-10-06 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 465731. yaxunl marked an inline comment as done. yaxunl edited the summary of this revision. yaxunl added a comment. update comments with issue link CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135269/new/ https://reviews.llvm.org/D135269 Files:

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

2022-10-05 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:1792 // attach range metadata to the load. - } else if (CGM.getCodeGenOpts().OptimizationLevel > 0) +// TODO: Enable range metadata for AMDGCN after backend

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

2022-10-05 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:1792 // attach range metadata to the load. - } else if (CGM.getCodeGenOpts().OptimizationLevel > 0) +// TODO: Enable range metadata for AMDGCN after backend issue is fixed. + } else if

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

2022-10-05 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D135269#3837394 , @tra wrote: > Is there more info about the issue? What does AMDGPU currently emit for the > test case? > > AFAICT from running it on CE (https://godbolt.org/z/ccq3vnbrM) llvm optimizes > it to essentially

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

2022-10-05 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. Is there more info about the issue? What does AMDGPU currently emit for the test case? AFAICT from running it on CE (https://godbolt.org/z/ccq3vnbrM) llvm optimizes it to essentially `*y = *x` and generates a 1-byte load+store for both NVPTX and AMDGPU. CHANGES SINCE

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

2022-10-05 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 465403. yaxunl added a comment. fix comments in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135269/new/ https://reviews.llvm.org/D135269 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGenCUDA/bool-range.cu Index:

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

2022-10-05 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tra, ronl. Herald added subscribers: kosarev, t-tye, tpr, dstuttard, kzhuravl. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: wdng. Currently there is some backend issue which causes values