[PATCH] D135989: [clang][Sema] Use size of char for void types

serge-sans-paille added a comment. Thanks for clarifying! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135989/new/ https://reviews.llvm.org/D135989 ___ cfe-commits mailing list

[PATCH] D135989: [clang][Sema] Use size of char for void types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91b3823bd000: [clang][Sema] Use size of char in bits for void types (authored by void). Changed prior to commit:

[PATCH] D135989: [clang][Sema] Use size of char for void types

void added a comment. In D135989#3859763 , @nickdesaulniers wrote: > LGTM; please consider appending to the commit message something along the > lines of "operations on the result of getTypeSize() are in bits, not bytes. > Using 1 as the value for

[PATCH] D135989: [clang][Sema] Use size of char for void types

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. LGTM; please consider appending to the commit message something along the lines of "operations on the result of getTypeSize() are in bits, not bytes. Using 1 as the value

[PATCH] D135989: [clang][Sema] Use size of char for void types

void updated this revision to Diff 467912. void added a comment. Fix up testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135989/new/ https://reviews.llvm.org/D135989 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D135989: [clang][Sema] Use size of char for void types

void added inline comments. Comment at: clang/test/Sema/array-bounds-ptr-arith.c:14 +void* broken (struct ext2_super_block *es,int a) { + return (void *)es->s_uuid + 9; // expected-warning {{the pointer incremented by 9 refers past the end of the array (that contains 8

[PATCH] D135989: [clang][Sema] Use size of char for void types

nickdesaulniers added inline comments. Comment at: clang/test/Sema/array-bounds-ptr-arith.c:14 +void* broken (struct ext2_super_block *es,int a) { + return (void *)es->s_uuid + 9; // expected-warning {{the pointer incremented by 9 refers past the end of the array (that

[PATCH] D135989: [clang][Sema] Use size of char for void types

void added inline comments. Comment at: clang/test/Sema/array-bounds-ptr-arith.c:14 +void* broken (struct ext2_super_block *es,int a) { + return (void *)es->s_uuid + 9; // expected-warning {{the pointer incremented by 9 refers past the end of the array (that contains 8

[PATCH] D135989: [clang][Sema] Use size of char for void types

serge-sans-paille added inline comments. Comment at: clang/test/Sema/array-bounds-ptr-arith.c:14 +void* broken (struct ext2_super_block *es,int a) { + return (void *)es->s_uuid + 9; // expected-warning {{the pointer incremented by 9 refers past the end of the array (that

[PATCH] D135989: [clang][Sema] Use size of char for void types

void created this revision. void added reviewers: serge-sans-paille, kees, nickdesaulniers. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The extension that allows for pointer arithmetic on 'void' types