[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

uabelho added a comment. I noticed that gvn-hoist doesn't handle this very nicely, I just wrote https://github.com/llvm/llvm-project/issues/61023 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

This revision was automatically updated to reflect the committed changes. Closed by commit rG329ef60f3e21: [Clang] support for outputs along indirect edges of asm goto (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 498157. nickdesaulniers added a comment. - final rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 Files: clang/docs/LanguageExtensions.rst

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 495175. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 Files: clang/docs/LanguageExtensions.rst

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers marked 2 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1584 +Outputs may be used along any branches from the ``asm goto`` whether the +branches are taken or not. void wrote: >

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

void accepted this revision. void added a comment. This revision is now accepted and ready to land. One small comment about the documentation but L:GTM. Comment at: clang/docs/LanguageExtensions.rst:1584 +Outputs may be used along any branches from the ``asm goto`` whether the

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

efriedma added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1584 +Outputs may be used along any branches from the ``asm goto`` whether the +branches are taken or not. Maybe put a note about earlier releases, so people don't get confused if

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 491857. nickdesaulniers marked 3 inline comments as done. nickdesaulniers added a comment. - use densemap, update release note, use !empty rather than size as per @void Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

void added inline comments. Comment at: clang/docs/ReleaseNotes.rst:199 + guaranteed (and necessary to support outputs along indirect edges, which is + now supported as of this release). + Is it worth it to mention that this change makes Clang's behavior with

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 490246. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 Files: clang/docs/LanguageExtensions.rst

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 487929. nickdesaulniers added a comment. - rebase, format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 Files: clang/docs/LanguageExtensions.rst

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers added a comment. Ready for review: 1. https://reviews.llvm.org/D135997 2. https://reviews.llvm.org/D140166 3. https://reviews.llvm.org/D139861 4. https://reviews.llvm.org/D139872 5. https://reviews.llvm.org/D139883 6. https://reviews.llvm.org/D139970 7.

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 484678. nickdesaulniers added a comment. - add clang release notes from D138078 and new one for new feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 484671. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - rebase, drop callbrpad inst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers added a comment. Probably should copy the release note change from https://reviews.llvm.org/D138078. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 480993. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - rebase, use new callbrpad inst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2868-2873 + // If we happen to share the same indirect and default dest, don't re-add + // stores. That was done for the default destination in the above call to + // EmitAsmStores. +

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 472152. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - reroll for a new sha so that phab unmarks this as "changes planned" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2868-2873 + // If we happen to share the same indirect and default dest, don't re-add + // stores. That was done for the default destination in the above call to + // EmitAsmStores. +

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 472144. nickdesaulniers added a comment. - remove unnecssary asserts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 Files:

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2868-2873 + // If we happen to share the same indirect and default dest, don't re-add + // stores. That was done for the default destination in the above call to + // EmitAsmStores. +

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

void added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2868-2873 + // If we happen to share the same indirect and default dest, don't re-add + // stores. That was done for the default destination in the above call to + // EmitAsmStores. +

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2867 +for (unsigned i = 0, e = CBR->getNumIndirectDests(); i != e; ++i) { + assert(CBRRegResults[i].size() == ResultRegTypes.size()); +

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 472136. nickdesaulniers added a comment. - rebase on D137113 , add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2850 assert(RegResults.size() == ResultRegTypes.size()); assert(RegResults.size() == ResultTruncRegTypes.size()); nickdesaulniers wrote: > void wrote: > > Should these

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2362 + // a pointer. + if (TruncTy->isFloatingPointTy()) +Tmp = Builder.CreateFPTrunc(Tmp, TruncTy); nickdesaulniers wrote: > void wrote: > > This looks like a

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. In D136497#3889938 , @void wrote: > It might be easier to see the main changes here if you submit the (very nice) > refactoring of `EmitAsmStores` first. D137113

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

void added a comment. It might be easier to see the main changes here if you submit the (very nice) refactoring of `EmitAsmStores` first. Comment at: clang/lib/CodeGen/CGStmt.cpp:2358 +// the expression, do the conversion. +if (ResultRegTypes[i] !=

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 469782. nickdesaulniers added a comment. - update LanguageExtensions doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 Files:

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers added a comment. Note to reviewers: I expect this to be one of a 3 part progression. 1. Fix DomTree D135997 2. Fix front end D136497 3. Fix back end (TODO) Hopefully that's it; famous last words...

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 469767. nickdesaulniers added a comment. - git clang-format HEAD~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 Files: clang/lib/CodeGen/CGStmt.cpp

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 469764. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - add note to commit message (let's see if phab captures what I wrote, used arc diff --verbatim) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers created this revision. nickdesaulniers added reviewers: nikic, void, jyknight, efriedma, craig.topper. Herald added a subscriber: StephenFan. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: