[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG983f63f7f0d1: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138010/new/ https://reviews.llvm.org/D138010 _

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/include/llvm/Support/ARMTargetParser.def:127 + ARM::AEK_HWDIVTHUMB | ARM::AEK_DSP | ARM::AEK_CRC | ARM::AEK_RAS | + ARM::AEK_DOTPROD | ARM::AEK_BF16 | ARM::AEK_I8MM)) ARM_ARCH

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

stuij updated this revision to Diff 475489. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138010/new/ https://reviews.llvm.org/D138010 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

pratlucas added inline comments. Comment at: llvm/unittests/Support/TargetParserTest.cpp:532 + testARMArch("armv9.4-a", "generic", "v9.4a", + ARMBuildAttrs::CPUArch::v8_A)); EXPECT_TRUE( Should this be testing for `ARMBuildAttrs::

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

pratlucas added inline comments. Comment at: llvm/include/llvm/Support/ARMTargetParser.def:127 + ARM::AEK_HWDIVTHUMB | ARM::AEK_DSP | ARM::AEK_CRC | ARM::AEK_RAS | + ARM::AEK_DOTPROD | ARM::AEK_BF16 | ARM::AEK_I8MM)) ARM_ARCH("armv9-a", ARMV9A, "9-A", "v9a", --

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/include/llvm/Support/ARMTargetParser.def:127 + ARM::AEK_HWDIVTHUMB | ARM::AEK_DSP | ARM::AEK_CRC | ARM::AEK_RAS | + ARM::AEK_DOTPROD | ARM::AEK_BF16 | ARM::AEK_I8MM)) ARM_ARCH

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

stuij updated this revision to Diff 475454. stuij added a comment. make work with recent TargetParser changes (D137924 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138010/new/ https://reviews.llvm.org/D138010

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

tmatheson added inline comments. Comment at: llvm/include/llvm/Support/ARMTargetParser.def:127 + ARM::AEK_HWDIVTHUMB | ARM::AEK_DSP | ARM::AEK_CRC | ARM::AEK_RAS | + ARM::AEK_DOTPROD | ARM::AEK_BF16 | ARM::AEK_I8MM)) ARM_ARCH("armv9-a", ARMV9A, "9-A", "v9a", --

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

pratlucas added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:70-76 +AARCH64_ARCH("armv8.9-a", ARMV8_9A, "8.9-A", "v8.9a", + ARMBuildAttrs::CPUArch::v8_A, FK_CRYPTO_NEON_FP_ARMV8, + (AArch64::AEK_CRC | AArch64::AEK_FP | +

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

stuij created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. stuij requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. For both ARM and AArch64 add support for specifyi