[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45659b3bd98e: [include-cleaner] Remove filtering from UsingDecl visit. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 481213. VitaNuo marked 4 inline comments as done. VitaNuo added a comment. Formatting fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D138821 Files:

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks. You can add a `Fix: https://github.com/llvm/llvm-project/issues/59147` in the commit message, it will automatically close the github issue when you commit the patch.

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo marked 2 inline comments as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:130 TEST(WalkAST, Using) { - // Make sure we ignore unused overloads. + // We should report unused overloads as ambiguous.

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 480418. VitaNuo added a comment. Change/remove stale comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D138821 Files:

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:130 TEST(WalkAST, Using) { - // Make sure we ignore unused overloads. + // We should report unused overloads as ambiguous. testWalk(R"cpp( hokein wrote: >

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:86 report(UD->getLocation(), TD, IsUsed ? RefType::Explicit : RefType::Ambiguous); } hokein wrote: > VitaNuo wrote: > > kadircet wrote: > > >

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 480375. VitaNuo added a comment. Re-introduce the isUsed check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D138821 Files:

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:86 report(UD->getLocation(), TD, IsUsed ? RefType::Explicit : RefType::Ambiguous); } VitaNuo wrote: > kadircet wrote: > > hokein wrote: > > > we

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 479216. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Address review comments, remove excessive tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo marked 4 inline comments as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:86 report(UD->getLocation(), TD, IsUsed ? RefType::Explicit : RefType::Ambiguous); } kadircet wrote:

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:86 report(UD->getLocation(), TD, IsUsed ? RefType::Explicit : RefType::Ambiguous); } hokein wrote: > we should report all references as

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:130 TEST(WalkAST, Using) { - // Make sure we ignore unused overloads. + // We should report unused overloads as ambiguous. testWalk(R"cpp( nit: update the

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:87 - // headers might still be used by the dependents of the header. - if (!IsUsed && !IsHeader) -continue;

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 478556. VitaNuo added a comment. Address review comments: turn all references into explicit, remove the "isHeader" field. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:86 report(UD->getLocation(), TD, IsUsed ? RefType::Explicit : RefType::Ambiguous); } we should report all references as explicit.

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 478267. VitaNuo added a comment. Edit commit message, add "[include-cleaner]". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D138821 Files: