[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

glandium added a comment. There is a check already, but it's not enough: https://github.com/llvm/llvm-project/issues/52683 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138846/new/ https://reviews.llvm.org/D138846

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

MaskRay added a comment. In D138846#4657246 , @hans wrote: >> I just saw @glandium's earlier comment: >> >>> Code built with older versions of LLVM (e.g. rust) and running with the >>> updated runtime crash at startup with this change. >> >> This is the

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

hans added a comment. > I just saw @glandium's earlier comment: > >> Code built with older versions of LLVM (e.g. rust) and running with the >> updated runtime crash at startup with this change. > > This is the exact same issue we encountered. Because there is a profile > format change, it's

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

glandium added a comment. FWIW, it's the first time for as long as I remember that mixing LLVM versions causes a runtime crash (that looks like a null deref). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138846/new/

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

zequanwu added a comment. In D138846#4657195 , @zequanwu wrote: > In D138846#4657194 , @alanphipps > wrote: > >> In D138846#4657193 , @zequanwu >> wrote: >> >>> In

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

zequanwu added a comment. In D138846#4657194 , @alanphipps wrote: > In D138846#4657193 , @zequanwu > wrote: > >> In D138846#4657175 , @hans wrote: >> >>> We're seeing

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

alanphipps added a comment. In D138846#4657193 , @zequanwu wrote: > In D138846#4657175 , @hans wrote: > >> We're seeing crashes in `initializeValueProfRuntimeRecord` that bisects to >> this commit. I think

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

zequanwu added a comment. In D138846#4657175 , @hans wrote: > We're seeing crashes in `initializeValueProfRuntimeRecord` that bisects to > this commit. I think Zequan is investigating: > https://bugs.chromium.org/p/chromium/issues/detail?id=1503919 It

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

alanphipps added a comment. In D138846#4657152 , @glandium wrote: > In D138846#4656607 , @glandium > wrote: > >> Code built with older versions of LLVM (e.g. rust) and running with the >> updated runtime crash

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

hans added a comment. We're seeing crashes in `initializeValueProfRuntimeRecord` that bisects to this commit. I think Zequan is investigating: https://bugs.chromium.org/p/chromium/issues/detail?id=1503919 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

glandium added a comment. In D138846#4656607 , @glandium wrote: > Code built with older versions of LLVM (e.g. rust) and running with the > updated runtime crash at startup with this change. FWIW, neither followups fixed this issue. The crash happens

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

alanphipps added a comment. In D138846#4656594 , @hans wrote: > Just a heads up that we're seeing crashes in the Rust compiler which bisects > to this change. Investigating in > https://bugs.chromium.org/p/chromium/issues/detail?id=1500558 Thank you

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

hans added a comment. In D138846#4656594 , @hans wrote: > Just a heads up that we're seeing crashes in the Rust compiler which bisects > to this change. Investigating in > https://bugs.chromium.org/p/chromium/issues/detail?id=1500558 Here's a small

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

glandium added a comment. Code built with older versions of LLVM (e.g. rust) and running with the updated runtime crash at startup with this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138846/new/ https://reviews.llvm.org/D138846

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

hans added a comment. Just a heads up that we're seeing crashes in the Rust compiler which bisects to this change. Investigating in https://bugs.chromium.org/p/chromium/issues/detail?id=1500558 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

w2yehia added a comment. @alanphipps thanks for handling the AIX case. From inspection it looks sufficient. I wasn't able to apply the patch with `arc`, so I'll wait for it to land and report/fix any AIX specific issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138846/new/

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

alanphipps added a comment. Hi @hans @w2yehia Please let me know if you have any additional concerns. I'd like to reland this within the next day or so. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138846/new/ https://reviews.llvm.org/D138846

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

alanphipps added a comment. In D138846#4649609 , @w2yehia wrote: > Please update InstrProfilingPlatformAIX.c as well, specifically add new dummy > vars for the new section. > Edit: I can post the patch if you wish. I just added the dummy vars, but you

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

alanphipps added a comment. > I added steps to download the profile here: > https://bugs.chromium.org/p/chromium/issues/detail?id=1485303#c4 > I think this should be reverted while being investigated: > https://github.com/llvm/llvm-project/commit/53a2923bf67bc164558d489493176630123abf7e Thank

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

w2yehia added a comment. Please update InstrProfilingPlatformAIX.c as well, specifically add new dummy vars for the new section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138846/new/ https://reviews.llvm.org/D138846

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

hans added a comment. I just noticed this also broke some lit tests on mac: https://bugs.chromium.org/p/chromium/issues/detail?id=1485487#c0 That's also visible on greendragon: https://green.lab.llvm.org/green/view/Clang/job/clang-stage1-RA/35721/testReport/ Repository: rG LLVM Github

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

hans added a comment. In D138846#4649147 , @alanphipps wrote: > In D138846#4649110 , @akhuang wrote: > >> I'm still working on a repro, but after this patch we're seeing "truncated >> profile data" errors in

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

alanphipps added a comment. In D138846#4649110 , @akhuang wrote: > I'm still working on a repro, but after this patch we're seeing "truncated > profile data" errors in chromium (crbug.com/1485303) Thank you for the heads-up! If there's an issue, I'm

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

akhuang added a comment. I'm still working on a repro, but after this patch we're seeing "truncated profile data" errors in chromium Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138846/new/ https://reviews.llvm.org/D138846