[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:7 // RUN: %clang_cc1 -emit-llvm %std_cxx17- -dwarf-version=4 -triple x86_64 %s -O0 -disable-llvm-passes -debug-info-kind=standalone -o - | FileCheck %s

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

aprantl added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:7 // RUN: %clang_cc1 -emit-llvm %std_cxx17- -dwarf-version=4 -triple x86_64 %s -O0 -disable-llvm-passes -debug-info-kind=standalone -o - | FileCheck %s

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

aprantl added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:7 // RUN: %clang_cc1 -emit-llvm %std_cxx17- -dwarf-version=4 -triple x86_64 %s -O0 -disable-llvm-passes -debug-info-kind=standalone -o - | FileCheck %s

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:7 // RUN: %clang_cc1 -emit-llvm %std_cxx17- -dwarf-version=4 -triple x86_64 %s -O0 -disable-llvm-passes -debug-info-kind=standalone -o - | FileCheck %s

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 added a comment. Ack, looking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139953/new/ https://reviews.llvm.org/D139953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

chapuni added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:7 // RUN: %clang_cc1 -emit-llvm %std_cxx17- -dwarf-version=4 -triple x86_64 %s -O0 -disable-llvm-passes -debug-info-kind=standalone -o - | FileCheck %s

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9861e5718f6: [llvm][DebugInfo] Backport DW_AT_default_value for template args (authored by Michael137). Repository: rG LLVM Github Monorepo

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 updated this revision to Diff 482995. Michael137 added a comment. - Fix label name - Add check for end of block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139953/new/ https://reviews.llvm.org/D139953 Files:

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

dblaikie accepted this revision. dblaikie added a comment. I think this is good - with some check after the template list to constrain the dag/not checks to only be within the intended tag, not accidentally skip past into some other tag. Comment at:

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

probinson added a comment. > CHECK-LABEL doesn't have to match a line in the file uniquely. I mean, it's good practice if they do match uniquely; that way you don't get excessively confusing results when the output changes, and things start matching where you didn't expect. But it's not a

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

probinson added a comment. > IIUC the labels have to match a line in the file uniquely, which the DW_TAGs > wouldn't CHECK-LABEL doesn't have to match a line in the file uniquely. What happens is that all the -LABEL directives are processed first, in order, subdividing the input text into

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 updated this revision to Diff 482664. Michael137 added a comment. - Use `CHECK-DAG` for attributes - Also compile with non-strict DWARFv4 - Widen the `STRICT-NOT` checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139953/new/

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:37 +// STRICT-NOT: DW_AT_default_value (true) +// DWARF-DUMP: DW_TAG_template_value_parameter +// DWARF-DUMP-NEXT:DW_AT_type({{.*}} "bool")

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:37 +// STRICT-NOT: DW_AT_default_value (true) +// DWARF-DUMP: DW_TAG_template_value_parameter +// DWARF-DUMP-NEXT:DW_AT_type({{.*}} "bool")

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me - maybe minor optional tweaks to the test. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:37 +// STRICT-NOT:

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a subscriber: hiraditya. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. **Summary**