This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4a2c4acb9869: [clang][Interp] Support pointers in compound
assignment operators (authored by tbaeder).
Changed prior to commit:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140874/new/
https://reviews.llvm.org/D140874
___
cfe-commits mailing
tbaeder added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140874/new/
https://reviews.llvm.org/D140874
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:727-728
+this->emitSubOffset(*RT, E);
+ else
+return false;
+
aaron.ballman wrote:
> Should this be an early return before we visit anything? Or an assert on the
>
tbaeder updated this revision to Diff 491619.
tbaeder marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140874/new/
https://reviews.llvm.org/D140874
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/ByteCodeExprGen.h
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:727-728
+this->emitSubOffset(*RT, E);
+ else
+return false;
+
Should this be an early return before we visit anything? Or an assert on the
assumption that we
tbaeder updated this revision to Diff 489694.
tbaeder marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140874/new/
https://reviews.llvm.org/D140874
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/ByteCodeExprGen.h
erichkeane added a comment.
I'm pretty far behind on reviews of the interpreter, but this one I noticed
while looking th rough it.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:710
+
+ assert(*LT == PT_Ptr);
+
This is UB here if LT doesn't contain a
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This was still missing.
Repository:
rG LLVM
